Re: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-24 Thread Doug Anderson
Jaehoon, On Tue, Jun 24, 2014 at 8:18 PM, Jaehoon Chung wrote: > On 06/25/2014 03:00 AM, Doug Anderson wrote: >> Yuvaraj, >> >> On Mon, Jun 23, 2014 at 3:45 AM, Yuvaraj Kumar C D >> wrote: >>> This patch makes use of mmc_regulator_get_supply() to handle >>> the vmmc and vqmmc regulators.Also it

Re: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-24 Thread Jaehoon Chung
On 06/25/2014 03:00 AM, Doug Anderson wrote: > Yuvaraj, > > On Mon, Jun 23, 2014 at 3:45 AM, Yuvaraj Kumar C D > wrote: >> This patch makes use of mmc_regulator_get_supply() to handle >> the vmmc and vqmmc regulators.Also it moves the code handling >> the these regulators to dw_mci_set_ios().It

[PATCH 1/3] mmc: vub300: use request_firmware_direct() for pseudo code

2014-06-24 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" vub300 uses the request_firmware() API for downloading pseudo code twice and if this fails its not considered fatal. Avoid letting the request linger 60 seconds because of udev if one of the requests fails by explicitly skipping the udev helper. This was found with the

Re: [PATCH 3/3] mmc: dw_mmc: Support voltage changes

2014-06-24 Thread Doug Anderson
Yuvaraj, On Mon, Jun 23, 2014 at 3:45 AM, Yuvaraj Kumar C D wrote: > From: Doug Anderson > > For UHS cards we need the ability to switch voltages from 3.3V to > 1.8V. Add support to the dw_mmc driver to handle this. Note that > dw_mmc needs a little bit of extra code since the interface needs

Re: [PATCH 2/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-06-24 Thread Doug Anderson
Yuvaraj, On Mon, Jun 23, 2014 at 3:45 AM, Yuvaraj Kumar C D wrote: > On exynos 5250 and 5420 based boards which uses built-in CD# line > for card detection.But unfortunately CD# line is on the same voltage > rails as of I/O voltage rails.When we cut off vqmmc,the consequent > card detection will

Re: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-24 Thread Doug Anderson
Yuvaraj, On Mon, Jun 23, 2014 at 3:45 AM, Yuvaraj Kumar C D wrote: > This patch makes use of mmc_regulator_get_supply() to handle > the vmmc and vqmmc regulators.Also it moves the code handling > the these regulators to dw_mci_set_ios().It turned on the vmmc > and vqmmc during MMC_POWER_UP and MM

Re: sdhci_s3c_consider_clock scheduling while atomic - clk_round_rate

2014-06-24 Thread Tomasz Figa
Hi Daniel, [adding Ulf, Chris and Mike to the discussion] On 24.06.2014 11:48, Daniel Drake wrote: > sdhci_s3c_set_clock is called from sdhci_do_set_ios with interrupts > disabled, and this calls into sdhci_s3c_consider_clock(). > > The patch "mmc: sdhci-s3c: Cache bus clock rates" addressed som

[PATCH 1/6] mmc: sdhci-s3c: Fix local I/O clock gating

2014-06-24 Thread Tomasz Figa
For internal card detection mechanism it is required that the local I/O clock is always running. However while current implementation accounts for this, it does so incorrectly leading to race conditions and warnings about unbalanced clock disables. This patch fixes it by inverting the logic, which

Re: MMC error on Exynos4210 board

2014-06-24 Thread Tim Kryger
Sure thing. I'll try to get it sent out later today. -Tim On Tue, Jun 24, 2014 at 4:11 AM, Ulf Hansson wrote: > > > On 23 juni 2014 06:30:08 CEST, Sachin Kamat wrote: >>Hi Tim, >> >>On Sat, Jun 21, 2014 at 2:31 AM, Tim Kryger >>wrote: >>> On Thu, Jun 19, 2014 at 8:33 PM, Sachin Kamat >>wrote

Re: MMC error on Exynos4210 board

2014-06-24 Thread Ulf Hansson
On 23 juni 2014 06:30:08 CEST, Sachin Kamat wrote: >Hi Tim, > >On Sat, Jun 21, 2014 at 2:31 AM, Tim Kryger >wrote: >> On Thu, Jun 19, 2014 at 8:33 PM, Sachin Kamat >wrote: >>> On Thu, Jun 19, 2014 at 6:11 PM, Jaehoon Chung > wrote: On 06/19/2014 07:40 PM, Sachin Kamat wrote: > On Thu,

sdhci_s3c_consider_clock scheduling while atomic - clk_round_rate

2014-06-24 Thread Daniel Drake
sdhci_s3c_set_clock is called from sdhci_do_set_ios with interrupts disabled, and this calls into sdhci_s3c_consider_clock(). The patch "mmc: sdhci-s3c: Cache bus clock rates" addressed some scheduling while atomic in this function, but there are more issues here, seen while testing 3.16-rc2 on ex