Re: [ulf.hansson-mmc:next 17/29] drivers/input/touchscreen/cyttsp4_core.c:1218:1: warning: 'cyttsp4_irq' uses dynamic stack allocation

2014-08-19 Thread Ulf Hansson
On 18 August 2014 19:13, Linus Walleij linus.wall...@linaro.org wrote: On Mon, Aug 18, 2014 at 11:39 AM, kbuild test robot fengguang...@intel.com wrote: tree: git://git.linaro.org/people/ulf.hansson/mmc next head: 612b2c14449ba90b633f51fcfba83dd66614697a commit:

Re: [PATCH] mmc: slot-gpio: restore error reporting

2014-08-19 Thread Ulf Hansson
On 19 August 2014 05:28, Linus Walleij linus.wall...@linaro.org wrote: The patch switching the MMC core to use GPIO descriptors depromoted errors to debug messages for unsuccessful attempt to get CD or WP GPIOs. This was because sometimes these are not specified, and that should not be an

Re: [PATCH v2] mmc: execute tuning when device is not busy.

2014-08-19 Thread Ulf Hansson
On 19 August 2014 05:53, Sun, Yi Y yi.y@intel.com wrote: Hi, Uffe, Could you please review the patch? Thanks! BRs, Sun Yi Please don't top post. I am not the only one to review sdhci patches. There are probably other better suited and I rely to get some input on this kind of patch.

[PATCH v5] mmc: implement Driver Stage Register handling

2014-08-19 Thread Uwe Kleine-König
From: Sascha Hauer s.ha...@pengutronix.de Some eMMC and SD cards implement a DSR register that allows to tune raise/fall times and drive strength of the CMD and DATA outputs. The values to use depend on the card in use and the host. It might be needed to reduce the drive strength to prevent

Re: [PATCH] mmc: tmio: Fix hang during suspend

2014-08-19 Thread Geert Uytterhoeven
Hi Ulf, On Mon, Aug 18, 2014 at 3:10 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 18 August 2014 14:36, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Fri, Aug 15, 2014 at 2:49 PM, Ian Molton ian.mol...@codethink.co.uk wrote: On Thu, 14 Aug 2014 17:23:53 +0200 Geert Uytterhoeven

Re: [PATCH v5] mmc: implement Driver Stage Register handling

2014-08-19 Thread Ulf Hansson
On 19 August 2014 10:45, Uwe Kleine-König u.kleine-koe...@pengutronix.de wrote: From: Sascha Hauer s.ha...@pengutronix.de Some eMMC and SD cards implement a DSR register that allows to tune raise/fall times and drive strength of the CMD and DATA outputs. The values to use depend on the card

[PATCH v2 3/4] mmc: mmci: Add sdio enable mask in variant data

2014-08-19 Thread Srinivas Kandagatla
This patch adds sdio enable mask in variant data, SOCs like ST have special bits in datactrl register to enable sdio. Unconditionally setting this bit in this driver breaks other SOCs like Qualcomm which maps this bits to something else, so making this enable bit to come from variant data solves

[PATCH v2 1/4] mmc: mmci: Support any block sizes for ux500v2 and qcom variant

2014-08-19 Thread Srinivas Kandagatla
From: Ulf Hansson ulf.hans...@linaro.org For the ux500v2 variant of the PL18x block, any block sizes are supported. This will make it possible to decrease data overhead for SDIO transfers. This patch is based on Ulf Hansson patch http://www.spinics.net/lists/linux-mmc/msg12160.html

[PATCH v2 4/4] mmc: mmci: rename sdio flag in vendor data to st_sdio

2014-08-19 Thread Srinivas Kandagatla
This patch renames sdio flag in vendor data to st_sdio, as this flag is only used to enable ST specific sdio setup. This will also ensure that the ST specfic setup is not done on other vendor like Qualcomm. Originally the issue was detected while testing WLAN ath6kl on IFC6410 board with APQ8064

[PATCH v2 0/4] mmc: mmci: sdio related fixes

2014-08-19 Thread Srinivas Kandagatla
This patchset fixes few sdio related issues encountered while testing WLAN ath6kl via SDIO on IFC6410 board with Qualcomm APQ8064 SOC. Patch: mmc: mmci: Support any block sizes for ux500v2 and qcom variant is a very old patch by Ulf to support IPs which support any size of block sizes.

Re: [PATCH] mmc: sdhci-sirf: fix 8bit width enable by overwriting set_bus_width

2014-08-19 Thread Ulf Hansson
On 19 August 2014 09:07, Barry Song barry.s...@csr.com wrote: From: Minda Chen minda.c...@csr.com 8bit-width enable bit of CSR MMC hosts is 3, while stardard hosts use bit 5. this patch fixes the functionality of 8bit transfer in CSR mmc controllers and improve performance for mmc0 a lot.

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-19 Thread Javier Martinez Canillas
Hello Ulf, On 08/15/2014 04:51 PM, Ulf Hansson wrote: Just wanted to add some input regarding the errors in the mmc case. These are of high importance. In principle if you get, Failed getting OCR mask: -22, likely you will be using a wrong OCR mask while negotiating the voltage level with

Re: [PATCH v2 2/4] mmc: mmci: move block size validation under relevant code

2014-08-19 Thread Ulf Hansson
On 19 August 2014 13:14, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: This code moves a BUG_ON condition to relevant if block, this check is not necessary for IPs which can set any arbitrary block size in a given range. This patch is necessary for SDIO which sets block sizes that

Re: [PATCH v2 2/4] mmc: mmci: move block size validation under relevant code

2014-08-19 Thread Srinivas Kandagatla
On 19/08/14 12:55, Ulf Hansson wrote: writel(host-size, base + MMCIDATALENGTH); - blksz_bits = ffs(data-blksz) - 1; - BUG_ON(1 blksz_bits != data-blksz); I don't like this BUG_ON at all, I would prefer if we remove it. The original patch mmc: mmci: Support any block

Re: [PATCH v2 1/4] mmc: mmci: Support any block sizes for ux500v2 and qcom variant

2014-08-19 Thread Ulf Hansson
On 19 August 2014 13:14, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: From: Ulf Hansson ulf.hans...@linaro.org For the ux500v2 variant of the PL18x block, any block sizes are supported. This will make it possible to decrease data overhead for SDIO transfers. This patch is based

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-19 Thread Ulf Hansson
On 19 August 2014 13:29, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Ulf, On 08/15/2014 04:51 PM, Ulf Hansson wrote: Just wanted to add some input regarding the errors in the mmc case. These are of high importance. In principle if you get, Failed getting OCR mask:

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-19 Thread Ulf Hansson
On 14 August 2014 14:39, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: The operation conditions register (OCR) stores the voltage profile of the card, however the list of possible voltages is restricted by the voltage range supported by the supply used as VCC/VDD. So in

Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask is empty.

2014-08-19 Thread Javier Martinez Canillas
On 08/19/2014 02:43 PM, Ulf Hansson wrote: Well, currently this seems like the best approach. If we end up having some new regulator helper function, future wise, we can convert to such later on. Great, thanks a lot for your help! Kind regards Uffe Best regards, Javier -- To

[PATCH v2] mmc: sdhci-sirf: fix 8bit width enable by overwriting set_bus_width

2014-08-19 Thread Barry Song
From: Minda Chen minda.c...@csr.com 8bit-width enable bit of CSR MMC hosts is 3, while stardard hosts use bit 5. this patch fixes the functionality of 8bit transfer in CSR mmc controllers and improve performance for mmc0 a lot. Signed-off-by: Minda Chen minda.c...@csr.com Signed-off-by: Barry

Re: [ulf.hansson-mmc:next 17/29] drivers/input/touchscreen/cyttsp4_core.c:1218:1: warning: 'cyttsp4_irq' uses dynamic stack allocation

2014-08-19 Thread Linus Walleij
On Tue, Aug 19, 2014 at 2:19 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 18 August 2014 19:13, Linus Walleij linus.wall...@linaro.org wrote: Or maybe even do the second approach of putting stubs in slot-gpio.h for !GPIOLIB... Hmm, that doesn't sound the proper solution either.

Re: [PATCH] mmc: slot-gpio: restore error reporting

2014-08-19 Thread Simon Baatz
Hi Ulf, Linus, On Tue, Aug 19, 2014 at 09:29:59AM +0200, Ulf Hansson wrote: On 19 August 2014 05:28, Linus Walleij linus.wall...@linaro.org wrote: The patch switching the MMC core to use GPIO descriptors depromoted errors to debug messages for unsuccessful attempt to get CD or WP GPIOs.

Re: [PATCH] mmc: atmel-mci: add 0x600 IP version

2014-08-19 Thread Nicolas Ferre
On 12/06/2014 02:47, Ludovic Desroches : From: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com Chris, Ufl, It seems that this tiny patch got forgotten: Should we re-send it? Thanks, bye,