Re: [PATCH] mmc:sdhci: handle busy-end interrupt during command

2014-08-21 Thread Ulf Hansson
On 21 August 2014 03:53, Chanho Min chanho@lge.com wrote: It is fully legal for a controller to start handling busy-end interrupt before it has signaled that the command has completed. So make sure we do things in the proper order, Or it results that command interrupt is ignored so it can

RE: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-08-21 Thread Alex Lemberg
-Original Message- From: Ulf Hansson [mailto:ulf.hans...@linaro.org] Sent: Monday, August 18, 2014 1:57 PM To: Alex Lemberg Cc: linux-mmc@vger.kernel.org; c...@laptop.org; Grant Grundler; Avi Shchislowski; Gwendal Grignou (gwen...@chromium.org) Subject: Re: [RFC PATCH 1/1 v8]mmc:

Re: [PATCH v2] mmc: sdhci-sirf: fix 8bit width enable by overwriting set_bus_width

2014-08-21 Thread Barry Song
2014-08-20 22:25 GMT+08:00 Romain Izard romain.izard@gmail.com: [Followup-To: header set to gmane.linux.kernel.mmc.] On 2014-08-19, Barry Song 21cn...@gmail.com wrote: From: Minda Chen minda.c...@csr.com 8bit-width enable bit of CSR MMC hosts is 3, while stardard hosts use bit 5. this

Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-08-21 Thread Ulf Hansson
[snip] By just browsing through the code for preparing and handling the mmc data request in the above functions, I find quite some duplication of code from the card/*.c files. Could we maybe share some code between these layers to avoid duplications, and thus errors? Yes, we are aware

Re: [PATCH 1/5] mmc: remove .owner field for drivers using module_platform_driver

2014-08-21 Thread Peter Griffin
Hi Michal, On Mon, 18 Aug 2014, Michal Simek wrote: I have checked this for all xilinx drivers we have in the tree and I have sent similar patches. This problem is probably in all subsystems. Yep With communication with Mark Brown. Don't you have cocinelle script for fixing this

[PATCH v3 1/3] mmc: mmci: Support any block sizes for ux500v2 and qcom variant

2014-08-21 Thread Srinivas Kandagatla
From: Ulf Hansson ulf.hans...@linaro.org For the ux500v2 variant of the PL18x block, any block sizes are supported. This will make it possible to decrease data overhead for SDIO transfers. This patch is based on Ulf Hansson patch http://www.spinics.net/lists/linux-mmc/msg12160.html

[PATCH v3 2/3] mmc: mmci: Add sdio enable mask in variant data

2014-08-21 Thread Srinivas Kandagatla
This patch adds sdio enable mask in variant data, SOCs like ST have special bits in datactrl register to enable sdio. Unconditionally setting this bit in this driver breaks other SOCs like Qualcomm which maps this bits to something else, so making this enable bit to come from variant data solves

[PATCH v3 3/3] mmc: mmci: rename sdio flag in vendor data to st_sdio

2014-08-21 Thread Srinivas Kandagatla
This patch renames sdio flag in vendor data to st_sdio, as this flag is only used to enable ST specific sdio setup. This will also ensure that the ST specfic setup is not done on other vendor like Qualcomm. Originally the issue was detected while testing WLAN ath6kl on IFC6410 board with APQ8064