Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-25 Thread Ulf Hansson
On 22 August 2014 20:27, Sonny Rao sonny...@chromium.org wrote: On Fri, Aug 22, 2014 at 8:31 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 22 August 2014 15:47, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote: Exynos 5250 and 5420 based boards uses built-in CD# line for card detection.But

Re: [PATCH V2 2/3] mmc: dw_mmc: Support voltage changes

2014-08-25 Thread Ulf Hansson
On 22 August 2014 22:38, Doug Anderson diand...@google.com wrote: Ulf, On Fri, Aug 22, 2014 at 8:35 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 22 August 2014 15:47, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote: From: Doug Anderson diand...@chromium.org For UHS cards we need the

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-25 Thread Jaehoon Chung
On 08/25/2014 05:13 PM, Ulf Hansson wrote: On 22 August 2014 20:27, Sonny Rao sonny...@chromium.org wrote: On Fri, Aug 22, 2014 at 8:31 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 22 August 2014 15:47, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote: Exynos 5250 and 5420 based boards uses

Re: [PATCH 01/10 v2 resend] mmc: block: add block number limitation flag for multiple block read

2014-08-25 Thread Ulf Hansson
On 25 August 2014 02:53, Kuninori Morimoto kuninori.morimoto...@gmail.com wrote: Hi Ulf Thank you for your feedback MMC_CAP2_NO_MULTI_READ flags disable all multiple block read, but, it is over-kill for this issue. This patch adds new MMC_CAP2_2BLKS_LIMIT to use single block read when

Re: [ulf.hansson-mmc:next 17/29] drivers/input/touchscreen/cyttsp4_core.c:1218:1: warning: 'cyttsp4_irq' uses dynamic stack allocation

2014-08-25 Thread Linus Walleij
On Wed, Aug 20, 2014 at 10:17 AM, Ulf Hansson ulf.hans...@linaro.org wrote: Implementation wise, I would prefer to not have stubs unless it's explicitly needed. Still one may argue that a built kernel binary should have the smallest possible footprint, which means stubs should be added. Do

Re: [PATCHv6 3/5] ARM: dts: socfpga: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

2014-08-25 Thread Pavel Machek
On Fri 2014-07-25 10:11:51, Jaehoon Chung wrote: dw-mmc controller can support multiple slots. But, there are no use-cases anywhere. So we don't need to support the slot-node for dw-mmc controller. And supports-highspeed property in dw-mmc is deprecated. supports-highspeed property can be

Re: [PATCHv10 0/5] ARM: remove the sub-node and deprecate supports-highspeed property for dwmmc.

2014-08-25 Thread Pavel Machek
On Thu 2014-08-07 16:37:57, Jaehoon Chung wrote: Since used the mmc_of_parse(), didn't parse the sub-node. So we can remove the sub-node, because almost SoC used the only one card per a host. And supports-highspeed can be replaced with cap-mmc/sd-highspeed property. Would it be better to fix

Re: [PATCHv10 0/5] ARM: remove the sub-node and deprecate supports-highspeed property for dwmmc.

2014-08-25 Thread Jaehoon Chung
On 08/25/2014 08:21 PM, Pavel Machek wrote: On Thu 2014-08-07 16:37:57, Jaehoon Chung wrote: Since used the mmc_of_parse(), didn't parse the sub-node. So we can remove the sub-node, because almost SoC used the only one card per a host. And supports-highspeed can be replaced with

Re: [PATCHv10 0/5] ARM: remove the sub-node and deprecate supports-highspeed property for dwmmc.

2014-08-25 Thread Pavel Machek
On Mon 2014-08-25 20:28:21, Jaehoon Chung wrote: On 08/25/2014 08:21 PM, Pavel Machek wrote: On Thu 2014-08-07 16:37:57, Jaehoon Chung wrote: Since used the mmc_of_parse(), didn't parse the sub-node. So we can remove the sub-node, because almost SoC used the only one card per a host.

Re: [PATCHv10 0/5] ARM: remove the sub-node and deprecate supports-highspeed property for dwmmc.

2014-08-25 Thread Jaehoon Chung
On 08/25/2014 08:37 PM, Pavel Machek wrote: On Mon 2014-08-25 20:28:21, Jaehoon Chung wrote: On 08/25/2014 08:21 PM, Pavel Machek wrote: On Thu 2014-08-07 16:37:57, Jaehoon Chung wrote: Since used the mmc_of_parse(), didn't parse the sub-node. So we can remove the sub-node, because almost SoC

Re: [PATCHv10 0/5] ARM: remove the sub-node and deprecate supports-highspeed property for dwmmc.

2014-08-25 Thread Jaehoon Chung
On 08/25/2014 09:09 PM, Jaehoon Chung wrote: On 08/25/2014 08:37 PM, Pavel Machek wrote: On Mon 2014-08-25 20:28:21, Jaehoon Chung wrote: On 08/25/2014 08:21 PM, Pavel Machek wrote: On Thu 2014-08-07 16:37:57, Jaehoon Chung wrote: Since used the mmc_of_parse(), didn't parse the sub-node. So

RE: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-08-25 Thread Alex Lemberg
-Original Message- From: Ulf Hansson [mailto:ulf.hans...@linaro.org] Sent: Thursday, August 21, 2014 3:18 PM To: Alex Lemberg Cc: linux-mmc@vger.kernel.org; c...@laptop.org; Grant Grundler; Avi Shchislowski; Gwendal Grignou (gwen...@chromium.org) Subject: Re: [RFC PATCH 1/1

[PATCH 07/12] mmc: tmio: Make runtime PM callbacks available for CONFIG_PM

2014-08-25 Thread Ulf Hansson
To give the option for tmio hosts to use the runtime PM callbacks for CONFIG_PM_SLEEP as well as CONFIG_PM_RUNTIME, move them to CONFIG_PM. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/mmc/host/tmio_mmc.h | 2 +- drivers/mmc/host/tmio_mmc_pio.c | 2 +- 2 files changed, 2

[PATCH 05/12] mmc: tmio: Handle clock gating from runtime PM functions

2014-08-25 Thread Ulf Hansson
Add clock gating control as a part of the tmio library functions for runtime PM. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/mmc/host/tmio_mmc.h | 3 ++- drivers/mmc/host/tmio_mmc_pio.c | 28 2 files changed, 26 insertions(+), 5 deletions(-)

[PATCH 01/12] mmc: tmio: Keep host active while SDIO IRQ is enabled

2014-08-25 Thread Ulf Hansson
The host must be kept active to be able to serve SDIO IRQs, thus let's prevent it from going inactive while SDIO IRQ is enabled. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/mmc/host/tmio_mmc.h | 1 + drivers/mmc/host/tmio_mmc_pio.c | 19 +++ 2 files

[PATCH 11/12] mmc: tmio_mmc: Fixup system PM suspend lock-up

2014-08-25 Thread Ulf Hansson
At system PM suspend, the tmio core accessed the internal registers of the controller without first moving the device into active state. This caused a lock-up in system PM suspend phase. The reason for the register access were masking of IRQs. Since that is managed via the runtime PM suspend

[PATCH 03/12] mmc: tmio: Extract bus_width modifications to a separate function

2014-08-25 Thread Ulf Hansson
Move code for bus_width modification, out of the -set_ios() callback and into a separate function, to simplify code. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/mmc/host/tmio_mmc_pio.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git

[PATCH 10/12] mmc: sdhi: Fixup system PM suspend lock-up

2014-08-25 Thread Ulf Hansson
At system PM suspend, the tmio core accessed the internal registers of the controller without first moving the device into active state. This caused a lock-up in system PM suspend phase. The reason for the register access were masking of IRQs. Since that is managed via the runtime PM suspend

[PATCH 04/12] mmc: tmio: Restructure -set_ios() and adapt -probe() to it

2014-08-25 Thread Ulf Hansson
An internal power state machine were beeing used to keep -probe() and -set_ios() in sync. Especially for handling specific scenarios while using CONFIG_MMC_CLKGATE. Moreover dependency to CONFIG_MMC_CLKGATE existed to handle runtime PM properly, which we moves away from here. By removing the

[PATCH 08/12] mmc: sdhi: Make runtime PM callbacks available for CONFIG_PM

2014-08-25 Thread Ulf Hansson
To be able to simplify system PM, let's re-use the runtime PM callbacks by converting to the SET_PM_RUNTIME_PM_OPS macro. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/mmc/host/sh_mobile_sdhi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 00/12] mmc: tmio: Fixup PM support

2014-08-25 Thread Ulf Hansson
This patchset fixup the PM support for tmio and the tmio hosts. Some re-structuring of the code was also necessary to accomplish the above. A few of these patches has been posted earlier, but at that time I couldn't get help in testing them on hardware. Let's give this a second try now.

Re: [PATCH 07/14] clk: sunxi: Introduce mbus compatible

2014-08-25 Thread Chen-Yu Tsai
Hi, On Thu, Jul 17, 2014 at 5:08 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: Even though the mbus clock is a regular module clock, given its nature, it needs to be enabled all the time. Introduce a new compatible, to differentiate it from the other module clocks.

Re: [PATCH 07/14] clk: sunxi: Introduce mbus compatible

2014-08-25 Thread Maxime Ripard
On Mon, Aug 25, 2014 at 10:17:37PM +0800, Chen-Yu Tsai wrote: Hi, On Thu, Jul 17, 2014 at 5:08 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: Even though the mbus clock is a regular module clock, given its nature, it needs to be enabled all the time. Introduce a new

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-25 Thread Doug Anderson
Ulf, On Mon, Aug 25, 2014 at 1:13 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 22 August 2014 20:27, Sonny Rao sonny...@chromium.org wrote: On Fri, Aug 22, 2014 at 8:31 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 22 August 2014 15:47, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote:

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-25 Thread Doug Anderson
Jaehoon, On Mon, Aug 25, 2014 at 1:50 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 08/25/2014 05:13 PM, Ulf Hansson wrote: On 22 August 2014 20:27, Sonny Rao sonny...@chromium.org wrote: On Fri, Aug 22, 2014 at 8:31 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 22 August 2014 15:47,

Re: [PATCH] mmc: core: sdio: Fix unconditional wake_up_process() on sdio thread

2014-08-25 Thread Fu, Zhonghui
Many thanks for your helps. Thanks, Zhonghui On 2014/8/18 20:07, Ulf Hansson wrote: On 18 August 2014 05:04, Fu, Zhonghui zhonghui...@linux.intel.com wrote: From 21266249bbbaf9407c1e88cd5950e06ac88aeebf Mon Sep 17 00:00:00 2001 From: Fu Zhonghui zhonghui...@linux.intel.com Date: Mon, 18

[PATCH] mmc: dw_mmc: Pass back errors from mmc_of_parse()

2014-08-25 Thread Doug Anderson
It's possible that mmc_of_parse() could return errors (possibly in some future version it might return -EPROBE_DEFER even). Let's pass those errors back. Signed-off-by: Doug Anderson diand...@chromium.org --- drivers/mmc/host/dw_mmc.c | 10 ++ 1 file changed, 6 insertions(+), 4

Re: [PATCH V2 2/3] mmc: dw_mmc: Support voltage changes

2014-08-25 Thread Doug Anderson
Ulf, On Mon, Aug 25, 2014 at 1:31 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 22 August 2014 22:38, Doug Anderson diand...@google.com wrote: Ulf, On Fri, Aug 22, 2014 at 8:35 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 22 August 2014 15:47, Yuvaraj Kumar C D yuvaraj...@gmail.com

[PATCH v3] mmc: sdhci-sirf: fix 8bit width enable by overwriting set_bus_width

2014-08-25 Thread Barry Song
From: Minda Chen minda.c...@csr.com the implementation of CSR SDHCI controller is a modified version of the one described in the 1.0 specification, and not a normal 3.0 controller. and 8bit-width enable bit of CSR MMC hosts is 3, while stardard hosts use bit 5. this patch fixes the functionality