Re: [PATCH] mmc: pxamci: prepare and unprepare the clocks

2014-09-02 Thread Ulf Hansson
On 1 September 2014 15:28, Robert Jarzmik robert.jarz...@free.fr wrote: Ulf Hansson ulf.hans...@linaro.org writes: I understand your concern, but I don't see why there should be any major difference in clock management code (clk tree wise), due to this patch. It worked before, so likely it

Re: [PATCH v2 10/12] clk: sunxi: mod0: Introduce MMC proper phase handling

2014-09-02 Thread Maxime Ripard
Hi, On Mon, Sep 01, 2014 at 02:39:45PM -0700, Mike Turquette wrote: Quoting Maxime Ripard (2014-08-30 13:03:09) The MMC clock we thought we had until now are actually not one but three different clocks. The main one is unchanged, and will have three outputs: - The clock fed into the

sdhci-esdhc-imx : cannot read eMMC

2014-09-02 Thread Jean-Michel Hautbois
Hi there, I start a new thread, as I have done lots of test and this will be clearer. I have problems reading and writing eMMC on my i.MX6 board with 3.17-rc3. Sometimes I don't have read errors explicitly in dmesg, but fdisk has no effects. I activated MMC debug in my config file, and here is an

Re: [PATCH] sdhci: Make sdhci_disable_irq_wakeups() static

2014-09-02 Thread Ulf Hansson
On 30 August 2014 19:53, Fabio Estevam feste...@gmail.com wrote: From: Fabio Estevam fabio.este...@freescale.com sdhci_disable_irq_wakeups() is exported, but it is not called outside sdhci.c. Make it static and do not export it, so that the following sparse warning is fixed:

[PATCH v2] mmc: pxamci: prepare and unprepare the clocks

2014-09-02 Thread Robert Jarzmik
Add the clock prepare and unprepare call to the driver set_ios calls phase. This will remove a warning once the PXA architecture is migrated to the clock infrastructure. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/mmc/host/pxamci.c | 4 ++-- 1 file changed, 2 insertions(+),

Re: [PATCH v2] mmc:sdhci: handle busy-end interrupt during command

2014-09-02 Thread Ulf Hansson
On 30 August 2014 05:40, Chanho Min chanho@lge.com wrote: It is fully legal for a controller to start handling busy-end interrupt before it has signaled that the command has completed. So make sure we do things in the proper order, Or it results that command interrupt is ignored so it can

Re: [PATCH v2 03/12] clk: Add a function to retrieve phase

2014-09-02 Thread Maxime Ripard
Hi, On Mon, Sep 01, 2014 at 12:00:54PM -0700, Mike Turquette wrote: Quoting Maxime Ripard (2014-08-30 13:03:02) The current phase API doesn't look into the actual hardware to get the phase value, but will rather get it from a variable only set by the set_phase function. This will

Re: [PATCH v2 03/12] clk: Add a function to retrieve phase

2014-09-02 Thread Maxime Ripard
On Mon, Sep 01, 2014 at 01:27:28PM +0200, Hans de Goede wrote: Hi, On 09/01/2014 12:20 PM, Maxime Ripard wrote: Hi, On Sun, Aug 31, 2014 at 12:15:50PM +0200, Hans de Goede wrote: Hi, On 08/30/2014 10:03 PM, Maxime Ripard wrote: The current phase API doesn't look into the actual

Re: [PATCH] mmc: sdhci: enable runtime pm for Intel Merrifield platform

2014-09-02 Thread Ulf Hansson
On 18 August 2014 09:05, Yunpeng Gao yunpeng@intel.com wrote: Enable runtime pm support on Intel Merrifield platform. Signed-off-by: Yunpeng Gao yunpeng@intel.com Thanks! Applied for next. Kind regards Uffe --- drivers/mmc/host/sdhci-pci.c |1 + 1 file changed, 1 insertion(+)

Re: [PATCH] mmc: sdhci-pci: disable preset register for Baytrail and Merrifield

2014-09-02 Thread Ulf Hansson
On 18 August 2014 09:32, Yunpeng Gao yunpeng@intel.com wrote: Due to HW issue, SDHCI host controller on Intel Baytrail/Merrifield platforms can not use preset register. So, disable preset registers for them by quirks. Signed-off-by: Yunpeng Gao yunpeng@intel.com Signed-off-by:

Re: [PATCH v2] mmc: pxamci: prepare and unprepare the clocks

2014-09-02 Thread Ulf Hansson
On 2 September 2014 11:23, Robert Jarzmik robert.jarz...@free.fr wrote: Add the clock prepare and unprepare call to the driver set_ios calls phase. This will remove a warning once the PXA architecture is migrated to the clock infrastructure. Signed-off-by: Robert Jarzmik

Re: [PATCH v2] mmc: sdhci-acpi: add probe_slot method for emmc/sd/sdio

2014-09-02 Thread Ulf Hansson
On 1 September 2014 05:35, Yunpeng Gao yunpeng@intel.com wrote: Similar to sdhci-pci controller, also add probe_slot and remove_slot method in the sdhci-acpi driver. This is the v2 version patch and fixed checkpatch errors. Signed-off-by: Yunpeng Gao yunpeng@intel.com Signed-off-by:

Re: [PATCH v2 03/12] clk: Add a function to retrieve phase

2014-09-02 Thread David Lanzendörfer
Hi Yep, except that if I see a value -1 as a phase, I would assume that it's 359, but maybe it's just me :) -1 looks suspiciously like an error return value from somewhere... -- David Lanzendörfer OpenSourceSupport GmbH System engineer and supporter http://www.o2s.ch/ signature.asc

Re: sdhci-esdhc-imx : cannot read eMMC

2014-09-02 Thread Jean-Michel Hautbois
2014-09-02 11:20 GMT+02:00 Jean-Michel Hautbois jean-michel.hautb...@vodalys.com: Hi there, I start a new thread, as I have done lots of test and this will be clearer. I have problems reading and writing eMMC on my i.MX6 board with 3.17-rc3. Sometimes I don't have read errors explicitly in

Re: [PATCH v3] mmc: core: try 1.8v signling in ddr mode if host and device

2014-09-02 Thread Jean-Michel Hautbois
2014-08-15 10:36 GMT+02:00 Dong, Chuanxiao chuanxiao.d...@intel.com: -Original Message- From: Ulf Hansson [mailto:ulf.hans...@linaro.org] Sent: Friday, August 15, 2014 4:34 PM To: Dong, Chuanxiao Cc: linux-mmc; ch...@printf.org Subject: Re: [PATCH v3] mmc: core: try 1.8v signling

[PATCH] mmc: sdhci-esdhc-imx: Enable boot partition access from DT

2014-09-02 Thread Jean-Michel Hautbois
This property is useful when we don't want to access boot partitions on eMMC Signed-off-by: Jean-Michel Hautbois jean-michel.hautb...@vodalys.com --- Documentation/devicetree/bindings/mmc/mmc.txt | 1 + drivers/mmc/host/sdhci-esdhc-imx.c| 8

[PATCH] mmc: dw_mmc: Don't enable interrupts until we're ready

2014-09-02 Thread Doug Anderson
On dw_mmc there's a small race if you happen to get a card detect interrupt at just the wrong time during probe. You may have enabled the interrupt but host-slot[0] may be NULL. Fix the race by enabling interrupts all the way at the end of the probe. We can also use free_irq() instead of dw_mmc

Re: [PATCH 1/7 v2] mmc: add blk_size_workaround for HW bug

2014-09-02 Thread Kuninori Morimoto
Hi Ulf Current mmc block.c has MMC_CAP2_NO_MULTI_READ flag for HW bug workaround, but it should be implemented under driver, not framework. This patch is prepare for it I like the idea of this patchset! Still, historically, we have been using MMC_CAP* to solve these kind issues.

Re: mmc: eMMC BKOPS status handling lock for non urgent case

2014-09-02 Thread Jaehoon Chung
Hi, Markus Sorry for replying too late. On 08/30/2014 01:49 AM, Markus Niebel wrote: Hello, experimenting with the current BKOPS code we found, that when triggering from BKOPS_LEVEL 1, the status stored with mmc_card_set_doing_bkops is never reset preventing BKOPS from working. In now,

[PATCH 0/7 v3] mmc: remove MMC_CAP2_NO_MULTI_READ flags

2014-09-02 Thread Kuninori Morimoto
Hi Ulf, Chris, and Simon These are v3 patches of removing MMC_CAP2_NO_MULTI_READ from mmc. Simon 5) and 6) are for sh-arm patches. Can you check it ? Kuninori Morimoto (7): mmc: add .multi_io_quirk callback for multi I/O HW bug mmc: use .multi_io_quirk on omap_hsmmc mmc: use

[PATCH 4/7 v3] mmc: use .multi_io_quirk on sh_mobile

2014-09-02 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com Now, sh_mobile_sdhi can use .multi_io_quirk callback instead of MMC_CAP2_NO_MULTI_READ flags. let's use it. Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- v2 - v3 - blk_size_workaround - multi_io_quirk

[PATCH 2/7 v3] mmc: use .multi_io_quirk on omap_hsmmc

2014-09-02 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com Now, omap_hsmmc can use .multi_io_quirk callback instead of MMC_CAP2_NO_MULTI_READ flags. let's use it. Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- v2 - v3 - blk_size_workaround - multi_io_quirk

[PATCH 3/7 v3] mmc: use .multi_io_quirk on tmio_mmc

2014-09-02 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com Now, tmio_mmc can use .multi_io_quirk callback instead of MMC_CAP2_NO_MULTI_READ flags. let's use it. Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- v2 - v3 - blk_size_workaround - multi_io_quirk

[PATCH 5/7 v3] ARM: shmobile: remove MMC_CAP2_NO_MULTI_READ from koelsch

2014-09-02 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com sh_mobile_sdhi cares multiblock read bug. remove MMC_CAP2_NO_MULTI_READ flag from board code Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- v2 - v3 - no change arch/arm/mach-shmobile/board-koelsch.c |3 --- 1

[PATCH 1/7 v3] mmc: add .multi_io_quirk callback for multi I/O HW bug

2014-09-02 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com Historically, we have been using MMC_CAP* to solve some issues, and current mmc block.c has MMC_CAP2_NO_MULTI_READ flag for multi I/O HW bug workaround. But it should be implemented under driver, not framework. This patch is prepare for it

Re: [PATCH] mmc: core: sdio: Fix unconditional wake_up_process() on sdio thread

2014-09-02 Thread Fu, Zhonghui
Hi,Uffe Could you please tell me into which git repository this patch is merged now? Thanks, Zhonghui On 2014/8/26 0:10, Fu, Zhonghui wrote: Many thanks for your helps. Thanks, Zhonghui On 2014/8/18 20:07, Ulf Hansson wrote: On 18 August 2014 05:04, Fu, Zhonghui

[PATCH 7/7 v3] mmc: remove MMC_CAP2_NO_MULTI_READ flags

2014-09-02 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com Now, mmc framework uses multi_io_quirk for I/O HW bug workaround. MMC_CAP2_NO_MULTI_READ flag is no longer needed Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- v2 - v3 - no change drivers/mmc/card/block.c |5

[PATCH 6/7 v3] ARM: shmobile: remove MMC_CAP2_NO_MULTI_READ from lager

2014-09-02 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com sh_mobile_sdhi cares multiblock read bug. remove MMC_CAP2_NO_MULTI_READ flag from board code Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- v2 - v3 - no change arch/arm/mach-shmobile/board-lager.c |2 -- 1

Re: [PATCH] mmc: sdhci-esdhc-imx: Enable boot partition access from DT

2014-09-02 Thread Dong Aisheng
On Tue, Sep 02, 2014 at 05:49:37PM +0200, Jean-Michel Hautbois wrote: This property is useful when we don't want to access boot partitions on eMMC Any special reason why not access boot partitions on eMMC? Not allow user to access it? Signed-off-by: Jean-Michel Hautbois