[PATCH] mmc: Convert pr_warning to pr_warn

2014-09-12 Thread Joe Perches
Use the much more common pr_warn instead of pr_warning. Other miscellanea: o Coalesce formats o Realign arguments o Remove extra spaces when coalescing formats Signed-off-by: Joe Perches --- drivers/mmc/card/block.c | 4 ++-- drivers/mmc/card/queue.c | 6 ++ drivers/mmc/card/sdio

[PATCH] mmc: don't request CD IRQ until mmc_start_host()

2014-09-12 Thread Stephen Warren
From: Stephen Warren As soon as the CD IRQ is requested, it can trigger, since it's an externally controlled event. If it does, delayed_work host->detect will be scheduled. Many host controller probe()s are roughly structured as: *_probe() { host = sdhci_pltfm_init(); mmc_of_parse(host-

Re: mmc: freeing host while host->detect work queue is still active

2014-09-12 Thread Stephen Warren
On 09/11/2014 04:03 PM, Stephen Warren wrote: Running Fedora rawhides's 3.17.0-0.rc4.git2.1.fc22.armv7hl kernel on Jetson TK1 (an ARM board containing Tegra SoC), I see the following during boot most times the Tegra SDHCI driver defers probe for the SD slot: (and indeed I can reproduce the same

[PATCH v5 0002/0003] mmc: Replace "enhanced_area_en" attribute by "partition_setting_completed"

2014-09-12 Thread Grégory Soutadé
Replace ext_csd "enhanced_area_en" attribute by "partition_setting_completed". It was used whether or not enhanced user area is defined and without checks of EXT_CSD_PARTITION_SETTING_COMPLETED bit. Signed-off-by: Grégory Soutadé --- drivers/mmc/core/mmc.c | 14 +- include/lin

[PATCH v5 0003/0003] mmc: Checks EXT_CSD_PARTITION_SETTING_COMPLETED before partitions computation

2014-09-12 Thread Grégory Soutadé
Checks EXT_CSD_PARTITION_SETTING_COMPLETED bit before computing enhanced user area offset and size, and adding mmc general purpose partitions. The two needs EXT_CSD_PARTITION_SETTING_COMPLETED bit be set to be valid (as described in JEDEC standard). Warn user in case of misconfiguration. Signe

[PATCH v5 0000/0003] mmc: EXT_CSD_PARTITION_SETTING_COMPLETED bit not checked

2014-09-12 Thread Grégory Soutadé
JEDEC standard requires that EXT_CSD_PARTITION_SETTING_COMPLETED bit must be set in order to take in account enhanced area and general purpose partitions (gp) values. Current code doesn't checks this bit and blindly trust enhanced area and gp values. Moreover, "enhanced_area_en" attribute was set

[PATCH v5 0001/0003] mmc: Move code that manages user area and gp partitions into functions

2014-09-12 Thread Grégory Soutadé
Move code that manages user area and general purpose partitions into functions. Signed-off-by: Grégory Soutadé --- drivers/mmc/core/mmc.c | 162 ++-- 1 file changed, 89 insertions(+), 73 deletions(-) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc

Re: [PATCH v3 09/12] ARM: sunxi: dt: Add sample and output mmc clocks

2014-09-12 Thread Chen-Yu Tsai
On Fri, Sep 12, 2014 at 4:18 AM, Maxime Ripard wrote: > Add the sample and output clocks for the MMC phase support. > > Signed-off-by: Maxime Ripard > --- > arch/arm/boot/dts/sun4i-a10.dtsi | 104 > +++--- > arch/arm/boot/dts/sun5i-a10s.dtsi | 79 ++

Re: [PATCH] mmc: omap_hsmmc: Add small delay after enabling power

2014-09-12 Thread Stefan Roese
On 11.09.2014 16:15, Ulf Hansson wrote: On 11 September 2014 16:11, Stefan Roese wrote: From: Thorsten Einsbein On the TAO3530 (OMAP3530 based) we noticed that some SD cards are not detected reliably upon bootup (timeout). Especially the SanDisk Ultra 8GiB seems to be problematic here. The Sa

Re: [PATCH v3 00/12] clk: sunxi: Improve MMC clocks support

2014-09-12 Thread Hans de Goede
Hi, On 09/11/2014 10:18 PM, Maxime Ripard wrote: > Hi everyone, > > Here is an attempt at improving the MMC clock support in the Allwinner > SoCs. > > Until now, the MMC clocks were having a custom phase function that was > directly setting an obscure value in the right register, because we > we