Re: [PATCH] mmc: Add delay between CMD6 and CMD13 for Sandisk eMMC cards

2014-09-15 Thread hisanao.kinkawa
Hi Do not hit the following bug? Often, This bug fails setting of CMD6. Original Message Subject:Re: [PATCH v2] mmc:sdhci: handle busy-end interrupt during command Date: Tue, 2 Sep 2014 11:27:51 +0200 From: Ulf Hansson To: Chanho Min On 30 August 20

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-15 Thread Stephen Boyd
On 09/04/14 15:01, Stephen Boyd wrote: > > 8< > From: Stephen Boyd > Subject: [PATCH] mmc: Consolidate emmc tuning blocks > > The same tuning block array exists in the dw_mmc h.c and sdhci-msm.c > files. Move these into mmc.c so that they can be shared across > drivers. > > Reported-by: Ja

[PATCH v6 0002/0003] mmc: Replace "enhanced_area_en" attribute by "partition_setting_completed"

2014-09-15 Thread Grégory Soutadé
Replace ext_csd "enhanced_area_en" attribute by "partition_setting_completed". It was used whether or not enhanced user area is defined and without checks of EXT_CSD_PARTITION_SETTING_COMPLETED bit. Signed-off-by: Grégory Soutadé --- drivers/mmc/core/mmc.c | 13 - include/linu

[PATCH v6 0001/0003] mmc: Move code that manages user area and gp partitions into functions

2014-09-15 Thread Grégory Soutadé
Move code that manages user area and general purpose partitions into functions. Signed-off-by: Grégory Soutadé --- drivers/mmc/core/mmc.c | 162 ++-- 1 file changed, 89 insertions(+), 73 deletions(-) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc

[PATCH v6 0003/0003] mmc: Checks EXT_CSD_PARTITION_SETTING_COMPLETED before partitions computation

2014-09-15 Thread Grégory Soutadé
Checks EXT_CSD_PARTITION_SETTING_COMPLETED bit before computing enhanced user area offset and size, and adding mmc general purpose partitions. The two needs EXT_CSD_PARTITION_SETTING_COMPLETED bit be set to be valid (as described in JEDEC standard). Warn user in case of misconfiguration. Signe

[PATCH v6 0000/0003] mmc: EXT_CSD_PARTITION_SETTING_COMPLETED bit not checked

2014-09-15 Thread Grégory Soutadé
JEDEC standard requires that EXT_CSD_PARTITION_SETTING_COMPLETED bit must be set in order to take in account enhanced area and general purpose partitions (gp) values. Current code doesn't checks this bit and blindly trust enhanced area and gp values. Moreover, "enhanced_area_en" attribute was set

Re: mmc: eMMC BKOPS status handling lock for non urgent case

2014-09-15 Thread Markus Niebel
Hello, Am 12.09.2014 um 04:45 schrieb Jaehoon Chung: > Hi, > > On 09/08/2014 05:15 PM, Markus Niebel wrote: >> Hello Jaehoon Chung >> Hello, experimenting with the current BKOPS code we found, that when triggering from BKOPS_LEVEL 1, the status stored with mmc_card_set_do

Re: [PATCH] mmc: Add delay between CMD6 and CMD13 for Sandisk eMMC cards

2014-09-15 Thread Jean-Michel Hautbois
2014-09-15 12:53 GMT+02:00 Jean-Michel Hautbois : > 2014-09-15 12:44 GMT+02:00 Jaehoon Chung : >> On 09/15/2014 07:08 PM, Jean-Michel Hautbois wrote: >>> Hi Jaehoon, >>> On 09/09/2014 09:26 PM, Jean-Michel Hautbois wrote: > Tested on a i.MX6 board, with Sandisk SDIN5D1-2G. > Without th

Re: [PATCH v3] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock()

2014-09-15 Thread Ian Molton
Seems reasonable, Acked-by: Ian Molton -Ian On Sun, 14 Sep 2014 23:51:24 +0400 Sergei Shtylyov wrote: > I spent a couple of days with the driver just hanging due to me forgetting to > specify the external crystal frequency, so that clk_get_rate() returned 0 and > thus the loop in tmio_mmc_se

Re: [PATCH] mmc: Add delay between CMD6 and CMD13 for Sandisk eMMC cards

2014-09-15 Thread Jean-Michel Hautbois
2014-09-15 12:44 GMT+02:00 Jaehoon Chung : > On 09/15/2014 07:08 PM, Jean-Michel Hautbois wrote: >> Hi Jaehoon, >> >>> On 09/09/2014 09:26 PM, Jean-Michel Hautbois wrote: Tested on a i.MX6 board, with Sandisk SDIN5D1-2G. Without this patch, I/O errors occur. This eMMC seems to have a

Re: [PATCH] mmc: Add delay between CMD6 and CMD13 for Sandisk eMMC cards

2014-09-15 Thread Jaehoon Chung
On 09/15/2014 07:08 PM, Jean-Michel Hautbois wrote: > Hi Jaehoon, > >> On 09/09/2014 09:26 PM, Jean-Michel Hautbois wrote: >>> Tested on a i.MX6 board, with Sandisk SDIN5D1-2G. >>> Without this patch, I/O errors occur. >>> This eMMC seems to have a different Manufacturer ID as it reads 0x45 >>> an

[PATCH] mmc: dw_mmc-exynos: fixed wrong sample-clock selection

2014-09-15 Thread Jaehoon Chung
Almost all case is selected to 0. (It's not correct sample-clock value.) Since it set to wrong value, HS200 mode don't work fine. If we want to select the correct value, it has to check from 1 to 7.(skip 0) Signed-off-by: Jaehoon Chung --- drivers/mmc/host/dw_mmc-exynos.c |9 - 1 fil

Re: [PATCH] mmc: Add delay between CMD6 and CMD13 for Sandisk eMMC cards

2014-09-15 Thread Jean-Michel Hautbois
Hi Jaehoon, > On 09/09/2014 09:26 PM, Jean-Michel Hautbois wrote: >> Tested on a i.MX6 board, with Sandisk SDIN5D1-2G. >> Without this patch, I/O errors occur. >> This eMMC seems to have a different Manufacturer ID as it reads 0x45 >> and not 0x2 as specified in datasheet. > > I think this patch d