Re: [PATCH] mmc: don't request CD IRQ until mmc_start_host()

2014-09-17 Thread Adrian Hunter
On 09/18/2014 08:25 AM, Adrian Hunter wrote: > On 09/17/2014 10:57 PM, Stephen Warren wrote: >> On 09/17/2014 01:55 PM, Ulf Hansson wrote: >>> On 12 September 2014 19:18, Stephen Warren wrote: From: Stephen Warren As soon as the CD IRQ is requested, it can trigger, since it's an >>

Re: [PATCH] mmc: don't request CD IRQ until mmc_start_host()

2014-09-17 Thread Adrian Hunter
On 09/17/2014 10:57 PM, Stephen Warren wrote: > On 09/17/2014 01:55 PM, Ulf Hansson wrote: >> On 12 September 2014 19:18, Stephen Warren wrote: >>> From: Stephen Warren >>> >>> As soon as the CD IRQ is requested, it can trigger, since it's an >>> externally controlled event. If it does, delayed_w

[PATCH] sdhci: fix sd/emmc clear transfer mode issue

2014-09-17 Thread Vincent Wan
This patch is to fix AMD SD/eMMC host controller issue. We have seen this DMA false trigger after the following sequence: 1.The first command has data transfer and driver enable DMA. 2.Driver did not clear transfer mode register, and send second command. 3.The second command has a response with b

Re: [PATCH] mmc: block: change stop errors to info

2014-09-17 Thread Ulf Hansson
On 17 September 2014 09:50, Johan Rudholm wrote: > Stop command errors are not fatal to the transfer since we make sure > that the card returns to the transfer state and check the card status. > Change an unnecessary error to an info. > > Signed-off-by: Johan Rudholm Thanks! Applied for next. K

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-17 Thread Stephen Boyd
On 09/18, Ulf Hansson wrote: > 2014-09-15 23:45 GMT+02:00 Stephen Boyd : > > On 09/04/14 15:01, Stephen Boyd wrote: > >> > >> 8< > >> From: Stephen Boyd > >> Subject: [PATCH] mmc: Consolidate emmc tuning blocks > >> > >> The same tuning block array exists in the dw_mmc h.c and sdhci-msm.c

Re: [PATCH] mmc: dw_mmc: Remove unused function for !CONFIG_OF

2014-09-17 Thread Ulf Hansson
On 16 September 2014 09:54, Tobias Klauser wrote: > dw_mci_of_find_slot_node() is only used in dw_mci_of_get_slot_quirks() > if CONFIG_OF is defined, thus there is no need to have a !CONFIG_OF > version of it. Fixes the following compile warning with !CONFIG_OF: > > CC [M] drivers/mmc/host/dw_m

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-17 Thread Ulf Hansson
2014-09-15 23:45 GMT+02:00 Stephen Boyd : > On 09/04/14 15:01, Stephen Boyd wrote: >> >> 8< >> From: Stephen Boyd >> Subject: [PATCH] mmc: Consolidate emmc tuning blocks >> >> The same tuning block array exists in the dw_mmc h.c and sdhci-msm.c >> files. Move these into mmc.c so that they

Re: [PATCH 6/7] mmc: sdhci-esdhc-imx: add imx6sx support

2014-09-17 Thread Ulf Hansson
On 3 September 2014 14:05, Dong Aisheng wrote: > The imx6sx usdhc is derived from imx6sl, the difference is minor. > imx6sx have the errata ESDHC_FLAG_ERR004536 fixed. > So introduce a new compatible string for imx6sx to distinguish them. > > Signed-off-by: Dong Aisheng Hi Dong, This one has ch

Re: [PATCH v6 0003/0003] mmc: Checks EXT_CSD_PARTITION_SETTING_COMPLETED before partitions computation

2014-09-17 Thread Ulf Hansson
On 15 September 2014 17:47, Grégory Soutadé wrote: > Checks EXT_CSD_PARTITION_SETTING_COMPLETED bit before > computing enhanced user area offset and size, and > adding mmc general purpose partitions. The two needs > EXT_CSD_PARTITION_SETTING_COMPLETED bit be set to be > valid (as described in

Re: [PATCH v6 0002/0003] mmc: Replace "enhanced_area_en" attribute by "partition_setting_completed"

2014-09-17 Thread Ulf Hansson
On 15 September 2014 17:47, Grégory Soutadé wrote: > Replace ext_csd "enhanced_area_en" attribute by > "partition_setting_completed". It was used whether or > not enhanced user area is defined and without checks of > EXT_CSD_PARTITION_SETTING_COMPLETED bit. > > Signed-off-by: Grégory Soutadé

Re: [PATCH v6 0001/0003] mmc: Move code that manages user area and gp partitions into functions

2014-09-17 Thread Ulf Hansson
On 15 September 2014 17:47, Grégory Soutadé wrote: > Move code that manages user area and general purpose > partitions into functions. > > Signed-off-by: Grégory Soutadé Thanks! Applied for next. Kind regards Uffe > --- > drivers/mmc/core/mmc.c | 162 > ++---

Re: [PATCH v3] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock()

2014-09-17 Thread Ulf Hansson
On 14 September 2014 21:51, Sergei Shtylyov wrote: > I spent a couple of days with the driver just hanging due to me forgetting to > specify the external crystal frequency, so that clk_get_rate() returned 0 and > thus the loop in tmio_mmc_set_clock() never ended. I don't think that's an > accepta

Re: [PATCH] mmc: don't request CD IRQ until mmc_start_host()

2014-09-17 Thread Stephen Warren
On 09/17/2014 01:55 PM, Ulf Hansson wrote: On 12 September 2014 19:18, Stephen Warren wrote: From: Stephen Warren As soon as the CD IRQ is requested, it can trigger, since it's an externally controlled event. If it does, delayed_work host->detect will be scheduled. Many host controller probe

Re: [PATCH] mmc: don't request CD IRQ until mmc_start_host()

2014-09-17 Thread Ulf Hansson
On 12 September 2014 19:18, Stephen Warren wrote: > From: Stephen Warren > > As soon as the CD IRQ is requested, it can trigger, since it's an > externally controlled event. If it does, delayed_work host->detect will > be scheduled. > > Many host controller probe()s are roughly structured as: > >

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-17 Thread Ulf Hansson
On 17 September 2014 11:11, micky wrote: > On 09/17/2014 02:01 AM, Ulf Hansson wrote: >> >> On 12 September 2014 03:39, wrote: >>> >>> From: Roger Tseng >>> >>> Some platform have both UEFI driver and MFD/mmc driver, if entering >>> linux while card in the slot, the card power is already on, an

[PATCH] MAINTAINERS: omap_hsmmc: remove myself from MAINTAINERS

2014-09-17 Thread Balaji T K
As I won't be able to maintain omap_hsmmc driver Signed-off-by: Balaji T K --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5e7866a..b296e43 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6540,10 +6540,9 @@ S: Maintained

Re: [PATCH] mmc: dw_mmc-exynos: fixed wrong sample-clock selection

2014-09-17 Thread Alim Akhtar
Hi Jaehoon On Wed, Sep 17, 2014 at 8:06 AM, Jaehoon Chung wrote: > Hi, Alim. > > On 09/17/2014 07:27 AM, Alim Akhtar wrote: >> Hi Jaehoon, >> >> On Mon, Sep 15, 2014 at 3:56 PM, Jaehoon Chung >> wrote: >>> Almost all case is selected to 0. >>> (It's not correct sample-clock value.) >>> Since it

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-17 Thread micky
On 09/17/2014 02:01 AM, Ulf Hansson wrote: On 12 September 2014 03:39, wrote: From: Roger Tseng Some platform have both UEFI driver and MFD/mmc driver, if entering linux while card in the slot, the card power is already on, and rtsx-mmc driver have no chance to make card power off. This will

[PATCH] mmc: block: change stop errors to info

2014-09-17 Thread Johan Rudholm
Stop command errors are not fatal to the transfer since we make sure that the card returns to the transfer state and check the card status. Change an unnecessary error to an info. Signed-off-by: Johan Rudholm --- drivers/mmc/card/block.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-

Re: "Card stuck in programming state! __mmc_switch" problem on i.MX6 + eMMC

2014-09-17 Thread ELSOFT AG
Hi Jean-Michel Jean-Michel Hautbois wrote: > Can you show your DT (at least pinmux part and usdhc3 node) ? pinctrl_usdhc3: usdhc3grp { fsl,pins = < MX6QDL_PAD_SD3_CMD__SD3_CMD0x1b0b1 MX6QDL_PAD_SD3_CLK__SD3_CLK0x100b1