Re: [PATCH] mmc: atmel-mci: fix mismatched section on atmci_cleanup_slot

On Fri, Sep 26, 2014 at 09:34:58PM +0200, Arnd Bergmann wrote: As of 528bc7808f4e (mmc: atmel-mci: Release mmc resources on failure in probe), the atmci_probe() function calls atmci_cleanup_slot in the failure path. This causes a new warning whenever the driver is built: WARNING:

Re: [PATCH v3 03/12] clk: Add a function to retrieve phase

Hi Mike, On Sat, Sep 27, 2014 at 05:17:32PM -0700, Mike Turquette wrote: Quoting Maxime Ripard (2014-09-11 13:18:17) The current phase API doesn't look into the actual hardware to get the phase value, but will rather get it from a variable only set by the set_phase function. This will

[PATCH v2 3/9] omap_hsmmc: remove un-initialized callbacks from platform data

these callbacks are not set, probably legacy omap 1/2 features Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 5f2b5b7..f68ac1a 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@

[PATCH v2 2/9] omap_hsmmc: remove unused fields in platform_data

platform data is built from omap2_hsmmc_info, remove all fields that are never set in omap_hsmmc_info, hence never copied to platform data. Note that the omap_hsmmc driver never used any of these fields, they were completely unused compile tested for these platforms CONFIG_MACH_OMAP3_BEAGLE=y

[PATCH v2 5/9] omap_hsmmc: remove unused get_context_loss_count callback

trigger of this callback has been removed in 0a82e06e6183 Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/arch/arm/mach-omap2/hsmmc.c b/arch/arm/mach-omap2/hsmmc.c index 1c10402..312f13d 100644 --- a/arch/arm/mach-omap2/hsmmc.c +++ b/arch/arm/mach-omap2/hsmmc.c @@ -32,17 +32,6 @@

[PATCH v2 0/9] unshare and simplify omap_hsmmc platform struct

v2: - replace erroneous mmci by omap1/2 - add description to all patches - full compile check with: CONFIG_MACH_OMAP3_BEAGLE=y CONFIG_MACH_DEVKIT8000=y CONFIG_MACH_OMAP_LDP=y CONFIG_MACH_OMAP3530_LV_SOM=y CONFIG_MACH_OMAP3_TORPEDO=y

[PATCH v2 9/9] omap_hsmmc: remove unused slot_id parameter

omap_hsmmc only supports one slot. So slot id is always zero, and slot id is never used in the callbacks Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c index 0a8ac84..3d5040f 100644 ---

[PATCH v2 7/9] omap_hsmmc: pass mmc_priv struct to gpio init / free

this is needed when installing callbacks in the host struct and not in the platform data, e.g. cover detect irq should be stored in omap_hsmmc_host and not platform data Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c

[PATCH v2 4/9] omap_hsmmc: remove un-ready power_saving field in omap2_hsmmc_info

these fields are never read, probably an unimplemented feature or superseded by pm_runtime Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c index ddfc8df..0a8ac84 100644 ---

[PATCH v2 6/9] omap_hsmmc: remove unnecessary omap_hsmmc_slot_data indirection

omap_hsmmc supports only one slot per controller, see OMAP_MMC_MAX_SLOTS. This unnecessary indirection leads to confusion in the omap_hsmmc driver. For example the card_detect callback is not installed by platform code but from the driver probe function. So it should be a field of omap_hsmmc_host.

[PATCH v2 1/9] omap_hsmmc: use separate platform data for ompa3 and omap 1/2 driver

- mmci driver supports multiple slots, omap_hsmmc only one this leads to one of the major confusions in the omap_hsmmc driver - platform data should be read-only for the driver most callbacks are not set by the omap3 platform init code while being required by the driver, leading to the fact that

[PATCH v2 8/9] omap_hsmmc: Remove unnecessary callbacks from platform data

These callbacks are set during driver probe and not from the platform init, -- evtl. they had been for oamp 1/2 -- for omap3 they are local functions of the driver. These indirection could be dropped altogether in favor of regular function calls TODO Signed-off-by: Andreas Fenkart

Re: [PATCH] mmc: atmel-mci: fix mismatched section on atmci_cleanup_slot

On 26 September 2014 21:34, Arnd Bergmann a...@arndb.de wrote: As of 528bc7808f4e (mmc: atmel-mci: Release mmc resources on failure in probe), the atmci_probe() function calls atmci_cleanup_slot in the failure path. This causes a new warning whenever the driver is built: WARNING:

Re: [PATCH 2/6] mmc: Fix incorrect warning when setting 0 Hz via debugfs

On 23 September 2014 22:00, Adrian Hunter adrian.hun...@intel.com wrote: It is possible to turn off the card clock by setting the frequency to zero via debugfs e.g. echo 0 /sys/kernel/debug/mmc0/clock However that produces an incorrect warning that is designed to warn if the

Re: [PATCH 1/6] mmc: Fix use of wrong device in mmc_gpiod_free_cd()

On 23 September 2014 22:00, Adrian Hunter adrian.hun...@intel.com wrote: mmc_gpiod_free_cd() is paired with mmc_gpiod_request_cd() and both must reference the same device which is the actual host controller device not the mmc_host class device. Signed-off-by: Adrian Hunter

Re: [PATCH V2 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

Hi, On Friday, August 29, 2014 01:34:44 PM Ulf Hansson wrote: On 22 August 2014 15:47, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote: This patch makes use of mmc_regulator_get_supply() to handle the vmmc and vqmmc regulators.Also it moves the code handling the these regulators to

Re: [PATCH V2 2/3] mmc: dw_mmc: Support voltage changes

Hi, On Friday, August 29, 2014 01:43:16 PM Ulf Hansson wrote: On 25 August 2014 22:59, Doug Anderson diand...@google.com wrote: Ulf, On Mon, Aug 25, 2014 at 1:31 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 22 August 2014 22:38, Doug Anderson diand...@google.com wrote: Ulf, On

[PATCH] mmc: sdhci-pxav3: Fix Sparse warning of duplicate set_uhs_signaling entry

This fixes below sparse warning: drivers/mmc/host/sdhci-pxav3.c:227:10: warning: Initializer entry defined twice drivers/mmc/host/sdhci-pxav3.c:232:10: also defined here by removing duplicate initialization of .set_uhs_signaling in struct sdhci_ops. Also does away with duplcated function. Cc:

eMMC and mkfs.ext3 hangs without -E nodiscard

Hi all, on kernel 3.16.3 running on an i.MX6 with an eMMC card formatting a partition won't work, it hangs. With an added -v the last thing it spit out is Discarding device blocks: 4096/196608. When I run mkfs with -E nodiscard, formatting booting works. Noteworthy: when the eMMC device was

Re: eMMC and mkfs.ext3 hangs without -E nodiscard

On Monday 29 September 2014 15:46:10 Holger Schurig wrote: on kernel 3.16.3 running on an i.MX6 with an eMMC card formatting a partition won't work, it hangs. With an added -v the last thing it spit out is Discarding device blocks: 4096/196608. When I run mkfs with -E nodiscard, formatting

Re: Card stuck in programming state! __mmc_switch problem on i.MX6 + eMMC

Hi David, On Tue, Sep 16, 2014 at 11:37 AM, David Müller (ELSOFT AG) d.muel...@elsoft.ch wrote: Hello I have a custom i.MX6Q based board with a Hynix eMMC chip attached to USDHC3. OS is a vanilla Linux 3.16 with some patches. Loading the iMX SDHC driver results in the following error:

Re: [PATCH V2 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

Hi On 09/29/2014 09:31 PM, Bartlomiej Zolnierkiewicz wrote: Hi, On Friday, August 29, 2014 01:34:44 PM Ulf Hansson wrote: On 22 August 2014 15:47, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote: This patch makes use of mmc_regulator_get_supply() to handle the vmmc and vqmmc regulators.Also