Re: [PATCHv2 4/5] mmc: shdci-bcm2835: add verify for 32-bit back-to-back workaround

2014-11-05 Thread Stephen Warren
On 11/05/2014 12:00 AM, Scott Branden wrote: > On 14-11-04 08:59 PM, Stephen Warren wrote: >> On 10/30/2014 12:36 AM, Scott Branden wrote: >>> Add a verify option to driver to print out an error message if a >>> potential back to back write could cause a clock domain issue. >> >>> index f8c450a..11

Re: [PATCHv2 5/5] mmc: sdhci-bcm2835: add sdhci quirk SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12

2014-11-05 Thread Stephen Warren
On 11/05/2014 12:02 AM, Scott Branden wrote: > On 14-11-04 09:00 PM, Stephen Warren wrote: >> On 10/30/2014 12:36 AM, Scott Branden wrote: >>> SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 is missing and needed for this >>> controller. >> >> This seems fine, although any explanation of why this quirk is neede

Re: [PATCHv2 3/5] mmc: shdci-bcm2835: add efficient back-to-back write workaround

2014-11-05 Thread Stephen Warren
On 11/04/2014 11:55 PM, Scott Branden wrote: > On 14-11-04 08:57 PM, Stephen Warren wrote: >> On 10/30/2014 12:36 AM, Scott Branden wrote: >>> The bcm2835 has clock domain issues when back to back writes to certain >>> registers are written. The existing driver works around this issue with >>> ude

[PATCH] mmc_block: Increase max_devices

2014-11-05 Thread Ben Hutchings
Currently the driver imposes a limit of 256 total minor numbers, apparently based on the historic Unix/Linux limit. This is quite restrictive, particularly if we raise the maximum number of partitions per card to 256 to match sd. In order to make the full minor number space available we would hav

Re: Possible regression with commit 52221610d

2014-11-05 Thread Alexandre Courbot
On 11/06/2014 12:27 AM, Tim Kryger wrote: On Wed, Nov 5, 2014 at 12:10 AM, Alexandre Courbot wrote: On 11/05/2014 12:31 AM, Tim Kryger wrote: On Tue, Nov 4, 2014 at 1:00 AM, Alexandre Courbot wrote: Hi Tim, thanks for your reply! On 11/04/2014 02:28 PM, Tim Kryger wrote: On Mon, Nov 3,

RE: [ulf.hansson-mmc:next 72/74] drivers/mmc/host/atmel-mci.c:2593: error: 'atmci_dev_pm_ops' undeclared here (not in a function)

2014-11-05 Thread Yang, Wenyou
Thank you very much! > -Original Message- > From: Ulf Hansson [mailto:ulf.hans...@linaro.org] > Sent: Wednesday, November 05, 2014 9:01 PM > To: Yang, Wenyou > Cc: linux-mmc > Subject: Re: [ulf.hansson-mmc:next 72/74] drivers/mmc/host/atmel-mci.c:2593: > error: 'atmci_dev_pm_ops' undeclare

Re: [PATCH v2] [RESEND] mmc: add Toshiba PCI SD controller driver

2014-11-05 Thread Ondrej Zary
On Tuesday 04 November 2014 22:41:44 Ondrej Zary wrote: > On Tuesday 04 November 2014 12:09:44 Ulf Hansson wrote: > > On 2 November 2014 22:51, Ondrej Zary wrote: > > > This patch resurrects an old never-finished driver for Toshiba PCI SD > > > controllers found in some older Toshiba laptops (such

userspace interface of emmc reliable write

2014-11-05 Thread Meng Wang
Hello everyone, I have an arndale board which equips with KLM4G1FE3B-B001 emmc chip. According to the datasheet, it's compatible with emmc 4.1 spec and support reliable write. I want to measure the reliable write performance but I didn't find the user space interface. Could anyone give me some sugg

Re: Possible regression with commit 52221610d

2014-11-05 Thread Tim Kryger
On Wed, Nov 5, 2014 at 12:10 AM, Alexandre Courbot wrote: > On 11/05/2014 12:31 AM, Tim Kryger wrote: >> >> On Tue, Nov 4, 2014 at 1:00 AM, Alexandre Courbot >> wrote: >>> >>> Hi Tim, thanks for your reply! >>> >>> On 11/04/2014 02:28 PM, Tim Kryger wrote: On Mon, Nov 3, 2014 at 7:

Re: [PATCH v2 3/4] mmc: core: turn hw_reset into a bus_ops

2014-11-05 Thread Johan Rudholm
Hi Adrian, 2014-11-05 13:10 GMT+01:00 Adrian Hunter : > On 04/11/14 17:07, Johan Rudholm wrote: >> Move the (e)MMC specific hw_reset code from core.c into mmc.c and call >> it from the new bus_ops member hw_reset. This also lets us add code >> for reseting SD cards as well. >> >> Signed-off-by: Jo

Re: [PATCH 3/4] mmc: sdhci: Clear also HS400 1.2V capability if 1.2V is not supported

2014-11-05 Thread Ulf Hansson
On 5 November 2014 14:50, Adrian Hunter wrote: > On 05/11/14 15:36, Ulf Hansson wrote: >> On 31 October 2014 13:22, Adrian Hunter wrote: >>> 1.2V HS200 mode capability is cleared if there is not a voltage >>> regulator that supports 1.2V. Do the same for 1.2V HS400 mode. >>> >>> Signed-off-by: A

Re: [PATCH 3/4] mmc: sdhci: Clear also HS400 1.2V capability if 1.2V is not supported

2014-11-05 Thread Adrian Hunter
On 05/11/14 15:36, Ulf Hansson wrote: > On 31 October 2014 13:22, Adrian Hunter wrote: >> 1.2V HS200 mode capability is cleared if there is not a voltage >> regulator that supports 1.2V. Do the same for 1.2V HS400 mode. >> >> Signed-off-by: Adrian Hunter >> --- >> drivers/mmc/host/sdhci.c | 13

Re: [PATCH 3/4] mmc: sdhci: Clear also HS400 1.2V capability if 1.2V is not supported

2014-11-05 Thread Ulf Hansson
On 31 October 2014 13:22, Adrian Hunter wrote: > 1.2V HS200 mode capability is cleared if there is not a voltage > regulator that supports 1.2V. Do the same for 1.2V HS400 mode. > > Signed-off-by: Adrian Hunter > --- > drivers/mmc/host/sdhci.c | 13 +++-- > include/linux/mmc/host.h | 1

Re: [PATCH] mmc: dw_mmc: add the message for deprecating supports-highspeed

2014-11-05 Thread Ulf Hansson
On 4 November 2014 09:30, Jaehoon Chung wrote: > Recommend to use "mmc-cap-highspeed" or "sd-cap-highspeed" instead of > "supports-highspeed". > Although "supports-highspeed" supports, devloper can use > "mmc-cap-highspeed" or "sd-cap-highspeed" through this message. > > Signed-off-by: Jaehoon Chu

Re: [ulf.hansson-mmc:next 72/74] drivers/mmc/host/atmel-mci.c:2593: error: 'atmci_dev_pm_ops' undeclared here (not in a function)

2014-11-05 Thread Ulf Hansson
On 5 November 2014 13:16, kbuild test robot wrote: > tree: https://git.linaro.org/people/ulf.hansson/mmc next > head: c78dfc314bb79d5a364b6764f07e1e7fd6229391 > commit: 0ad8e93fc8ad5c815dc3b5a298ce05e2df6da0b8 [72/74] mmc: atmel-mci: add > runtime pm support > config: avr32-atngw100_mrmt_defc

Re: [PATCH v2 2/4] mmc: core: group default initial state

2014-11-05 Thread Johan Rudholm
Hi Ulf, 2014-11-05 11:13 GMT+01:00 Ulf Hansson : > On 4 November 2014 16:07, Johan Rudholm wrote: >> mmc_do_hw_reset, mmc_power_up and mmc_power_off all set the same >> group of initial values, simplify by sticking them together. > > That's not entirely true. This patch will actually change the >

Re: [PATCH v2 3/4] mmc: core: turn hw_reset into a bus_ops

2014-11-05 Thread Adrian Hunter
On 04/11/14 17:07, Johan Rudholm wrote: > Move the (e)MMC specific hw_reset code from core.c into mmc.c and call > it from the new bus_ops member hw_reset. This also lets us add code > for reseting SD cards as well. > > Signed-off-by: Johan Rudholm > --- > drivers/mmc/card/mmc_test.c |3 -- >

Re: [PATCH v3 3/3] mmc:sdhci-pci: enable sdhci doesn't support hs200 quirk for AMD sdhci

2014-11-05 Thread Ulf Hansson
On 5 November 2014 07:09, Vincent Wan wrote: > AMD SD controller supports the SDR104 mode, but caps2 can not > be promoted to support hs200 for eMMC. > > Signed-off-by: Vincent Wan > Signed-off-by: Wan Zongshun Thanks! Applied for next. Kind regards Uffe > --- > drivers/mmc/host/sdhci-pci.c

Re: [PATCH v3 1/3] mmc:sdhci: Add a quirk for AMD SDHC transfer mode register need to be cleared for cmd without data

2014-11-05 Thread Ulf Hansson
On 5 November 2014 07:09, Vincent Wan wrote: > SDHC controller in AMD chipsets require SDHC transfer mode > register to be cleared for commands without data. The issue was > uncovered during testing eMMC cards on KB/ML based platforms > > Signed-off-by: Vincent Wan > Signed-off-by: Wan Zongshun

Re: [PATCH v3 2/3] mmc:sdhci-pci: enable the clear transfer mode register quirk for AMD sdhci

2014-11-05 Thread Ulf Hansson
On 5 November 2014 07:09, Vincent Wan wrote: > This patch is to enable the quirk for AMD sdhci requiring transfer > mode register need to be cleared for commands without data > > Signed-off-by: Vincent Wan > Signed-off-by: Wan Zongshun Thanks! Applied for next. Kind regards Uffe > --- > dri

Re: [PATCH v2 2/4] mmc: core: group default initial state

2014-11-05 Thread Ulf Hansson
On 4 November 2014 16:07, Johan Rudholm wrote: > mmc_do_hw_reset, mmc_power_up and mmc_power_off all set the same > group of initial values, simplify by sticking them together. That's not entirely true. This patch will actually change the behaviour for the "ios.bus_mode", which isn't exactly what

Re: [PATCH v2 1/4] mmc: core: use mmc_send_status to check hw_reset

2014-11-05 Thread Ulf Hansson
On 4 November 2014 16:07, Johan Rudholm wrote: > Signed-off-by: Johan Rudholm Thanks! Applied for next. Kind regards Uffe > --- > drivers/mmc/core/core.c | 10 ++ > 1 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c >

Re: [PATCH] mmc: core: fix card detection regression

2014-11-05 Thread Ulf Hansson
On 5 November 2014 01:22, Kristina Martšenko wrote: > Since commit 89168b489915 ("mmc: core: restore detect line inversion > semantics"), the SD card on i.MX28 (and possibly other) devices isn't > detected and booting stops at: > > [4.120617] Waiting for root device /dev/mmcblk0p3... > > This

Re: [PATCH 2/2] mmc-utils: add support to create gp partition

2014-11-05 Thread Mickael Legrand
Hi, can I suggest to you this little fix: --- mmc-utils.ref/mmc_cmds.c2014-11-05 09:38:49.567266375 +0100 +++ mmc-utils/mmc_cmds.c2014-11-05 10:15:00.002010783 +0100 @@ -618,7 +618,7 @@ ext_attr = strtol(argv[5], NULL, 10); device = argv[6]; - if (partition < 0

Re: Possible regression with commit 52221610d

2014-11-05 Thread Alexandre Courbot
On 11/05/2014 12:31 AM, Tim Kryger wrote: On Tue, Nov 4, 2014 at 1:00 AM, Alexandre Courbot wrote: Hi Tim, thanks for your reply! On 11/04/2014 02:28 PM, Tim Kryger wrote: On Mon, Nov 3, 2014 at 7:05 PM, Alexandre Courbot wrote: Hi guys, On the NVIDIA shield (tegra114-roth) platform, I h