Re: [PATCH 3/4] mmc: sunxi: Reset behavior fix

2014-12-16 Thread Hans de Goede
Hi, On 16-12-14 01:37, David Lanzendörfer wrote: When there is only one DES available the DMA performs a FIFO reset and waits until the reinitialization has been completed. Disabling the SDXC_IDMAC_DES0_DIC bit prevents the DMA from sending an interrupt after it has finished this

[PATCH] mmc: mmci: Get rid of unused variable and operations on it

2014-12-16 Thread Pramod Gurav
DMA configuration has been removed from function mmci_dma_setup but the local mask variable was not removed. This remains unused hence remove it from the function and operations on it Signed-off-by: Pramod Gurav pramod.gu...@smartplayin.com --- drivers/mmc/host/mmci.c |5 - 1 file

[PATCH 0/4] mmc: sunxi: General fixup (v2)

2014-12-16 Thread David Lanzendörfer
Hello This patchset was inspired questions from 李想 of Allwinner and incorporates as well suggestions from Hans related to spin locks. For example have not all attributes of the shared host object been protected by the spin lock, this has been changed. Also some register names and reset behavior

[PATCH 4/4] mmc: sunxi: Removing unused code

2014-12-16 Thread David Lanzendörfer
Removing a relict from reverse engineering of the Android driver code in sunxi_mmc_clk_set_rate. Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch Reported-by: 李想 lixi...@allwinnertech.com --- drivers/mmc/host/sunxi-mmc.c | 10 +- 1 file changed, 1 insertion(+), 9

[PATCH 3/4] mmc: sunxi: Correcting SDXC_HARDWARE_RESET bit

2014-12-16 Thread David Lanzendörfer
Fixing the register name in sunxi_mmc_reset_host since the SDXC_HARDWARE_RESET bit is actually located within REG_GCTRL and not REG_CMDR as it was pointed out by Allwinner. Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch Reported-by: 李想 lixi...@allwinnertech.com ---

[PATCH 1/4] mmc: sunxi: Fix setup of last descriptor of dma transfer

2014-12-16 Thread David Lanzendörfer
From: Hans de Goede hdego...@redhat.com The last descriptor might be the first descriptor as well, so use masking to add the LD (last descriptor) bit and drop the DIC (disable interrupt on completion) bit rather then hard assignment as hard assigment will override the FD (first descriptor) bit if

[PATCH 2/4] mmc: sunxi: Lock fix

2014-12-16 Thread David Lanzendörfer
1) Adding a comment in order to clarify the choice of the locks within sunxi_mmc_handle_manual_stop 2) As 李想 has pointed out the wait_dma variable was not accessed within the spin lock block in sunxi_mmc_request and so (even if it should never happend) it would have

Re: [PATCH 0/4] mmc: sunxi: General fixup (v2)

2014-12-16 Thread Hans de Goede
Hi, On 16-12-14 15:10, David Lanzendörfer wrote: Hello This patchset was inspired questions from 李想 of Allwinner and incorporates as well suggestions from Hans related to spin locks. For example have not all attributes of the shared host object been protected by the spin lock, this has been

Re: Possible regression with commit 52221610d

2014-12-16 Thread Bjorn Andersson
On Mon, Dec 15, 2014 at 10:27 PM, Bjorn Andersson bj...@kryo.se wrote: On Sun, Dec 14, 2014 at 8:48 PM, Tim Kryger tim.kry...@gmail.com wrote: On Sat, Dec 13, 2014 at 11:22 PM, Bjorn Andersson bj...@kryo.se wrote: [..] Or simply; what is vmmc (in the code) supposed to represent? Hi Bjorn,

Re: Possible regression with commit 52221610d

2014-12-16 Thread Stephen Warren
On 12/14/2014 09:48 PM, Tim Kryger wrote: On Sat, Dec 13, 2014 at 11:22 PM, Bjorn Andersson bj...@kryo.se wrote: ... Or simply; what is vmmc (in the code) supposed to represent? Hi Bjorn, VMMC is the supply that delivers power out to the SD card itself (aka VDD). It is not the internal

[patch] mmc: mxs-mmc: remove unneeded NULL check

2014-12-16 Thread Dan Carpenter
Static checkers complain about the inconsistent NULL checking here: drivers/mmc/host/mxs-mmc.c:680 mxs_mmc_probe() warn: variable dereferenced before check 'ssp-dmach' (see line 660) The variable can't actually be NULL so we can remove the check. Signed-off-by: Dan Carpenter

Re: Possible regression with commit 52221610d

2014-12-16 Thread Tim Kryger
On Tue, Dec 16, 2014 at 10:18 AM, Bjorn Andersson bj...@kryo.se wrote: We are routing the regulators straight to vdd of the memory and should hence use vmmc to specify this. However unless I actually program 0x29 in the Qualcomm sdhci block I get no responses from the card. Which I believe