Re: [PATCH 2/9] mmc: tmio: tmio_mmc_host has .dma

2015-01-06 Thread Kuninori Morimoto
Hi Arnd > dmaengine: shdma: use normal interface for passing slave id > > The shmobile platform is one of only two users of the slave_id field > in dma_slave_config, which is incompatible with the way that the > dmaengine API normally works. > > I've had a closer look at the existing code now a

Re: [PATCH 2/9] mmc: tmio: tmio_mmc_host has .dma

2015-01-06 Thread Kuninori Morimoto
Hi Arnd, Ulf > > > > > The alignment_shift and dma_rx_offset values seem to always be > > > > > the same for all users (at least the remaining ones, possibly there > > > > > were others originally), so you could hardcode those in tmio_mmc_dma.c > > > > > and remove the tmio_mmc_dma structure enti

Re: [PATCH 2/9] mmc: tmio: tmio_mmc_host has .dma

2015-01-06 Thread Kuninori Morimoto
Hi Arnd Thank you for your DMAEngine fixup patch. I tried this patch, and have comment. > dmaengine: shdma: use normal interface for passing slave id > > The shmobile platform is one of only two users of the slave_id field > in dma_slave_config, which is incompatible with the way that the > dma

Re: [PATCH 2/9] mmc: tmio: tmio_mmc_host has .dma

2015-01-06 Thread Kuninori Morimoto
Hi Arnd, Ulf Thank you for your feedback > > Then, I want to try "dmaengine cleanup" patch-set as 2nd step if possible. > > I guess [8/9] and [9/9] are not good for "header cleanup" (?) I don't know. > > Arnd, Ulf, what is your opinion ? > > Patch 8 looks great to me. > > Patch 9 as I mentione

RTS5129 card reader fails to read SDXC card using the new kernel drivers

2015-01-06 Thread Adrian Sándor
Hi, I have a Lenovo Yoga 13 laptop with a Realtek RTS5129 card reader (0bda:0129) It used to work fine with the RTS5139 kernel driver, but apparently that driver was removed since kernel 3.16 and replaced with MFD_RTSX_USB / MMC_REALTEK_USB. I upgraded to kernel 3.18.1 and compiled those drivers

Re: [PATCH 1/2] mmc: host: arasan: Add addition of-arasan quirks and add IOMMU support.

2015-01-06 Thread Arnd Bergmann
On Tuesday 06 January 2015 17:10:29 Suman Tripathi wrote: > Hi Arnd, > > On Monday 15 December 2014 22:31:06 Suman Tripathi wrote: > > > @@ -162,6 +206,16 @@ static int sdhci_arasan_probe(struct > > > platform_device *pdev)> > > > > > goto clk_dis_ahb; > > > > > >

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-06 Thread Arnd Bergmann
On Tuesday 06 January 2015 11:45:58 Lars-Peter Clausen wrote: > On 01/05/2015 11:39 PM, Arnd Bergmann wrote: > > As discussed on the topic of shmobile DMA today, jz4740 is the only > > user of the slave_id field in dma_slave_config besides shmobile. This > > use is really incompatible with the way

Re: [PATCH 2/9] mmc: tmio: tmio_mmc_host has .dma

2015-01-06 Thread Arnd Bergmann
On Tuesday 06 January 2015 00:20:59 Kuninori Morimoto wrote: > > Hi Arnd, Ulf > > Thank you for your feedback > > > > > The slave_id/chan_priv values are now passed three times into the > > > > driver, and one should really be enough. I'd suggest removing the > > > > integer fields from both tmi

Re: [PATCH 2/9] mmc: tmio: tmio_mmc_host has .dma

2015-01-06 Thread Arnd Bergmann
On Tuesday 06 January 2015 02:38:53 Kuninori Morimoto wrote: > Hi Arnd again > > > > > The alignment_shift and dma_rx_offset values seem to always be > > > > the same for all users (at least the remaining ones, possibly there > > > > were others originally), so you could hardcode those in tmio_mmc

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-06 Thread Lars-Peter Clausen
On 01/06/2015 01:47 PM, Måns Rullgård wrote: Lars-Peter Clausen writes: On 01/05/2015 11:39 PM, Arnd Bergmann wrote: As discussed on the topic of shmobile DMA today, jz4740 is the only user of the slave_id field in dma_slave_config besides shmobile. This use is really incompatible with the wa

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-06 Thread Måns Rullgård
Lars-Peter Clausen writes: > On 01/05/2015 11:39 PM, Arnd Bergmann wrote: >> As discussed on the topic of shmobile DMA today, jz4740 is the only >> user of the slave_id field in dma_slave_config besides shmobile. This >> use is really incompatible with the way that other drivers use the >> dmaeng

Re: [PATCH 1/2] mmc: host: arasan: Add addition of-arasan quirks and add IOMMU support.

2015-01-06 Thread Suman Tripathi
Hi Arnd, On Monday 15 December 2014 22:31:06 Suman Tripathi wrote: > @@ -162,6 +206,16 @@ static int sdhci_arasan_probe(struct platform_device > *pdev) > goto clk_dis_ahb; > } > > +#if defined(CONFIG_IOMMU_SUPPORT) > + sdhci_arasan->domain = iommu_domain_alloc(&amba_

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-06 Thread Lars-Peter Clausen
On 01/05/2015 11:39 PM, Arnd Bergmann wrote: As discussed on the topic of shmobile DMA today, jz4740 is the only user of the slave_id field in dma_slave_config besides shmobile. This use is really incompatible with the way that other drivers use the dmaengine API, so we should get rid of it. Do