Re: [PATCH 3/5] mmc: card: Add eMMC command queuing support in mmc block layer

2015-01-15 Thread Asutosh Das
Hi Ulf Thanks for reviewing the patchset. On 1/15/2015 7:26 PM, Ulf Hansson wrote: On 2 December 2014 at 12:58, Asutosh Das wrote: Command queueing is defined in eMMC-5.1. It is designed for higher performance by ensuring upto 32 requests to be serviced at a time. All non-data commands are ref

Re: [PATCH 2/5] mmc: queue: initialization of command-queue support

2015-01-15 Thread Asutosh Das
On 1/15/2015 4:07 PM, Ulf Hansson wrote: On 2 December 2014 at 12:57, Asutosh Das wrote: Add command queue initialization support. This is applicable for emmc devices supporting cmd-queueing. Signed-off-by: Asutosh Das Signed-off-by: Konstantin Dorfman --- drivers/mmc/card/queue.c | 74 +++

Re: [PATCH v3 4/4] mmc: sdhci: host: add new f_sdh30

2015-01-15 Thread Vincent Yang
2015-01-13 20:19 GMT+08:00 Ulf Hansson : > On 9 January 2015 at 12:41, Vincent Yang > wrote: >> This patch adds new host controller driver for >> Fujitsu SDHCI controller f_sdh30. >> >> Signed-off-by: Andy Green >> Signed-off-by: Vincent Yang >> Signed-off-by: Tetsuya Takinishi >> --- >> .../

Re: [PATCH 1/5] mmc: core: Add support to read command queue parameters

2015-01-15 Thread Asutosh Das
On 1/15/2015 2:40 PM, Ulf Hansson wrote: On 2 December 2014 at 12:56, Sujit Reddy Thumma wrote: eMMC cards with EXT_CSD version >= 7, optionally support command queuing feature as defined by Jedec eMMC5.1. Add support for probing command queue feature for such type of cards. Signed-off-by: Suj

Re: [PATCHv5] mmc: remove MMC_CAP_ERASE to enable trim in eMMC/SD Device

2015-01-15 Thread Jaehoon Chung
Hi, On 01/16/2015 08:17 AM, Puthikorn Voravootivat wrote: > *resend in text mode > Hi Ulf > > Is the bug regarding TRIM/ERASE/DISCARD already fixed by now? > Can you look at this patch one more time As i knew, it doesn't fix yet. But thanks for reminding this. I will also check this. Best Regar

Re: [PATCHv5] mmc: remove MMC_CAP_ERASE to enable trim in eMMC/SD Device

2015-01-15 Thread Puthikorn Voravootivat
*resend in text mode Hi Ulf Is the bug regarding TRIM/ERASE/DISCARD already fixed by now? Can you look at this patch one more time Regards, On Mon, May 26, 2014 at 7:44 AM, Ulf Hansson wrote: > On 26 May 2014 10:29, Jaehoon Chung wrote: >> From: Puthikorn Voravootivat >> >> Remove MMC_CAP_ERA

Re: [PATCH V2 2/4] mmc: pwrseq: Document DT bindings for the simple MMC power sequence

2015-01-15 Thread NeilBrown
On Thu, 15 Jan 2015 16:58:26 + Mark Rutland wrote: > Hi Ulf, > > On Wed, Jan 14, 2015 at 01:02:08PM +, Ulf Hansson wrote: > > The simple MMC power sequence provider, intends to supports a set of > > common properties between SOC designs. It thus enables us to re-use the > > same provider

Re: [PATCH v2 08/11] mmc: pwrseq_simple: Add support for a delay

2015-01-15 Thread Stephen Warren
On 01/15/2015 09:12 AM, Tomeu Vizoso wrote: Signed-off-by: Tomeu Vizoso Ah, having read the explanation in the next patch, I think ... diff --git a/Documentation/devicetree/bindings/mmc/mmc,pwrseq-simple.txt b/Documentation/devicetree/bindings/mmc/mmc,pwrseq-simple.txt +- delay : delay t

Re: [PATCH v2 08/11] mmc: pwrseq_simple: Add support for a delay

2015-01-15 Thread Stephen Warren
On 01/15/2015 09:12 AM, Tomeu Vizoso wrote: Signed-off-by: Tomeu Vizoso Some explanation of why such a delay might be useful would be ... useful! -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH V2 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-01-15 Thread Mark Rutland
Hi, On Wed, Jan 14, 2015 at 01:02:10PM +, Ulf Hansson wrote: > The need for a reset GPIO has several times been pointed out from > earlier posted patchsets. Especially some WLAN chips which are > attached to an SDIO interface may use a GPIO reset. > > In this first version, one reset pin is s

Re: [PATCH V2 2/4] mmc: pwrseq: Document DT bindings for the simple MMC power sequence

2015-01-15 Thread Mark Rutland
Hi Ulf, On Wed, Jan 14, 2015 at 01:02:08PM +, Ulf Hansson wrote: > The simple MMC power sequence provider, intends to supports a set of > common properties between SOC designs. It thus enables us to re-use the > same provider for several SOCs. > > In this initial step, let's add the top level

[PATCH v2 08/11] mmc: pwrseq_simple: Add support for a delay

2015-01-15 Thread Tomeu Vizoso
Signed-off-by: Tomeu Vizoso --- Documentation/devicetree/bindings/mmc/mmc,pwrseq-simple.txt | 2 ++ drivers/mmc/core/pwrseq_simple.c| 8 2 files changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/mmc,pwrseq-simple.txt b/Documentatio

Re: [RFC 0/3] mmc: Add dynamic frequency scaling

2015-01-15 Thread Tomeu Vizoso
On 12 January 2015 at 10:23, Krzysztof Kozlowski wrote: > Hi, > > > I would like to hear some comments about idea of scaling MMC clock > frequency. The basic idea is to lower the clock when device is > completely idle or not busy enough. > > The patchset adds MMC card as a devfreq device and uses

Re: [PATCH 02/13] mmc: host: Add facility to support re-tuning

2015-01-15 Thread Arend van Spriel
On 01/15/15 15:46, Ulf Hansson wrote: On 15 January 2015 at 15:17, Arend van Spriel wrote: On 01/15/15 15:07, Arend van Spriel wrote: On 01/15/15 14:39, Ulf Hansson wrote: On 15 January 2015 at 11:17, Adrian Hunter wrote: On 14/01/15 14:59, Ulf Hansson wrote: [...] The value from the

Re: [PATCH 02/13] mmc: host: Add facility to support re-tuning

2015-01-15 Thread Ulf Hansson
On 15 January 2015 at 15:17, Arend van Spriel wrote: > On 01/15/15 15:07, Arend van Spriel wrote: >> >> On 01/15/15 14:39, Ulf Hansson wrote: >>> >>> On 15 January 2015 at 11:17, Adrian Hunter >>> wrote: On 14/01/15 14:59, Ulf Hansson wrote: > > [...] > >>> >>> The va

Re: [PATCH 02/13] mmc: host: Add facility to support re-tuning

2015-01-15 Thread Arend van Spriel
On 01/15/15 15:07, Arend van Spriel wrote: On 01/15/15 14:39, Ulf Hansson wrote: On 15 January 2015 at 11:17, Adrian Hunter wrote: On 14/01/15 14:59, Ulf Hansson wrote: [...] The value from the register is also just randomly selected, only difference is that it's the HW that has randomly se

Re: [PATCH 02/13] mmc: host: Add facility to support re-tuning

2015-01-15 Thread Arend van Spriel
On 01/15/15 14:39, Ulf Hansson wrote: On 15 January 2015 at 11:17, Adrian Hunter wrote: On 14/01/15 14:59, Ulf Hansson wrote: [...] The value from the register is also just randomly selected, only difference is that it's the HW that has randomly set it. Presumably the value is chosen base

Re: [PATCH 3/5] mmc: card: Add eMMC command queuing support in mmc block layer

2015-01-15 Thread Ulf Hansson
On 2 December 2014 at 12:58, Asutosh Das wrote: > Command queueing is defined in eMMC-5.1. It is designed for > higher performance by ensuring upto 32 requests to be serviced > at a time. > All non-data commands are referred as DCMD commands and are handled > differently than conventional eMMCs. >

Re: [PATCH 02/13] mmc: host: Add facility to support re-tuning

2015-01-15 Thread Ulf Hansson
On 15 January 2015 at 11:17, Adrian Hunter wrote: > On 14/01/15 14:59, Ulf Hansson wrote: >> [...] >> The value from the register is also just randomly selected, only difference is that it's the HW that has randomly set it. >>> >>> Presumably the value is chosen based on the maximum

Re: [PATCH 2/5] mmc: queue: initialization of command-queue support

2015-01-15 Thread Ulf Hansson
On 2 December 2014 at 12:57, Asutosh Das wrote: > Add command queue initialization support. This is > applicable for emmc devices supporting cmd-queueing. > > Signed-off-by: Asutosh Das > Signed-off-by: Konstantin Dorfman > --- > drivers/mmc/card/queue.c | 74 >

Re: [PATCH 02/13] mmc: host: Add facility to support re-tuning

2015-01-15 Thread Adrian Hunter
On 14/01/15 14:59, Ulf Hansson wrote: > [...] > >>> >>> The value from the register is also just randomly selected, only >>> difference is that it's the HW that has randomly set it. >> >> Presumably the value is chosen based on the maximum rate of temperature >> change and the corresponding effect

Re: [RFC 0/3] mmc: Add dynamic frequency scaling

2015-01-15 Thread Ulf Hansson
On 15 January 2015 at 10:20, Krzysztof Kozlowski wrote: > On czw, 2015-01-15 at 09:20 +0100, Ulf Hansson wrote: >> + Mike, Stephen (Clock maintainers) >> >> On 12 January 2015 at 10:23, Krzysztof Kozlowski >> wrote: >> > Hi, >> > >> > >> > I would like to hear some comments about idea of scaling

Re: [RFC 0/3] mmc: Add dynamic frequency scaling

2015-01-15 Thread Krzysztof Kozlowski
On czw, 2015-01-15 at 09:20 +0100, Ulf Hansson wrote: > + Mike, Stephen (Clock maintainers) > > On 12 January 2015 at 10:23, Krzysztof Kozlowski > wrote: > > Hi, > > > > > > I would like to hear some comments about idea of scaling MMC clock > > frequency. The basic idea is to lower the clock when

Re: [PATCH 1/5] mmc: core: Add support to read command queue parameters

2015-01-15 Thread Ulf Hansson
On 2 December 2014 at 12:56, Sujit Reddy Thumma wrote: > eMMC cards with EXT_CSD version >= 7, optionally support command > queuing feature as defined by Jedec eMMC5.1. Add support for probing > command queue feature for such type of cards. > > Signed-off-by: Sujit Reddy Thumma > Signed-off-by: A

[GIT PULL] MMC fixes for v.3.19, take 3

2015-01-15 Thread Ulf Hansson
Hi Linus, Here is one more mmc fix for 3.19, take 3. I expect this to be the last fix for mmc for 3.19. Do note that it's based on your master branch from yesterday and not on an rc which is what I do normally. If you don't like it like this, I can re-base it next week. Details are as usual foun

Re: [RFC 0/3] mmc: Add dynamic frequency scaling

2015-01-15 Thread Ulf Hansson
+ Mike, Stephen (Clock maintainers) On 12 January 2015 at 10:23, Krzysztof Kozlowski wrote: > Hi, > > > I would like to hear some comments about idea of scaling MMC clock > frequency. The basic idea is to lower the clock when device is > completely idle or not busy enough. We already have host d