Re: [PATCH v3 4/4] mmc: sdhci: host: add new f_sdh30

2015-01-16 Thread Vincent Yang
2015-01-16 16:36 GMT+08:00 Ulf Hansson : > [...] > + pm_runtime_set_active(&pdev->dev); + pm_runtime_enable(&pdev->dev); + ret = pm_runtime_get_sync(&pdev->dev); + if (ret < 0) + dev_err(dev, "Failed to pm_runtime_get_sync: %d\n", ret);

Re: [PATCH] mmc: sdhci-s3c: solve problem with sleeping in atomic context

2015-01-16 Thread Krzysztof Kozlowski
On piÄ…, 2015-01-16 at 15:30 +0100, Paul Osmialowski wrote: > This change addresses following problem: > > [2.560726] [ cut here ] > [2.565341] WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2744 > lockdep_trace_alloc+0xec/0x118() > [2.574439] DEBUG_LOCKS_WA

[PATCH] mmc: sdhci-s3c: solve problem with sleeping in atomic context

2015-01-16 Thread Paul Osmialowski
This change addresses following problem: [2.560726] [ cut here ] [2.565341] WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2744 lockdep_trace_alloc+0xec/0x118() [2.574439] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) [2.579821] Modules linked in: [

Re: [PATCH V3 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-01-16 Thread Ulf Hansson
On 16 January 2015 at 13:45, Sascha Hauer wrote: > On Fri, Jan 16, 2015 at 01:37:41PM +0100, Ulf Hansson wrote: >> On 16 January 2015 at 12:34, Tomeu Vizoso wrote: >> > On 16 January 2015 at 11:47, Ulf Hansson wrote: >> >> >> >> int mmc_pwrseq_simple_alloc(struct mmc_host *host, struct device *

Re: [PATCH V3 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-01-16 Thread Sascha Hauer
On Fri, Jan 16, 2015 at 01:37:41PM +0100, Ulf Hansson wrote: > On 16 January 2015 at 12:34, Tomeu Vizoso wrote: > > On 16 January 2015 at 11:47, Ulf Hansson wrote: > >> > >> int mmc_pwrseq_simple_alloc(struct mmc_host *host, struct device *dev) > >> { > >> struct mmc_pwrseq_simple *pwrs

Re: [PATCH V3 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-01-16 Thread Ulf Hansson
On 16 January 2015 at 12:34, Tomeu Vizoso wrote: > On 16 January 2015 at 11:47, Ulf Hansson wrote: >> >> int mmc_pwrseq_simple_alloc(struct mmc_host *host, struct device *dev) >> { >> struct mmc_pwrseq_simple *pwrseq; >> + int ret = 0; >> >> pwrseq = kzalloc(sizeof(struct

Re: [PATCH V2 2/4] mmc: pwrseq: Document DT bindings for the simple MMC power sequence

2015-01-16 Thread Russell King - ARM Linux
On Fri, Jan 16, 2015 at 07:53:08AM +1300, NeilBrown wrote: > Also, it isn't clear to me whether the need for power/reset is a function of > the mmc-host, or a function of the device attached to the host. I suspect > some are needed by one, some by the other. Any by both? Neil, There's a horrid

Re: [PATCH V3 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-01-16 Thread Tomeu Vizoso
On 16 January 2015 at 11:47, Ulf Hansson wrote: > > int mmc_pwrseq_simple_alloc(struct mmc_host *host, struct device *dev) > { > struct mmc_pwrseq_simple *pwrseq; > + int ret = 0; > > pwrseq = kzalloc(sizeof(struct mmc_pwrseq_simple), GFP_KERNEL); > if (!pwrseq) >

[PATCH V3 1/4] mmc: core: Initial support for MMC power sequences

2015-01-16 Thread Ulf Hansson
System on chip designs may specify a specific MMC power sequence. To successfully detect an (e)MMC/SD/SDIO card, that power sequence must be followed while initializing the card. To be able to handle these SOC specific power sequences, let's add a MMC power sequence interface. It provides the foll

[PATCH V3 2/4] mmc: pwrseq: Document DT bindings for the simple MMC power sequence

2015-01-16 Thread Ulf Hansson
To support SOCs which specifies specific MMC power sequences, document some MMC DT bindings to be able to describe these hardwares. Let's also document bindings for a simple MMC power sequence provider, which purpose is to support a set of common properties between various SOCs. In this initial s

[PATCH V3 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-01-16 Thread Ulf Hansson
The need for reset GPIOs has several times been pointed out from erlier posted patchsets. Especially some WLAN chips which are attached to an SDIO interface may use a GPIO reset. The reset GPIO is asserted at initialization and prior we start the power up procedure. The GPIO will be de-asserted ri

[PATCH V3 3/4] mmc: pwrseq: Initial support for the simple MMC power sequence provider

2015-01-16 Thread Ulf Hansson
To add the core part for the MMC power sequence, let's start by adding initial support for the simple MMC power sequence provider. In this initial step, the MMC power sequence node are fetched and the compatible string for the simple MMC power sequence provider are verified. At this point we don'

[PATCH V3 0/4] mmc: core: Add support for MMC power sequences

2015-01-16 Thread Ulf Hansson
Changes in v3: Fixed comments from Mark Rutland: - Document binding in one patch to get the big picture. - Keep code and DT document consistent around how many GPIO resets we support. I decided to go for one GPIO, we can extend that if needed later on.

Re: [PATCH V2 2/4] mmc: pwrseq: Document DT bindings for the simple MMC power sequence

2015-01-16 Thread Ulf Hansson
On 15 January 2015 at 19:53, NeilBrown wrote: > On Thu, 15 Jan 2015 16:58:26 + Mark Rutland wrote: > >> Hi Ulf, >> >> On Wed, Jan 14, 2015 at 01:02:08PM +, Ulf Hansson wrote: >> > The simple MMC power sequence provider, intends to supports a set of >> > common properties between SOC desig

Re: [PATCH V2 2/4] mmc: pwrseq: Document DT bindings for the simple MMC power sequence

2015-01-16 Thread Ulf Hansson
On 15 January 2015 at 17:58, Mark Rutland wrote: > Hi Ulf, > > On Wed, Jan 14, 2015 at 01:02:08PM +, Ulf Hansson wrote: >> The simple MMC power sequence provider, intends to supports a set of >> common properties between SOC designs. It thus enables us to re-use the >> same provider for severa

Re: [PATCH V2 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-01-16 Thread Ulf Hansson
On 15 January 2015 at 18:04, Mark Rutland wrote: > Hi, > > On Wed, Jan 14, 2015 at 01:02:10PM +, Ulf Hansson wrote: >> The need for a reset GPIO has several times been pointed out from >> earlier posted patchsets. Especially some WLAN chips which are >> attached to an SDIO interface may use a

Re: [PATCH v3 4/4] mmc: sdhci: host: add new f_sdh30

2015-01-16 Thread Ulf Hansson
[...] >>> + pm_runtime_set_active(&pdev->dev); >>> + pm_runtime_enable(&pdev->dev); >>> + ret = pm_runtime_get_sync(&pdev->dev); >>> + if (ret < 0) >>> + dev_err(dev, "Failed to pm_runtime_get_sync: %d\n", ret); >> >> As I stated earlier I think this is a stra

Re: [PATCH 3/5] mmc: card: Add eMMC command queuing support in mmc block layer

2015-01-16 Thread Ulf Hansson
[...] >> >> Also, please don't forget to provide some perfomance numbers. > > I can provide some performance numbers in the last week of february or in > the beginning of March. Is that fine ? > Do you want the comments addressed before I publish the performance numbers > or do you prefer the comm