Re: [PATCH V2 11/15] mmc: sdhci: Change to new way of doing re-tuning

2015-03-23 Thread Ulf Hansson
On 10 March 2015 at 15:20, Adrian Hunter adrian.hun...@intel.com wrote: On 10/03/15 15:55, Ulf Hansson wrote: [...] @@ -2834,11 +2763,8 @@ int sdhci_runtime_suspend_host(struct sdhci_host *host) { unsigned long flags; - /* Disable tuning since we are suspending */ -

Re: [PATCH v4] mmc: OCTEON: Add host driver for OCTEON MMC controller

2015-03-23 Thread Ulf Hansson
[...] + +This controller is present on some members of the Cavium OCTEON SoC +family, provide an interface for eMMC, MMC and SD devices. There is a +single controller that may have several slots connected. These Even it it may have several slots, that's not being supported by the mmc

unrecognised SCR structure version when using beaglebone black MMC0

2015-03-23 Thread Da Shi Cao
When using my stripped version of kernel (3.18.9), the MMC0 will sometimes complain unrecognized SCR structure... when a microSD is inserted. This is because the driver function omap_hsmmc_request will always return garbage when called by mmc_app_send_scr. I didn't experienced this issue while

Re: [PATCH V2 11/15] mmc: sdhci: Change to new way of doing re-tuning

2015-03-23 Thread Ulf Hansson
[...] I have no locking issues, so I am not sure what you mean here. Okay, I should have stated race conditions. I think we need an generic approach to deal with the runtime PM synchronization issue described above. More precisely in those scenarios when mmc hosts needs to notify the

Re: [PATCH 2/4] mmc: core: allow non-blocking form of mmc_claim_host

2015-03-23 Thread Ulf Hansson
On 23 March 2015 at 10:58, Ulf Hansson ulf.hans...@linaro.org wrote: On 24 February 2015 at 03:42, NeilBrown ne...@suse.de wrote: Change the handling for the 'abort' flag so that if it is set, but we can claim the host, then do the claim, rather than aborting. When the abort is async this

Re: [PATCH V3 00/15] mmc: host: Add facility to support re-tuning

2015-03-23 Thread Adrian Hunter
On 16/03/15 16:00, Adrian Hunter wrote: On 10/03/15 14:42, Adrian Hunter wrote: Hi Here is V3 of some patches to move re-tuning support out of sdhci and into the core, and add support for HS400 re-tuning. Currently sdhci does re-tuning transparently by calling sdhci_execute_tuning() from

Re: [PATCH 2/4] mmc: core: allow non-blocking form of mmc_claim_host

2015-03-23 Thread Ulf Hansson
On 24 February 2015 at 03:42, NeilBrown ne...@suse.de wrote: Change the handling for the 'abort' flag so that if it is set, but we can claim the host, then do the claim, rather than aborting. When the abort is async this just means that a race between aborting an allowing a claim is resolved

Re: [PATCH V2 11/15] mmc: sdhci: Change to new way of doing re-tuning

2015-03-23 Thread Adrian Hunter
On 23/03/15 14:54, Ulf Hansson wrote: On 10 March 2015 at 15:20, Adrian Hunter adrian.hun...@intel.com wrote: On 10/03/15 15:55, Ulf Hansson wrote: [...] @@ -2834,11 +2763,8 @@ int sdhci_runtime_suspend_host(struct sdhci_host *host) { unsigned long flags; - /* Disable

[PATCH v3] mmc: sdhci-msm: Add support for vendor capabilities registers

2015-03-23 Thread Georgi Djakov
Some versions of this controller do not advertise their 3.0v and 8bit bus-width support capabilities. It is required to explicitly set these capabilities for the specific controller versions. Signed-off-by: Georgi Djakov georgi.dja...@linaro.org --- Changes since v2: * Use the generic sdhci

Re: [PATCH 3/4] mmc: sdio: support switching to 1-bit before turning off clocks

2015-03-23 Thread Ulf Hansson
On 24 February 2015 at 03:42, NeilBrown ne...@suse.de wrote: According to section 7.1.2 of http://www.sandisk.com/media/File/OEM/Manuals/SD_SDIO_specsv1.pdf In the case where the interrupt mechanism is used to wake the host while the card is in a low power state (i.e. no clocks),

Re: [PATCH 1/4] mmc: core: fold mmc_set_bus_width calls into sdio_enable_4bit_bus.

2015-03-23 Thread Ulf Hansson
On 24 February 2015 at 03:42, NeilBrown ne...@suse.de wrote: Every call to sdio_enable_4bit_bus is followed (on success) but a call /s /but / by to mmc_set_bus_width(). To simplify the code, include those calls directly in sdio_enable_4bit_bus(). Signed-off-by: NeilBrown n...@brown.name

Re: [PATCH 33/35 linux-next] mmc: constify of_device_id array

2015-03-23 Thread Ulf Hansson
On 21 March 2015 at 21:09, Fabian Frederick f...@skynet.be wrote: On 20 March 2015 at 09:56 Ulf Hansson ulf.hans...@linaro.org wrote: On 17 March 2015 at 10:49, Ulf Hansson ulf.hans...@linaro.org wrote: On 16 March 2015 at 20:59, Fabian Frederick f...@skynet.be wrote: of_device_id is

Re: [PATCH V2 11/15] mmc: sdhci: Change to new way of doing re-tuning

2015-03-23 Thread Adrian Hunter
On 23/03/2015 5:02 p.m., Ulf Hansson wrote: [...] I have no locking issues, so I am not sure what you mean here. Okay, I should have stated race conditions. Which I resolved using runtime get / put calls. Returning -EBUSY from runtime suspend, on the other hand, seems less than ideal.

Re: [PATCH V2 11/15] mmc: sdhci: Change to new way of doing re-tuning

2015-03-23 Thread NeilBrown
On Mon, 23 Mar 2015 16:26:07 +0200 Adrian Hunter adrian.hun...@intel.com wrote: For Neil's problem I would do something quiet different: 1. The host driver already knows the bus width so can easily get/put runtime pm to prevent suspend when the bus width does not permit it. 2. The need to