Re: [PATCH v2 1/2] mmc: Add support for marking hpi as broken through devicetree

2015-04-02 Thread Ulf Hansson
On 1 April 2015 at 17:26, Hans de Goede hdego...@redhat.com wrote: The eMMC on a tablet I've will stop working / communicating as soon as the kernel executes: mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, EXT_CSD_HPI_MGMT, 1,

Re: [PATCH V4 01/15] mmc: host: Add facility to support re-tuning

2015-04-02 Thread Ulf Hansson
[...] - ability to hold off re-tuning if the card is busy What do you mean by card is busy? I guess, more accurately, any time the card is in a state that is incapable of supporting re-tuning. For example: - DAT0 busy This state is not specific to re-tuning. An SDIO device

RE: [PATCH 0/5] mmc: Soft Command queue implementation for eMMC5.1 device

2015-04-02 Thread Alex Lemberg
Hi Chuanxiao, -Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Chuanxiao Dong Sent: Tuesday, March 17, 2015 1:10 PM To: linux-mmc@vger.kernel.org Subject: [PATCH 0/5] mmc: Soft Command queue implementation for eMMC5.1

Re: [RFC PATCH 0/4] mmc: sdhci: Support maximum DMA latency request via PM QoS

2015-04-02 Thread Adrian Hunter
On 1/04/2015 10:59 p.m., Len Brown wrote: Ad hoc testing with Lenovo Thinkpad 10 showed a stress test could run for at least 24 hours with the patches, compared to less than an hour without. There is a patch in linux-next to delete C1E from BYT, since it is problematic on multiple platforms. I

Re: [PATCH V4 01/15] mmc: host: Add facility to support re-tuning

2015-04-02 Thread NeilBrown
On Thu, 2 Apr 2015 16:00:52 +0200 Ulf Hansson ulf.hans...@linaro.org wrote: [...] Also SDIO cards can have a custom sleep state where tuning won't work. Our SDIO wifi device has such a state and it can only come out of it upon CMD52 write or CMD14 (ExitSleep). So how

RE: [PATCH 0/5] mmc: Soft Command queue implementation for eMMC5.1 device

2015-04-02 Thread Dong, Chuanxiao
Thanks Alex for review. From my understanding, if host-areq == areq, then means the areq is the current running request. By this way, driver will clear the executable ready bit in slots and continue to find the next one. So the task with the same ID won't be executed at the same time. +

Re: [PATCH V4 01/15] mmc: host: Add facility to support re-tuning

2015-04-02 Thread Arend van Spriel
On 04/02/15 10:43, Ulf Hansson wrote: [...] - ability to hold off re-tuning if the card is busy What do you mean by card is busy? I guess, more accurately, any time the card is in a state that is incapable of supporting re-tuning. For example: - DAT0 busy This state is not

Re: [PATCH V4 01/15] mmc: host: Add facility to support re-tuning

2015-04-02 Thread Ulf Hansson
[...] - ability to enable / disable re-tuning Handled internally by the mmc core. The host controller driver enables re-tuning based on whether the host controller requires it for that transfer mode. For example, only the SDHCI host controller knows if tuning is required for SDR50 mode

Re: [PATCH V4 01/15] mmc: host: Add facility to support re-tuning

2015-04-02 Thread Adrian Hunter
On 02/04/15 15:10, Ulf Hansson wrote: On 2 April 2015 at 12:30, Arend van Spriel ar...@broadcom.com wrote: On 04/02/15 10:43, Ulf Hansson wrote: [...] - ability to hold off re-tuning if the card is busy What do you mean by card is busy? I guess, more accurately, any time the card

Re: [PATCH V4 01/15] mmc: host: Add facility to support re-tuning

2015-04-02 Thread Ulf Hansson
On 2 April 2015 at 14:18, Adrian Hunter adrian.hun...@intel.com wrote: On 02/04/15 15:10, Ulf Hansson wrote: On 2 April 2015 at 12:30, Arend van Spriel ar...@broadcom.com wrote: On 04/02/15 10:43, Ulf Hansson wrote: [...] - ability to hold off re-tuning if the card is busy What do

Re: [PATCH V4 01/15] mmc: host: Add facility to support re-tuning

2015-04-02 Thread Arend van Spriel
On 04/02/15 14:25, Ulf Hansson wrote: On 2 April 2015 at 14:18, Adrian Hunteradrian.hun...@intel.com wrote: On 02/04/15 15:10, Ulf Hansson wrote: On 2 April 2015 at 12:30, Arend van Sprielar...@broadcom.com wrote: On 04/02/15 10:43, Ulf Hansson wrote: [...] - ability to hold off

Re: [PATCH V4 01/15] mmc: host: Add facility to support re-tuning

2015-04-02 Thread Adrian Hunter
On 02/04/15 15:27, Arend van Spriel wrote: On 04/02/15 14:25, Ulf Hansson wrote: On 2 April 2015 at 14:18, Adrian Hunteradrian.hun...@intel.com wrote: On 02/04/15 15:10, Ulf Hansson wrote: On 2 April 2015 at 12:30, Arend van Sprielar...@broadcom.com wrote: On 04/02/15 10:43, Ulf Hansson

Re: [PATCH V4 01/15] mmc: host: Add facility to support re-tuning

2015-04-02 Thread Ulf Hansson
On 2 April 2015 at 12:30, Arend van Spriel ar...@broadcom.com wrote: On 04/02/15 10:43, Ulf Hansson wrote: [...] - ability to hold off re-tuning if the card is busy What do you mean by card is busy? I guess, more accurately, any time the card is in a state that is incapable of

Re: [PATCH V4 01/15] mmc: host: Add facility to support re-tuning

2015-04-02 Thread Ulf Hansson
[...] Also SDIO cards can have a custom sleep state where tuning won't work. Our SDIO wifi device has such a state and it can only come out of it upon CMD52 write or CMD14 (ExitSleep). So how will the mmc core know about these states? I guess we will require SDIO func drivers to deal

Re: [PATCH V4 01/15] mmc: host: Add facility to support re-tuning

2015-04-02 Thread Adrian Hunter
On 2/04/2015 4:05 p.m., Ulf Hansson wrote: [...] - ability to enable / disable re-tuning Handled internally by the mmc core. The host controller driver enables re-tuning based on whether the host controller requires it for that transfer mode. For example, only the SDHCI host

Re: [PATCH v2 2/2] ARM: dts: sun5i: Add broken-hpi property for Utoo-P66 eMMC

2015-04-02 Thread Maxime Ripard
On Wed, Apr 01, 2015 at 05:26:24PM +0200, Hans de Goede wrote: The eMMC on the A13 based Utoo-P66 tablet does not properly support hpi, and trying to enable it results in the eMMC not working, so add a child-node describing the eMMC, and set the broken-hpi property on it. Signed-off-by: Hans