[PATCH v2 0/6] regulator: Fix pbias regulator enable

2015-09-02 Thread Kishon Vijay Abraham I
vsel_reg and enable_reg of the pbias regulator descriptor should actually have the offset from syscon. However after "ARM: dts: : add minimal l4 bus layout with control module support" vsel_reg and enable_reg started to have the absolute address because of address translation that happens due to p

[PATCH v2 2/6] ARM: dts: dra7: use "ti,pbias-dra7" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-dra7" compatible string which is specifically added for DRA7 SoCs. Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/boot/dts/dra7.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/d

[PATCH v2 3/6] ARM: dts: omap243x: use "ti,pbias-omap2" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-omap2" compatible string which is specifically added for OMAP2. Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/boot/dts/omap2430.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap2430.dtsi b/arch/arm/boot/

[PATCH v2 1/6] regulator: pbias: program pbias register offset in pbias driver

2015-09-02 Thread Kishon Vijay Abraham I
Add separate compatible strings for every platform and populate the pbias register offset in the driver data. This helps avoid depending on the dt for pbias register offset. Also update the dt binding documentation for the new compatible strings. Suggested-by: Tony Lindgren Signed-off-by: Kishon

[PATCH v2 4/6] ARM: dts: omap3: use "ti,pbias-omap3" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-omap3" compatible string which is specifically added for OMAP3. Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/boot/dts/omap3.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/om

[PATCH v2 6/6] ARM: dts: omap5: use "ti,pbias-omap5" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-omap5" compatible string which is specifically added for OMAP5. Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/boot/dts/omap5.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/om

[PATCH v2 5/6] ARM: dts: omap4: use "ti,pbias-omap4" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-omap4" compatible string which is specifically added for OMAP4. Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/boot/dts/omap4.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/om

Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-02 Thread Grant Grundler
[resending text-only] On Wed, Sep 2, 2015 at 3:07 PM, Grant Grundler wrote: > > > On Wed, Sep 2, 2015 at 11:28 AM, Olof Johansson wrote: > ... >> > +/** >> > + * struct mmc_ioc_combo_cmd - combo command information >> > + * @num_of_cmds: number of commands to send >> > + * @mmc_ioc_cmd_list: poi

Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-02 Thread Olof Johansson
Hi, On Wed, Sep 2, 2015 at 7:21 AM, Jon Hunter wrote: > From: Seshagiri Holi > > Certain eMMC devices allow vendor specific device information to be read > via a sequence of vendor commands. These vendor commands must be issued > in sequence and an atomic fashion. One way to support this would b

Re: [PATCH 1/6] regulator: pbias: program pbias register offset in pbias driver

2015-09-02 Thread Mark Brown
On Wed, Sep 02, 2015 at 04:17:28PM +0530, Kishon Vijay Abraham I wrote: > Add separate compatible strings for every platform and populate the > pbias register offset in the driver data. > This helps avoid depending on the dt for pbias register offset. Can you respin with Tony's comment please and

mmc: host: sdhci-esdhc-imx.c: seems driver is broken

2015-09-02 Thread Igor Plyatov
Hello dear developers! Please advise how to resolve issue with SD card driver. I work on adaptation of Voipac i.MX51 board for linux-4.2.0. Generally, this is the creation of suitable Device-tree file. .. &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>; bus-width

Re: [PATCH 3/8] mmc: core: Add mmc_regulator_set_vqmmc()

2015-09-02 Thread Doug Anderson
Ulf, On Wed, Sep 2, 2015 at 4:38 AM, Ulf Hansson wrote: >> +/** >> + * mmc_regulator_set_vqmmc - Set VQMMC as per the ios >> + * >> + * For 3.3V signaling, we try to match VQMMC to VMMC as closely as possible. > > Looking at the code, I don't think this statement is entirely true. > Isn't it so t

Re: [PATCH 1/6] regulator: pbias: program pbias register offset in pbias driver

2015-09-02 Thread Tony Lindgren
* Kishon Vijay Abraham I [150902 03:51]: > --- a/drivers/regulator/pbias-regulator.c > +++ b/drivers/regulator/pbias-regulator.c How about add a comment here: /* Offset from SCM general area (and syscon) base */ > +static const struct pbias_of_data pbias_of_data_omap2 = { > + .offset = 0x

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 08:37 PM, Joe Perches wrote: On Wed, 2015-09-02 at 18:37 +0530, Vaibhav Hiremath wrote: On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: Return value would give clear information about the ac

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Joe Perches
On Wed, 2015-09-02 at 18:37 +0530, Vaibhav Hiremath wrote: > On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: > > On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: > >> Return value would give clear information about the actual root-cause > >> of the failure. > >> diff --git a/d

Re: [RFC 3/3] mmc: sdhci-pxav3: Add ->voltage_switch callback support

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 07:21 PM, Shawn Lin wrote: On 2015/9/2 3:32, Vaibhav Hiremath wrote: In case PXA1928 family of devices, there is device/controller specific configuration to control voltage/power on the IO pins. This patch implements and enables the sdhci_ops->voltage_switch() c

[RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-02 Thread Jon Hunter
From: Seshagiri Holi Certain eMMC devices allow vendor specific device information to be read via a sequence of vendor commands. These vendor commands must be issued in sequence and an atomic fashion. One way to support this would be to add an ioctl function for sending a sequence of commands to

Re: [RFC 3/3] mmc: sdhci-pxav3: Add ->voltage_switch callback support

2015-09-02 Thread Shawn Lin
On 2015/9/2 3:32, Vaibhav Hiremath wrote: In case PXA1928 family of devices, there is device/controller specific configuration to control voltage/power on the IO pins. This patch implements and enables the sdhci_ops->voltage_switch() callback api. Note that IO pad register addresses are fetched

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: Return value would give clear information about the actual root-cause of the failure. diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c @@ -455,7 +4

Re: [PATCH 1/2] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 02:01 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: There were some coding style issues where spaces have been used instead of tabs, for example, in macro definitions, alignment of function declarations/definitions, etc... Thi

Re: [v2, 2/3] mmc: sdhci-of-esdhc: get SOC version and revision from GUTS_SVR

2015-09-02 Thread Ulf Hansson
On 27 August 2015 at 11:29, Yangbo Lu wrote: > Freescale QorIQ SOCs have the SVR(System version register) containing > the system version number for the device. Sometimes the eSDHC driver > needs to know this information for some errata workaround. So, we read > SVR from the global utilities block

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 01:56 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 13:49:53 +0530 Vaibhav Hiremath wrote: On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath wrote: Currently, the sdhci_do_start_signal_voltage_s

Re: [PATCH 3/8] mmc: core: Add mmc_regulator_set_vqmmc()

2015-09-02 Thread Ulf Hansson
On 31 August 2015 at 20:24, Heiko Stuebner wrote: > From: Douglas Anderson > > This adds logic to the MMC core to set VQMMC. This is expected to be > called by MMC drivers like dw_mmc as part of (or instead of) their > start_signal_voltage_switch() callback. > > A few notes: > > * When setting t

[PATCH 2/6] ARM: dts: dra7: use "ti,pbias-dra7" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-dra7" compatible string which is specifically added for DRA7 SoCs. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index 1e29ccf..d

[PATCH 3/6] ARM: dts: omap243x: use "ti,pbias-omap2" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-omap2" compatible string which is specifically added for OMAP2. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap2430.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap2430.dtsi b/arch/arm/boot/dts/omap2430.dtsi index 2

[PATCH 4/6] ARM: dts: omap3: use "ti,pbias-omap3" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-omap3" compatible string which is specifically added for OMAP3. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap3.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index 69a40cf..9

[PATCH 1/6] regulator: pbias: program pbias register offset in pbias driver

2015-09-02 Thread Kishon Vijay Abraham I
Add separate compatible strings for every platform and populate the pbias register offset in the driver data. This helps avoid depending on the dt for pbias register offset. Also update the dt binding documentation with the new compatible strings. Suggested-by: Tony Lindgren Signed-off-by: Kisho

[PATCH 5/6] ARM: dts: OMAP4: use "ti,pbias-omap4" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-omap4" compatible string which is specifically added for OMAP4. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index abc4473..5

[PATCH 6/6] ARM: dts: OMAP5: use "ti,pbias-omap5" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-omap5" compatible string which is specifically added for OMAP5. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap5.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index b1a1263..7

[PATCH 0/6] Fix pbias regulator enable

2015-09-02 Thread Kishon Vijay Abraham I
vsel_reg and enable_reg of the pbias regulator descriptor should actually have the offset from syscon. However after "ARM: dts: : add minimal l4 bus layout with control module support" vsel_reg and enable_reg started to have the absolute address because of address translation that happens due to p

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Jisheng Zhang
On Wed, 2 Sep 2015 13:49:53 +0530 Vaibhav Hiremath wrote: > > > On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote: > > On Wed, 2 Sep 2015 01:02:17 +0530 > > Vaibhav Hiremath wrote: > > > >> Currently, the sdhci_do_start_signal_voltage_switch() function invokes > >> controller specif

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath wrote: Currently, the sdhci_do_start_signal_voltage_switch() function invokes controller specific voltage switch configuration only for 1.8v usecase; but it is required for others

Re: [PATCH 5/8] mmc: dw_mmc: dt-binding: Add tuning related things

2015-09-02 Thread Heiko Stuebner
Hi Jaehoon, Am Mittwoch, 2. September 2015, 14:01:52 schrieb Jaehoon Chung: > Hi, Heiko. > > On 09/01/2015 03:24 AM, Heiko Stuebner wrote: > > From: Alexandru M Stan > > > > Add ciu_drv, ciu_sample clocks and default-sample-phase. This will later > > be used by tuning code. > > As i know, ciu_

Re: [PATCH 1/2] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 12:24 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 00:54:13 +0530 Vaibhav Hiremath wrote: There were some coding style issues where spaces have been used instead of tabs, for example, in macro definitions, alignment of function declarations/definitions, etc...

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Jisheng Zhang
On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath wrote: > Currently, the sdhci_do_start_signal_voltage_switch() function invokes > controller specific voltage switch configuration only for 1.8v usecase; > but it is required for others as well. > > For example, in case of PXA1928 SDH controller