Re: [PATCH 2/3] mmc: sd: Allow calling sd mode switch with retries

2015-09-09 Thread Yousong Zhou
On 10 September 2015 at 08:33, Shawn Lin wrote: > On 2015/9/10 0:33, Yousong Zhou wrote: >> >> This will allow retrying access mode switch to High-Speed in the >> following commit. >> >> Signed-off-by: Yousong Zhou >> --- >> drivers/mmc/core/core.c |4 >> drivers/mmc/core/sd_ops.c |

Re: [PATCH 2/3] mmc: sd: Allow calling sd mode switch with retries

2015-09-09 Thread Shawn Lin
On 2015/9/10 0:33, Yousong Zhou wrote: This will allow retrying access mode switch to High-Speed in the following commit. Signed-off-by: Yousong Zhou --- drivers/mmc/core/core.c |4 drivers/mmc/core/sd_ops.c |5 +++-- drivers/mmc/core/sd_ops.h | 10 -- 3 files chan

Re: [RESEND PATCH] ARM: multi_v7_defconfig: Enable PBIAS regulator

2015-09-09 Thread Kevin Hilman
Kishon Vijay Abraham I writes: > PBIAS regulator is required for MMC module in OMAP2, OMAP3, OMAP4, > OMAP5 and DRA7 SoCs. Enable it here. > > Signed-off-by: Kishon Vijay Abraham I Thanks, added to our next/late branch. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-m

Re: [PATCH] mmc: block: Add new ioctl to send multi commands

2015-09-09 Thread Arnd Bergmann
On Wednesday 09 September 2015 17:44:54 Jon Hunter wrote: > > On 09/09/15 16:56, Arnd Bergmann wrote: > > On Wednesday 09 September 2015 16:06:01 Jon Hunter wrote: > >> + > >> + idata = kcalloc(mcci.num_of_cmds, sizeof(*idata), GFP_KERNEL); > >> + if (!idata) { > >> + err

Re: [PATCH 1/3] mmc: sd: Remove superfluous error code assignment

2015-09-09 Thread Hans de Goede
Hi All, I requested yousong to send this set to further discuss it, and hopefully get some fix for this in the kernel. Yousong, I actually intended you to do a patch to the sunxi-mmc code, rather then too the core. Ah well. Since we've this set now lets see if people like it, it may help other c

Re: [PATCH] mmc: block: Add new ioctl to send multi commands

2015-09-09 Thread Jon Hunter
On 09/09/15 16:56, Arnd Bergmann wrote: > On Wednesday 09 September 2015 16:06:01 Jon Hunter wrote: >> + >> + idata = kcalloc(mcci.num_of_cmds, sizeof(*idata), GFP_KERNEL); >> + if (!idata) { >> + err = -ENOMEM; >> + goto cmd_err; >> + } >> + >> +

[PATCH 2/3] mmc: sd: Allow calling sd mode switch with retries

2015-09-09 Thread Yousong Zhou
This will allow retrying access mode switch to High-Speed in the following commit. Signed-off-by: Yousong Zhou --- drivers/mmc/core/core.c |4 drivers/mmc/core/sd_ops.c |5 +++-- drivers/mmc/core/sd_ops.h | 10 -- 3 files changed, 15 insertions(+), 4 deletions(-) diff -

[PATCH 3/3] mmc: sd: Retry switching to highspeed mode in case of error

2015-09-09 Thread Yousong Zhou
A SD card with sunxi-mmc can fail with the following error message (RCE for response CRC error) when trying to switch to highspeed mode. But the mode switch can almost always succeed on the second try. Dmesg before this commit. [1.112060] mmc0: host does not support reading read-only swi

[PATCH 1/3] mmc: sd: Remove superfluous error code assignment

2015-09-09 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- drivers/mmc/core/sd.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c index 4e7366a..e28ebf3 100644 --- a/drivers/mmc/core/sd.c +++ b/drivers/mmc/core/sd.c @@ -357,8 +357,6 @@ int mmc_sd_switch_hs(struct mmc_car

Re: [PATCH] mmc: block: Add new ioctl to send multi commands

2015-09-09 Thread Arnd Bergmann
On Wednesday 09 September 2015 16:06:01 Jon Hunter wrote: > + > + idata = kcalloc(mcci.num_of_cmds, sizeof(*idata), GFP_KERNEL); > + if (!idata) { > + err = -ENOMEM; > + goto cmd_err; > + } > + > + cmds = (struct mmc_ioc_cmd __user *)(unsigned lon

[PATCH] mmc: block: Add new ioctl to send multi commands

2015-09-09 Thread Jon Hunter
From: Seshagiri Holi Certain eMMC devices allow vendor specific device information to be read via a sequence of vendor commands. These vendor commands must be issued in sequence and an atomic fashion. One way to support this would be to add an ioctl function for sending a sequence of commands to

Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-09 Thread Jon Hunter
Hi Ulf, On 09/09/15 13:42, Ulf Hansson wrote: > On 3 September 2015 at 17:08, Jon Hunter wrote: >> Hi Olof, >> >> On 02/09/15 19:28, Olof Johansson wrote: >>> Hi, >>> >>> On Wed, Sep 2, 2015 at 7:21 AM, Jon Hunter wrote: From: Seshagiri Holi Certain eMMC devices allow vendor spec

Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands

2015-09-09 Thread Ulf Hansson
On 3 September 2015 at 17:08, Jon Hunter wrote: > Hi Olof, > > On 02/09/15 19:28, Olof Johansson wrote: >> Hi, >> >> On Wed, Sep 2, 2015 at 7:21 AM, Jon Hunter wrote: >>> From: Seshagiri Holi >>> >>> Certain eMMC devices allow vendor specific device information to be read >>> via a sequence of v

Re: [PATCH-v2 2/7] mmc: sdhci-pxav3: binding: Add pxa1928 compatible support

2015-09-09 Thread Vaibhav Hiremath
On Wednesday 09 September 2015 05:19 AM, Rob Herring wrote: On 09/07/2015 06:18 AM, Vaibhav Hiremath wrote: With support for pxa1928 family of devices , this patch updates the binding document with compatible property of "marvell,pxav3-1928-sdhci". Signed-off-by: Vaibhav Hiremath --- Docum

Re: [linux-sunxi] Re: [RFC] mmc: core: Set clock before switching to highspeed mode.

2015-09-09 Thread Hans de Goede
Hi, On 08-09-15 17:38, Yousong Zhou wrote: I just tried a method from allwinner's u-boot sources: retry the mode switch in case of an error [1]. It was accompanied with a comment quoted below: //retry for Toshiba emmc;for the first time Toshiba emmc change to HS //it will return response crc e

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

2015-09-09 Thread Linus Walleij
On Tue, Sep 8, 2015 at 5:07 PM, Vaibhav Hiremath wrote: > But I still have one small doubt on expectation from > devm_pinctrl_get() function. > > If pinctrl properties are not populated in Devicetree node, > then, shouldn't devm_pinctrl_get() return error ? > I followed the code flow, and it seem