Re: [patch] mmc: sdhci-of-at91: remove a line of dead code

2015-09-16 Thread Ludovic Desroches
On Wed, Sep 16, 2015 at 09:19:49AM +0300, Dan Carpenter wrote: > The goto is correct and the unreachable "return -EINVAL" should be > removed. > > Signed-off-by: Dan Carpenter Of course Acked-by: Ludovic Desroches Thanks > > diff --git a/drivers/mmc/host/sdhci-of-at91.c > b/drivers/mmc/host/

[v2, 7/8] mmc: sd: set 4bit bus width after IO signal voltage switching

2015-09-16 Thread Yangbo Lu
IO signal voltage switching is used for UHS speed mode. After the voltage switching, the card is in UHS mode and it's needed to set 4bit bus width before any data transfer command. Signed-off-by: Yangbo Lu --- drivers/mmc/core/sd.c | 9 + 1 file changed, 9 insertions(+) diff --git a/dri

[v2, 8/8] mmc: sdhci-of-esdhc: add SDR50 mode support for SD/MMC Legacy Adapter Card

2015-09-16 Thread Yangbo Lu
The eSDHC is not compatible with SD spec well, so we need to use eSDHC-special code to switch to SDR50 mode. 1. IO signal voltage switching, eSDHC uses SDHC_VS to switch io voltage and it's needed to configure a global utilities register SCFG_SDHCIOVSELCR(if it has) and SDHC_VS signal. 2. Before ex

[v2, 6/8] mmc: sdhci-of-esdhc: add tuning cycles delay quirk for t2080/t1040

2015-09-16 Thread Yangbo Lu
Signed-off-by: Yangbo Lu --- drivers/mmc/host/sdhci-of-esdhc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index bffc8c4..5aabadf 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc

[v2, 4/8] mmc: sdhci-of-esdhc: add eMMC Adapter Card HS200 mode support

2015-09-16 Thread Yangbo Lu
Freescale QorIQ QDS boards use different SDHC Adapter card types as below. To support SDHC Adapter card type 1(eMMC card Rev4.5) HS200 mode, select to use peripheral clock and add callbacks for signal voltage switching and tuning block setting for eSDHC. SDHC_ADAPTER_TYPE: ADAPTER_TYPE_1 0x1

[v2, 1/8] mmc: sdhci: add a callback of signal voltage switching

2015-09-16 Thread Yangbo Lu
Add a signal voltage switching callback to let host use its own switching process. Signed-off-by: Yangbo Lu --- Changes for v2: - Modified commit message - Added SDR50 support patches --- drivers/mmc/host/sdhci.c | 5 + drivers/mmc/host/sdhci.h | 2 ++ 2 files changed, 7 inse

[v2, 2/8] mmc: sdhci: add a callback of tuning block setting

2015-09-16 Thread Yangbo Lu
Add a tuning block setting callback to let host set its tuning block before executing tuning procedure. Signed-off-by: Yangbo Lu --- drivers/mmc/host/sdhci.c | 3 +++ drivers/mmc/host/sdhci.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.

[v2, 5/8] mmc: sdhci: add SDHCI_QUIRK2_DELAY_BETWEEN_TUNING_CYCLES quirk

2015-09-16 Thread Yangbo Lu
Although eMMC spec does not require a delay between tuning cycles, some hosts need it to avoid tuning failure. Signed-off-by: Yangbo Lu --- drivers/mmc/host/sdhci.c | 3 ++- drivers/mmc/host/sdhci.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/

[v2, 3/8] mmc: dt: add DT bindings for Freescale eSDHC

2015-09-16 Thread Yangbo Lu
Document Freescale eSDHC 'adapter-type' and 'peripheral-frequency' properties. Signed-off-by: Yangbo Lu --- Documentation/devicetree/bindings/mmc/fsl-esdhc.txt | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt b/Documentation/d

Re: [PATCH 6/8] mmc: dw_mmc: Generic MMC tuning with the clock phase framework

2015-09-16 Thread Jaehoon Chung
Hi, On 09/16/2015 11:52 PM, Heiko Stübner wrote: > Hi, > > Am Mittwoch, 16. September 2015, 11:30:26 schrieb Jaehoon Chung: >> On 09/16/2015 07:09 AM, Heiko Stübner wrote: >>> Am Dienstag, 15. September 2015, 17:25:38 schrieb Jaehoon Chung: On 09/01/2015 03:24 AM, Heiko Stuebner wrote: >

[PATCH v2] mmc: pxamci: fix card detect with slot-gpio API

2015-09-16 Thread Robert Jarzmik
Move pxamci to mmc slot-gpio API to fix interrupt request. It fixes the case where the card detection is on a gpio expander, on I2C for example on zylonite board. In this case, the card detect netsted interrupt is called from a threaded interrupt. The request_irq() fails, because a hard irq cannot

Re: [PATCH V3] mmc: block: Add new ioctl to send multi commands

2015-09-16 Thread Gwendal Grignou
On Mon, Sep 14, 2015 at 8:00 AM, Jon Hunter wrote: > From: Seshagiri Holi > > Certain eMMC devices allow vendor specific device information to be read > via a sequence of vendor commands. These vendor commands must be issued > in sequence and an atomic fashion. One way to support this would be to

Re: [PATCH] mmc: sdhci-bcm-kona: fix logic to check for 8-bit data width

2015-09-16 Thread Ray Jui
On 9/16/2015 2:53 AM, Javier Martinez Canillas wrote: > The driver prints if the data width is 8-bit but it's using a > binary OR instead of a binary AND so it will always report as > "is_8bit=Y" regardless of the flags in host->mmc->caps. > > Signed-off-by: Javier Martinez Canillas > > --- >

Re: [PATCH V3] mmc: block: Add new ioctl to send multi commands

2015-09-16 Thread Jon Hunter
On 16/09/15 12:08, Ulf Hansson wrote: > On 14 September 2015 at 17:00, Jon Hunter wrote: >> From: Seshagiri Holi >> >> Certain eMMC devices allow vendor specific device information to be read >> via a sequence of vendor commands. These vendor commands must be issued >> in sequence and an atomic

Re: [PATCH 6/8] mmc: dw_mmc: Generic MMC tuning with the clock phase framework

2015-09-16 Thread Heiko Stübner
Hi, Am Mittwoch, 16. September 2015, 11:30:26 schrieb Jaehoon Chung: > On 09/16/2015 07:09 AM, Heiko Stübner wrote: > > Am Dienstag, 15. September 2015, 17:25:38 schrieb Jaehoon Chung: > >> On 09/01/2015 03:24 AM, Heiko Stuebner wrote: > >>> From: Alexandru M Stan > >>> > >>> This algorithm will

Re: [GIT PULL] Update dw-mmc controller

2015-09-16 Thread Alexey Brodkin
Hello, On Mon, 2015-08-17 at 12:32 +0200, Ulf Hansson wrote: > On 17 August 2015 at 12:12, Alexey Brodkin > wrote: > > Hi Ulf, > > > > On Mon, 2015-08-17 at 11:47 +0200, Ulf Hansson wrote: > > > On 10 August 2015 at 18:54, Jaehoon Chung wrote: > > > > Dear, Ulf. > > > > > > > > Could you pull

Re: [PATCH V3] mmc: block: Add new ioctl to send multi commands

2015-09-16 Thread Ulf Hansson
On 14 September 2015 at 17:00, Jon Hunter wrote: > From: Seshagiri Holi > > Certain eMMC devices allow vendor specific device information to be read > via a sequence of vendor commands. These vendor commands must be issued > in sequence and an atomic fashion. One way to support this would be to >

[PATCH] mmc: sdhci-bcm-kona: fix logic to check for 8-bit data width

2015-09-16 Thread Javier Martinez Canillas
The driver prints if the data width is 8-bit but it's using a binary OR instead of a binary AND so it will always report as "is_8bit=Y" regardless of the flags in host->mmc->caps. Signed-off-by: Javier Martinez Canillas --- drivers/mmc/host/sdhci-bcm-kona.c | 2 +- 1 file changed, 1 insertion(

[PATCH 2/2] mmc: vub300: Remove unneded semicolons

2015-09-16 Thread Javier Martinez Canillas
They aren't needed and are just creating null statements so remove it. Signed-off-by: Javier Martinez Canillas --- drivers/mmc/host/vub300.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c index fbabbb82b354..1e819

[PATCH 1/2] mmc: wbsd: Remove unneded semicolon

2015-09-16 Thread Javier Martinez Canillas
It's not needed an is just creating a null statement, so remove it. Signed-off-by: Javier Martinez Canillas --- drivers/mmc/host/wbsd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c index ca183ea767b3..c3fd16d997ca 100644 -

Re: [PATCH] mmc: pxamci: fix card detect threaded interrupt

2015-09-16 Thread Robert Jarzmik
Ulf Hansson writes: > On 12 September 2015 at 11:03, Robert Jarzmik wrote: >> Change the interrupt flavor of the card detection, from a hard interrupt >> to a threaded interrupt. There is no strong requirement for a hard >> interrupt. >> >> It fixes the case where the card detection is on a gpio

[RESEND PATCH] mmc: mmc_spi: Export OF module alias information

2015-09-16 Thread Javier Martinez Canillas
Drivers needs to export the OF id table and this be built into the module or udev won't have the necessary information to autoload the driver module when the device is registered via OF. Signed-off-by: Javier Martinez Canillas --- drivers/mmc/host/mmc_spi.c | 1 + 1 file changed, 1 insertion(+

Re: [PATCH] mmc: pxamci: fix card detect threaded interrupt

2015-09-16 Thread Ulf Hansson
On 12 September 2015 at 11:03, Robert Jarzmik wrote: > Change the interrupt flavor of the card detection, from a hard interrupt > to a threaded interrupt. There is no strong requirement for a hard > interrupt. > > It fixes the case where the card detection is on a gpio expander, on I2C > for examp