Re: MMC runtime PM patches break libertas probe

2011-06-07 Thread Arnd Hannemann
Hi Ohad, Am 04.06.2011 00:52, schrieb Ohad Ben-Cohen: (cc'ing Arnd Hannermann) On Sat, Jun 4, 2011 at 1:28 AM, Bing Zhao bz...@marvell.com wrote: CMD5 Arg=0 refers to the very first CMD5 sent from host during initialization sequence. This is required because our state machine always

Re: outstanding TMIO MMC patches

2011-01-05 Thread Arnd Hannemann
Hi Chris, Am 05.01.2011 19:57, schrieb Chris Ball: On Thu, Jan 06, 2011 at 02:30:30AM +0900, Paul Mundt wrote: Again, this isn't the first time this has happened. Any perceived hostility in this matter is not directed at you directly since you did come in to things rather late and were

Re: [PATCH 1/2 v2] mmc: tmio: handle missing HW interrupts

2011-01-05 Thread Arnd Hannemann
Hi Chris, Am 05.01.2011 22:22, schrieb Chris Ball: Hi Arnd, On Wed, Dec 29, 2010 at 02:21:13PM +0100, Arnd Hannemann wrote: This patch addresses this problem by introducing timeouts for outstanding interrupts. If a hardware interrupt is missing, a soft reset will be performed to bring

Re: [PATCH] [RFC] mmc: perform SDIO reset on power restore of host

2010-12-29 Thread Arnd Hannemann
Hi Ohad, Am 28.12.2010 15:24, schrieb Ohad Ben-Cohen: Do you mean that your card is always powered on regardless of mmc_power_off() invocations ? Yes, it seems so. Ok, thanks for letting us know. It bothered me that we didn't understand the issue you had, but now it seems that

[PATCH 0/2 v2] mmc: tmio: handle missing HW interrupts

2010-12-29 Thread Arnd Hannemann
://patchwork.kernel.org/patch/201982/ They now depend on -rc7 and: mmc: tmio: merge the private header into the driver https://patchwork.kernel.org/patch/349931/ Signed-off-by: Arnd Hannemann a...@arndnet.de -- To unsubscribe from this list: send the line unsubscribe linux-mmc

[PATCH 1/2 v2] mmc: tmio: handle missing HW interrupts

2010-12-29 Thread Arnd Hannemann
to a working state. Tested with the SDHI hardware block in sh7372 / AP4EVB. Signed-off-by: Arnd Hannemann a...@arndnet.de --- Changes in v2: - rebased against -rc7 - depends on: mmc: tmio: merge the private header into the driver https://patchwork.kernel.org/patch/349931/ drivers

[PATCH 2/2 v2] mmc: tmio: fix CMD irq handling

2010-12-29 Thread Arnd Hannemann
commands from the core. This patch changes the behavior so that CMDs are only acked, if CMD_TIMEOUT or CMD_RESPEND is received. Signed-off-by: Arnd Hannemann a...@arndnet.de --- drivers/mmc/host/tmio_mmc.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host

Re: outstanding TMIO MMC patches

2010-12-29 Thread Arnd Hannemann
Hi Guennadi, Am 29.12.2010 00:32, schrieb Guennadi Liakhovetski: Hi Ian There are a number of outstanding tmio-mmc patches from Arnd Hannemann and myself, many of them posted weeks ago. We really would like to have them in 2.6.38. Would you have time to process them? Otherwise, could

[PATCH] [RFC] mmc: perform SDIO reset on power restore of host

2010-12-28 Thread Arnd Hannemann
. This was observed on AP4EVB with tmio_mmc and a b43 based SDIO card: http://marc.info/?l=linux-mmcm=128854536521274w=2 This patch, fixes the problem by resetting the SDIO card on power restore. Signed-off-by: Arnd Hannemann a...@arndnet.de --- drivers/mmc/core/core.c |7 ++- 1 files changed, 6

Re: [PATCH] [RFC] mmc: perform SDIO reset on power restore of host

2010-12-28 Thread Arnd Hannemann
Hi Ohad, Am 28.12.2010 13:45, schrieb Ohad Ben-Cohen: On Tue, Dec 28, 2010 at 1:25 PM, Arnd Hannemann a...@arndnet.de wrote: On some boards card power is hard wired to the slot and active regardless of host controller state. ... This was observed on AP4EVB with tmio_mmc and a b43 based SDIO

[PATCH 0/6 v3] mmc: tmio: Add SDIO IRQ support

2010-12-28 Thread Arnd Hannemann
Damm - Activate this flag for sh_mobile_sdhi - Add a patch which disables IRQs early in remove to avoid spurious SDIO IRQs, during module unload - Patches 4-6 are unmodified but included for completeness Signed-off-by: Arnd Hannemann a...@arndnet.de -- To unsubscribe from this list: send

[PATCH 1/6 v3] mmc: tmio: implement SDIO IRQ

2010-12-28 Thread Arnd Hannemann
This patch implements SDIO IRQ support for mfds which announce the TMIO_MMC_SDIO_IRQ flag for tmio_mmc. If MMC_CAP_SDIO_IRQ is also set SDIO IRQ signalling is activated. Tested with a b43-based wireless SDIO card and sh_mobile_sdhi. Signed-off-by: Arnd Hannemann a...@arndnet.de --- Changes in v3

[PATCH 2/6 v3] mfd: sh_mobile_sdhi: activate SDIO IRQ for tmio_mmc

2010-12-28 Thread Arnd Hannemann
The SDHI Controller on SH-Mobile SoCs supports SDIO IRQ signalling. This patch advertises this fact to the tmio_mmc driver. Signed-off-by: Arnd Hannemann a...@arndnet.de Acked-by: Samuel Ortiz sa...@linux.intel.com --- drivers/mfd/sh_mobile_sdhi.c |5 + 1 files changed, 5 insertions

[PATCH 4/6 v3] sh: sh7724 Enable SDIO IRQs

2010-12-28 Thread Arnd Hannemann
This patch enables the interrupt generation for SDIO IRQs of the sdhi controllers of the SoC. To make sure interrupt are handled announce the MMC_CAP_SDIO_IRQ capability on ecovec, kfr2r09 and se7724. Tested with a b43-based SDIO wireless card on ecovec. Signed-off-by: Arnd Hannemann

[PATCH 5/6 v3] sh: sh7722 Enable SDIO IRQs

2010-12-28 Thread Arnd Hannemann
This patch enables the interrupt generation for SDIO IRQs of the sdhi controllers of the SoC. To make sure SDIO IRQs are used, announce the MMC_CAP_SDIO_IRQ capability on migor. Signed-off-by: Arnd Hannemann a...@arndnet.de --- Changes in v3: - Added missing include to migor. arch/sh/boards

[PATCH 6/6 v3] sh: sh7723 / ap325rxa enable SDIO IRQs

2010-12-28 Thread Arnd Hannemann
This patch enables the interrupt generation for SDIO IRQs of the sdhi controllers of the SoC. To make sure SDIO IRQs are used announce the MMC_CAP_SDIO_IRQ capability on ap325rxa. Signed-off-by: Arnd Hannemann a...@arndnet.de Acked-by: Magnus Damm d...@opensource.se --- arch/sh/boards/mach

[PATCH 6/6 v3] [RFC] sh: sh7722 Enable SDIO IRQs

2010-12-23 Thread Arnd Hannemann
This patch enables the interrupt generation for SDIO IRQs of the sdhi controllers of the SoC. To make sure SDIO IRQs are used, announce the MMC_CAP_SDIO_IRQ capability on migor. Untested, therefore RFC. Signed-off-by: Arnd Hannemann a...@arndnet.de --- Changes since v2: - Added missing include

[PATCH] [RFC] sh: sh7723 / ap325rxa enable SDIO IRQs

2010-12-23 Thread Arnd Hannemann
This patch enables the interrupt generation for SDIO IRQs of the sdhi controllers of the SoC. To make sure SDIO IRQs are used announce the MMC_CAP_SDIO_IRQ capability on ap325rxa. Untested, therefore RFC. Signed-off-by: Arnd Hannemann a...@arndnet.de --- arch/sh/boards/mach-ap325rxa/setup.c

[PATCH 2/6 v2] mfd: sh_mobile_sdhi: activate SDIO IRQ for tmio_mmc

2010-12-20 Thread Arnd Hannemann
The SDHI Controller on SH-Mobile SoCs supports SDIO IRQ signalling. This patch advertises this fact to the tmio_mmc driver. Signed-off-by: Arnd Hannemann a...@arndnet.de --- drivers/mfd/sh_mobile_sdhi.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/mfd

[PATCH 6/6 v2] [RFC] sh: sh7722 Enable SDIO IRQs

2010-12-20 Thread Arnd Hannemann
This patch enables the interrupt generation for SDIO IRQs of the sdhi controllers of the soc. To make sure SDIO IRQs are used announce the MMC_CAP_SDIO_IRQ capability on migor. Untested, therefore RFC. Signed-off-by: Arnd Hannemann a...@arndnet.de --- arch/sh/boards/mach-migor/setup.c

[PATCH 5/6 v2] sh: sh7724 Enable SDIO IRQs

2010-12-20 Thread Arnd Hannemann
This patch enables the interrupt generation for SDIO IRQs of the sdhi controllers of the SoC. To make sure interrupt are handled announce the MMC_CAP_SDIO_IRQ capability on ecovec, kfr2r09 and se7724. Tested with a b43-based SDIO wireless card on ecovec. Signed-off-by: Arnd Hannemann

[PATCH 0/6 v2] mmc: tmio: Add SDIO IRQ support

2010-12-20 Thread Arnd Hannemann
is known to support SDIO IRQ as suggested by Magnus Damm - Activate this flag for sh_mobile_sdhi - Add a patch which disables IRQs early in remove to avoid spurious SDIO IRQs, during module unload - Patches 4-6 are unmodified but included for completeness Signed-off-by: Arnd Hannemann

[PATCH] mmc: tmio_mmc: silence compiler warnings

2010-12-19 Thread Arnd Hannemann
into the driver mmc: tmio: implement a bounce buffer for unaligned DMA Signed-off-by: Arnd Hannemann a...@arndnet.de --- drivers/mmc/host/tmio_mmc.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c index

Re: [PATCH 1/4] mmc: tmio: Implement SDIO IRQ

2010-12-07 Thread Arnd Hannemann
Hi Magnus, Am 07.12.2010 09:37, schrieb Magnus Damm: On Tue, Dec 7, 2010 at 9:22 PM, Arnd Hannemann a...@arndnet.de wrote: Am 07.12.2010 00:39, schrieb Magnus Damm: On Tue, Dec 7, 2010 at 2:35 AM, Arnd Hannemann a...@arndnet.de wrote: This patch implements SDIO IRQ support for mfds which

[PATCH 1/4] mmc: tmio: Implement SDIO IRQ

2010-12-06 Thread Arnd Hannemann
descriptor allocation failure mmc: tmio: merge the private header into the driver mmc: tmio: implement a bounce buffer for unaligned DMA Signed-off-by: Arnd Hannemann a...@arndnet.de CC: Ian Molton i...@mnementh.co.uk CC: Samuel Ortiz sa...@linux.intel.com CC: Guennadi Liakhovetski g.liakhovet

[PATCH 3/4] sh: sh7724 Enable SDIO IRQs

2010-12-06 Thread Arnd Hannemann
This patch enables the interrupt generation for SDIO IRQs of the sdhi controllers of the soc. To make sure interrupts are handled announce the MMC_CAP_SDIO_IRQ capability on ecovec, kfr2r09 and se7724. Tested with a b43-based SDIO wireless card on ecovec. Signed-off-by: Arnd Hannemann

[PATCH 4/4] [RFC] sh: sh7722 Enable SDIO IRQs

2010-12-06 Thread Arnd Hannemann
This patch enables the interrupt generation for SDIO IRQs of the sdhi controllers of the soc. To make sure interrupts are handled announce the MMC_CAP_SDIO_IRQ capability on migor. Untested, therefore RFC. Signed-off-by: Arnd Hannemann a...@arndnet.de --- arch/sh/boards/mach-migor/setup.c

[PATCH 2/4] ARM: mach-shmobile: sh7372 Enable SDIO IRQs

2010-12-06 Thread Arnd Hannemann
This patch enables the interrupt generation for SDIO IRQs of the sdhi controllers of the soc. To make sure interrupts are handled announce the MMC_CAP_SDIO_IRQ capability on AP4EVB. Tested with a b43-based SDIO wireless card. Signed-off-by: Arnd Hannemann a...@arndnet.de --- arch/arm/mach

Re: MMC runtime PM patches break libertas probe

2010-11-16 Thread Arnd Hannemann
Am 16.11.2010 14:22, schrieb Ohad Ben-Cohen: On Mon, Nov 1, 2010 at 10:27 AM, Ohad Ben-Cohen o...@wizery.com wrote: On Sun, Oct 31, 2010 at 9:06 PM, Ohad Ben-Cohen o...@wizery.com wrote: ... we need to support boards with controllers/cards which we can't power off in runtime. On

Re: MMC runtime PM patches break libertas probe

2010-11-16 Thread Arnd Hannemann
Am 16.11.2010 21:58, schrieb Ohad Ben-Cohen: On Tue, Nov 16, 2010 at 7:17 PM, Arnd Hannemann hannem...@nets.rwth-aachen.de Its an AP4 (SH7372) evaluation board from renesas. It has an SD-Slot, where you plug the SDIO card into it. No special wiring or something like this. So I doubt

Re: regression: b43-sdio: probe of mmc0:0001:1 failed with error -16

2010-11-01 Thread Arnd Hannemann
Am 01.11.2010 05:50, schrieb Ohad Ben-Cohen: On Sun, Oct 31, 2010 at 11:51 PM, Arnd Hannemann a...@arndnet.de wrote: In Daniel's scenario, mmc_sdio_init_card() fails because mmc_send_relative_addr() returns -110. Can you please check out if that's the same thing you have too ? No, it seems

Re: regression: b43-sdio: probe of mmc0:0001:1 failed with error -16

2010-11-01 Thread Arnd Hannemann
Am 01.11.2010 10:02, schrieb Ohad Ben-Cohen: On Mon, Nov 1, 2010 at 10:05 AM, Arnd Hannemann a...@arndnet.de wrote: No, actually mmc_sdio_init_card() is called _before_ sdio_bus_probe Yes, it is called once at boot while the card is mmc_rescan()ed. But that's not interesting, because

regression: b43-sdio: probe of mmc0:0001:1 failed with error -16

2010-10-31 Thread Arnd Hannemann
Hi, on todays Linus' git (v2.6.36-9871-g3985c7c) b43 sdio stopped working. It was working on (v2.6.36-6794-g12ba8d1). b43-sdio: probe of mmc0:0001:1 failed with error -16 The error seems to originate from the following code in drivers/mmc/core/sdio_bus.c:sdio_bus_probe() 135 ret =

Re: regression: b43-sdio: probe of mmc0:0001:1 failed with error -16

2010-10-31 Thread Arnd Hannemann
Am 31.10.2010 18:16, schrieb Arnd Hannemann: on todays Linus' git (v2.6.36-9871-g3985c7c) b43 sdio stopped working. It was working on (v2.6.36-6794-g12ba8d1). b43-sdio: probe of mmc0:0001:1 failed with error -16 The error seems to originate from the following code in drivers/mmc/core

Re: regression: b43-sdio: probe of mmc0:0001:1 failed with error -16

2010-10-31 Thread Arnd Hannemann
Hi Ohad, Am 31.10.2010 20:14, schrieb Ohad Ben-Cohen: On Sun, Oct 31, 2010 at 7:16 PM, Arnd Hannemann a...@arndnet.de wrote: b43-sdio: probe of mmc0:0001:1 failed with error -16 It's exactly what Daniel is experiencing with the XO-1.5. In Daniel's scenario, mmc_sdio_init_card() fails

Re: b43 sdio: WARNING: at drivers/mmc/core/core.c:237 mmc_wait_for_cmd

2010-10-28 Thread Arnd Hannemann
Hi, Am 28.10.2010 16:49, schrieb Larry Finger: On 10/28/2010 09:28 AM, Arnd Hannemann wrote: Hi, \ [ 1364.620044] b43-phy1 debug: Removing Interface type 2 [ 1364.621812] b43-phy1 debug: Wireless interface stopped [ 1372.440297] b43-sdio: before ssb_bus_unregister, claimed is 0

b43 sdio: WARNING: at drivers/mmc/core/core.c:237 mmc_wait_for_cmd

2010-10-27 Thread Arnd Hannemann
Hi, first of all: great! b43 sdio card works with open firmware! However, on rmmod b43 I get the following backtraces with current Linus git (v2.6.36-6794-g12ba8d1): [ 831.696189] b43-phy1 debug: Removing Interface type 2 [ 831.698425] b43-phy1 debug: Wireless interface stopped [

Re: [PATCH 1/2] tmio_mmc: handle missing HW interrupts

2010-09-24 Thread Arnd Hannemann
Added MLs into CC Am 23.09.2010 21:30, schrieb Ian Molton: this looks like something we should have... did you get any feedback? No not yet. Regards Arnd -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH 1/2] tmio_mmc: handle missing HW interrupts

2010-09-23 Thread Arnd Hannemann
to a working state. Tested with the SDHI hardware block in sh7372. Signed-off-by: Arnd Hannemann a...@arndnet.de --- drivers/mmc/host/tmio_mmc.c | 81 -- drivers/mmc/host/tmio_mmc.h |7 2 files changed, 84 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 2/2] tmio_mmc: fix CMD irq handling

2010-09-23 Thread Arnd Hannemann
commands from the core. This patch changes the behavior so that CMDs are only acked, if CMD_TIMEOUT or CMD_RESPEND is received. Signed-off-by: Arnd Hannemann a...@arndnet.de --- drivers/mmc/host/tmio_mmc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host

Re: [PATCH 1/4] tmio_mmc: Allow the mfd driver to specify get_cd handler

2010-09-12 Thread Arnd Hannemann
AM 10.09.2010 18:10, schrieb Samuel Ortiz: On Tue, Aug 24, 2010 at 05:26:59PM +0200, Arnd Hannemann wrote: Some controllers, supported by the tmio_mmc driver do not have the card detect pin of a slot connected, so that polling needs to be used and card detection is handled by other means

[PATCH 0/4] Fix/improve hotplug for sh_mobile_sdhi/tmio_mmc/sh_mmcif

2010-08-24 Thread Arnd Hannemann
This patch series attempts to fix hotplug (for sh_mobile_sdhi/tmio_mmc) and improve hotplug (for sh_mmcif) on the AP4EVB (shmobile) board, by handling the card detect in platform code. Best regards, Arnd -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a

[PATCH 1/4] tmio_mmc: Allow the mfd driver to specify get_cd handler

2010-08-24 Thread Arnd Hannemann
Some controllers, supported by the tmio_mmc driver do not have the card detect pin of a slot connected, so that polling needs to be used and card detection is handled by other means. This patch exposes a get_cd hook for that purpose. Signed-off-by: Arnd Hannemann a...@arndnet.de --- drivers/mmc

[PATCH 3/4] sh_mmcif: Allow the platform to specify own get_cd handler

2010-08-24 Thread Arnd Hannemann
. This patch exposes a get_cd hook for that purpose. Signed-off-by: Arnd Hannemann a...@arndnet.de --- drivers/mmc/host/sh_mmcif.c | 12 include/linux/mmc/sh_mmcif.h |1 + 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc

Re: [PATCH] tmio_mmc: Allow 2 byte requests in 4-bit mode

2010-08-20 Thread Arnd Hannemann
- no regression. Tested-by: Arnd Hannemann a...@arndnet.de -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tmio_mmc: Make ack_mmc_irqs() write-only

2010-08-20 Thread Arnd Hannemann
for an interrupt that will never come. Observed with the TMIO_STAT_RXRDY bit together with CMD53 on AR6002 and BCM4318 SDIO cards in polled mode. Signed-off-by: Yusuke Goda yusuke.goda...@renesas.com Tested on AP4EVB (sh7372) with SDHC and MMC cards - no regression. Tested-by: Arnd Hannemann

Bug in mmc_test or host driver?

2010-08-13 Thread Arnd Hannemann
Hi, if I peform the test 23 mmc_test_best_read_performance() with tmio_mmc on Linus tree, I hit the following BUG: [ 152.625000] mmc0: Starting tests of card mmc0:2daf... [ 152.625000] mmc0: Test case 23. Best-case read performance... [ 152.632812] mmc0: starting CMD16 arg 0200 flags