Re: [PATCH v2] mmc: sdhci-msm: Boost controller core clock

2015-11-06 Thread Bjorn Andersson
On Fri 06 Nov 00:10 PST 2015, Ulf Hansson wrote: > On 6 November 2015 at 02:42, Bjorn Andersson <bj...@kryo.se> wrote: > > On Mon, Jul 6, 2015 at 4:53 AM, Ivan T. Ivanov <ivan.iva...@linaro.org> > > wrote: > >> Ensure SDCC is working with maximum clock

Re: [PATCH v2] mmc: sdhci-msm: Boost controller core clock

2015-11-05 Thread Bjorn Andersson
On Mon, Jul 6, 2015 at 4:53 AM, Ivan T. Ivanov wrote: > Ensure SDCC is working with maximum clock otherwise card > detection could be extremely slow, up to 7 seconds. > > Signed-off-by: Ivan T. Ivanov > Reviewed-by: Georgi Djakov

Re: [PATCH v2] mmc: core: Allow specifying current consumption

2015-10-17 Thread Bjorn Andersson
On Fri 16 Oct 05:55 PDT 2015, Ulf Hansson wrote: > On 13 October 2015 at 03:00, Bjorn Andersson > <bjorn.anders...@sonymobile.com> wrote: > > This allows us to specify expected current consumption of the vmmc and > > vqmmc regulators. This is needed to bring the

[PATCH v2] mmc: core: Allow specifying current consumption

2015-10-12 Thread Bjorn Andersson
This allows us to specify expected current consumption of the vmmc and vqmmc regulators. This is needed to bring the supplying regulators out of their low-power-mode while accessing the mmc. Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> --- The sd specification

Re: [PATCH v3 1/3] mmc: mmci: Support any block sizes for ux500v2 and qcom variant

2015-07-09 Thread Bjorn Andersson
On Thu, Aug 21, 2014 at 9:54 PM, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: From: Ulf Hansson ulf.hans...@linaro.org For the ux500v2 variant of the PL18x block, any block sizes are supported. This will make it possible to decrease data overhead for SDIO transfers. This patch

Re: [PATCH] mmc: core: Set load on vmmc and vqmmc

2015-07-02 Thread Bjorn Andersson
On Wed 01 Jul 03:59 PDT 2015, Mark Brown wrote: On Tue, Jun 30, 2015 at 09:38:45PM -0700, Bjorn Andersson wrote: +- vmmc-load: requested load for the vmmc regulator, in mA +- vqmmc-load: requested load for the vqmmc regulator, in mA Isn't this something that should have default values

[PATCH] mmc: core: Set load on vmmc and vqmmc

2015-06-30 Thread Bjorn Andersson
Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- This is needed to get our regulators into hpm, to give enough power to our sdhci cards to run at higher clockrates - e.g. hs200. Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++ drivers/mmc/core/core.c

[PATCH] mmc: mmci: Cascade EPROBE_DEFER from regulators.

2015-03-24 Thread Bjorn Andersson
Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- drivers/mmc/host/mmci.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c index 7fe1619..fb26674 100644 --- a/drivers/mmc/host/mmci.c +++ b/drivers/mmc/host

Re: [PATCH v2] mmc: sdhci-msm: Add support for vendor capabilities registers

2015-03-21 Thread Bjorn Andersson
On Sat, Mar 21, 2015 at 7:50 AM, Georgi Djakov georgi.dja...@linaro.org wrote: Some versions of this controller do not advertise their 3.0v and 8bit bus-width support capabilities. It is required to explicitly set these capabilities for the specific controller versions. [..] diff --git

Re: [PATCH] mmc: sdhci-msm: Add support for vendor capabilities registers

2015-03-19 Thread Bjorn Andersson
On Thu, Mar 19, 2015 at 9:21 AM, Georgi Djakov georgi.dja...@linaro.org wrote: [..] Does the 8916 board you have work without bumping the regulator_set_load() (previously regulator_set_optimum_mode())? None of my 8974 boards work reliably without it. My 8916 board seems to be working fine

Re: [PATCH] mmc: sdhci-msm: Add support for vendor capabilities registers

2015-03-19 Thread Bjorn Andersson
On Thu, Mar 19, 2015 at 5:55 AM, Georgi Djakov georgi.dja...@linaro.org wrote: [..] @@ -516,6 +527,22 @@ static int sdhci_msm_probe(struct platform_device *pdev) host_version, ((host_version SDHCI_VENDOR_VER_MASK) SDHCI_VENDOR_VER_SHIFT)); +

Re: Possible regression with commit 52221610d

2015-01-05 Thread Bjorn Andersson
On Sun, Dec 21, 2014 at 7:01 PM, Tim Kryger tim.kry...@gmail.com wrote: On Wed, Dec 17, 2014 at 11:57 AM, Bjorn Andersson bj...@kryo.se wrote: [..] Non-the-less, feel free to propose a patch and I will give it a test. Lets start with the simplest change first. Please give this a try and let

Re: [PATCH] mmc: dt: Add property for broken hs200 quirk

2014-12-29 Thread Bjorn Andersson
On Mon 22 Dec 02:04 PST 2014, Ulf Hansson wrote: On 19 December 2014 at 21:01, Bjorn Andersson bj...@kryo.se wrote: On Fri, Dec 19, 2014 at 3:38 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 12 December 2014 at 20:28, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: Some more

Re: [PATCH] mmc: dt: Add property for broken hs200 quirk

2014-12-19 Thread Bjorn Andersson
On Fri, Dec 19, 2014 at 3:38 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 12 December 2014 at 20:28, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: Some more explanation to why this needed would be good. Because (according to the git log) some of the memories that we mounted

Re: Possible regression with commit 52221610d

2014-12-17 Thread Bjorn Andersson
On Tue, Dec 16, 2014 at 10:20 PM, Tim Kryger tim.kry...@gmail.com wrote: On Tue, Dec 16, 2014 at 10:18 AM, Bjorn Andersson bj...@kryo.se wrote: We are routing the regulators straight to vdd of the memory and should hence use vmmc to specify this. However unless I actually program 0x29

Re: Possible regression with commit 52221610d

2014-12-16 Thread Bjorn Andersson
On Mon, Dec 15, 2014 at 10:27 PM, Bjorn Andersson bj...@kryo.se wrote: On Sun, Dec 14, 2014 at 8:48 PM, Tim Kryger tim.kry...@gmail.com wrote: On Sat, Dec 13, 2014 at 11:22 PM, Bjorn Andersson bj...@kryo.se wrote: [..] Or simply; what is vmmc (in the code) supposed to represent? Hi Bjorn

Re: Possible regression with commit 52221610d

2014-12-15 Thread Bjorn Andersson
On Sun, Dec 14, 2014 at 8:48 PM, Tim Kryger tim.kry...@gmail.com wrote: On Sat, Dec 13, 2014 at 11:22 PM, Bjorn Andersson bj...@kryo.se wrote: [..] Or simply; what is vmmc (in the code) supposed to represent? Hi Bjorn, VMMC is the supply that delivers power out to the SD card itself (aka VDD

Re: Possible regression with commit 52221610d

2014-12-13 Thread Bjorn Andersson
On Tue, Nov 4, 2014 at 7:31 AM, Tim Kryger tim.kry...@gmail.com wrote: On Tue, Nov 4, 2014 at 1:00 AM, Alexandre Courbot acour...@nvidia.com wrote: Hi Tim, thanks for your reply! On 11/04/2014 02:28 PM, Tim Kryger wrote: On Mon, Nov 3, 2014 at 7:05 PM, Alexandre Courbot acour...@nvidia.com

[PATCH] mmc: dt: Add property for broken hs200 quirk

2014-12-12 Thread Bjorn Andersson
Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++ drivers/mmc/host/sdhci-pltfm.c| 3 +++ 2 files changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree

Re: [PATCH v2 00/14] Add Qualcomm SD Card Controller support

2014-05-23 Thread Bjorn Andersson
On Fri, May 23, 2014 at 1:11 AM, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: On 23/05/14 08:50, Ulf Hansson wrote: [...] It seems like you had some CRC issues during read/write? Did you manage to resolve that issue? Bjorn is using different SOC and board than the IFC6410 Am

Re: [PATCH v2 00/14] Add Qualcomm SD Card Controller support

2014-05-23 Thread Bjorn Andersson
On Fri, May 23, 2014 at 9:50 AM, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: Hi Bjorn, Thanks for the update. Hi Srini, After pulling in Ulfs next branch again and reapplying v3 my issues are now gone. Not sure what I screwed up when I merged v2, this seems to work just fine

Re: [PATCH RFC 00/12] Add Qualcomm SD Card Controller support.

2014-05-19 Thread Bjorn Andersson
On Mon, Apr 21, 2014 at 2:43 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org [snip] This patches are tested in PIO mode on IFC8064 board with both eMMC and external SD card. I would appreciate any feedback/suggestions on the overall

Re: [PATCH v9 2/3] mmc: sdhci-msm: Initial support for Qualcomm chipsets

2014-03-03 Thread Bjorn Andersson
On Fri, Feb 28, 2014 at 3:24 AM, Georgi Djakov gdja...@mm-sol.com wrote: This platform driver adds the initial support of Secure Digital Host Controller Interface compliant controller found in Qualcomm chipsets. Hi Georgi, Sorry for reposting this, I have no idea how I managed to send this

Re: [PATCH v9 1/3] mmc: sdhci-msm: Qualcomm SDHCI binding documentation

2014-03-02 Thread Bjorn Andersson
On Fri, Feb 28, 2014 at 3:24 AM, Georgi Djakov gdja...@mm-sol.com wrote: This platform driver adds the initial support of Secure Digital Host Controller Interface compliant controller found in Qualcomm chipsets. Hi Georgi, When testing this I was confused by the warnings from sdhci not

Re: [PATCH v6 2/2] mmc: sdhci-msm: Initial support for MSM chipsets

2013-10-05 Thread Bjorn Andersson
Hi Georgi, Thanks for working on this, unfortunately it seems like I need to port the rpm regulators to be able to test this. But I did find that... On Fri, Sep 27, 2013 at 9:57 AM, Georgi Djakov gdja...@mm-sol.com wrote: ... +static irqreturn_t sdhci_msm_pwr_irq(int irq, void *data) +{ +