[PATCH v2 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume

2012-09-20 Thread Chander Kashyap
From: Chander Kashyap Perform clock disable/enable in runtime suspend/resume. Signed-off-by: Chander Kashyap Acked-by: Jaehoon Chung --- Changelog: v2: - Wrapped clk_disable in probe and clk_enable in remove with #ifdef CONFIG_PM_RUNTIME conditional check. drivers/mmc/host/sdhci-s3c.c

Re: [PATCH 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume

2012-09-19 Thread Chander Kashyap
Thanks Chris , Sure i will do. On 19 September 2012 19:51, Chris Ball wrote: > Hi, > > On Wed, Sep 19 2012, Chander Kashyap wrote: >> I will resend this patch after fixing the issue. > > Thanks; please base your new patch against current mmc-next. > > - Chris. &

Re: [PATCH 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume

2012-09-19 Thread Chander Kashyap
Hi Chris, On 19 September 2012 13:13, Jaehoon Chung wrote: > Looks good to me. > > Acked-by: Jaehoon Chung > > On 09/19/2012 03:14 PM, Chris Ball wrote: >> Hi Jaehoon, Girish, >> >> On Fri, Sep 14 2012, Chander Kashyap wrote: >>> Perform cloc

Re: [PATCH 1/3] mmc: sdhci-s3c: Enable only required bus clock

2012-09-14 Thread Chander Kashyap
Hi Jaehoon Chung, On 14 September 2012 15:25, Jaehoon Chung wrote: > Hi Chander, > > Could you add the error control for clk_enable()? It is maintained as original and clk is already checked for error using IS_ERR. > > On 09/14/2012 06:08 PM, Chander Kashyap wrote: >> In

[PATCH 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume

2012-09-14 Thread Chander Kashyap
Perform clock disable/enable in runtime suspend/resume. Signed-off-by: Chander Kashyap --- drivers/mmc/host/sdhci-s3c.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 3f4518d

[PATCH 2/3] mmc: sdhci-s3c: Fix crash on module insertion for second time

2012-09-14 Thread Chander Kashyap
]) from [] (platform_drv_probe+0x18/0x1c) Signed-off-by: Chander Kashyap --- drivers/mmc/host/sdhci-s3c.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 0cbb4c2..3f4518d 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers

[PATCH 1/3] mmc: sdhci-s3c: Enable only required bus clock

2012-09-14 Thread Chander Kashyap
of old bus clock and enables the best clock selected in sdhci_s3c_set_clock(). Signed-off-by: Chander Kashyap --- drivers/mmc/host/sdhci-s3c.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c

[PATCH 0/3] mmc: sdhci-s3c: fixes and enhancements

2012-09-14 Thread Chander Kashyap
This patchset does as follows: Patch 1: Enable only required bus clock in case of multiple clock sources. Patch 2: Add pm_runtime_dont_use_autosuspend() in sdhci_s3c_remove(); Patch 3: Disable clocks in runtime suspend and enable at runtime resume. Chander Kashyap (3): mmc: sdhci-s3c: Enable