Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-20 Thread David Miller
From: Benoit Taine Date: Fri, 18 Jul 2014 17:26:47 +0200 > We should prefer `const struct pci_device_id` over > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. > This issue was reported by checkpatch. > > A simplified version of the semantic patch that makes this change is as >

[PATCH] of_mmc_spi: Need to include irq.h and of_irq.h

2011-03-18 Thread David Miller
Since these are the headers that provide irq_of_parse_and_map() and NO_IRQ. Signed-off-by: David S. Miller diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c index 5530def..e2aecb7 100644 --- a/drivers/mmc/host/of_mmc_spi.c +++ b/drivers/mmc/host/of_mmc_spi.c @@ -15,9 +1

Re: [net-next 3/3] iwmc3200top: simplify imwct_tx

2009-12-23 Thread David Miller
From: Tomas Winkler Date: Wed, 16 Dec 2009 16:26:26 +0200 > 1. remove address argument since we use same address IWMC_SDIO_DATA_ADDR in > all cases > 2. add __iwmct_tx - non locking tx function for already locked contexts > > Signed-off-by: Tomas Winkler Applied. -- To unsubscribe from thi

Re: [net-next 2/3] iwmc3200top: cleanup log messages

2009-12-23 Thread David Miller
From: Tomas Winkler Date: Wed, 16 Dec 2009 16:26:25 +0200 > 1. add TRACE level > 2. use TRACE where needed to reduce the noise > 3 don't INFOEX from driver > 4. add DUMP level for packets dumps > 5. use correct context for the log messages > > Signed-off-by: Tomas Winkler Applied. -- To unsub

Re: [net-next 1/3] iwmc3200top: clean up fw_download

2009-12-23 Thread David Miller
From: Tomas Winkler Date: Wed, 16 Dec 2009 16:26:24 +0200 > 1. removed redundant NULL-pointers checks in iwmct_fw_load > as release_firmware and kfree are NULL pointer friendly > 2. remove redundant memset of the parser since the structure > is fully initialized in iwmct_fw_parser_init function >

Re: [net-2.6 1/3] iwmc3200top: clean up fw_download

2009-12-14 Thread David Miller
Unless you've been living under a rock, you should know that the net-2.6 tree was closed for all non-bugfix changes as of more than a week ago. Therefore submitting cleanups for net-2.6 is not appropriate. Resend your patches when net-next-2.6 opens up, which should be shorly after Linus release

Re: [net-next 1/1] iwmc3200top: revamp fw name handling

2009-11-18 Thread David Miller
From: Tomas Winkler Date: Thu, 19 Nov 2009 01:55:19 +0200 > 1. define macro for handling firmware api version > 2. add MODULE_FIRMWARE > 3. cleanup iwmct_fw_load style > > Signed-off-by: Tomas Winkler Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in t

Re: [net-next 2/2] iwmc3200top: simplify the driver version

2009-11-15 Thread David Miller
From: Tomas Winkler Date: Sat, 14 Nov 2009 20:36:36 +0200 > drop the version parts not needed for in-tree driver > > Signed-off-by: Tomas Winkler Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordom

Re: [net-next 1/2] iwmc3200top: use prefered style for the device table.

2009-11-15 Thread David Miller
From: Tomas Winkler Date: Sat, 14 Nov 2009 20:36:35 +0200 > Use device id number directly accompany with > comment rather then a #define > > Signed-off-by: Tomas Winkler Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.

Re: [PATCH net-next V2 3/3] i2400m-sdio: select IWMC3200TOP in Kconfig

2009-10-19 Thread David Miller
From: Tomas Winkler Date: Sat, 17 Oct 2009 21:09:36 +0200 > i2400m-sdio requires iwmc3200top for its operation > > Signed-off-by: Tomas Winkler > Acked-by: Inaky Perez-Gonzalez Applied to net-next-2.6, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body

Re: [PATCH net-next V2 2/3] iwmc3200wifi: select IWMC3200TOP in Kconfig

2009-10-19 Thread David Miller
From: Tomas Winkler Date: Sat, 17 Oct 2009 21:09:35 +0200 > iwmc3200wifi requires iwmc3200top for its operation > > Signed-off-by: Tomas Winkler > Acked-by: Zhu Yi Applied to net-next-2.6 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majo

Re: [PATCH net-next V2 1/3] iwmc3200top: Add Intel Wireless MultiCom 3200 top driver.

2009-10-19 Thread David Miller
From: Tomas Winkler Date: Sat, 17 Oct 2009 21:09:34 +0200 > This patch adds Intel Wireless MultiCom 3200 top driver. > IWMC3200 is 4Wireless Com CHIP (GPS/BT/WiFi/WiMAX). > Top driver is responsible for device initialization and firmware download. > Firmware handled by top is responsible for top

Re: [PATCH 1/3] iwmc3200top: Add Intel Wireless MultiCom 3200 top driver.

2009-10-11 Thread David Miller
From: Eric Dumazet Date: Sun, 11 Oct 2009 09:40:54 +0200 > diff --git a/MAINTAINERS b/MAINTAINERS > index e1da925..18244ad 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3654,6 +3654,7 @@ NETWORKING [GENERAL] > M: "David S. Miller" > L: net...@vger.kernel.org > W: http://www.linux

Re: [PATCH 1/3] iwmc3200top: Add Intel Wireless MultiCom 3200 top driver.

2009-10-11 Thread David Miller
From: Tomas Winkler Date: Sun, 11 Oct 2009 10:05:20 +0200 > Just close my eyes and there is new game to play. :) > It's not in the patchwork, so is there any reason you are not planning > to add it. The patch intention was for net-next, it looks like > I didn't mark it as such, my fault. Becau

Re: [PATCH 1/3] iwmc3200top: Add Intel Wireless MultiCom 3200 top driver.

2009-10-10 Thread David Miller
From: Tomas Winkler Date: Sat, 10 Oct 2009 11:38:50 +0200 > On Wed, Sep 23, 2009 at 1:38 AM, Tomas Winkler > wrote: >> This patch adds Intel Wireless MultiCom 3200 top driver. >> IWMC3200 is 4Wireless Com CHIP (GPS/BT/WiFi/WiMAX). >> Top driver is responsible for device initialization and firmw

Re: [PATCH 1/3] iwmc3200top: Add Intel Wireless MultiCom 3200 top driver.

2009-10-10 Thread David Miller
PLEASE! Don't quote all of a big huge driver patch like that. Just quote the parts you want to comment on! Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majo