[PATCH v4] mmc: dw_mmc: Add MSHC compatible for Exynos4412

2013-02-22 Thread Dongjin Kim
This patch adds the compatible string for MSHC controller of Exynos4412. And exynos5250_dwmmc_caps is renamed to exynos_dwmmc_caps, since it has the capablities of common feature supported by Exynos4 and Exynos5. Cc: Seungwon Jeon Cc: Jaehoon Chung Cc: Sachin Kamat Signed-off-by: Dongjin Kim

Re: [PATCH v3] mmc: dw_mmc: Add MSHC compatible for Exynos4412

2013-02-21 Thread Dongjin Kim
2013 at 7:53 PM, Seungwon Jeon wrote: > On Wednesday, February 20, 2013, Alim Akhtar wrote: >> Hi, >> >> On Tue, Feb 19, 2013 at 6:04 PM, Dongjin Kim wrote: >> > Hello Seungwon, >> > >> > Thank you for reviewing and I understand what you mean. >

Re: [PATCH v3] mmc: dw_mmc: Add MSHC compatible for Exynos4412

2013-02-19 Thread Dongjin Kim
not have the information of Exynos5250. And suggestion do you have? Regards, Dongjin. On Tue, Feb 19, 2013 at 7:19 PM, Seungwon Jeon wrote: > On Tuesday, February 19, 2013, Dongjin Kim wrote: >> This patch adds the compatible string for MSHC controller of Exynos4412, and >> share

[PATCH v3] mmc: dw_mmc: Add MSHC compatible for Exynos4412

2013-02-18 Thread Dongjin Kim
: Dongjin Kim --- drivers/mmc/host/dw_mmc-exynos.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c index 4d50da6..38cd03c 100644 --- a/drivers/mmc/host/dw_mmc-exynos.c +++ b/drivers/mmc/host/dw_mmc

Re: [PATCH 1/2] mmc: dw_mmc: exynos: Add compatibility for exynos4412 SoC

2013-02-18 Thread Dongjin Kim
arated into two patches. like this "compatibility for >> exynos4412 SOC" and "rename the drv_data" > > Came across this patch from Dongjin Kim [1] who has already attempetd > the above suggestion. Hence dropping my patch. > > Dongjin, > Are you still wor

Re: [PATCH] mmc: dw_mmc: No bus setup if default pinctrl is used

2013-02-07 Thread Dongjin Kim
nd remove the for-block, it makes the code more simple. I like to have a comment from Thomas if have to support both cases, gpios and default-pinctrl. Best regards, Dongjin. On Fri, Feb 8, 2013 at 4:03 AM, Linus Walleij wrote: > On Thu, Feb 7, 2013 at 7:17 PM, Dongjin Kim wrote: > >>

[PATCH] mmc: dw_mmc: No bus setup if default pinctrl is used

2013-02-07 Thread Dongjin Kim
215000] dwmmc_exynos: probe of 1255.mshc failed with error -22 Cc: Thomas Abraham Cc: Linus Walleij Signed-off-by: Dongjin Kim --- drivers/mmc/host/dw_mmc-exynos.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host

[PATCH v2] mmc: dw_mmc: Add MSHC compatible for Exynos4412

2013-01-24 Thread Dongjin Kim
This patch adds the compatible string for MSHC controller of Exynos4412, and share the controller specific properties with Exynos5250 since they have same features. Its driver data name is changed to exynos5_drv_data not to use SoC specific name. Signed-off-by: Dongjin Kim --- drivers/mmc/host

Re: [PATCH] mmc: dw_mmc: Add MSHC compatible for Exynos4412

2013-01-23 Thread Dongjin Kim
Hi Jaehoon, Yes, completely agree with you but I wanted to keep "exynos5250_" before Exynos4210's drv_data is sorted out. Anyway "exynos5_" would be ok, I think. Regards, Dongjin. On Thu, Jan 24, 2013 at 11:41 AM, Jaehoon Chung wrote: > On 01/24/2013 12:24 AM, Dong

[PATCH] mmc: dw_mmc: Add MSHC compatible for Exynos4412

2013-01-23 Thread Dongjin Kim
This patch adds the compatible string for MSHC controller of Exynos4412, and reuse the controller specific properties with Exynos5250 since those have same features. Signed-off-by: Dongjin Kim --- drivers/mmc/host/dw_mmc-exynos.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers

Re: [PATCH] mmc: host: dw_mmc-exynos: Add support for pinctrl

2013-01-22 Thread Dongjin Kim
here is no "gpios = <...>" property. So I guess bus setup has to be ignored when the gpios are configured with pinctrl. What's your advice? Thank you in advance. Dongjin. On Fri, Jan 4, 2013 at 3:33 AM, Dongjin Kim wrote: > Hi Thomas, > > Thank you for your reviewing,

Re: [PATCH] mmc: host: dw_mmc-exynos: Add support for pinctrl

2013-01-03 Thread Dongjin Kim
Mon, Dec 31, 2012 at 2:57 PM, Thomas Abraham wrote: > On 21 December 2012 09:11, Dongjin Kim wrote: >> This patch adds support for pin configuration using pinctrl subsystem to >> dw_mmc-exynos driver. The property 'wp-gpios' can be specified for write >> protect b

Re: [PATCH] mmc: host: dw_mmc-exynos: Add support for pinctrl

2012-12-30 Thread Dongjin Kim
Hi, Does anyone have advice on this patch? On Sat, Dec 22, 2012 at 2:11 AM, Dongjin Kim wrote: > This patch adds support for pin configuration using pinctrl subsystem to > dw_mmc-exynos driver. The property 'wp-gpios' can be specified for write > protect but 'samsung,c

[PATCH] mmc: host: dw_mmc-exynos: Add support for pinctrl

2012-12-21 Thread Dongjin Kim
uld specify pin control groups (clock, comand and data lines) used for this controller. -. 'pinctrl-names' should contain only one value, 'default'. Signed-off-by: Dongjin Kim --- drivers/mmc/host/dw_mmc-exynos.c | 44 -- 1 file change

Re: mmc: dw_mmc: release hardware lock error

2012-02-28 Thread Dongjin Kim
host->cmd_status = status; >8>8 On Tue, 28 Feb 2012 16:44:08 +0900, Jaehoon Chung wrote: > Hi Dongjin. > > This patch is corrupt due to line-wrapping. > > Best Regards, > Jaehoon Chung > > On 02/28

Re: mmc: dw_mmc: release hardware lock error

2012-02-27 Thread Dongjin Kim
Jaehoon Chung samsung.com> writes: > > On 02/28/2012 02:32 PM, Dongjin Kim wrote: > > > Hello, > > > > I encountered the problem that my hardware is frozen while switching clock from > > 400kHz to others. This is caused that hardware locked error was t

mmc: dw_mmc: release hardware lock error

2012-02-27 Thread Dongjin Kim
Hello, I encountered the problem that my hardware is frozen while switching clock from 400kHz to others. This is caused that hardware locked error was triggered when CMD register was written and interrupt was pended. Tested IP version is 2.10a Cheers, Dongjin. diff --git a/drivers/mmc/host/dw_