Re: [PATCH] mmc: sdhci: only invoke clock re-tuning for adtc type commands

2014-03-26 Thread Franky Lin
On 03/17/2014 09:51 AM, Franky Lin wrote: Hi Ulf, On 03/17/2014 02:12 AM, Ulf Hansson wrote: On 7 January 2014 19:37, Franky Lin fran...@broadcom.com wrote: For high clock frequency modes, ie. SDR104 and possibly SDR50, the data window on the CMD and DAT lines needs to be tuned. Once tuned

Re: [PATCH] mmc: sdhci: only invoke clock re-tuning for adtc type commands

2014-03-17 Thread Franky Lin
Hi Ulf, On 03/17/2014 02:12 AM, Ulf Hansson wrote: On 7 January 2014 19:37, Franky Lin fran...@broadcom.com wrote: For high clock frequency modes, ie. SDR104 and possibly SDR50, the data window on the CMD and DAT lines needs to be tuned. Once tuned to a sample clock rate, a re-tuning might

Re: [PATCH] mmc: sdhci: only invoke clock re-tuning for adtc type commands

2014-03-15 Thread Franky Lin
Hi Chris and Ulf, On 03/07/2014 11:54 AM, Franky Lin wrote: On 02/24/2014 11:57 AM, Franky Lin wrote: Hi Chris, On 01/07/2014 10:37 AM, Franky Lin wrote: For high clock frequency modes, ie. SDR104 and possibly SDR50, the data window on the CMD and DAT lines needs to be tuned. Once tuned

Re: [PATCH] mmc: sdhci: only invoke clock re-tuning for adtc type commands

2014-03-07 Thread Franky Lin
On 02/24/2014 11:57 AM, Franky Lin wrote: Hi Chris, On 01/07/2014 10:37 AM, Franky Lin wrote: For high clock frequency modes, ie. SDR104 and possibly SDR50, the data window on the CMD and DAT lines needs to be tuned. Once tuned to a sample clock rate, a re-tuning might required because

Re: [PATCH] mmc: sdhci: only invoke clock re-tuning for adtc type commands

2014-02-24 Thread Franky Lin
Hi Chris, On 01/07/2014 10:37 AM, Franky Lin wrote: For high clock frequency modes, ie. SDR104 and possibly SDR50, the data window on the CMD and DAT lines needs to be tuned. Once tuned to a sample clock rate, a re-tuning might required because of drifted signal on different lines. This re

[PATCH] mmc: sdhci: only invoke clock re-tuning for adtc type commands

2014-01-07 Thread Franky Lin
the DAT lines, ie. adtc type commands. This patch is an optimization by adding the condition of the requested command being adtc type in order to execute the re-tuning procedure. Signed-off-by: Franky Lin fran...@broadcom.com --- drivers/mmc/host/sdhci.c |3 ++- 1 file changed, 2 insertions(+), 1

Re: Where to power on the wifi device before loading the driver.

2012-06-15 Thread Franky Lin
On 06/14/2012 11:09 PM, Wei Ni wrote: I talked with Franky, this power sequence is generally for 4329, so it mean this sequence can be put into the wifi driver. Hold on. It's generally for 4329. But fullmac supports 4329/4330 along with USB dongle chips. Also more chips are incoming. I dont

Re: Where to power on the wifi device before loading the driver.

2012-06-14 Thread Franky Lin
On 06/13/2012 09:17 PM, Wei Ni wrote: Wei: Yes, in OOB mode, it's easy to add a device node in the DT, to pass the gpio property to brcmfmac driver. But the NO-OOB mode doesn’t use the virtual platform device, so we can't pass the gpio to driver. We need to find a way to support these two mode

Re: Where to power on the wifi device before loading the driver.

2012-06-13 Thread Franky Lin
Hi Wei, On 06/13/2012 03:40 AM, Wei Ni wrote: In the brcmfmac init routine, it call sdio_register_driver() to register driver, if the wifi device is powered on, then the mmc driver will enumerate it, and call the probe callback routine. On the Cardhu, the wifi's power is controlled by two