Re: [RFC][PATCH] mmc: add an ioctl for erasing

2010-05-25 Thread George G. Davis
Hi, On Fri, May 21, 2010 at 04:47:40PM +0300, Adrian Hunter wrote: > >From f3baf566eb33a22bf12a48e4cdc7c99611bde934 Mon Sep 17 00:00:00 2001 > From: Adrian Hunter > Date: Wed, 5 May 2010 14:07:55 +0300 > Subject: [PATCH] mmc: add an ioctl for erasing > > As SD and MMC cards have a NAND core, the

Re: drivers/mmc/card/queue.c: 5 * redundant conditions

2010-02-21 Thread George G. Davis
On Sun, Feb 21, 2010 at 03:15:15PM +0100, Wolfram Sang wrote: > > > Checking ./drivers/mmc/card/queue.c... > > > [./drivers/mmc/card/queue.c:212]: (style) Redundant condition. It is safe > > > to deallocate a NULL pointer > > > [./drivers/mmc/card/queue.c:215]: (style) Redundant condition. It is s

Re: drivers/mmc/card/queue.c: 5 * redundant conditions

2010-02-21 Thread George G. Davis
Hi, On Sun, Feb 21, 2010 at 09:21:27AM +, d binderman wrote: > > > Hello there, > > I just ran the sourceforge tool cppcheck over the source code of the > new Linux kernel 2.6.33-rc8 > > It said > > Checking ./drivers/mmc/card/queue.c... > [./drivers/mmc/card/queue.c:212]: (style) Redunda

[RFC/PATCH] mmc: sdhci: Enable high speed support for MMC cards

2010-02-18 Thread George G. Davis
Allow high speed mode for high speed capable ver 4.x MMC cards. Comments and/or feedback appreciated. Signed-off-by: George G. Davis --- drivers/mmc/host/sdhci.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c

[RFC/PATCH] mmc: sdhci: Add 8-bit bus width support

2010-02-18 Thread George G. Davis
host capabilities issue via platform data may also eliminate the need for some of the quirks, e.g. SDHCI_QUIRK_FORCE_1_BIT_DATA would not be necessary if platform data specifies bus_width = 1, etc.,. Comments and/or feedback greatly appreciated. [1] http://patchwork.kernel.org/patch/20993/

[PATCH] mmc: sdhci: Make consistent use of CONFIG_MMC_DEBUG for "DEBUG"ging

2010-02-18 Thread George G. Davis
The "6882a8c sdhci: Add better ADMA error reporting" commit added sdhci_show_adma_error() which is built when DEBUG is defined. Since we already have CONFIG_MMC_DEBUG used elsewhere in this driver, may as well make consistent use of that config knob instead. Signed-off-by: George G.

[PATCH] mmc: sdhci: Fix SDHCI_INT_ADMA_ERROR typo in SDHCI_INT_DATA_MASK

2010-02-18 Thread George G. Davis
The "4accfe2 sdhci: catch ADMA errors" commit added SDHCI_ADMA_ERROR to the definition of SDHCI_INT_DATA_MASK but obviously intended to use SDHCI_INT_ADMA_ERROR. Signed-off-by: George G. Davis Cc: Pierre Ossman --- drivers/mmc/host/sdhci.h |2 +- 1 files changed, 1 insert