RE: [PATCH 5/5] mmc: omap_hsmmc: Add reg-offset to bindings documentation

2013-06-25 Thread Hebbar, Gururaja
On Wed, Jun 26, 2013 at 06:55:01, Fernandes, Joel wrote: > From: Joel A Fernandes > > A new reg-offset property was added to account for register offsets > in some omap-hsmmc's. Document the new property. > Small nitpick I usually get feedback that any driver DT changes and the associated Bind

RE: [PATCH 09/11] mmc: omap_hsmmc: enhance pinctrl support

2013-06-04 Thread Hebbar, Gururaja
On Tue, Jun 04, 2013 at 12:49:57, Linus Walleij wrote: > On Tue, Jun 4, 2013 at 9:11 AM, Linus Walleij > wrote: > > On Fri, May 31, 2013 at 12:13 PM, Hebbar Gururaja > > wrote: > > > >> Amend the hsmmc controller to optionally take a pin control handle and

[PATCH 09/11] mmc: omap_hsmmc: enhance pinctrl support

2013-05-31 Thread Hebbar Gururaja
ain drops the domain regulator. If any of the above pin states are missing in dt, a warning message about the missing state is displayed. If certain pin-states are not available, to remove this warning message pass respective state name with null phandler. Signed-off-by: Hebbar Gururaja Cc: Balaji

RE: [PATCH v4 05/14] dmaengine: edma: Add TI EDMA device tree binding

2013-01-10 Thread Hebbar, Gururaja
On Fri, Jan 11, 2013 at 11:18:41, Porter, Matt wrote: > The binding definition is based on the generic DMA controller > binding. > > Signed-off-by: Matt Porter > --- > Documentation/devicetree/bindings/dma/ti-edma.txt | 51 > + > 1 file changed, 51 insertions(+) > create

RE: [PATCH v4 01/14] ARM: davinci: move private EDMA API to arm/common

2013-01-10 Thread Hebbar, Gururaja
On Fri, Jan 11, 2013 at 11:18:37, Porter, Matt wrote: > Move mach-davinci/dma.c to common/edma.c so it can be used > by OMAP (specifically AM33xx) as well. This just moves the > private EDMA API and enables it to build on OMAP. > > Signed-off-by: Matt Porter > --- > arch/arm/Kconfig

RE: [RFC PATCH v3 13/16] ARM: dts: add AM33XX MMC support

2013-01-03 Thread Hebbar, Gururaja
Matt, On Thu, Oct 18, 2012 at 18:56:52, Porter, Matt wrote: > Adds AM33XX MMC support for am335x-bone and am335x-evm. I want to test Suspend/Resume feature on omap hsmmc driver. Do you any tree based on mainline kernel v3.8-rc1 with these edma & mmc patches. > > Signed-off-by: Matt Porter > -

RE: [RFC PATCH v3 00/16] DMA Engine support for AM33XX

2012-11-04 Thread Hebbar, Gururaja
On Thu, Oct 18, 2012 at 18:56:39, Porter, Matt wrote: ...snip... ...snip... ...snip... > > This series adds DMA Engine support for AM33xx, which uses > an EDMA DMAC. The EDMA DMAC has been previously supported by only > a private API implementation (much like the situation with OMAP > DMA) found

RE: [PATCH V3] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-11-01 Thread Hebbar, Gururaja
On Thu, Nov 01, 2012 at 01:46:26, Balbi, Felipe wrote: > Hi, > > On Thu, Nov 01, 2012 at 01:21:36AM +0530, Venkatraman S wrote: > > On Wed, Oct 31, 2012 at 5:56 PM, Felipe Balbi wrote: > > > Hi, > > > > > > On Wed, Oct 31, 2012 at 05:27:36PM +0530,

[PATCH V3] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-10-31 Thread Hebbar, Gururaja
off-by: Hebbar, Gururaja --- Rebased on mmc-next (v3.7.0-rc1) Only Build tested since EDMA support for AM335x is not yet added Changes in V2 - Added note in commit message about code re-use - replaced ((a & BIT(n) == BIT(n))) with (a & BIT(n)) since effectively

[RESEND PATCH V2] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-10-31 Thread Hebbar, Gururaja
off-by: Hebbar, Gururaja --- Rebased on mmc-next (v3.7.0-rc1) Only Build tested since EDMA support for AM335x is not yet added Changes in V2 - Added note in commit message about code re-use - replaced ((a & BIT(n) == BIT(n))) with (a & BIT(n)) since effectively

RE: [RESEND PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-10-30 Thread Hebbar, Gururaja
On Wed, Oct 31, 2012 at 11:14:28, Balbi, Felipe wrote: > Hi, > > On Wed, Oct 31, 2012 at 06:17:02AM +0100, Hebbar, Gururaja wrote: > > On Mon, Oct 29, 2012 at 21:47:19, Balbi, Felipe wrote: > > > Hi, > > > > > > On Mon, Oct 29, 2012 at 06:26:48PM +0530

RE: [RESEND PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-10-30 Thread Hebbar, Gururaja
On Mon, Oct 29, 2012 at 21:47:19, Balbi, Felipe wrote: > Hi, > > On Mon, Oct 29, 2012 at 06:26:48PM +0530, Hebbar, Gururaja wrote: > > HSMMC IP on AM33xx need a special setting to handle High-speed cards. > > Other platforms like TI81xx, OMAP4 may need this as-well. This dep

[RESEND PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-10-29 Thread Hebbar, Gururaja
Bit and - Controller should not be using DDR Mode and - Controller should advertise that it supports High Speed in capabilities register and - MMC/SD clock coming out of controller > 25MHz Signed-off-by: Hebbar, Gururaja --- Rebased on mmc-next (v3.7.0-rc1) Only Build tested since EDMA suppo

RE: [RFC PATCH v3 05/16] ARM: edma: add AM33XX crossbar event support

2012-10-26 Thread Hebbar, Gururaja
On Thu, Oct 18, 2012 at 18:56:44, Porter, Matt wrote: > Adds support for the per-EDMA channel event mux. This is required > for any peripherals using DMA crossbar mapped events. > > Signed-off-by: Matt Porter > --- > arch/arm/common/edma.c | 63 > ++

RE: [RFC PATCH v2 08/16] ARM: omap: add hsmmc am33xx specific init

2012-10-12 Thread Hebbar, Gururaja
Matt On Fri, Oct 12, 2012 at 00:34:33, Porter, Matt wrote: > AM33xx requires special handling in hsmmc initialization > platform glue. Since AM335x boots mainly through DT, do we still need this patch. This function will be called in case of initializing hsmmc with Platform data. > > Signed-of

RE: [PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-09-27 Thread Hebbar, Gururaja
On Thu, Sep 27, 2012 at 16:31:14, Koen Kooi wrote: > > Op 26 sep. 2012, om 13:37 heeft "Hebbar, Gururaja" > het volgende geschreven: > > > On Wed, Sep 12, 2012 at 17:32:38, Hebbar, Gururaja wrote: > >> On Wed, Sep 12, 2012 at 14:19:51, S, Venkatraman wrote:

RE: [PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-09-26 Thread Hebbar, Gururaja
On Wed, Sep 12, 2012 at 17:32:38, Hebbar, Gururaja wrote: > On Wed, Sep 12, 2012 at 14:19:51, S, Venkatraman wrote: > > On Tue, Sep 4, 2012 at 6:39 PM, Hebbar, Gururaja > > wrote: > > > HSMMC IP on AM33xx need a special setting to handle High-speed cards. > > > O

RE: [RFC PATCH 00/13] DMA Engine support for AM33xx

2012-09-26 Thread Hebbar, Gururaja
On Fri, Sep 21, 2012 at 23:52:11, Porter, Matt wrote: > On Fri, Sep 21, 2012 at 08:27:07AM +0000, Hebbar, Gururaja wrote: > > On Thu, Sep 20, 2012 at 20:13:33, Porter, Matt wrote: > > > This series adds DMA Engine support for AM33xx, which uses > > > an EDMA DMAC. The ED

RE: [RFC PATCH 00/13] DMA Engine support for AM33xx

2012-09-24 Thread Hebbar, Gururaja
On Fri, Sep 21, 2012 at 23:52:11, Porter, Matt wrote: > On Fri, Sep 21, 2012 at 08:27:07AM +0000, Hebbar, Gururaja wrote: > > On Thu, Sep 20, 2012 at 20:13:33, Porter, Matt wrote: > > > This series adds DMA Engine support for AM33xx, which uses > > > an EDMA DMAC. The ED

RE: [RFC PATCH 01/13] ARM: davinci: move private EDMA API to arm/common

2012-09-23 Thread Hebbar, Gururaja
On Thu, Sep 20, 2012 at 20:13:34, Porter, Matt wrote: > Move mach-davinci/dma.c to common/edma.c so it can be used > by OMAP (specifically AM33xx atm) as well. This just moves > the private EDMA API but does not support OMAP. > > Signed-off-by: Matt Porter > --- > arch/arm/Kconfig

RE: [RFC PATCH 01/13] ARM: davinci: move private EDMA API to arm/common

2012-09-21 Thread Hebbar, Gururaja
On Fri, Sep 21, 2012 at 14:59:23, Russell King - ARM Linux wrote: > On Thu, Sep 20, 2012 at 10:43:34AM -0400, Matt Porter wrote: > > Move mach-davinci/dma.c to common/edma.c so it can be used > > by OMAP (specifically AM33xx atm) as well. This just moves > > the private EDMA API but does not suppor

RE: [RFC PATCH 03/13] ARM: edma: add DT and runtime PM support for AM335x

2012-09-21 Thread Hebbar, Gururaja
On Thu, Sep 20, 2012 at 20:13:36, Porter, Matt wrote: > Adds support for parsing the TI EDMA DT data into the required > EDMA private API platform data. > > Calls runtime PM API only in the DT case in order to unidle the > associated hwmods on AM335x. > > Signed-off-by: Matt Porter > --- > arch

RE: [RFC PATCH 05/13] dma: Add TI EDMA device tree binding

2012-09-21 Thread Hebbar, Gururaja
On Thu, Sep 20, 2012 at 20:13:38, Porter, Matt wrote: > The binding definition is based on the generic DMA controller > binding. > > Signed-off-by: Matt Porter > --- > Documentation/devicetree/bindings/dma/ti-edma.txt | 49 > + > 1 file changed, 49 insertions(+) > create

RE: [RFC PATCH 00/13] DMA Engine support for AM33xx

2012-09-21 Thread Hebbar, Gururaja
On Thu, Sep 20, 2012 at 20:13:33, Porter, Matt wrote: > This series adds DMA Engine support for AM33xx, which uses > an EDMA DMAC. The EDMA DMAC has been previously supported by only > a private API implementation (much like the situation with OMAP > DMA) found on the DaVinci family of SoCs. > > T

RE: [RFC PATCH 01/13] ARM: davinci: move private EDMA API to arm/common

2012-09-21 Thread Hebbar, Gururaja
On Thu, Sep 20, 2012 at 20:13:34, Porter, Matt wrote: > Move mach-davinci/dma.c to common/edma.c so it can be used > by OMAP (specifically AM33xx atm) as well. This just moves > the private EDMA API but does not support OMAP. > > Signed-off-by: Matt Porter > --- > arch/arm/Kconfig

RE: [PATCH] mmc: omap_hsmmc: Pass on the suspend failure to the PM core

2012-09-13 Thread Hebbar, Gururaja
On Tue, Sep 11, 2012 at 11:13:26, S, Venkatraman wrote: > On Tue, Sep 4, 2012 at 6:38 PM, Hebbar, Gururaja > wrote: > > From: Vaibhav Bedia > > > > In some cases mmc_suspend_host() is not able to claim the > > host and proceed with the suspend process. The core

[PATCH V2] mmc: omap_hsmmc: Pass on the suspend failure to the PM core

2012-09-12 Thread Hebbar, Gururaja
still fail but it does not end up making the system unusable. Suspend gets aborted and the user can try suspending the system again. Signed-off-by: Vaibhav Bedia Signed-off-by: Hebbar, Gururaja --- Changes from V1: - Instead of forcibly returning -EBUSY on err, retain old status

RE: [PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-09-12 Thread Hebbar, Gururaja
On Wed, Sep 12, 2012 at 14:19:51, S, Venkatraman wrote: > On Tue, Sep 4, 2012 at 6:39 PM, Hebbar, Gururaja > wrote: > > HSMMC IP on AM33xx need a special setting to handle High-speed cards. > > Other platforms like TI81xx, OMAP4 may need this as-well. This depends > >

RE: [PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-09-12 Thread Hebbar, Gururaja
On Wed, Sep 12, 2012 at 14:51:34, Krishnamoorthy, Balaji T wrote: > On Tue, Sep 4, 2012 at 6:39 PM, Hebbar, Gururaja > wrote: > > HSMMC IP on AM33xx need a special setting to handle High-speed cards. > > Other platforms like TI81xx, OMAP4 may need this as-well. This depends &

RE: [PATCH] mmc: omap_hsmmc: Pass on the suspend failure to the PM core

2012-09-12 Thread Hebbar, Gururaja
On Tue, Sep 11, 2012 at 11:13:26, S, Venkatraman wrote: > On Tue, Sep 4, 2012 at 6:38 PM, Hebbar, Gururaja > wrote: > > From: Vaibhav Bedia > > > > In some cases mmc_suspend_host() is not able to claim the > > host and proceed with the suspend process. The core

RE: [PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-09-12 Thread Hebbar, Gururaja
On Tue, Sep 04, 2012 at 18:39:11, Hebbar, Gururaja wrote: > HSMMC IP on AM33xx need a special setting to handle High-speed cards. > Other platforms like TI81xx, OMAP4 may need this as-well. This depends > on the HSMMC IP timing closure done for the high speed cards. > > From AM335

[PATCH] mmc: omap_hsmmc: Enable HSPE bit for high speed cards

2012-09-04 Thread Hebbar, Gururaja
Bit and - Controller should not be using DDR Mode and - Controller should advertise that it supports High Speed in capabilities register and - MMC/SD clock coming out of controller > 25MHz Signed-off-by: Hebbar, Gururaja --- :100644 100644 be76a23... ed271fc... M Documentation/devicetree/bi

[PATCH] mmc: omap_hsmmc: Pass on the suspend failure to the PM core

2012-09-04 Thread Hebbar, Gururaja
and the user can try suspending the system again. Signed-off-by: Vaibhav Bedia Signed-off-by: Hebbar, Gururaja --- :100644 100644 9afdd20... c3e96a2... M drivers/mmc/host/omap_hsmmc.c drivers/mmc/host/omap_hsmmc.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers

RE: [PATCH v2 1/3] dmaengine: add TI EDMA DMA engine driver

2012-08-22 Thread Hebbar, Gururaja
On Wed, Aug 22, 2012 at 00:13:07, Porter, Matt wrote: > Add a DMA engine driver for the TI EDMA controller. This driver > is implemented as a wrapper around the existing DaVinci private > DMA implementation. This approach allows for incremental conversion > of each peripheral driver to the DMA engi

RE: [PATCH V4]mmc: remove MMC bus legacy suspend/resume method

2012-04-15 Thread Hebbar, Gururaja
sted > >> > >> Changes in v4: > >>fix the warning when disable CONFIG_PM_RUNTIME > >> > > > > Looks good to me! Acked-by: Ulf Hansson > > Thanks! Pushed to mmc-next for 3.4. Can you consider my Tested-by for this patch. Tested on AM335x

RE: [PATCH V4]mmc: remove MMC bus legacy suspend/resume method

2012-04-15 Thread Hebbar, Gururaja
when PM_RUNTIME is not > selected, as Ulf Hansson suggested > > Changes in v4: > fix the warning when disable CONFIG_PM_RUNTIME Tested on AM335x Platform. Solves major issue/crash reported at http://www.mail-archive.com/linux-omap@vger.kernel.org/msg65425.html Tested-by

RE: [GIT PULL] MMC fixes for 3.4-rc2

2012-04-08 Thread Hebbar, Gururaja
Hi, Is the pull already completed? If not can you add the recent mmc suspend/resume fix patch . http://www.spinics.net/lists/linux-pm/msg27090.html This is actually a fix (for bug) in mmc/sd suspend/resume path. This fixed a hard-to-find MMC suspend/resume while cp in progress race condition r

RE: [PATCH V2]mmc: remove MMC bus legacy suspend/resume method

2012-04-08 Thread Hebbar, Gururaja
6 -- > include/linux/mmc/card.h |2 +- > 3 files changed, 14 insertions(+), 16 deletions(-) > Tested on AM335x Platform. Solves major issue/crash reported at http://www.mail-archive.com/linux-omap@vger.kernel.org/msg65425.html Tested-by: Hebbar, Gururaja ..sn

RE: BUG/PATCH? mmcblk devices don't suspend properly.

2012-04-05 Thread Hebbar, Gururaja
I contacted the original author of the patch (http://comments.gmane.org/gmane.linux.kernel.mmc/9168) And he has posted the 2nd version of the commit. [PATCH V2]mmc: remove MMC bus legacy suspend/resume method MMC bus is using legacy suspend/resume method, which is not compatible if runtime pm c

RE: BUG/PATCH? mmcblk devices don't suspend properly.

2012-04-04 Thread Hebbar, Gururaja
On Tue, Apr 03, 2012 at 02:13:54, Per Forlin wrote: > On Fri, Mar 30, 2012 at 7:25 AM, Sujit Reddy Thumma > wrote: > > On 3/30/2012 8:17 AM, NeilBrown wrote: > >> > >> ...snip... ...snip... > >> > >> The net effect is that - as I observed - mmc_bus_suspend is never called. > >> > >> I added line

RE: Occasional crashes in suspend-resume with MMC transactions

2012-03-22 Thread Hebbar, Gururaja
On Thu, Mar 22, 2012 at 19:57:16, S, Venkatraman wrote: > On Thu, Mar 22, 2012 at 6:50 PM, Bedia, Vaibhav wrote: > > On Thu, Mar 22, 2012 at 09:53:23, Bedia, Vaibhav wrote: > >> Hi, > >> > >> I am trying to do suspend-resume test with a file copy on MMC/SD going on > >> in the background. The test

RE: [PATCH v2 5/8] mmc: host: omap_hsmmc: trivial cleanups

2012-03-18 Thread Hebbar, Gururaja
On Fri, Mar 16, 2012 at 19:09:01, S, Venkatraman wrote: > From: Felipe Balbi > > a bunch of non-functional cleanups to the omap_hsmmc > driver. > > It basically decreases indentation level, drop unneeded s/unneeded/unneeded. Better to use unnecessary > dereferences and drop unneded accesses to

RE: [PATCH] mmc: omap: remove clock rate hard coding

2011-12-20 Thread Hebbar, Gururaja
(host->base, SYSCTL) | ICE); > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Tested on AM3

OMAP HSMMC data timeout calculation

2011-10-21 Thread Hebbar, Gururaja
Hi all, I am trying to understand data timeout value (dto) calculation done in omap hsmmc driver (omap_hsmmc.c) I summed my understanding & my doubts in below code [GH]. Can someone help me in understanding the code Thanks in advance. Regards Gururaja static void set_data_timeout(struct om

Linux v3.1-rc3/8 : card insertion/removal not working

2011-10-13 Thread Hebbar, Gururaja
Hi all, Hi all, We are porting existing OMAP HSMMC driver (omap_hsmmc.c) to an upcoming SOC. The HSMMC IP is same as the one found in DM814x which uses the IP CD pins to detect MMC card insertion/removal rather than using gpio pins. When testing the driver with SanDisk 16GB SDHC Card (SanDisk

Linux v3.1-rc8 : SDHC card do not switch to high speed mode

2011-10-13 Thread Hebbar, Gururaja
Hi all, We are porting existing OMAP HSMMC driver (omap_hsmmc.c) to an upcoming SOC. When testing the driver with SanDisk 16GB SDHC Card (SanDisk Extreme HD Video 16GB 20Mb/s), we observed that the card doesn't switch to High Speed mode. The card shows that it is compatible with SDA spec3.

Linux v3.1-rc8 : SDHC card do not switch to high speed mode

2011-10-13 Thread Hebbar, Gururaja
Hi all, We are porting existing OMAP HSMMC driver (omap_hsmmc.c) to an upcoming SOC. When testing the driver with SanDisk 16GB SDHC Card (SanDisk Extreme HD Video 16GB 20Mb/s), we observed that the card doesn't switch to High Speed mode. The card shows that it is compatible with SDA spec3.