Re: [PATCH 2/5 v2] MMC/core: Add f_min to mmc_power_on()

2011-12-06 Thread Hein_Tibosch
Hi Jerry, On 12/6/2011 5:18 PM, r66...@freescale.com wrote: From: Jerry Huang chang-ming.hu...@freescale.com When f_init is zero, the SDHC can't work correctly. So f_min will replace f_init, when f_init is zero. Signed-off-by: Jerry Huang chang-ming.hu...@freescale.com CC: Chris Ball

Re: [PATCH 1/5 v2] MMC/core: Make sure the power is up, when detect the card

2011-12-06 Thread Hein_Tibosch
Hi Jerry, On 12/6/2011 5:18 PM, r66...@freescale.com wrote: From: Jerry Huang chang-ming.hu...@freescale.com Before running get_cd() recall function to detect whether the card is present, must make sure the power is up. Signed-off-by: Jerry Huang chang-ming.hu...@freescale.com CC: Chris

Re: [PATCH 4/5 v2] SDHCI: add sdhci_get_cd callback to detect the card

2011-12-06 Thread Hein_Tibosch
Hi Jerry, On 12/6/2011 5:15 PM, r66...@freescale.com wrote: From: Jerry Huang chang-ming.hu...@freescale.com Add callback function sdhci_get_cd to detect the card. And one new callback added to implement the card detect in sdhci struncture. If special platform has the card detect callback,

Re: [PATCH 2/5 v2] MMC/core: Add f_min to mmc_power_on()

2011-12-06 Thread Hein_Tibosch
On 12/6/2011 8:13 PM, Hein_Tibosch wrote: On 12/6/2011 5:18 PM, r66...@freescale.com wrote: When f_init is zero, the SDHC can't work correctly. So f_min will replace f_init, when f_init is zero. -host-ios.clock = host-f_init; +if (host-f_init) +host-ios.clock = host

Re: [PATCH 2/5 v2] MMC/core: Add f_min to mmc_power_on()

2011-12-06 Thread Hein_Tibosch
Hi Jerry, On 12/7/2011 10:23 AM, Huang Changming-R66093 wrote: -Original Message- From: Hein_Tibosch [mailto:hein_tibo...@yahoo.es] Sent: Tuesday, December 06, 2011 8:13 PM To: Huang Changming-R66093 Cc: linux-mmc@vger.kernel.org; Huang Changming-R66093; Chris Ball Subject: Re

SD power-control necessary?

2011-01-07 Thread Hein_Tibosch
Hello, Maybe a stupid question, but when designing new hardware with a slot for an sd-card, how essential is it that the driver is able to power off/on the card? I would say essential, because I've seen sd-cards in a state in which they didn't respond to MMC_GO_IDLE_STATE anymore, until they

Re: [PATCH] Fix sd/sdio/mmc initialization frequency retries

2011-01-02 Thread Hein_Tibosch
On 1-1-2011 04:43, Hein_Tibosch wrote: On 29-12-2010 01:15, Andy Ross wrote: I'm working with a eMMC device that broke after this commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=88ae8b86648 The older hack I'd been given hard-coded the initialisation

Re: [PATCH] Fix sd/sdio/mmc initialization frequency retries

2010-12-31 Thread Hein_Tibosch
Hi Andy, It looks like a good cleanup! On 29-12-2010 01:15, Andy Ross wrote: I'm working with a eMMC device that broke after this commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=88ae8b86648 The older hack I'd been given hard-coded the initialisation

Re: [PATCH v2] mmc_rescan: reduce verbosity

2010-10-12 Thread Hein_Tibosch
On 12-10-2010 23:08, Chris Ball wrote: Hi Eric, On Tue, Oct 12, 2010 at 09:29:37AM +0200, Eric BĂ©nard wrote: since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan includes a pr_info which prints 4 lines each second for hosts configured with MMC_CAP_NEEDS_POLL. Tested on i.MX51's

Re: [PATCH] sdhci: adjust sd 3.0 host controller spec clock divider

2010-10-05 Thread Hein_Tibosch
Hi Philip, Chris, On 5-10-2010 10:34, Chris Ball wrote: Hi David, On Thu, Sep 30, 2010 at 08:03:14PM -0700, Philip Rakity wrote: From: Philip Rakity prak...@marvell.com Date: Thu, 30 Sep 2010 15:34:24 -0700 Subject: [PATCH] sdhci: adjust sd 3.0 host controller spec clock divider The sd

Re: linux-2.6.36-rc4 problems booting rootfs from SD card

2010-09-28 Thread Hein_Tibosch
On 28-9-2010 22:16, Vasily Khoruzhick wrote: On 28 of September 2010 14:00:43 dylan cristiani wrote: Hi sirs, here is my scenario: kernel 2.6.36-rc4; cpu pxa270; platform is an enhancement (i like to see things that way...) and customisation of the mainstone III board; here comes the (my)

Re: [patch] mmc: fix init f_min

2010-09-27 Thread Hein_Tibosch
On 28-9-2010 11:34, zhangfei gao wrote: Just curious how to get 40, which is slowest speed for initializaion, is this OK for all card? Hi Zhangfei, It looks as if you missed another thread about f_min recently? See: https://patchwork.kernel.org/patch/177932/ This was in response to

[PATCH v5] mmc: Make ID freq configurable

2010-09-05 Thread Hein_Tibosch
Matt, Chris, Thanks both for reviewing. I never noticed that the host wasn't released because my f_min was low enough so that all frequencies would be tried. But yes, you're both right. Before somebody else makes the remark: unsigned freqs[] can be declared as const. Below, I changed the order

[PATCH v4] mmc: Make ID freq configurable

2010-09-02 Thread Hein_Tibosch
In the latest releases of the mmc driver, the freq during initialization is set to a fixed 400 Khz. This was reportedly too fast for several users. As there doesn't seem to be an ideal frequency which-works-for-all, Pierre suggested to let the driver try several frequencies. This patch implements

Re: [PATCH v2] mmc: lower init clock frequency to 300kHz

2010-01-06 Thread Hein_Tibosch
On 6-1-2010 15:01, Pavel Machek wrote: Machine with minimum clock of 1MHz is clearly broken, yet you issue soft warning. What about: if (f_min 400k) print existing warning else if (f_min 300k) print warning 'if your card does not work, its broken, but

Re: [PATCH v3] mmc: Make ID freq configurable

2010-01-04 Thread Hein_Tibosch
On 3-1-2010 07:38, Pierre Ossman wrote: cut We all use the same pool of cards so we should all be using the same init sequence. If there isn't a single frequency where all cards will work, then we'll have to make something more advanced where the kernel will try the init several times with

Re: [PATCH v3] mmc: Make ID freq configurable

2010-01-04 Thread Hein_Tibosch
In my last mail the spaces in the patch were mistreated, sorry for that. Below a patch which tries mmc-initialization using several frequencies from an array 400, 300, 200 and 100. Signed-off-by: Hein Tibosch hein_tibo...@yahoo.es --- diff -Nurp a/drivers/mmc/core/core.c

Re: [PATCH v3] mmc: Make ID freq configurable

2010-01-03 Thread Hein_Tibosch
Pierre Ossman wrote: On Sun, 3 Jan 2010 09:23:30 +1100 Ben Nizette b...@niasdigital.com wrote: Broken cards seem to be all over the spectrum, so I wouldn't be suprised if you find ones that break if you go too low as well. Yea good point, though given there might not even be a One