Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

2015-10-09 Thread Hongtao Wu
On Thu, Oct 8, 2015 at 9:54 PM, Ulf Hansson wrote: > [...] > >>> Thanks for clarifying! >>> >>> You have some differences towards the "standard" sdhci variant, but >>> that doesn't mean you should go off and implement a new driver from >>> scratch, instead you should create a new sdhci variant and

Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

2015-10-08 Thread Hongtao Wu
On Tue, Oct 6, 2015 at 5:18 PM, Ulf Hansson wrote: > +Russell > > On 28 September 2015 at 09:18, Hongtao Wu wrote: >>>> >> >> On Thu, Sep 10, 2015 at 9:28 PM, Ulf Hansson wrote: >>> >>> On 14 August 2015 at 18:55, Hongtao Wu wrote: >>

[RFC PATCH v3 0/3] Add MMC host driver for Spreadtrum SoC

2015-08-14 Thread Hongtao Wu
This patch adds MMC host driver for Spreadtrum SoC. The following coding style may be not meet kernel coding style. I am not sure this kind of coding style is better or worse. 1) A macro that represent some bits of a register is added a prefix "__", for example: #define SDHOST_16_HOST_CTRL_

[RFC PATCH v3 2/3] Documentation: Add Spreadtrum MMC DT bindings.

2015-08-14 Thread Hongtao Wu
The bindings is used to interpret Spreadtrum MMC dts file. Signed-off-by: Billows Wu(WuHongtao) --- Documentation/devicetree/bindings/mmc/sprd-mmc.txt | 46 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/mmc/sprd-mmc.txt diff --git

[RFC PATCH v3 3/3] DT: Add MMC nodes in Spreadtrum DT files.

2015-08-14 Thread Hongtao Wu
The MMC nodes is used to supply device nodes for Spreadtrum MMC driver. Signed-off-by: Billows Wu(WuHongtao) --- arch/arm64/boot/dts/sprd/sc9836-openphone.dts | 24 ++ arch/arm64/boot/dts/sprd/sharkl64.dtsi| 44 + 2 files changed, 68 insertions(+)

[RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

2015-08-14 Thread Hongtao Wu
the Spreadtrum MMC host driver is used to supply EMMC, SD, and SDIO types of memory cards Signed-off-by: Billows Wu(WuHongtao) --- drivers/mmc/host/Kconfig |6 + drivers/mmc/host/Makefile |1 + drivers/mmc/host/sprd_sdhost.c | 1202 +

[RFC PATCH v2 1/1] mmc: sprd: add MMC host driver for Spreadtrum SoC

2015-08-04 Thread Hongtao Wu
This patch adds MMC host driver for Spreadtrum SoC. The following coding style may be not meet kernel coding style. I am not sure this kind of coding style is better or worse. 1) A macro that represent some bits of a register is added a prefix "__", for example: #define SDHOST_16_HOST_CTRL_