On Wed, 2015-09-02 at 18:37 +0530, Vaibhav Hiremath wrote:
> On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote:
> > On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
> >> Return value would give clear information about the actual root-cause
> >> of the
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
> There were some coding style issues where spaces have been used instead
> of tabs, for example, in macro definitions, alignment of function
> declarations/definitions, etc...
>
> This patch fixes all such occurrences in the code.
> And a
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
> Return value would give clear information about the actual root-cause
> of the failure.
I'm not sure why that is as nearly every error path in
sdhci_add_host emits a message.
> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/h
On Tue, 2015-06-23 at 20:44 -0400, nick wrote:
>
> On 2015-06-23 08:40 PM, Joe Perches wrote:
> > On Wed, 2015-06-24 at 00:24 +, Kuninori Morimoto wrote:
> >> Hi Joe, Nick
> >>
> >>>>>> This adds a cast to the variables,slave_id_rx and slave
On Wed, 2015-06-24 at 00:24 +, Kuninori Morimoto wrote:
> Hi Joe, Nick
>
> > >>> This adds a cast to the variables,slave_id_rx and slave_id_rx
> > >>> to uintptr_t before casting to void* in order to avoid build
> > >>> warning on 64bit platforms for the function, sh_mmcif_request_dma_one.
> >
On Wed, 2015-06-24 at 08:54 +0900, Kuninori Morimoto wrote:
> Can you please teach us about status of this patch ?
> > This adds a cast to the variables,slave_id_rx and slave_id_rx
> > to uintptr_t before casting to void* in order to avoid build
> > warning on 64bit platforms for the function, sh_m
On Fri, 2015-03-13 at 13:52 +0100, Ulf Hansson wrote:
> As Chris Ball has moved on to other assignments, he's no longer able to
> help me maintain MMC. Let's remove him from the MMC sections.
>
> This also affects the SDHCI DRIVER section, since its state now becomes
> orphan.
Maybe add a CREDITS
On Mon, 2015-02-02 at 01:36 +0530, Sheetal Tigadoli wrote:
> This patch fixes "Missing blank line warnings". Following lines show warnings
> generated upon running checkpatch.pl script
>
> drivers/mmc/card/block.c:186: WARNING: Missing a blank line after
> declarations
> drivers/m
On Sat, 2015-01-31 at 23:37 +0530, Sheetal Tigadoli wrote:
> The patch fixes some of the following error/warnings from the file block.c
>
> ./scripts/checkpatch.pl --file --terse drivers/mmc/card/block.c
Hi.
It's a lot easier to review and accept these sorts of
changes if you break them into mo
On Tue, 2015-01-27 at 13:06 +0100, Richard Weinberger wrote:
> Am 27.01.2015 um 13:02 schrieb Alexander Holler:
> > Am 27.01.2015 um 12:55 schrieb Richard Weinberger:
> >> On Tue, Jan 27, 2015 at 12:48 PM, Alexander Holler
> >> wrote:
> >>> It's an interesting detail, so inform the user about it.
Use the much more common pr_warn instead of pr_warning.
Other miscellanea:
o Coalesce formats
o Realign arguments
o Remove extra spaces when coalescing formats
Signed-off-by: Joe Perches
---
drivers/mmc/card/block.c | 4 ++--
drivers/mmc/card/queue.c | 6 ++
drivers/mmc/card
On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote:
> On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
> > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
> > > We should prefer `const struct pci_device_id` over
> > > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding styl
Use the zeroing function instead of dma_alloc_coherent & memset(,0,)
Signed-off-by: Joe Perches
---
drivers/mmc/host/msm_sdcc.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c
index 9405ecd..3035d84 10
Use the zeroing function instead of dma_alloc_coherent & memset(,0,)
Joe Perches (26):
powerpc: Use dma_zalloc_coherent
sh: Use dma_zalloc_coherent
ata: Use dma_zalloc_coherent
block: Use dma_zalloc_coherent
crypto: Use dma_zalloc_coherent
dma: Use dma_zalloc_coherent
gpu:
On Wed, 2014-04-16 at 14:40 +0200, Antoine Ténart wrote:
> Add a Driver to support the SDHCI controller of the Marvell Berlin SoCs.
> This controller supports 3 sockets.
trivial notes:
> diff --git a/drivers/mmc/host/sdhci-berlin.c b/drivers/mmc/host/sdhci-berlin.c
[]
> +static struct sdhci_ops s
On Mon, 2012-11-12 at 02:12 -0500, Chris Ball wrote:
> Hi,
>
> On Sun, Nov 11 2012, Tushar Behera wrote:
> > Yes, I can do that. I did split it specifically so that we could drop
> > any patches if required.
> >
> > I will wait for a word from Chris regarding what he prefers.
>
> I would want to
On Fri, 2012-10-19 at 02:19 +0900, Sangho Yi wrote:
> Added a space between comma and an argument on the function definition
Hi Sangho.
Please don't just be a checkpatch robot, but look at the
code and see if you can improve it.
> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> inde
On Fri, 2012-10-19 at 01:31 +0900, Sangho Yi wrote:
> I fixed lines over 80 characters per line.
If you really must do these things, please use
checkpatch.pl --strict for guidance on how to align
function arguments.
> diff --git a/drivers/mmc/core/sdio_io.c b/drivers/mmc/core/sdio_io.c
[]
> @@ -6
On Wed, 2011-11-16 at 10:55 +0900, NamJae Jeon wrote:
> 2011/11/16 Joe Perches :
> > On Wed, 2011-11-16 at 10:48 +0900, NamJae Jeon wrote:
> >
> > [123K of untrimmed reply]
> >
> > If you wrote something, I didn't find it.
> >
>
> > -
On Wed, 2011-11-16 at 10:48 +0900, NamJae Jeon wrote:
[123K of untrimmed reply]
If you wrote something, I didn't find it.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/
On Wed, 2011-11-16 at 10:14 +0900, NamJae Jeon wrote:
> 2011/11/16 Joe Perches :
> > On Wed, 2011-11-16 at 09:52 +0900, NamJae Jeon wrote:
> >> 2011/11/16 Joe Perches :
> >> > Centralize the pr_ uses of mmc_hostname into specific
> >> > mmc_host_ ca
On Wed, 2011-11-16 at 09:52 +0900, NamJae Jeon wrote:
> 2011/11/16 Joe Perches :
> > Centralize the pr_ uses of mmc_hostname into specific
> > mmc_host_ calls to allow a flexible presentation style
> > and shorten the code a bit.
> I don't know why pr_info
Add pr_fmt.
Remove DRIVER_NAME from logging calls.
Remove DBG, use pr_debug.
Signed-off-by: Joe Perches
---
drivers/mmc/host/wbsd.c | 36
1 files changed, 16 insertions(+), 20 deletions(-)
diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c
Convert pr_warning to pr_warn.
Coalesce format strings.
Align arguments.
Add missing \n.
Signed-off-by: Joe Perches
---
drivers/mmc/card/block.c |4 +-
drivers/mmc/card/queue.c |6 +---
drivers/mmc/card/sdio_uart.c | 10
drivers/mmc/core/bus.c|4
Joe Perches (4):
mmc: Update logging style
wbsd: Use current logging
mmc: Logging neatening
mmc: Add mmc_host_ logging
drivers/mmc/card/block.c|4 +-
drivers/mmc/card/mmc_test.c | 77 ++-
drivers/mmc/card/queue.c|6 +-
drivers/mmc/card
ya trivial series...
Joe Perches (44):
arch/arm: Remove unnecessary semicolons
arch/microblaze: Remove unnecessary semicolons
arch/um: Remove unnecessary semicolons
drivers/cpufreq: Remove unnecessary semicolons
drivers/gpio: Remove unnecessary semicolons
drivers/i2c: Remove
Signed-off-by: Joe Perches
---
drivers/mmc/host/davinci_mmc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index e15547c..b643dde 100644
--- a/drivers/mmc/host/davinci_mmc.c
+++ b/drivers/mmc/host
On Tue, 2010-07-13 at 00:20 +0200, Lars-Peter Clausen wrote:
> This patch adds support for the mmc controller on JZ4740 SoCs.
> +static bool jz4740_mmc_write_data(struct jz4740_mmc_host *host,
> + struct mmc_data *data)
> +{
> + struct sg_mapping_iter *miter = &host->miter;
> + uint32_t
28 matches
Mail list logo
