On Thu, May 21, 2015 at 09:24:43AM +, Joakim Tjernlund wrote:
> The HW 8BIT can be confused with SDHCI_CTRL_HISPD(0x04) as it is the same bit.
>
> However, now I see that esdhc_writeb() has
> /* Prevent SDHCI core from writing reserved bits (e.g. HISPD). */
> if (reg == SDHCI_HOST_C
On Wed, May 20, 2015 at 02:54:27PM +, Joakim Tjernlund wrote:
> On Tue, 2015-05-19 at 17:20 +0800, Kevin Hao wrote:
> > On Sun, May 17, 2015 at 08:36:07AM +, Joakim Tjernlund wrote:
> > > On Sun, 2015-05-17 at 13:06 +0800, Kevin Hao wrote:
> > > > &
On Sun, May 17, 2015 at 08:36:07AM +, Joakim Tjernlund wrote:
> On Sun, 2015-05-17 at 13:06 +0800, Kevin Hao wrote:
> > >
> > > How about this one:
> > >
> > > From af6b18c056b6064424bd2ab1f9989bbadae5e701 Mon Sep 17 00:00:00 2001
> > > From: J
Simplify the error and remove path.
Signed-off-by: Kevin Hao
---
v2: No change.
drivers/mmc/host/sdhci-tegra.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index f3778d58d1cd..0643f66b4e14
Actually we can use the "clk" in the struct sdhci_pltfm_host.
With this change we can also kill the private function for get
max clock in this driver.
Signed-off-by: Kevin Hao
---
v2: Also kill the private sdhci_sirf_get_max_clk().
drivers/mmc/host/sdhci-s
In these drivers, the driver specific .remove function just a simple
wrapper of function sdhci_pltfm_unregister(). So remove these wrappers
and just set .remove to sdhci_pltfm_unregister().
Signed-off-by: Kevin Hao
---
v2: No change.
drivers/mmc/host/sdhci-bcm-kona.c | 7 +--
drivers/mmc
So we can avoid to sprinkle the clk_disable_unprepare() in many
drivers.
Signed-off-by: Kevin Hao
---
v2: No change.
drivers/mmc/host/sdhci-bcm-kona.c | 12 +---
drivers/mmc/host/sdhci-dove.c | 8 +---
drivers/mmc/host/sdhci-of-arasan.c | 1 -
drivers/mmc/host/sdhci-pltfm.c
Actually we can use the "clk" in the struct sdhci_pltfm_host. Also
change the "external clock" to "core clock" and kill two redundant
private functions in this driver as suggested by Ray Jui.
Signed-off-by: Kevin Hao
---
v2:
- s/external clock/core clock/
There is only one "clk" member in this driver specific private struct.
Actually we can use the "clk" member in the struct sdhci_pltfm_host,
and then kill this struct completely.
Signed-off-by: Kevin Hao
---
v2: No change.
drivers/mmc/host/sdhci-dove.c | 26 +-
sdhci_pltfm_unregister() with just a bit twist.
Only run test for sdhci-of-esdhc driver. All others just passed the build test.
Kevin Hao (7):
mmc: sdhci-dove: remove the unneeded error check
mmc: sdhci-dove: kill the driver specific private struct
mmc: tegra: use devm help functions to get the clk and gpio
The function clk_disable_unprepare() already take care of either error
or null cases.
Signed-off-by: Kevin Hao
---
v2: No change.
drivers/mmc/host/sdhci-dove.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci
Signed-off-by: Kevin Hao
---
v2: No change.
drivers/mmc/host/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 61ac63a3776a..7858d7a52818 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
f0b66a2cf68e ("PCI: Add pci_device_to_OF_node() stub for !CONFIG_OF")
- Add the ack in v1 cycle.
- Resolve the comments in v1 cycle.
We plan to merge this patch series via the powerpc tree in 4.1 cycle. So please
ack the corresponding patches if you are OK with these changes.
On Thu, Feb 05, 2015 at 09:51:17PM -0800, Ray Jui wrote:
> > @@ -265,19 +264,19 @@ static int sdhci_bcm_kona_probe(struct
> > platform_device *pdev)
> > }
> >
> > /* Get and enable the external clock */
>
> Would you mind changing the above comment to "/* Get and enable the core
> clock
There is only one "clk" member in this driver specific private struct.
Actually we can use the "clk" member in the struct sdhci_pltfm_host,
and then kill this struct completely.
Signed-off-by: Kevin Hao
---
drivers/mmc/host/sdhci-dove.c | 26 +
The function clk_disable_unprepare() already take care of either error
or null cases.
Signed-off-by: Kevin Hao
---
drivers/mmc/host/sdhci-dove.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c
index
In these drivers, the driver specific .remove function just a simple
wrapper of function sdhci_pltfm_unregister(). So remove these wrappers
and just set .remove to sdhci_pltfm_unregister().
Signed-off-by: Kevin Hao
---
drivers/mmc/host/sdhci-bcm-kona.c | 7 +--
drivers/mmc/host/sdhci
Actually we can use the "clk" in the struct sdhci_pltfm_host.
Signed-off-by: Kevin Hao
---
drivers/mmc/host/sdhci-sirf.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/mmc/host/sdhci-sirf.c b/drivers/mmc/host/sdhci-sirf.c
index f6
Actually we can use the "clk" in the struct sdhci_pltfm_host.
Signed-off-by: Kevin Hao
---
drivers/mmc/host/sdhci-bcm-kona.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/mmc/host/sdhci-bcm-kona.c
b/drivers/mmc/host/sdhci-bcm-ko
Hi,
In the current kernel, the specific .remove function in several sdhci platform
drivers seem pretty similar. Actually we can just set all of them to
sdhci_pltfm_unregister() with just a bit twist.
Only run test for sdhci-of-esdhc driver. All others just passed the build test.
Kevin Hao (7
Simplify the error and remove path.
Signed-off-by: Kevin Hao
---
drivers/mmc/host/sdhci-tegra.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index f3778d58d1cd..0643f66b4e14 100644
--- a
So we can avoid to sprinkle the clk_disable_unprepare() in many
drivers.
Signed-off-by: Kevin Hao
---
drivers/mmc/host/sdhci-bcm-kona.c | 12 +---
drivers/mmc/host/sdhci-dove.c | 8 +---
drivers/mmc/host/sdhci-of-arasan.c | 1 -
drivers/mmc/host/sdhci-pltfm.c | 2
. At the same time make the default
value a bit bigger, and the system which really need the per second
poll can tweak this parameter to be compatible with the old kernel.
Signed-off-by: Kevin Hao
---
drivers/mmc/core/core.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
bled device. In this case, it just doesn't parse
the dtb for the infos such as quirks or clock, but it will continue
to try to init the disabled device after that check. So just remove it.
Signed-off-by: Kevin Hao
---
drivers/mmc/host/sdhci-pltfm.c | 54 -
Signed-off-by: Kevin Hao
---
drivers/mmc/host/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index f145f1558353..a18dde1078ea 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -132,7 +132,7
25 matches
Mail list logo
