Re: [PATCH v3 2/3] mmc: sdhci-of-arasan: add phy support for sdhci-of-arasan

2015-10-20 Thread Kishon Vijay Abraham I
Hi, On Tuesday 20 October 2015 02:09 PM, Ulf Hansson wrote: > + Kishon > > On 20 October 2015 at 09:05, Shawn Lin wrote: >> This patch adds Generic PHY access for sdhci-of-arasan. Driver >> can get PHY handler from dt-binding, and power-on/init the PHY. >> Also we add pm ops for PHY here if CONF

Re: All OMAP platforms: MMC is broken

2015-10-07 Thread Kishon Vijay Abraham I
Hi, On Wednesday 07 October 2015 01:27 AM, Russell King - ARM Linux wrote: > On Wed, Oct 07, 2015 at 12:59:29AM +0530, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Tuesday 06 October 2015 08:37 PM, Russell King - ARM Linux wrote: >>> On Tue, Oct 06, 2015 at 04:06:09

Re: All OMAP platforms: MMC is broken

2015-10-07 Thread Kishon Vijay Abraham I
Hi, On Thursday 08 October 2015 01:10 AM, Ulf Hansson wrote: > On 7 October 2015 at 17:52, Tony Lindgren wrote: >> * Ulf Hansson [151007 06:46]: >>> On 7 October 2015 at 15:26, Tony Lindgren wrote: >> Good idea, how about something like the following? AFAIK that's the >> only .config op

Re: All OMAP platforms: MMC is broken

2015-10-06 Thread Kishon Vijay Abraham I
Hi, On Tuesday 06 October 2015 08:37 PM, Russell King - ARM Linux wrote: > On Tue, Oct 06, 2015 at 04:06:09PM +0530, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Tuesday 06 October 2015 03:41 PM, Ulf Hansson wrote: >>> On 6 October 2015 at 11:44, Tony Lindgren wr

Re: All OMAP platforms: MMC is broken

2015-10-06 Thread Kishon Vijay Abraham I
Hi, On Tuesday 06 October 2015 03:41 PM, Ulf Hansson wrote: > On 6 October 2015 at 11:44, Tony Lindgren wrote: >> * Russell King - ARM Linux [151006 02:04]: >>> On Mon, Oct 05, 2015 at 07:38:13PM +0100, Russell King - ARM Linux wrote: On Mon, Oct 05, 2015 at 10:11:56AM -0700, Tony Lindgren

Re: [PATCH v3 0/2] regulator: Fix pbias regulator enable

2015-09-14 Thread Kishon Vijay Abraham I
Hi, On Tuesday 15 September 2015 01:52 AM, Tony Lindgren wrote: > Hi, > > * Ulf Hansson [150904 05:48]: >> >> Okay, just to be clear on the way forward. I spoked with Mark Brown >> offlist, and he will/has picked up the regulator patch and will send >> it as fix for the 4.3 rc[n]. >> >> Regardin

Re: [PATCH] mmc: core: Keep host claimed while invoking mmc_power_off|up()

2015-09-11 Thread Kishon Vijay Abraham I
Hi, On Friday 11 September 2015 07:29 PM, Ulf Hansson wrote: > On 11 September 2015 at 15:22, Kishon Vijay Abraham I wrote: >> Hi Ulf, >> >> On Friday 11 September 2015 06:11 PM, Ulf Hansson wrote: >>> As mmc_claim_host() invokes pm_runtime_get_sync() for the mmc h

Re: [PATCH] mmc: core: Keep host claimed while invoking mmc_power_off|up()

2015-09-11 Thread Kishon Vijay Abraham I
Hi Ulf, On Friday 11 September 2015 06:11 PM, Ulf Hansson wrote: > As mmc_claim_host() invokes pm_runtime_get_sync() for the mmc host device, > it's important that the host is kept claimed for *all* accesses to it via > the host_ops callbacks. > > In some code paths for SDIO, particularly related

Re: [RFC PATCH 2/2] mmc: core: sdio: claim host before power up or power off

2015-09-11 Thread Kishon Vijay Abraham I
Hi, On Friday 11 September 2015 06:15 PM, Ulf Hansson wrote: > On 24 August 2015 at 12:15, Kishon Vijay Abraham I wrote: >> mmc_sdio_runtime_resume and mmc_sdio_runtime_suspend does power up and >> power off respectively but does so without claiming the host. Among other >>

Re: [PATCH] ARM: multi_v7_defconfig: Enable PBIAS regulator

2015-09-08 Thread Kishon Vijay Abraham I
hi, On Wednesday 09 September 2015 09:33 AM, Guenter Roeck wrote: > On Sun, Sep 06, 2015 at 04:41:10PM -0700, Guenter Roeck wrote: >> On Thu, Sep 03, 2015 at 03:25:11PM +0530, Kishon Vijay Abraham I wrote: >>> PBIAS regulator is required for MMC module in OMAP2, OMAP3, OMAP4,

Re: [PATCH] ARM: multi_v7_defconfig: Enable PBIAS regulator

2015-09-04 Thread Kishon Vijay Abraham I
Hi, On Thursday 03 September 2015 08:53 PM, Tony Lindgren wrote: > * Kishon Vijay Abraham I [150903 02:58]: >> PBIAS regulator is required for MMC module in OMAP2, OMAP3, OMAP4, >> OMAP5 and DRA7 SoCs. Enable it here. >> >> Signed-off-by: Kishon Vijay Abraham I >

[RESEND PATCH] ARM: multi_v7_defconfig: Enable PBIAS regulator

2015-09-04 Thread Kishon Vijay Abraham I
PBIAS regulator is required for MMC module in OMAP2, OMAP3, OMAP4, OMAP5 and DRA7 SoCs. Enable it here. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/configs/multi_v7_defconfig |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs

[PATCH v3 0/2] regulator: Fix pbias regulator enable

2015-09-04 Thread Kishon Vijay Abraham I
Fixed Tony's review comments on adding a 'comment' for adding offset in the driver and adding a warning for using platform_get_resource. *) Added Tony's Acked-by. Tested these patches against mmc -next in omap4 panda, omap3 beagle xm, dra72 and omap5 uevm Kishon Vijay Abraham

[PATCH v3 2/2] ARM: dts: : use "ti,pbias-" compatible string for pbias

2015-09-04 Thread Kishon Vijay Abraham I
Use platform specific compatible strings instead of the common "ti,pbias-omap" compatible string. Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/boot/dts/dra7.dtsi |2 +- arch/arm/boot/dts/omap2430.dtsi |2 +- arch/arm/boot/dts/omap3.dtsi

[PATCH v3 1/2] regulator: pbias: program pbias register offset in pbias driver

2015-09-04 Thread Kishon Vijay Abraham I
: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- .../bindings/regulator/pbias-regulator.txt |7 ++- drivers/regulator/pbias-regulator.c| 56 +--- 2 files changed, 56 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/regulator

[PATCH] ARM: multi_v7_defconfig: Enable PBIAS regulator

2015-09-03 Thread Kishon Vijay Abraham I
PBIAS regulator is required for MMC module in OMAP2, OMAP3, OMAP4, OMAP5 and DRA7 SoCs. Enable it here. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/configs/multi_v7_defconfig |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs

Re: [PATCH v2 0/6] regulator: Fix pbias regulator enable

2015-09-03 Thread Kishon Vijay Abraham I
Hi, On Thursday 03 September 2015 01:09 PM, Ulf Hansson wrote: > +Olof > > On 3 September 2015 at 08:50, Kishon Vijay Abraham I wrote: >> vsel_reg and enable_reg of the pbias regulator descriptor should actually >> have the offset from syscon. >> >> However aft

[PATCH v2 0/6] regulator: Fix pbias regulator enable

2015-09-02 Thread Kishon Vijay Abraham I
adding offset in the driver and adding a warning for using platform_get_resource. *) Added Tony's Acked-by. Tested these patches against mmc -next in omap4 panda, omap3 beagle xm, dra72 and omap5 uevm Kishon Vijay Abraham I (6): regulator: pbias: program pbias register offset in pbias dri

[PATCH v2 2/6] ARM: dts: dra7: use "ti,pbias-dra7" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-dra7" compatible string which is specifically added for DRA7 SoCs. Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/boot/dts/dra7.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/ar

[PATCH v2 3/6] ARM: dts: omap243x: use "ti,pbias-omap2" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-omap2" compatible string which is specifically added for OMAP2. Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/boot/dts/omap2430.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap2430.dtsi b/arc

[PATCH v2 1/6] regulator: pbias: program pbias register offset in pbias driver

2015-09-02 Thread Kishon Vijay Abraham I
: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- .../bindings/regulator/pbias-regulator.txt |7 ++- drivers/regulator/pbias-regulator.c| 56 +--- 2 files changed, 56 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/regulator

[PATCH v2 4/6] ARM: dts: omap3: use "ti,pbias-omap3" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-omap3" compatible string which is specifically added for OMAP3. Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/boot/dts/omap3.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/ar

[PATCH v2 6/6] ARM: dts: omap5: use "ti,pbias-omap5" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-omap5" compatible string which is specifically added for OMAP5. Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/boot/dts/omap5.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/ar

[PATCH v2 5/6] ARM: dts: omap4: use "ti,pbias-omap4" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-omap4" compatible string which is specifically added for OMAP4. Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/boot/dts/omap4.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/ar

[PATCH 2/6] ARM: dts: dra7: use "ti,pbias-dra7" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-dra7" compatible string which is specifically added for DRA7 SoCs. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi ind

[PATCH 3/6] ARM: dts: omap243x: use "ti,pbias-omap2" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-omap2" compatible string which is specifically added for OMAP2. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap2430.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap2430.dtsi b/arch/arm/boot/dts/omap2430.

[PATCH 4/6] ARM: dts: omap3: use "ti,pbias-omap3" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-omap3" compatible string which is specifically added for OMAP3. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap3.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi ind

[PATCH 1/6] regulator: pbias: program pbias register offset in pbias driver

2015-09-02 Thread Kishon Vijay Abraham I
: Kishon Vijay Abraham I --- .../bindings/regulator/pbias-regulator.txt |7 ++- drivers/regulator/pbias-regulator.c| 52 +--- 2 files changed, 52 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/regulator/pbias-regulator.txt b

[PATCH 5/6] ARM: dts: OMAP4: use "ti,pbias-omap4" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-omap4" compatible string which is specifically added for OMAP4. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi ind

[PATCH 6/6] ARM: dts: OMAP5: use "ti,pbias-omap5" compatible string for pbias

2015-09-02 Thread Kishon Vijay Abraham I
Use "ti,pbias-omap5" compatible string which is specifically added for OMAP5. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap5.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi ind

[PATCH 0/6] Fix pbias regulator enable

2015-09-02 Thread Kishon Vijay Abraham I
ens due to pbias node made as the child node of syscon. This breaks the pbias regulator enable. This series adds the 'offset' to be populated in vsel_reg and enable_reg in the pbias driver itself. Tested these patches against mmc -next in omap4 panda, omap3 beagle xm, dra72 and omap

Re: [PATCH v3 02/15] mmc: host: omap_hsmmc: return on fatal errors from omap_hsmmc_reg_get

2015-08-30 Thread Kishon Vijay Abraham I
Hi, On Saturday 29 August 2015 12:33 AM, Tony Lindgren wrote: > * Olof Johansson [150828 11:11]: >> Hi, >> >> On Thu, Aug 27, 2015 at 2:13 AM, Kishon Vijay Abraham I >> wrote: >>> Now return error only if the return value of >>> devm_regulator_get

Re: [PATCH v3 00/15] omap_hsmmc: regulator usage cleanup and fixes

2015-08-27 Thread Kishon Vijay Abraham I
On Thursday 27 August 2015 06:39 PM, Ulf Hansson wrote: > On 27 August 2015 at 11:13, Kishon Vijay Abraham I wrote: >> This patch series does the following >> *) Uses devm_regulator_get_optional() for vmmc and then removes the >>CONFIG_REGULATOR check altoge

Re: [PATCH v3 13/15] mmc: host: omap_hsmmc: use regulator_is_enabled to find pbias status

2015-08-27 Thread Kishon Vijay Abraham I
Hi Uffe, On Thursday 27 August 2015 06:12 PM, Ulf Hansson wrote: > On 27 August 2015 at 14:41, Ulf Hansson wrote: >> On 27 August 2015 at 11:14, Kishon Vijay Abraham I wrote: >>> Use regulator_is_enabled of pbias regulator to find pbias regulator >>> status inst

[PATCH v3 01/15] mmc: host: omap_hsmmc: use devm_regulator_get_optional() for vmmc

2015-08-27 Thread Kishon Vijay Abraham I
-off-by: Kishon Vijay Abraham I Tested-by: Tony Lindgren --- drivers/mmc/host/omap_hsmmc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 19ae7e6..9b335af 100644 --- a/drivers/mmc/host/omap_hsmmc.c

[PATCH v3 02/15] mmc: host: omap_hsmmc: return on fatal errors from omap_hsmmc_reg_get

2015-08-27 Thread Kishon Vijay Abraham I
Now return error only if the return value of devm_regulator_get_optional() is not the same as -ENODEV, since with -EPROBE_DEFER, the regulator can be obtained later and all other errors are fatal. Signed-off-by: Kishon Vijay Abraham I Tested-by: Tony Lindgren --- drivers/mmc/host/omap_hsmmc.c

[PATCH v3 03/15] mmc: host: omap_hsmmc: cleanup omap_hsmmc_reg_get()

2015-08-27 Thread Kishon Vijay Abraham I
-by: Kishon Vijay Abraham I Reviewed-by: Roger Quadros Tested-by: Tony Lindgren --- drivers/mmc/host/omap_hsmmc.c | 38 -- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index

[PATCH v3 06/15] mmc: host: omap_hsmmc: remove unnecessary pbias set_voltage

2015-08-27 Thread Kishon Vijay Abraham I
Remove the unnecessary pbias regulator_set_voltage done after pbias regulator_disable in omap_hsmmc_set_power. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Roger Quadros Tested-by: Tony Lindgren --- drivers/mmc/host/omap_hsmmc.c |1 - 1 file changed, 1 deletion(-) diff --git a

[PATCH v3 05/15] mmc: host: omap_hsmmc: use mmc_host's vmmc and vqmmc

2015-08-27 Thread Kishon Vijay Abraham I
No functional change. Instead of using omap_hsmmc_host's vcc and vcc_aux members, use vmmc and vqmmc present in mmc_host which is present for the same purpose. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Roger Quadros Tested-by: Tony Lindgren --- drivers/mmc/host/omap_hsmmc.c |

[PATCH v3 04/15] mmc: host: omap_hsmmc: use the ocrmask provided by the vmmc regulator

2015-08-27 Thread Kishon Vijay Abraham I
-off-by: Kishon Vijay Abraham I Tested-by: Tony Lindgren --- drivers/mmc/host/omap_hsmmc.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 3fde2f9..30f363d 100644 --- a/drivers/mmc/host/omap_hsmmc.c

[PATCH v3 07/15] mmc: host: omap_hsmmc: return error if any of the regulator APIs fail

2015-08-27 Thread Kishon Vijay Abraham I
Return error if any of the regulator APIs (regulator_enable, regulator_disable, regulator_set_voltage) fails in omap_hsmmc_set_power to avoid undefined behavior. Signed-off-by: Kishon Vijay Abraham I Tested-by: Tony Lindgren --- drivers/mmc/host/omap_hsmmc.c | 52

[PATCH v3 08/15] mmc: host: omap_hsmmc: add separate functions for enable/disable supply

2015-08-27 Thread Kishon Vijay Abraham I
No functional change. Cleanup omap_hsmmc_set_power by adding separate functions for enable/disable supply and invoke it from omap_hsmmc_set_power. Signed-off-by: Kishon Vijay Abraham I Tested-by: Tony Lindgren --- drivers/mmc/host/omap_hsmmc.c | 101

[PATCH v3 10/15] mmc: host: omap_hsmmc: avoid pbias regulator enable on power off

2015-08-27 Thread Kishon Vijay Abraham I
Fix omap_hsmmc_set_power so that pbias regulator is not enabled during power off. Signed-off-by: Kishon Vijay Abraham I Tested-by: Tony Lindgren --- drivers/mmc/host/omap_hsmmc.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b

[PATCH v3 11/15] mmc: host: omap_hsmmc: don't use ->set_power to set initial regulator state

2015-08-27 Thread Kishon Vijay Abraham I
lso takes care of setting the voltages which is not needed at this point. Signed-off-by: Kishon Vijay Abraham I Tested-by: Tony Lindgren --- drivers/mmc/host/omap_hsmmc.c | 66 ++--- 1 file changed, 56 insertions(+), 10 deletions(-) diff --git a/drivers/

[PATCH v3 09/15] mmc: host: omap_hsmmc: add separate function to set pbias

2015-08-27 Thread Kishon Vijay Abraham I
No functional change. Cleanup omap_hsmmc_set_power by adding separate functions to set pbias and invoke it from omap_hsmmc_set_power. Signed-off-by: Kishon Vijay Abraham I Tested-by: Tony Lindgren --- drivers/mmc/host/omap_hsmmc.c | 78 + 1 file

[PATCH v3 12/15] mmc: host: omap_hsmmc: enable/disable vmmc_aux regulator based on previous state

2015-08-27 Thread Kishon Vijay Abraham I
enable vmmc_aux regulator only if it is in disabled state and disable vmmc_aux regulator only if it is in enabled state. Signed-off-by: Kishon Vijay Abraham I Tested-by: Tony Lindgren --- drivers/mmc/host/omap_hsmmc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff

[PATCH v3 14/15] mmc: host: omap_hsmmc: use ios->vdd for setting vmmc voltage

2015-08-27 Thread Kishon Vijay Abraham I
vdd voltage is set in mmc core to ios->vdd and vmmc should actually be set to this voltage. Modify omap_hsmmc_enable_supply to not take vdd as argument since now it's directly set to the voltage in ios->vdd. Signed-off-by: Kishon Vijay Abraham I Tested-by: Tony Lindgren --- drive

[PATCH v3 15/15] mmc: host: omap_hsmmc: remove CONFIG_REGULATOR check

2015-08-27 Thread Kishon Vijay Abraham I
Now that support for platforms which have optional regulator is added, remove CONFIG_REGULATOR check in omap_hsmmc. Signed-off-by: Kishon Vijay Abraham I Tested-by: Tony Lindgren --- drivers/mmc/host/omap_hsmmc.c | 34 +++--- 1 file changed, 3 insertions(+), 31

[PATCH v3 13/15] mmc: host: omap_hsmmc: use regulator_is_enabled to find pbias status

2015-08-27 Thread Kishon Vijay Abraham I
Use regulator_is_enabled of pbias regulator to find pbias regulator status instead of maintaining a custom bookkeeping pbias_enabled variable. Signed-off-by: Kishon Vijay Abraham I Tested-by: Tony Lindgren --- drivers/mmc/host/omap_hsmmc.c |8 ++-- 1 file changed, 2 insertions(+), 6

[PATCH v3 00/15] omap_hsmmc: regulator usage cleanup and fixes

2015-08-27 Thread Kishon Vijay Abraham I
4 PANDA and OMAP3gle xm. Kishon Vijay Abraham I (15): mmc: host: omap_hsmmc: use devm_regulator_get_optional() for vmmc mmc: host: omap_hsmmc: return on fatal errors from omap_hsmmc_reg_get mmc: host: omap_hsmmc: cleanup omap_hsmmc_reg_get() mmc: host: omap_hsmmc: use the ocrmask provided by t

Re: [PATCH v2 16/16] mmc: host: omap_hsmmc: use "mmc_of_parse_voltage" to get ocr_avail

2015-08-26 Thread Kishon Vijay Abraham I
Hi Ulf, On Tuesday 25 August 2015 08:20 PM, Ulf Hansson wrote: > On 3 August 2015 at 14:26, Kishon Vijay Abraham I wrote: >> From: Roger Quadros >> >> For platforms that doesn't have explicit regulator control in MMC, >> populate voltage-ranges

[PATCH v2 01/11] mmc: host: omap_hsmmc: Support vmmc_aux to switch to 1.8v

2015-08-25 Thread Kishon Vijay Abraham I
Add support for vmmc_aux to switch to 1.8v. Also use "iov" instead of "vdd" to indicate io voltage. This is in preparation for adding support for io signal voltage switch. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 48

[PATCH v2 02/11] mmc: host: omap_hsmmc: separate setting voltage capabilities from bus power

2015-08-25 Thread Kishon Vijay Abraham I
omap_hsmmc_conf_bus_power to be invoked every time there is a voltage switch. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c

[PATCH v2 04/11] mmc: host: omap_hsmmc: add voltage switch support for UHS SD card

2015-08-25 Thread Kishon Vijay Abraham I
From: Balaji T K UHS sd card i/o data line can operate at 3V and 1.8V on UHS speed modes. Add support for signal voltage switch and check for card_busy. Signed-off-by: Balaji T K Signed-off-by: Sourav Poddar [kis...@ti.com : cleanup the voltage switch sequence] Signed-off-by: Kishon Vijay

[PATCH v2 06/11] mmc: host: omap_hsmmc: set timing in the UHSMS field

2015-08-25 Thread Kishon Vijay Abraham I
Add a separate function to set the UHSMS field to one of SDR104, SDR50, DDR50, SDR25 or SDR12 depending on the inserted SD card. This is required for tuning to succeed in the case of SDR104/HS200 or SDR50. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 49

[PATCH v2 05/11] mmc: host: omap_hsmmc: set clk rate to the max frequency

2015-08-25 Thread Kishon Vijay Abraham I
Set the clock rate of the functional clock to the max frequency that is passed to the driver either using pdata or dt. Also remove unnecessary setting of host->fclk to NULL. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 13 - 1 file changed,

[PATCH v2 03/11] mmc: host: omap_hsmmc: program HCTL based on signal_voltage set by mmc core

2015-08-25 Thread Kishon Vijay Abraham I
set on power mode status being changed to MMC_POWER_ON. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index fd8cc81

[PATCH v2 11/11] mmc: host: omap_hsmmc: add software timer when timeout greater than hardware capablility

2015-08-25 Thread Kishon Vijay Abraham I
unthan V N Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 71 +++-- 1 file changed, 69 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index bc59822..ec80de9 100644 --- a/driver

[PATCH v2 09/11] mmc: host: omap_hsmmc: Allow io voltage switch even for fixed vdd

2015-08-25 Thread Kishon Vijay Abraham I
Now that vmmc regulator is made optional, do not bail out if vmmc regulator is not found. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index

[PATCH v2 08/11] mmc: host: omap_hsmmc: Workaround for errata id i802

2015-08-25 Thread Kishon Vijay Abraham I
of the tuning end flag. Assertion of tuning end flag is what masks the interrupts. Because of this race, an erroneous DCRC interrupt occurs. The suggested workaround is to disable DCRC interrupts during the tuning procedure which is implemented here. Signed-off-by: Kishon Vijay Abraham I Signed

[PATCH v2 10/11] mmc: host: omap_hsmmc: remove incorrect voltage switch sequence

2015-08-25 Thread Kishon Vijay Abraham I
in start_signal_voltage_switch ops to be used by mmc core for switching voltages. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 81 - 1 file changed, 81 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmm

[PATCH v2 00/11] omap_hsmmc: voltage switching and tuning

2015-08-25 Thread Kishon Vijay Abraham I
Eco, Beagle-x15, AM437x EVM, Beaglebone black, OMAP5 uEVM and OMAP4 PANDA, OMAP3 beagle xm. Also performed PM suspend/resume test with OMAP3 beagle xm. Balaji T K (2): mmc: host: omap_hsmmc: add voltage switch support for UHS SD card mmc: host: omap_hsmmc: add tuning support Kishon Vijay Abraham I

[PATCH v2 07/11] mmc: host: omap_hsmmc: add tuning support

2015-08-25 Thread Kishon Vijay Abraham I
;caps" field. Signed-off-by: Balaji T K Signed-off-by: Viswanath Puttagunta Signed-off-by: Sourav Poddar [kis...@ti.com : cleanup the tuning sequence] Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 234 - 1 file changed, 232

Re: [PATCH 12/17] ARM: dts: am57xx-beagle-x15: Fix regulator populated in MMC1 dt node

2015-08-24 Thread Kishon Vijay Abraham I
Hi Tony, On Thursday 30 July 2015 01:07 AM, Nishanth Menon wrote: > On 07/29/2015 06:09 AM, Kishon Vijay Abraham I wrote: >> For beagle x15, both the vdd and io lines are connected to the >> same regulator (ldo1_reg). However vmmc_aux is populated to vdd_3v3. >> Remove it

[RFC PATCH 2/2] mmc: core: sdio: claim host before power up or power off

2015-08-24 Thread Kishon Vijay Abraham I
mmc_sdio_runtime_resume and mmc_sdio_runtime_suspend respectively. This is required since certain platforms (like TI SoCs) access the controller registers during power up. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/core/sdio.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff

[RFC PATCH 1/2] mmc: core: sdio: move mmc_sdio_init_card to a separate function

2015-08-24 Thread Kishon Vijay Abraham I
: Kishon Vijay Abraham I --- drivers/mmc/core/sdio.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c index b91abed..0cbbfb8 100644 --- a/drivers/mmc/core/sdio.c +++ b/drivers/mmc/core/sdio.c @@ -970,15

Re: [PATCH v2 00/16] omap_hsmmc: regulator usage cleanup and fixes

2015-08-21 Thread Kishon Vijay Abraham I
Hi Tony, On Friday 21 August 2015 01:11 PM, Tony Lindgren wrote: > * Kishon Vijay Abraham I [150820 05:39]: >> Hi, >> >> On Monday 03 August 2015 05:56 PM, Kishon Vijay Abraham I wrote: >>> Changes from v1: >>> *) return on -EPROBE_DEFER and other fatal e

Re: [PATCH v2 00/16] omap_hsmmc: regulator usage cleanup and fixes

2015-08-20 Thread Kishon Vijay Abraham I
Hi, On Monday 03 August 2015 05:56 PM, Kishon Vijay Abraham I wrote: > Changes from v1: > *) return on -EPROBE_DEFER and other fatal errors. (Don't return only >if the return value is -ENODEV) > *) Remove the beagle x15 dts patch. It can be part of a different >seri

Re: [PATCH 00/11] omap_hsmmc: voltage switching and tuning

2015-08-07 Thread Kishon Vijay Abraham I
Hi, On Thursday 06 August 2015 12:18 PM, Tony Lindgren wrote: > * Kishon Vijay Abraham I [150805 08:03]: >> Hi, >> >> On Wednesday 05 August 2015 04:13 PM, Tony Lindgren wrote: >>> * Kishon Vijay Abraham I [150730 00:49]: >>>> Patch series implements v

Re: [PATCH 0/7] ARM: dts: MMC fixes for DRA7 based boards

2015-08-05 Thread Kishon Vijay Abraham I
Hi, On Wednesday 05 August 2015 04:24 PM, Tony Lindgren wrote: > * Kishon Vijay Abraham I [150730 01:16]: >> Miscellaneous fixes in dts files for MMC device tree nodes. >> >> Did basic read/write test in J6, J6 Eco and Beagle-x15 >> >> Balaji T K (1): >&g

Re: [PATCH 00/11] omap_hsmmc: voltage switching and tuning

2015-08-05 Thread Kishon Vijay Abraham I
Hi, On Wednesday 05 August 2015 04:13 PM, Tony Lindgren wrote: > * Kishon Vijay Abraham I [150730 00:49]: >> Patch series implements voltage switching and tuning for omap_hsmmc >> driver. >> >> Did basic read/write test in J6, J6 Eco, Beagle-x15, AM437x EVM, >>

[PATCH v2 07/16] mmc: host: omap_hsmmc: return error if any of the regulator APIs fail

2015-08-03 Thread Kishon Vijay Abraham I
Return error if any of the regulator APIs (regulator_enable, regulator_disable, regulator_set_voltage) fails in omap_hsmmc_set_power to avoid undefined behavior. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 52 +++-- 1 file

[PATCH v2 02/16] mmc: host: omap_hsmmc: return on fatal errors from omap_hsmmc_reg_get

2015-08-03 Thread Kishon Vijay Abraham I
Now return error only if the return value of devm_regulator_get_optional() is not the same as -ENODEV, since with -EPROBE_DEFER, the regulator can be obtained later and all other errors are fatal. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 22

[PATCH v2 04/16] mmc: host: omap_hsmmc: use the ocrmask provided by the vmmc regulator

2015-08-03 Thread Kishon Vijay Abraham I
-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 9d062a1..8cf040f 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host

[PATCH v2 06/16] mmc: host: omap_hsmmc: remove unnecessary pbias set_voltage

2015-08-03 Thread Kishon Vijay Abraham I
Remove the unnecessary pbias regulator_set_voltage done after pbias regulator_disable in omap_hsmmc_set_power. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Roger Quadros --- drivers/mmc/host/omap_hsmmc.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/omap_hsmmc.c

[PATCH v2 05/16] mmc: host: omap_hsmmc: use mmc_host's vmmc and vqmmc

2015-08-03 Thread Kishon Vijay Abraham I
No functional change. Instead of using omap_hsmmc_host's vcc and vcc_aux members, use vmmc and vqmmc present in mmc_host which is present for the same purpose. Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Roger Quadros --- drivers/mmc/host/omap_hsmmc.c |

[PATCH v2 03/16] mmc: host: omap_hsmmc: cleanup omap_hsmmc_reg_get()

2015-08-03 Thread Kishon Vijay Abraham I
-by: Kishon Vijay Abraham I Reviewed-by: Roger Quadros --- drivers/mmc/host/omap_hsmmc.c | 38 -- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 5637793..9d062a1 100644 --- a

[PATCH v2 11/16] mmc: host: omap_hsmmc: don't use ->set_power to set initial regulator state

2015-08-03 Thread Kishon Vijay Abraham I
lso takes care of setting the voltages which is not needed at this point. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 66 ++--- 1 file changed, 56 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/driv

[PATCH v2 08/16] mmc: host: omap_hsmmc: add separate functions for enable/disable supply

2015-08-03 Thread Kishon Vijay Abraham I
No functional change. Cleanup omap_hsmmc_set_power by adding separate functions for enable/disable supply and invoke it from omap_hsmmc_set_power. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 101 +++-- 1 file changed, 66

[PATCH v2 10/16] mmc: host: omap_hsmmc: avoid pbias regulator enable on power off

2015-08-03 Thread Kishon Vijay Abraham I
Fix omap_hsmmc_set_power so that pbias regulator is not enabled during power off. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c

[PATCH v2 09/16] mmc: host: omap_hsmmc: add separate function to set pbias

2015-08-03 Thread Kishon Vijay Abraham I
No functional change. Cleanup omap_hsmmc_set_power by adding separate functions to set pbias and invoke it from omap_hsmmc_set_power. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 78 + 1 file changed, 48 insertions(+), 30

[PATCH v2 14/16] mmc: host: omap_hsmmc: use ios->vdd for setting vmmc voltage

2015-08-03 Thread Kishon Vijay Abraham I
vdd voltage is set in mmc core to ios->vdd and vmmc should actually be set to this voltage. Modify omap_hsmmc_enable_supply to not take vdd as argument since now it's directly set to the voltage in ios->vdd. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsm

[PATCH v2 16/16] mmc: host: omap_hsmmc: use "mmc_of_parse_voltage" to get ocr_avail

2015-08-03 Thread Kishon Vijay Abraham I
ff-by: Franklin S Cooper Jr Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/mmc/ti-omap-hsmmc.txt |2 ++ drivers/mmc/host/omap_hsmmc.c |9 - 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mmc/ti

[PATCH v2 15/16] mmc: host: omap_hsmmc: remove CONFIG_REGULATOR check

2015-08-03 Thread Kishon Vijay Abraham I
Now that support for platforms which have optional regulator is added, remove CONFIG_REGULATOR check in omap_hsmmc. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a

[PATCH v2 12/16] mmc: host: omap_hsmmc: enable/disable vmmc_aux regulator based on previous state

2015-08-03 Thread Kishon Vijay Abraham I
enable vmmc_aux regulator only if it is in disabled state and disable vmmc_aux regulator only if it is in enabled state. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host

[PATCH v2 13/16] mmc: host: omap_hsmmc: use regulator_is_enabled to find pbias status

2015-08-03 Thread Kishon Vijay Abraham I
Use regulator_is_enabled of pbias regulator to find pbias regulator status instead of maintaining a custom bookkeeping pbias_enabled variable. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a

[PATCH v2 01/16] mmc: host: omap_hsmmc: use devm_regulator_get_optional() for vmmc

2015-08-03 Thread Kishon Vijay Abraham I
-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 4d12032..b4b1bde 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host

[PATCH v2 00/16] omap_hsmmc: regulator usage cleanup and fixes

2015-08-03 Thread Kishon Vijay Abraham I
ttps://lkml.org/lkml/2015/7/27/391 This series is in preparation for implementing the voltage switch sequence so that UHS cards can be supported. Did basic read/write test in J6, J6 Eco, Beagle-x15, AM437x EVM, Beaglebone black, OMAP5 uEVM and OMAP4 PANDA. Kishon Vijay Abraham I (15): mmc: h

Re: [PATCH 00/17] omap_hsmmc: regulator usage cleanup and fixes

2015-08-03 Thread Kishon Vijay Abraham I
the patches in a git tree. Thanks Kishon > > /Andi > > 2015-07-29 13:09 GMT+02:00 Kishon Vijay Abraham I : >> This patch series does the following >> *) Uses devm_regulator_get_optional() for vmmc and then removes the >>CONFIG_REGULATOR check altogether. >

Re: [PATCH 01/17] mmc: host: omap_hsmmc: use devm_regulator_get_optional() for vmmc

2015-07-31 Thread Kishon Vijay Abraham I
Hi Grygorii, On Wednesday 29 July 2015 05:39 PM, Grygorii Strashko wrote: > On 07/29/2015 02:09 PM, Kishon Vijay Abraham I wrote: >> Since vmmc can be optional for some platforms, use >> devm_regulator_get_optional() for vmmc. Now return error only >> in the case of -EPR

[PATCH 4/7] ARM: dts: dra7-evm: Add MMCSD card removal GPIO

2015-07-30 Thread Kishon Vijay Abraham I
From: Nishanth Menon SDMMC Card Detect can be used over default GPIO map. Reported-by: Yan Liu Signed-off-by: Nishanth Menon Signed-off-by: Sekhar Nori Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7-evm.dts |5 + 1 file changed, 5 insertions(+) diff --git a/arch

[PATCH 0/7] ARM: dts: MMC fixes for DRA7 based boards

2015-07-30 Thread Kishon Vijay Abraham I
Miscellaneous fixes in dts files for MMC device tree nodes. Did basic read/write test in J6, J6 Eco and Beagle-x15 Balaji T K (1): ARM: dts: dra7-evm: add evm_3v3_sd regulator Kishon Vijay Abraham I (5): ARM: dts: dra72-evm: add evm_3v3_sd regulator ARM: dts: dra72-evm: Set max clock

[PATCH 1/7] ARM: dts: dra72-evm: add evm_3v3_sd regulator

2015-07-30 Thread Kishon Vijay Abraham I
Add a node for evm_3v3_sd using pcf which feeds on to mmc vdd. Update mapping for vmmc-supply and vmmc_aux-supply. evm_3v3_sd supplies to SD card vdd, and ldo1 to sdcard i/o lines. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra72-evm.dts | 13 +++-- 1 file changed, 11

[PATCH 3/7] ARM: dts: dra72-evm: Set max clock frequency of MMC1 and MMC2

2015-07-30 Thread Kishon Vijay Abraham I
MMC1 supports SDR104 and MMC2 supports HS200 both of which requires 192MHz clock. Set the maximum operating clock frequency to 192 MHz. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra72-evm.dts |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/dra72

[PATCH 7/7] ARM: dts: dra72-evm: Fix spurious card insert/removal interrupt

2015-07-30 Thread Kishon Vijay Abraham I
, it does a regulator disable which again raises a card insertion interrupt. This happens in a loop causing infinite MMC interrupts. Fix it by making ldo1_reg as always_on. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra72-evm.dts |1 + 1 file changed, 1 insertion(+) diff

[PATCH 2/7] ARM: dts: dra7-evm: add evm_3v3_sd regulator

2015-07-30 Thread Kishon Vijay Abraham I
From: Balaji T K Add a node for evm_3v3_sd using onboard pcf GPIO expander which feeds on to mmc vdd. Update mapping for vmmc-supply and vmmc_aux-supply. evm_3v3_sd supplies to SD card vdd, and ldo1 to sdcard i/o lines. Signed-off-by: Balaji T K Signed-off-by: Kishon Vijay Abraham I

[PATCH 5/7] ARM: dts: am57xx-beagle-x15: mmc1: remove redundant pbias-supply property

2015-07-30 Thread Kishon Vijay Abraham I
pbias-supply is initialized in dra7.dtsi. Remove redundant initialization of pbias-supply from MMC1 dt node in am57xx-beagle-x15.dts Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/am57xx-beagle-x15.dts |1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/am57xx

[PATCH 6/7] ARM: dts: dra7-evm: Fix spurious card insert/removal interrupt

2015-07-30 Thread Kishon Vijay Abraham I
, it does a regulator disable which again raises a card insertion interrupt. This happens in a loop causing infinite MMC interrupts. Fix it by making ldo1_reg as always_on. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7-evm.dts |1 + 1 file changed, 1 insertion(+) diff

[PATCH 00/11] omap_hsmmc: voltage switching and tuning

2015-07-30 Thread Kishon Vijay Abraham I
: add tuning support Kishon Vijay Abraham I (8): mmc: host: omap_hsmmc: Support pbias and vmmc_aux to switch to 1.8v mmc: host: omap_hsmmc: separate setting voltage capabilities from bus power mmc: host: omap_hsmmc: program HCTL based on signal_voltage set by mmc core mmc: host

[PATCH 03/11] mmc: host: omap_hsmmc: program HCTL based on signal_voltage set by mmc core

2015-07-30 Thread Kishon Vijay Abraham I
set on power mode status being changed to MMC_POWER_ON. Signed-off-by: Kishon Vijay Abraham I --- drivers/mmc/host/omap_hsmmc.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 2dfef11

  1   2   >