Re: [PATCH] mmc: sdhci-msm: Fix fallout from sdhci refactoring

2014-06-10 Thread Kumar Gala
Boyd > --- > > Patch based on next-20140610 > > drivers/mmc/host/sdhci-msm.c | 4 > 1 file changed, 4 insertions(+) Acked-by: Kumar Gala Feel free to pick up this version of the patch and ignore mine. - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Ce

[PATCH] mmc: sdhci-msm: Fix crash due to missing ops functions

2014-06-10 Thread Kumar Gala
Recent changes in sdhci core need to get reflected in sdhci_msm_ops otherwise we ended up dereferencing null pointers in the ops struct and crash. Signed-off-by: Kumar Gala --- drivers/mmc/host/sdhci-msm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/host/sdhci-msm.c b

Re: [PATCH v9 3/3] mmc: sdhci-msm: Add platform_execute_tunning implementation

2014-02-28 Thread Kumar Gala
On Feb 28, 2014, at 5:24 AM, Georgi Djakov wrote: > This patch adds implementation for platform specific tuning in order to > support > HS200 bus speed mode on Qualcomm SDHCI controller. > > Signed-off-by: Asutosh Das > Signed-off-by: Venkat Gopalakrishnan > Signed-off-by: Georgi Djakov > -

Re: [PATCH v3 2/4] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-10-29 Thread Kumar Gala
+ ----- - > + > +In suspend the fclk is off and the module is disfunctional. Even > +register reads will fail. A small logic in the host will request fclk > +restore, when an external event is detected. Once the clock is > +restored, the host de

Re: [PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-10-27 Thread Kumar Gala
On Oct 23, 2013, at 8:03 AM, Zhangfei Gao wrote: > update: fix typo > > Add dw_mmc-k3.c for k3v2, support sd/emmc > > Signed-off-by: Zhangfei Gao > Tested-by: Zhigang Wang > --- > .../devicetree/bindings/mmc/k3-dw-mshc.txt | 77 + > drivers/mmc/host/Kconfig

Re: [PATCH 1/3 V2] mmc:core: parse voltage from device-tree

2013-08-09 Thread Kumar Gala
On Jul 31, 2013, at 1:25 AM, Haijun Zhang wrote: > Add function to support get voltage from device-tree. > If there are voltage-range specified in device-tree node, this function > will parse it and return the avail voltage mask. > > Signed-off-by: Haijun Zhang > --- > changes for v2: > -

Re: [PATCH 3/4 V2] mmc: esdhc: Correct host version of T4240-R1.0

2013-07-22 Thread Kumar Gala
On Jul 17, 2013, at 5:11 AM, Haijun Zhang wrote: > Vender version and sdhc spec version of T4240-R1.0 is incorrect. > The right value should be VVN=0x13, SVN = 0x1. The wrong version > number will break down the ADMA data transfer. > This defect only exist in T4240-R1.0. Will be fixed in T4240-R2

Re: [PATCH 1/2] Powerpc: Add voltage ranges support for T4

2013-07-22 Thread Kumar Gala
On Jul 22, 2013, at 4:47 AM, Wrobel Heinz-R39252 wrote: >> Subject: [PATCH 1/2] Powerpc: Add voltage ranges support for T4 >> >> Special voltages that can be support by eSDHC of T4 in esdhc node. >> >> Signed-off-by: Haijun Zhang >> Signed-off-by: Anton Vorontsov > >> --- a/Documentation/dev

Re: [PATCH v3] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-09-24 Thread Kumar Gala
gt; Sent: Monday, September 24, 2012 10:37 AM >> To: Kumar Gala; Chris Ball >> Cc: linux-mmc@vger.kernel.org; Xie Shaohui-B21989; Anton Vorontsov >> Subject: RE: [PATCH v3] powerpc/esdhc: disable CMD23 for some Freescale >> SoCs >> >> >> >>>

Re: [PATCH v3] powerpc/esdhc: disable CMD23 for some Freescale SoCs

2012-09-21 Thread Kumar Gala
On Sep 21, 2012, at 11:08 AM, Chris Ball wrote: > Hi, > > On Fri, Sep 21 2012, r66...@freescale.com wrote: >> --- a/drivers/mmc/host/sdhci-of-esdhc.c >> +++ b/drivers/mmc/host/sdhci-of-esdhc.c >> @@ -143,6 +143,35 @@ static void esdhc_of_resume(struct sdhci_host *host) >> } >> #endif >> >> +sta

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-17 Thread Kumar Gala
On Sep 17, 2012, at 8:09 PM, Huang Changming-R66093 wrote: >> On Sep 17, 2012, at 7:36 AM, Chris Ball wrote: >> >>> Hi, >>> >>> On Thu, Sep 13 2012, Kumar Gala wrote: >>>>>> Can you list out which SoCs support it and which don't.

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-17 Thread Kumar Gala
On Sep 17, 2012, at 7:36 AM, Chris Ball wrote: > Hi, > > On Thu, Sep 13 2012, Kumar Gala wrote: >>>> Can you list out which SoCs support it and which don't. Having this list >>>> will be useful in understanding which controller versions supported it. >&

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-14 Thread Kumar Gala
>>>>> >>>>>> -Original Message- >>>>>> From: Chris Ball [mailto:c...@laptop.org] >>>>>> Sent: Wednesday, September 12, 2012 4:59 AM >>>>>> To: Kumar Gala >>>>>> Cc: Huang

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-13 Thread Kumar Gala
On Sep 12, 2012, at 9:02 PM, Huang Changming-R66093 wrote: >>> >>>> -Original Message- >>>> From: Chris Ball [mailto:c...@laptop.org] >>>> Sent: Wednesday, September 12, 2012 4:59 AM >>>> To: Kumar Gala >>>> Cc: Huan

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-12 Thread Kumar Gala
On Sep 12, 2012, at 1:18 AM, Huang Changming-R66093 wrote: > > > Best Regards > Jerry Huang > > >> -Original Message- >> From: Chris Ball [mailto:c...@laptop.org] >> Sent: Wednesday, September 12, 2012 4:59 AM >> To: Kumar Ga

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Kumar Gala
On Sep 11, 2012, at 9:44 AM, Chris Ball wrote: > Hi, > > On Tue, Sep 11 2012, Kumar Gala wrote: >> In sdhci_add_host() >> >> We have the following >> >> ... >>mmc->caps |= MMC_CAP_SDIO_IRQ | MMC_CAP_ERASE

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Kumar Gala
In sdhci_add_host() We have the following ... mmc->caps |= MMC_CAP_SDIO_IRQ | MMC_CAP_ERASE | MMC_CAP_CMD23; if (host->quirks & SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12) host->flags |= SDHCI_AUTO_CMD12; /* Auto-CMD23 stuff only works in ADMA or PIO. */

Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23

2012-09-11 Thread Kumar Gala
ux driver code makes some assumptions about CMD23 support that it shouldn't. - k > > >> -Original Message- >> From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] >> Sent: Tuesday, September 11, 2012 4:05 PM >> To: Huang Changming-R66093

Re: [PATCH 1/3 v2] mmc: Move mmc_delay() to include/linux/mmc/core.h

2011-10-27 Thread Kumar Gala
On Aug 26, 2011, at 2:52 AM, Chunhe Lan wrote: > Move mmc_delay() from drivers/mmc/core/core.h to > include/linux/mmc/core.h. So when other functions > call it with include syntax using > of absolute path rather than "../core/core.h" of > relative path. > > Signed-off-by: Chunhe Lan > Cc: Chri

Re: [PATCH 3/3 v2] mmc: Use mmc_delay() instead of mdelay() for time delay

2011-08-31 Thread Kumar Gala
On Aug 26, 2011, at 2:55 AM, Chunhe Lan wrote: > The mmc_delay() is a wrapper function for mdelay() and msleep(). > >o mdelay() -- block the system when busy-waiting. >o msleep() -- suspend the currently running task to enable CPU > to process other tasks, so it is non-b