Re: [PATCH v5 resubmit] mmc-omap: Add support for 16-bit and 32-bit registers

2010-01-11 Thread Ladislav Michl
On Sat, Jan 09, 2010 at 09:52:16AM -0800, Cory Maccarrone wrote: > From: Marek Belisko > > The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring > a modification of the register addresses in the mmc-omap driver. To resolve > this, a bit shift is performed on base register add

Re: [PATCH v4] mmc-omap: Add support for 16-bit and 32-bit registers

2009-11-23 Thread Ladislav Michl
it works now (though it needs additional patch, see here: http://thread.gmane.org/gmane.linux.kernel.mmc/649). Tested-by: Ladislav Michl Best regards, ladis -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger

Re: [PATCH v3] mmc-omap: Add support for 16-bit and 32-bit registers

2009-11-23 Thread Ladislav Michl
On Sun, Nov 22, 2009 at 01:16:25PM -0800, Cory Maccarrone wrote: > The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring > a modification of the register addresses in the mmc-omap driver. To resolve > this, a bit shift is performed on base register addresses, either by 1 or 2 >

Re: [PATCH] [mmc-omap] Add support for 16-bit and 32-bit registers

2009-11-18 Thread Ladislav Michl
On Wed, Nov 18, 2009 at 01:09:22PM -0800, Cory Maccarrone wrote: > On Wed, Nov 18, 2009 at 10:41 AM, Ladislav Michl > wrote: > > Did you test it? It does not work on 5910, see here: > > http://thread.gmane.org/gmane.linux.kernel.mmc/649 > > Not sure why it wouldn't w

Re: [PATCH] mmci-omap: free irq resource

2009-11-18 Thread Ladislav Michl
On Mon, Nov 09, 2009 at 02:27:49PM -0800, Andrew Morton wrote: > On Sun, 1 Nov 2009 12:59:05 +0100 > ladislav.mi...@seznam.cz wrote: > > > Free IRQ on remove. > > > > Signed-off-by: Ladislav Michl > > Acked-by: Tony Lindgren > > > > diff --git

Re: [PATCH] [mmc-omap] Add support for 16-bit and 32-bit registers

2009-11-18 Thread Ladislav Michl
On Sat, Nov 14, 2009 at 07:24:55PM -0800, Cory Maccarrone wrote: > The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring > a modification of the register addresses in the mmc-omap driver. To > make this as portable as possible, I made the following changes: Hmm, I would not tr

mmci-omap does not detect a card

2009-11-01 Thread Ladislav . Michl
Last time I used MMC card with linux-2.6.15-omap2 and it worked pretty well on my custom OMAP5910 based board. Current git nor linux-2.6.22-omap1 (currently used for production) doesn't work at all. Inserting module ends this way: # modprobe omap mmci-omap mmci-omap.0: command timeout (CMD5) mmci-

[PATCH] mmci-omap: remove bogus check for host->iclk

2009-11-01 Thread Ladislav . Michl
Remove check for host->iclk being NULL from error path since we already know it is non-null and use return value from clk_get. Signed-off-by: Ladislav Michl Acked-by: Tony Lindgren diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 5d773b8..c6d7e8e 100644 --- a/drivers/

[PATCH] mmci-omap: free irq resource

2009-11-01 Thread Ladislav . Michl
Free IRQ on remove. Signed-off-by: Ladislav Michl Acked-by: Tony Lindgren diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 5d773b8..5f970e2 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c @@ -1529,6 +1529,7 @@ static int mmc_omap_remove(struct

[PATCH] mmci-omap: free irq resource

2009-11-01 Thread Ladislav . Michl
Free IRQ on remove. Signed-off-by: Ladislav Michl diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 5d773b8..5f970e2 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c @@ -1529,6 +1529,7 @@ static int mmc_omap_remove(struct platform_device *pdev