Re: [PATCH v2 8/8] ARM: STi: DT: STiH407: Add dt nodes for sdhci and emmc.

2015-03-30 Thread Lee Jones
t; > arch/arm/boot/dts/stih410-b2120.dts | 10 ++ > > > arch/arm/boot/dts/stihxxx-b2120.dtsi | 8 > > > 3 files changed, 48 insertions(+) > > > > > > > > Maybe you could also add SD/eMMC support to the b2199 too? >

Re: [PATCH 1/2] mmc: tmio: mmc: tmio: tmio_mmc_data has .chan_priv_?x

2015-03-05 Thread Lee Jones
On Thu, 05 Mar 2015, Ulf Hansson wrote: > + Lee Jones. > > On 24 February 2015 at 03:06, Kuninori Morimoto > wrote: > > From: Kuninori Morimoto > > > > dma_request_slave_channel_compat() in tmio_mmc_dma > > needs .chan_priv_tx/.chan_priv_rx. But these are

Re: [PATCH v5 1/6] mfd: rtsx: add func to split u32 into register

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Ulf Hansson wrote: > On 20 January 2015 at 15:47, Lee Jones wrote: > > On Tue, 23 Dec 2014, micky_ch...@realsil.com.cn wrote: > > > >> From: Micky Ching > >> > >> Add helper function to write u32 to registers, if we want to put u32

Re: [PATCH v5 1/6] mfd: rtsx: add func to split u32 into register

2015-01-20 Thread Lee Jones
On Tue, 23 Dec 2014, micky_ch...@realsil.com.cn wrote: > From: Micky Ching > > Add helper function to write u32 to registers, if we want to put u32 > value to 4 continuous register, this can help us reduce tedious work. > > Signed-off-by: Micky Ching > Acked-by: Lee Jo

Re: [PATCH 01/17] mmc: tmio: add tmio_mmc_host_alloc/free()

2015-01-20 Thread Lee Jones
+--- > > drivers/mmc/host/tmio_mmc.c | 10 +++-- > > drivers/mmc/host/tmio_mmc.h |5 +++-- > > drivers/mmc/host/tmio_mmc_pio.c | 43 > > +++-- > > include/linux/mfd/tmio.h |1 - Acked-b

Re: [PATCH 03/17] mmc: tmio: tmio_mmc_host has .write16_hook

2015-01-20 Thread Lee Jones
tch. > > > > Signed-off-by: Kuninori Morimoto > > --- > > drivers/mmc/host/sh_mobile_sdhi.c |2 +- > > drivers/mmc/host/tmio_mmc.h |4 +++- > > drivers/mmc/host/tmio_mmc_pio.c | 2 +- > > include/linux/mfd/tmio.h |3

Re: [PATCH 02/17] mmc: tmio: tmio_mmc_host has .dma

2015-01-20 Thread Lee Jones
> > > Signed-off-by: Kuninori Morimoto > > --- > > drivers/mmc/host/sh_mobile_sdhi.c |4 ++-- > > drivers/mmc/host/tmio_mmc.h | 11 +++ > > drivers/mmc/host/tmio_mmc_dma.c | 24 +++----- > > include/linux/mfd/tmio.h

Re: [PATCH 05/17] mmc: tmio: tmio_mmc_host has .clk_disable

2015-01-20 Thread Lee Jones
tch. > > > > Signed-off-by: Kuninori Morimoto > > --- > > drivers/mmc/host/sh_mobile_sdhi.c |2 +- > > drivers/mmc/host/tmio_mmc.h |1 + > > drivers/mmc/host/tmio_mmc_pio.c | 4 ++-- > > include/linux/mfd/tmio.h |3 +-- Acked-by:

Re: [PATCH 04/17] mmc: tmio: tmio_mmc_host has .clk_enable

2015-01-20 Thread Lee Jones
tch. > > > > Signed-off-by: Kuninori Morimoto > > --- > > drivers/mmc/host/sh_mobile_sdhi.c |2 +- > > drivers/mmc/host/tmio_mmc.h |1 + > > drivers/mmc/host/tmio_mmc_pio.c | 5 ++--- > > include/linux/mfd/tmio.h |1 - Acked-by:

Re: [PATCH 06/17] mmc: tmio: tmio_mmc_host has .multi_io_quirk

2015-01-20 Thread Lee Jones
tch. > > > > Signed-off-by: Kuninori Morimoto > > --- > > drivers/mmc/host/sh_mobile_sdhi.c |2 +- > > drivers/mmc/host/tmio_mmc.h |2 ++ > > drivers/mmc/host/tmio_mmc_pio.c | 5 ++--- > > include/linux/mfd/tmio.h |3

Re: [PATCH 07/17] mmc: tmio: tmio_mmc_host has .bus_shift

2015-01-20 Thread Lee Jones
> > > Signed-off-by: Kuninori Morimoto > > --- > > drivers/mmc/host/sh_mobile_sdhi.c |5 ++--- > > drivers/mmc/host/tmio_mmc.c |5 +++-- > > drivers/mmc/host/tmio_mmc.h | 17 + > > drivers/mmc/host/tmio_mmc_dma.c

Re: [PATCH 08/17] mmc: tmio: tmio_mmc_data has .alignment_shift

2015-01-20 Thread Lee Jones
tch. > > > > Signed-off-by: Kuninori Morimoto > > --- > > drivers/mmc/host/sh_mobile_sdhi.c |4 ++-- > > drivers/mmc/host/tmio_mmc.h |1 - > > drivers/mmc/host/tmio_mmc_dma.c | 4 ++-- > > include/linux/mfd/tmio.h |

Re: [PATCH 09/17] mmc: tmio: tmio_mmc_data has .dma_rx_offset

2015-01-20 Thread Lee Jones
tch. > > > > Signed-off-by: Kuninori Morimoto > > --- > > drivers/mmc/host/sh_mobile_sdhi.c |2 +- > > drivers/mmc/host/tmio_mmc.h |1 - > > drivers/mmc/host/tmio_mmc_dma.c |2 +- > > include/linux/mfd/tmio.h |1 + > > 4 fi

Re: [PATCH 17/17] mmc: tmio: remove TMIO_MMC_HAVE_CTL_DMA_REG flag

2015-01-20 Thread Lee Jones
> > Let's remove it > > > > Signed-off-by: Kuninori Morimoto > > --- > > drivers/mmc/host/sh_mobile_sdhi.c |5 - > > drivers/mmc/host/tmio_mmc_dma.c |3 --- > > include/linux/mfd/tmio.h |5 - > > 3 files changed, 13

Re: [PATCH v4 1/6] mfd: rtsx: add func to split u32 into register

2014-12-08 Thread Lee Jones
On Mon, 08 Dec 2014, Ulf Hansson wrote: > On 8 December 2014 at 10:57, Lee Jones wrote: > > On Fri, 05 Dec 2014, micky_ch...@realsil.com.cn wrote: > >> From: Micky Ching > >> > >> Add helper function to write u32 to registers, if we want to put u32 > >

Re: [PATCH v4 1/6] mfd: rtsx: add func to split u32 into register

2014-12-08 Thread Lee Jones
On Fri, 05 Dec 2014, micky_ch...@realsil.com.cn wrote: > From: Micky Ching > > Add helper function to write u32 to registers, if we want to put u32 > value to 4 continuous register, this can help us reduce tedious work. > > Signed-off-by: Micky Ching > Acked-by: Lee Jo

Re: [PATCH v4 1/6] mfd: rtsx: add func to split u32 into register

2014-12-08 Thread Lee Jones
On Mon, 08 Dec 2014, 敬锐 wrote: > > On 12/08/2014 04:49 PM, Lee Jones wrote: > >> diff --git a/include/linux/mfd/rtsx_pci.h b/include/linux/mfd/rtsx_pci.h > >> >index 74346d5..9234449 100644 > >> >--- a/include/linux/mfd/rtsx_pci.h > >> >+++ b/

Re: [PATCH v4 1/6] mfd: rtsx: add func to split u32 into register

2014-12-08 Thread Lee Jones
On Fri, 05 Dec 2014, micky_ch...@realsil.com.cn wrote: > From: Micky Ching > > Add helper function to write u32 to registers, if we want to put u32 > value to 4 continuous register, this can help us reduce tedious work. > > Signed-off-by: Micky Ching > Acked-by: Lee Jo

Re: [PATCH v2 1/2] mfd: rtsx: add func to split u32 into register

2014-12-01 Thread Lee Jones
linux/mfd/rtsx_pci.h | 9 + > 1 file changed, 9 insertions(+) Looks fine to me. Let me know how you want to handle this: For my own reference: Acked-by: Lee Jones > diff --git a/include/linux/mfd/rtsx_pci.h b/include/linux/mfd/rtsx_pci.h > index 74346d5..9234449 100644 >

Re: [PATCH v2 1/2] mfd: rtsx: add func to split u32 into register

2014-12-01 Thread Lee Jones
reg + 2, 0xFF, val >> 8); > + rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, reg + 3, 0xFF, val); > +} > + > #endif -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from th

Re: [PATCH 1/2] mfd: rtsx: add func to split u32 into register

2014-12-01 Thread Lee Jones
gt; 8); > + rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, reg + 2, 0xFF, val >> 16); > + rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, reg + 3, 0xFF, val >> 24); > +} > #endif -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM

Re: [PATCH 2/6 v4] mmc: use .multi_io_quirk on tmio_mmc

2014-09-09 Thread Lee Jones
.multi_io_quirk callback > instead of MMC_CAP2_NO_MULTI_READ flags. > let's use it. > > Signed-off-by: Kuninori Morimoto > --- > v3 -> v4 > > - remove un-needed header > > drivers/mmc/host/tmio_mmc_pio.c | 13 + > include/linux/mfd/tmio.h|3 +++

Re: [PATCH 3/7 v3] mmc: use .multi_io_quirk on tmio_mmc

2014-09-08 Thread Lee Jones
ta { > > /* clock management callbacks */ > > int (*clk_enable)(struct platform_device *pdev, unsigned int *f); > > void (*clk_disable)(struct platform_device *pdev); > > + int (*multi_io_quirk)(struct mmc_card *card, > > +

Re: [PATCH 0/2] mmc: rtsx: add support for async request

2014-07-18 Thread Lee Jones
-- include/linux/mfd/rtsx_pci.h | 6 ++ 3 files changed, 181 insertions(+), 34 deletions(-) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line

Re: [PATCH 1/2] mfd: rtsx: add dma transfer function

2014-07-02 Thread Lee Jones
On Wed, 02 Jul 2014, micky wrote: > On 06/18/2014 04:00 PM, Lee Jones wrote: > >On Mon, 16 Jun 2014, Ulf Hansson wrote: > > > >>On 16 June 2014 14:20, Lee Jones wrote: > >>>>From: Micky Ching > >>>> > >>>>rtsx driver using a

Re: [PATCH 1/2] mfd: rtsx: add dma transfer function

2014-06-18 Thread Lee Jones
On Mon, 16 Jun 2014, Ulf Hansson wrote: > On 16 June 2014 14:20, Lee Jones wrote: > >> From: Micky Ching > >> > >> rtsx driver using a single function for transfer data, dma map/unmap are > >> placed in one fix function. We need map/unmap dma in differe

Re: [PATCH 1/2] mfd: rtsx: add dma transfer function

2014-06-16 Thread Lee Jones
/linux/mfd/rtsx_pci.h > @@ -943,6 +943,12 @@ void rtsx_pci_send_cmd_no_wait(struct rtsx_pcr *pcr); > int rtsx_pci_send_cmd(struct rtsx_pcr *pcr, int timeout); > int rtsx_pci_transfer_data(struct rtsx_pcr *pcr, struct scatterlist *sglist, > int num_sg, bool read, int t

Re: [GIT PULL] MMC updates for 3.16-rc1

2014-06-12 Thread Lee Jones
.c driver is one f*cking > noisy compile, and knisr certainly has never been tested in a 64-bit > environment. Please either fix it, or make it depend on BROKEN. > > Grr. > > Anyway, pulled, merged correctly, and pushed out.. > > Linus -- Lee Jones Lina

Re: [PATCH v3 10/10] MAINTAINERS: Add sdhci-st file to ARCH/STI architecture

2014-06-05 Thread Lee Jones
> Signed-off-by: Peter Griffin > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Acked-by: Lee Jones > diff --git a/MAINTAINERS b/MAINTAINERS > index 6dc67b1..19dc265 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1306,6 +1306,7 @@ F: driver

Re: [PATCH v3 09/10] ARM: update multi_v7_defconfig for STI

2014-06-05 Thread Lee Jones
> This patch enables SDHCI STI platform driver. > > Signed-off-by: Peter Griffin > --- > arch/arm/configs/multi_v7_defconfig | 1 + > 1 file changed, 1 insertion(+) Acked-by: Lee Jones > diff --git a/arch/arm/configs/multi_v7_defconfig > b/arch/arm/configs/multi_v7_d

Re: Add SDHCI support for STMicroelectronics SoCs

2014-06-02 Thread Lee Jones
t on hols last week. I have fixed it in v2. This should be in its own patch. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH 1/8] mmc: sdhci-st: Intial support for ST SDHCI controller

2014-05-22 Thread Lee Jones
atic struct platform_driver sdhci_st_driver = { > + .probe = sdhci_st_probe, > + .remove = sdhci_st_remove, > + .driver = { > +.name = "sdhci-st", > +.owner = THIS_MODULE, > + .pm = SDHCI_ST_PMOPS, > +.of_match_ta

Re: [PATCH 2/8] mmc: sdhci-st: STMicroelectronics SDHCI binding documentation.

2014-05-22 Thread Lee Jones
"disabled"; > + reg = <0xfe81e000 0x1000>; > + interrupts = ; > + interrupt-names = "mmcirq"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_mmc0>; > + clock-names = "mmc";

Re: [PATCH 3/8] ARM: STi: DT: Add sdhci pins for stih416

2014-05-22 Thread Lee Jones
+++ > 1 file changed, 39 insertions(+) Acked-by: Lee Jones > diff --git a/arch/arm/boot/dts/stih416-pinctrl.dtsi > b/arch/arm/boot/dts/stih416-pinctrl.dtsi > index 6252188..140af6b 100644 > --- a/arch/arm/boot/dts/stih416-pinctrl.dtsi > +++ b/arch/arm/boot/dt

Re: [PATCH 4/8] ARM: STi: DT: Add sdhci controller for stih416

2014-05-22 Thread Lee Jones
t;st,sdhci"; > + status = "disabled"; > + reg = <0xfe81f000 0x1000>; > + interrupts = ; > + interrupt-names = "mmcirq"; > + pinctrl-names = "default";

Re: [PATCH 5/8] ARM: STi: DT: Add sdhci pin configuration for stih415

2014-05-22 Thread Lee Jones
+ pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_mmc0>; > + clock-names = "mmc"; > + clocks = <&clk_s_a1_ls 1>; Nit: These would be easier to read if the '=&

Re: [PATCH 6/8] ARM: STi: DT: Enable mmc0 for both stih415 and stih416 SoCs

2014-05-22 Thread Lee Jones
ro These are the wrong way around. You can correct that when adding my: Acked-by: Lee Jones > --- > arch/arm/boot/dts/stih41x-b2020x.dtsi | 4 > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/stih41x-b2020x.dtsi > b/arch/arm/boot/dts/stih41x-

Re: [PATCH 7/8] ARM: STi: DT: Enable second sdhci controller for stih416 b2020 boards.

2014-05-22 Thread Lee Jones
2,12 @@ > / { > model = "STiH416 B2020"; > compatible = "st,stih416-b2020", "st,stih416"; > + > + soc { > + mmc1: sdhci@fe81f000 { > + status = "okay"; > + non-removable; >

Re: [PATCH 8/8] ARM: update multi_v7_defconfig for STI

2014-05-22 Thread Lee Jones
> This patch enables SDHCI STI platform driver. > > Signed-off-by: Peter Griffin > --- > arch/arm/configs/multi_v7_defconfig | 1 + > 1 file changed, 1 insertion(+) Acked-by: Lee Jones > diff --git a/arch/arm/configs/multi_v7_defconfig > b/arch/arm/configs/multi_v7_d

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-05-08 Thread Lee Jones
;>Fix by excluding such condition when defining macro RTSX_USB_USE_LEDS_CLASS. > >> > >>Signed-off-by: Roger Tseng > > > >Acked-by: Ulf Hansson > > Would this patch be merged into linux-next or Lee's mfd.git > ib-mfd-mmc-memstick-3.16 branch? Thi

Re: [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify error handleandremove smatch warnings"

2014-05-08 Thread Lee Jones
Micky Ching > >>> > >>>This reverts commit 1f7b581b3ffcb2a8437397a02f4af89fa6934d08. > >>> > >>>The patch depend on commit c42deffd5b53c9e583d83c7964854ede2f12410d > >>>, but the previous > >>>patch was discard. So we have to delet

Re: [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

2014-05-08 Thread Lee Jones
id using the spinlock and also avoid the problem. > >> > >> Signed-off-by: Micky Ching > > > > Acked-by: Ulf Hansson > > Hi Lee, > > Would you mind to pick this up and send it for 3.15 fixes? > > The other revert "[PATCH 1/2] mmc: rtsx: Reve

Re: [PATCH 0/2] mmc: rtsx: revert support for mmc async request

2014-04-29 Thread Lee Jones
arify, what commit did you base these changes on? Have you tested to ensure everything works as it should with these two reversions? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe fr

Re: [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

2014-04-28 Thread Lee Jones
gt; > > > This patch should be sent to the -rcs as soon as possible: > > Do you mind helping out doing it here Lee? Not sure how busy Chris is > at the moment. I don't mind. I just need a maintainer Ack from one of you guys. > > > > Acked-by: Lee Jones

Re: [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

2014-04-28 Thread Lee Jones
nclude/linux/mfd/rtsx_pci.h |6 - > 4 files changed, 109 insertions(+), 448 deletions(-) This patch should be sent to the -rcs as soon as possible: Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Li

Re: [PATCH v7 3/4] mmc: Add realtek USB sdmmc host driver

2014-04-28 Thread Lee Jones
c/host/Makefile |1 + > drivers/mmc/host/rtsx_usb_sdmmc.c | 1455 > + > 3 files changed, 1463 insertions(+) > create mode 100644 drivers/mmc/host/rtsx_usb_sdmmc.c Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Lina

Re: [PATCH v7 4/4] memstick: Add realtek USB memstick host driver

2014-04-28 Thread Lee Jones
+ > drivers/memstick/host/rtsx_usb_ms.c | 839 > > 3 files changed, 850 insertions(+) > create mode 100644 drivers/memstick/host/rtsx_usb_ms.c Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open sou

Re: [PATCH v7 2/4] [v6 fix] mfd/rtsx_usb: add comment in rtsx_usb_suspend

2014-04-16 Thread Lee Jones
sx_usb.c | 6 ++ > 1 file changed, 6 insertions(+) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-mmc&quo

Re: [PATCH v7 1/4] [v6 fix] mfd/rtsx_usb: fix possible race condition

2014-04-16 Thread Lee Jones
| 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v7 4/4] memstick: Add realtek USB memstick host driver

2014-04-16 Thread Lee Jones
it anyway. In your last review you mentioned that it looked good to your inexpert eye. Can I apply your Ack to that effect? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this li

Re: [PATCH v7 0/4] Add modules for realtek USB card reader

2014-04-16 Thread Lee Jones
subsystems. Once the patchset or > >>>>its > >>>>revision is applied, we may need Greg's help to remove the staging one. > >>> > >>>Looks good to me. > >> > >>Is that an Ack? > >Acked-by: Oliver > > > &g

Re: [PATCH v7 0/4] Add modules for realtek USB card reader

2014-04-11 Thread Lee Jones
; > Looks good to me. Is that an Ack? > Regards > Oliver > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "

Re: [PATCH v5 3/3] memstick: Add realtek USB memstick host driver

2014-04-08 Thread Lee Jones
a1eae32ff2fe00b > Merge: c29aa15 2d28ca7 > Author: Linus Torvalds > Date: Mon Apr 7 10:24:18 2014 -0700 > > Merge tag 'mfd-for-linus-3.15' of > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd > > Is there any chance to revert it? Or what can I do to help curren

Re: [PATCH v5 3/3] memstick: Add realtek USB memstick host driver

2014-04-02 Thread Lee Jones
de. If that doesn't happen then I guess the best we > can do is to go ahead and merge it. Have you worked out via which tree > the patches will be merged? I'll be happy to take the set if one of the subsystem experts would be kind enough to cast an eye over it. Maxim, Alex? --

Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver

2014-03-28 Thread Lee Jones
not in a permanent cut-off state after here. It is called > to guarantee the LED is off during suspend to save more power. It > could be lit up in the card host drivers(e.g. rtsx_usb_sdmmc.c) > anytime whenever necessary. > > This has been asked may times. I'm considering put

Re: [PATCH v4 1/3] mfd: Add realtek USB card reader driver

2014-02-17 Thread Lee Jones
you say "depend on", do you mean as a build depenency, or won't > >run without the first patch applied? > > The later 2 patches actually invoke symbols defined in the first > patch and won't compile if it is not applied first. The Kconfig > changes for the later

Re: [PATCH v4 1/3] mfd: Add realtek USB card reader driver

2014-02-17 Thread Lee Jones
ween them, it's probably better that they go into their associated > >trees separately. > > > I think it would be better to apply them together since the later > patches really depend on the 1st one,so now we are waiting for Acks > from mmc/memstick subsystems. When you say

Re: [PATCH v4 1/3] mfd: Add realtek USB card reader driver

2014-02-17 Thread Lee Jones
Would you also apply patch 2/3 and 3/3 that to make the device fully > operational for users? Or should they be applied by maintainers of > mmc/memstick subsystems? > > Chris, would you give some comment? I can apply them, but I need the other Maintainer Acks. If they are build

Re: [PATCH v4 1/3] mfd: Add realtek USB card reader driver

2014-02-14 Thread Lee Jones
+ > 4 files changed, 1399 insertions(+) > create mode 100644 drivers/mfd/rtsx_usb.c > create mode 100644 include/linux/mfd/rtsx_usb.h Applied again, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook |

Re: [PATCH v3 1/3] mfd: Add realtek USB card reader driver

2014-02-11 Thread Lee Jones
On Tue, 11 Feb 2014, Roger wrote: > On 02/10/2014 07:30 PM, Lee Jones wrote: > >>From: Roger Tseng > >> > >>Realtek USB card reader provides a channel to transfer command or data to > >>flash > >>memory cards. This driver exports host instan

Re: [PATCH v3 1/3] mfd: Add realtek USB card reader driver

2014-02-10 Thread Lee Jones
e mode 100644 drivers/mfd/rtsx_usb.c > create mode 100644 include/linux/mfd/rtsx_usb.h Applied with Greg's Ack. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this l

Re: [PATCH 1/3] mfd: Add realtek USB card reader driver

2014-01-16 Thread Lee Jones
something like: struct rtsx_ucr *ucr = dev_get_drvdata(pdev->dev.parent); Naturally this is untested code and might not work off the bat, but it does give you some idea of what you can do without iterating through and populating each sub-device's platform data. > >>+#define D

Re: [PATCH 1/3] mfd: Add realtek USB card reader driver

2014-01-14 Thread Lee Jones
lso like to see the SHIFT #defined, although this may become superfluous once the 0x03 is clarified. > addr |= 0x03 << 14; > > value = __swab16(addr); > index = mask | (data << 8); This is 100% better/clearer. > > > + > > > + dev_dbg(&intf->

Re: [PATCH 1/3] mfd: Add realtek USB card reader driver

2014-01-14 Thread Lee Jones
tomatically when you write/read to/from it again? > + return 0; > +} > + > +static int rtsx_usb_reset_resume(struct usb_interface *intf) > +{ > + struct rtsx_ucr *ucr = > + (struct rtsx_ucr *)usb_get_intfdata(intf); > + > + rtsx_usb_reset_chip(ucr); &

Re: [PATCH 1/3] mfd:mmc:rtsx: Change default tx phase

2013-08-21 Thread Lee Jones
x/mfd/rtsx_pci.h | 15 ++ > 7 files changed, 69 insertions(+), 16 deletions(-) MFD parts looks okay to me: Acked-by: Lee Jones -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Lee Jones
On Thu, 13 Jun 2013, Balaji T K wrote: > On Thursday 13 June 2013 04:17 PM, Lee Jones wrote: > >On Thu, 13 Jun 2013, Linus Walleij wrote: > > > >>On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K wrote: > >> > >>>PBIAS register configuration is based on th

Re: [PATCH v2 06/10] mmc: omap_hsmmc: add support for pbias configuration in dt

2013-06-13 Thread Lee Jones
ode, loopback clock > > (in devconf0/devconf1/prog_io1 register for omap3) and pull strength > > configuration (in control_mmc1 for omap4) > > > > Signed-off-by: Balaji T K > > You *need* Lee Jones and Mark Brown to review this. > Maybe Laurent has something t

Re: [PATCH] mmc: mmci: Allow MMCI to request channels with information acquired from DT

2013-04-30 Thread Lee Jones
On Tue, 30 Apr 2013, Linus Walleij wrote: > On Wed, Apr 24, 2013 at 12:58 PM, Lee Jones wrote: > > > Currently, if DMA information isn't passed from platform data, then DMA > > will not be used. This patch allows DMA information obtained though Device > > Tree t

[PATCH v2] mmc: mmci: Allow MMCI to request channels with information acquired from DT

2013-04-24 Thread Lee Jones
Currently, if DMA information isn't passed from platform data, then DMA will not be used. This patch allows DMA information obtained though Device Tree to be used as well. Cc: Russell King Cc: Chris Ball Cc: linux-mmc@vger.kernel.org Signed-off-by: Lee Jones diff --git a/drivers/mmc

[PATCH] mmc: mmci: Allow MMCI to request channels with information acquired from DT

2013-04-24 Thread Lee Jones
Currently, if DMA information isn't passed from platform data, then DMA will not be used. This patch allows DMA information obtained though Device Tree to be used as well. Cc: Russell King Cc: Chris Ball Cc: linux-mmc@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mmc/host/mmci.c |

Re: [PATCH] mmc: mmci: Allow MMCI to request channels with information acquired from DT

2013-04-18 Thread Lee Jones
dev_warn(mmc_dev(host->mmc), "no TX DMA channel\n"); } else { @@ -1538,7 +1542,7 @@ static int mmci_probe(struct amba_device *dev, amba_rev(dev), (unsigned long long)dev->res.start, dev->irq[0], dev->irq[1]); - mmci_dma_setup

Re: [PATCH] mmc: mmci: Allow MMCI to request channels with information acquired from DT

2013-04-17 Thread Lee Jones
dma_tx_channel) dev_warn(mmc_dev(host->mmc), "no TX DMA channel\n"); } else { @@ -1538,7 +1542,7 @@ static int mmci_probe(struct amba_device *dev, amba_rev(dev), (unsigned long long)dev->res.start, dev->irq[0], dev->irq[1])

[PATCH] mmc: mmci: Allow MMCI to request channels with information acquired from DT

2013-04-17 Thread Lee Jones
Currently, if DMA information isn't passed from platform data, then DMA will not be used. This patch allows DMA information obtained though Device Tree to be used as well. Cc: Russell King Cc: Chris Ball Cc: linux-mmc@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mmc/host/mmci.c |

Re: [PATCH V2 2/2] mmc: mmci: Move ios_handler functionality into the driver

2013-01-23 Thread Lee Jones
On Wed, 23 Jan 2013, Russell King - ARM Linux wrote: > On Wed, Jan 23, 2013 at 10:13:49AM +0000, Lee Jones wrote: > > On Tue, 22 Jan 2013, Lee Jones wrote: > > > Are you saying that you won't do it? :) > > > > > > Is there anything I can do to make th

Re: [PATCH V2 2/2] mmc: mmci: Move ios_handler functionality into the driver

2013-01-23 Thread Lee Jones
On Tue, 22 Jan 2013, Lee Jones wrote: > On Tue, 22 Jan 2013, Russell King - ARM Linux wrote: > > > On Tue, Jan 22, 2013 at 10:20:10AM +0000, Lee Jones wrote: > > > On Tue, 22 Jan 2013, Russell King - ARM Linux wrote: > > > > > > > On Tue, Jan 22, 201

Re: [PATCH V2 2/2] mmc: mmci: Move ios_handler functionality into the driver

2013-01-22 Thread Lee Jones
On Tue, 22 Jan 2013, Russell King - ARM Linux wrote: > On Tue, Jan 22, 2013 at 10:20:10AM +0000, Lee Jones wrote: > > On Tue, 22 Jan 2013, Russell King - ARM Linux wrote: > > > > > On Tue, Jan 22, 2013 at 10:53:42AM +0100, Linus Walleij wrote: > > > > On Tue,

Re: [PATCH V2 2/2] mmc: mmci: Move ios_handler functionality into the driver

2013-01-22 Thread Lee Jones
On Tue, 22 Jan 2013, Russell King - ARM Linux wrote: > On Tue, Jan 22, 2013 at 10:53:42AM +0100, Linus Walleij wrote: > > On Tue, Jan 22, 2013 at 10:00 AM, Lee Jones wrote: > > > > >> From: Lee Jones > > >> > > >> There are currently two inst

Re: [PATCH V2 2/2] mmc: mmci: Move ios_handler functionality into the driver

2013-01-22 Thread Lee Jones
> From: Lee Jones > > There are currently two instances of the ios_handler being used. > Both of which mearly toy with some regulator settings. Now there > is a GPIO regulator API, we can use that instead, and lessen the > per platform burden. By doing this, we also become

Re: [PATCH V2 2/2] mmc: mmci: Move ios_handler functionality into the driver

2012-12-14 Thread Lee Jones
On Fri, 14 Dec 2012, Russell King - ARM Linux wrote: > On Fri, Dec 14, 2012 at 03:30:29PM +0100, Ulf Hansson wrote: > > From: Lee Jones > > > > There are currently two instances of the ios_handler being used. > > Both of which mearly toy with some regulator settin

Re: [PATCH] mmc: Standardise capability type

2012-11-19 Thread Lee Jones
On Mon, 19 Nov 2012, Chris Ball wrote: > Hi, > > On Mon, Nov 19 2012, Lee Jones wrote: > >> > There are discrepancies with regards to how MMC capabilities > >> > are carried throughout the subsystem. Let's standardise them > >> > to elevate any

Re: [PATCH] mmc: Standardise capability type

2012-11-19 Thread Lee Jones
On Sat, 17 Nov 2012, Chris Ball wrote: > Hi Lee, > > Pushed to mmc-next for 3.8 with a minor change: > > On Wed, Nov 14 2012, Lee Jones wrote: > > There are discrepancies with regards to how MMC capabilities > > are carried throughout the subsystem. Let's sta

[PATCH] mmc: Standardise capability type

2012-11-14 Thread Lee Jones
There are discrepancies with regards to how MMC capabilities are carried throughout the subsystem. Let's standardise them to elevate any confusion. Cc: Chris Ball Cc: linux-mmc@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mmc/core/mmc.c |2 +- include/linu

Re: [PATCH 1/1] mmc: Standardise capability type

2012-10-24 Thread Lee Jones
On Wed, 24 Oct 2012, Arnd Bergmann wrote: > On Wednesday 24 October 2012, Lee Jones wrote: > > > > There are discrepancies with regards to how MMC capabilities > > are carried throughout the subsystem. Let's standardise them > > to elevate any confusion. > &

[PATCH 1/1] mmc: Standardise capability type

2012-10-24 Thread Lee Jones
There are discrepancies with regards to how MMC capabilities are carried throughout the subsystem. Let's standardise them to elevate any confusion. Cc: Chris Ball Cc: linux-mmc@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mmc/core/mmc.c |2 +- include/linux/mmc/dw_mmc.h |

Re: [PATCH 1/2] mmc: core: Support all MMC capabilities when booting from Device Tree

2012-10-15 Thread Lee Jones
> On Monday 15 October 2012, Lee Jones wrote: > > Capabilities are an important part of the MMC subsystem. Much > > supported functionality would be lost if we didn't provide the > > same level of support when booting Device Tree as we currently > > do when the subs

[PATCH 2/2] mmc: mmci: Make use of new DT capability parsing function

2012-10-15 Thread Lee Jones
: Russell King Cc: linux-mmc@vger.kernel.org Acked-by: Linus Walleij Acked-by: Ulf Hansson Signed-off-by: Lee Jones --- drivers/mmc/host/mmci.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c index edc3e9b

[PATCH 1/2] mmc: core: Support all MMC capabilities when booting from Device Tree

2012-10-15 Thread Lee Jones
h one simple call to a DT parsing function. Cc: Chris Ball Cc: Russell King Cc: linux-mmc@vger.kernel.org Acked-by: Linus Walleij Acked-by: Ulf Hansson Signed-off-by: Lee Jones --- drivers/mmc/core/host.c | 93 ++ include/linux/mmc/host.h |3

Re: [PATCH 2/5] MMC: mmci: Seperate ARM variants from generic code

2012-03-15 Thread Lee Jones
On 15/03/12 17:36, Lee Jones wrote: > On 15/03/12 17:32, Russell King - ARM Linux wrote: >> On Wed, Mar 14, 2012 at 02:20:00PM +0000, Lee Jones wrote: >>> This is a step in the right direction for future Device >>> Tree support. It will allow variant specific attributes

Re: [PATCH 2/5] MMC: mmci: Seperate ARM variants from generic code

2012-03-15 Thread Lee Jones
On 15/03/12 17:32, Russell King - ARM Linux wrote: > On Wed, Mar 14, 2012 at 02:20:00PM +0000, Lee Jones wrote: >> This is a step in the right direction for future Device >> Tree support. It will allow variant specific attributes >> to be collected from a Device Tree witho

Re: [PATCH 0/5] MMC: mmci: Provide bindings for Device Tree

2012-03-15 Thread Lee Jones
On 15/03/12 15:32, Arnd Bergmann wrote: > On Thursday 15 March 2012, Lee Jones wrote: >>> I would like to see what the minimal required change is to support DT >>> for mmci without factorization. >>> 1. Minimal change in mmci. >>> 2. Add mmci_dt.c which con

Re: [PATCH 0/5] MMC: mmci: Provide bindings for Device Tree

2012-03-15 Thread Lee Jones
say? I'm wondering what the difference is as the work has already been done. It was Arnd's suggestion to separate out the two types of variants, and I'm quite fond of the new (fully featured) layout. Kind regards, Lee > On Wed, Mar 14, 2012 at 3:19 PM, Lee Jones wrote:

Re: [PATCH 3/5] MMC: mmci: Add generic Device Tree bindings to mmci core code

2012-03-15 Thread Lee Jones
On 15/03/12 15:12, Per Forlin wrote: > On Wed, Mar 14, 2012 at 3:20 PM, Lee Jones wrote: >> This adds the necessary bindings for collection of shared >> attributes used in the mmci driver. >> >> Signed-off-by: Lee Jones >> --- &

[PATCH 5/5] MMC: mmci: Add required documentation for Device Tree bindings

2012-03-14 Thread Lee Jones
This provides full documentation detailing each compulsory, optional and device (variant) specific properties available for use within the MMCI Device Tree. Signed-off-by: Lee Jones --- Documentation/devicetree/bindings/mmc/mmci.txt | 27 1 files changed, 27

[PATCH 4/5] MMC: mmci: Enable Device Tree support for ux500 variants

2012-03-14 Thread Lee Jones
Provide a means to collect attributes specific to ST-Ericsson's ux500 variant series. This patch registers itself as the AMBA driver to be called during the probe process. Once all attributes and ux500 specifics are are collected the normal mmci core probe is called. Signed-off-by: Lee

[PATCH 3/5] MMC: mmci: Add generic Device Tree bindings to mmci core code

2012-03-14 Thread Lee Jones
This adds the necessary bindings for collection of shared attributes used in the mmci driver. Signed-off-by: Lee Jones --- drivers/mmc/host/mmci.c | 43 +++ 1 files changed, 43 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/mmci.c b

[PATCH 2/5] MMC: mmci: Seperate ARM variants from generic code

2012-03-14 Thread Lee Jones
This is a step in the right direction for future Device Tree support. It will allow variant specific attributes to be collected from a Device Tree without overloading the MMCI core. It will also provide additional future variants a cleaner way to add support. Signed-off-by: Lee Jones

[PATCH 1/5] MMC: mmci: Seperate ux500 variants from generic code

2012-03-14 Thread Lee Jones
This is a step in the right direction for future Device Tree support. It will allow variant specific attributes to be collected from a Device Tree without overloading the MMCI core. It will also provide additional future variants a cleaner way to add support. Signed-off-by: Lee Jones

[PATCH 0/5] MMC: mmci: Provide bindings for Device Tree

2012-03-14 Thread Lee Jones
This patch-set splits out ux500 and ARM specific variants from mmci core code, applies generic bindings for use by all variants, then enables the ux500 variant for use with Device Tree. Documentation/devicetree/bindings/mmc/mmci.txt | 27 +++ arch/arm/boot/dts/db8500.dtsi |

Re: Patch "mmc: fix all hangs related to mmc/sd card insert/removal during suspend/resume" has been added to the 2.6.35-stable tree

2010-09-16 Thread Lee Jones
> If you, or anyone else, feels it should not be added to the stable tree, > please let know about it. I actually intended this patch go on into .32-stable, but I see no solid reason why it can't go into .35-stable too. There is one issue though. If you add this patch and leave out the one below

Re: MMC: [PATCH 0/2 v2] Two fixes for mmc system

2010-08-26 Thread Lee Jones
> ccc92c23240cdf952ef7cc39ba563910dcbc9cbe and > 4c2ef25fe0b847d2ae818f74758ddb0be1c27d8e in mainline, committed a > couple of weeks ago. For some reason the search box wasn't working for me. Thank you Andrew. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of

  1   2   >