Re: [PATCH v3 0/5] mmc: Add access to RPMB partition

2012-11-21 Thread Loic PALLARDY
Hi Krishna, On 11/20/2012 07:54 PM, Krishna Konda wrote: Loic/Linus/Chris, I think the IOCTL is not complete in terms of handling the RPMB requests. Here is why I think that is - let me know your opinion There are four request types that are needed to be supported - two under read category

Re: [PATCH v3 0/5] mmc: Add access to RPMB partition

2012-11-21 Thread Loic PALLARDY
Hi Sundar, On 11/21/2012 12:02 PM, Sundar J. Dev wrote: Hi Loic, On Wed, Nov 21, 2012 at 3:25 PM, Loic PALLARDYloic.palla...@st.com wrote: I am guessing that you would expect the userspace application too call into the ioctl twice to take care of the 4 5 Yes exactly, you have to first

Re: [PATCH v3 0/5] mmc: Add access to RPMB partition

2012-11-20 Thread Loic PALLARDY
On 11/19/2012 07:12 PM, Krishna Konda wrote: On Sat, 2012-11-17 at 18:12 -0500, Chris Ball wrote: I've merged this to mmc-next for 3.8 now; thanks to everyone who Acked. If you have any userspace sample code that could be added to mmc-utils to show how the interface can be used, feel free

Re: [PATCH v3 5/5] mmc: card: Add RPMB support in IOCTL interface

2012-08-22 Thread Loic pallardy
Hi, Any specific reason why the RPMB support is implemented using the IOCTL interface. Can this be done by the Kernel itself instead of being initiated by a user space application ? -- regards, Shashidhar Hiremath -- Hi, There are several reasons for that: - RPMB partition supports

[PATCH v3 0/5] mmc: Add access to RPMB partition

2012-08-06 Thread Loic Pallardy
as defined by JEDEC standard. --- Changes in v2: - Correction in patch 2: mmc: card: Do not scan RPMB partitions Remove GENHD_FL_EXT_DEVT flag Changes in v3: - Add acked-by and reviewed-by tags --- Loic Pallardy (5): mmc: core: Expose access to RPMB partition mmc: card: Do not scan RPMB

[PATCH v3 1/5] mmc: core: Expose access to RPMB partition

2012-08-06 Thread Loic Pallardy
Following JEDEC standard, if the mmc support RPMB partition, a new interface is created and exposed via /dev/block. Users will be able to access RPMB partition using standard mmc IOCTL command. Signed-off-by: Alex Macro alex.ma...@stericsson.com Signed-off-by: Loic Pallardy loic.palla

[PATCH v3 3/5] mmc: core: Extend sysfs to ext_csd parameters for RPMB support

2012-08-06 Thread Loic Pallardy
Extend current sysfs access to ext_csd rpmb parameters (RPMB partition size) and rel_sector information. Signed-off-by: Loic Pallardy loic.palla...@stericsson.com Acked-by: Linus Walleij linus.wall...@linaro.org Acked-by: Johan Rudholm johan.rudh...@stericsson.com Reviewed-by: Namjae Jeon linkinj

[PATCH v3 5/5] mmc: card: Add RPMB support in IOCTL interface

2012-08-06 Thread Loic Pallardy
RPMB partition is accessing though /dev/block/mmcXrpmb device User callers can read and write entire data frame(s) as defined by JEDEC Standard JESD84-A441, using standard IOCTL interface. Signed-off-by: Alex Macro alex.ma...@stericsson.com Signed-off-by: Loic Pallardy loic.palla

[PATCH v3 2/5] mmc: card: Do not scan RPMB partitions

2012-08-06 Thread Loic Pallardy
Do not scan rpmb partitions for soft partitions, since the rpmb partition contains protected data. Silences the following message during boot: mmcblkXRPMB: unknown partition table Signed-off-by: Johan Rudholm johan.rudh...@stericsson.com Acked-by: Linus Walleij linus.wall...@linaro.org

[PATCH v3 4/5] mmc: core: Add mmc_set_blockcount feature

2012-08-06 Thread Loic Pallardy
Provide support for automatically sending Set Block Count (CMD23) messages. Used at least for RPMB support. Signed-off-by: Alex Macro alex.ma...@stericsson.com Signed-off-by: Loic Pallardy loic.palla...@stericsson.com Acked-by: Linus Walleij linus.wall...@linaro.org Acked-by: Johan Rudholm

Re: [PATCH v2 2/5] mmc: card: Do not scan RPMB partitions

2012-07-24 Thread Loic pallardy
2012/7/16 Namjae Jeon linkinj...@gmail.com: Would you resend all v2 patches after including tag linus's ack and my reviewed-by ? Thanks. Yes, I will resend a new series including acked and reviewed-by tags. BR, Loic -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the

Re: [PATCH v1 2/5] mmc: card: Do not scan RPMB partitions

2012-07-11 Thread Loic pallardy
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index 276d21c..1b202fe 100644 --- a/drivers/mmc/card/block.c +++ b/drivers/mmc/card/block.c @@ -1521,6 +1521,9 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct mmc_card *card, md-disk-queue = md-queue.queue;

[PATCH v2 2/5] mmc: card: Do not scan RPMB partitions

2012-07-11 Thread Loic Pallardy
From: Loic Pallardy loic.palla...@stericsson.com Do not scan rpmb partitions for soft partitions, since the rpmb partition contains protected data. Silences the following message during boot: mmcblkXRPMB: unknown partition table Signed-off-by: Johan Rudholm johan.rudh...@stericsson.com

Re: [PATCH v1 5/5] mmc: card: Add RPMB support in IOCTL interface

2012-07-10 Thread Loic pallardy
Repost in text format 2012/7/10 Namjae Jeon linkinj...@gmail.com + err = mmc_blk_part_switch(card, md); + if (err) + goto cmd_rel_host; + Should it wrapped by if (is_rpbm) condition ? It can be called in other ioctl. It was my first implementation, but in that

[PATCH v1 2/5] mmc: card: Do not scan RPMB partitions

2012-07-06 Thread Loic Pallardy
Do not scan rpmb partitions for soft partitions, since the rpmb partition contains protected data. Silences the following message during boot: mmcblkXRPMB: unknown partition table Signed-off-by: Johan Rudholm johan.rudh...@stericsson.com --- drivers/mmc/card/block.c | 3 +++ 1 file changed, 3

[PATCH v1 1/5] mmc: core: Expose access to RPMB partition

2012-07-06 Thread Loic Pallardy
Following JEDEC standard, if the mmc support RPMB partition, a new interface is created and exposed via /dev/block. Users will be able to access RPMB partition using standard mmc IOCTL command. Signed-off-by: Alex Macro alex.ma...@stericsson.com Signed-off-by: Loic Pallardy loic.palla

[PATCH v1 0/5] mmc: Add access to RPMB partition

2012-07-06 Thread Loic Pallardy
as defined by JEDEC standard. Loic Pallardy (5): mmc: core: Add mmc_set_blockcount feature mmc: core: Expose access to RPMB partition mmc: card: Do not scan RPMB partitions mmc: core: Extend sysfs to ext_csd parameters for RPMB support mmc: card: Add RPMB support in IOCTL interface

[PATCH v1 4/5] mmc: core: Add mmc_set_blockcount feature

2012-07-06 Thread Loic Pallardy
Provide support for automatically sending Set Block Count (CMD23) messages. Used at least for RPMB support. Signed-off-by: Alex Macro alex.ma...@stericsson.com Signed-off-by: Loic Pallardy loic.palla...@stericsson.com --- drivers/mmc/core/core.c | 14 ++ include/linux/mmc/core.h

[PATCH v1 3/5] mmc: core: Extend sysfs to ext_csd parameters for RPMB support

2012-07-06 Thread Loic Pallardy
Extend current sysfs access to ext_csd rpmb parameters (RPMB partition size) and rel_sector information. Signed-off-by: Loic Pallardy loic.palla...@stericsson.com --- Documentation/mmc/mmc-dev-attrs.txt | 7 +++ drivers/mmc/core/mmc.c | 4 2 files changed, 11 insertions

[PATCH v1 5/5] mmc: card: Add RPMB support in IOCTL interface

2012-07-06 Thread Loic Pallardy
RPMB partition is accessing though /dev/block/mmcXrpmb device User callers can read and write entire data frame(s) as defined by JEDEC Standard JESD84-A441, using standard IOCTL interface. Signed-off-by: Alex Macro alex.ma...@stericsson.com Signed-off-by: Loic Pallardy loic.palla