Re: [PATCH v2 06/12] mmc: sdhci-of-at91: use sdhci_pltfm_init for private allocation

Hi Jisheng, Thanks for your patch but it needs to be updated since it breaks this driver. - struct sdhci_at91_priv *priv = pltfm_host->priv; + struct sdhci_at91_priv *priv = sdhci_pltfm_priv(pltfm_host); is missing in sdhci_at91_runtime_suspend and sdhci_at91_runtime_resume

Re: [PATCH v3 06/12] mmc: sdhci-of-at91: use sdhci_pltfm_init for private allocation

; sdhci-of-at91 driver to this allocation. > > Signed-off-by: Jisheng Zhang <jszh...@marvell.com> > Acked-by: Arnd Bergmann <a...@arndb.de> Acked-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Thanks > --- > drivers/mmc/host/sdhci-of-at91.c | 24

questions about runtime pm

Hi guys, I have recently added PM support for my driver but I don't have the behavior I was expecting. I am wondering if I didn't do something wrong. I have implemented runtime_suspend in a very simple way, I call sdhci_runtime_suspend_host() and I disable the clocks. It works pretty well with

Re: [PATCH v2] mmc: sdhci: restore behavior when setting VDD via external regulator

hci_set_power() function. > > > > After this patch, the sdcard on Marvell Berlin SoC boards work again. > > > > Signed-off-by: Jisheng Zhang <jszh...@marvell.com> > > Fixes: 52221610dd84 ("mmc: sdhci: Improve external VDD ...") Reviewed-by: Ludovic De

Re: [PATCH v2] mmc: sdhci: restore behavior when setting VDD via external regulator

On Fri, Dec 11, 2015 at 03:48:04PM +0100, Ulf Hansson wrote: > + Ludovic (We had some discussions around this code recently as well) > Thanks Ulf. > On 11 December 2015 at 14:36, Jisheng Zhang wrote: > > After commit 52221610dd84 ("mmc: sdhci: Improve external VDD

Re: [PATCH] mmc: sdhci-of-at91: controller is suspended too early

On Fri, Nov 27, 2015 at 03:11:58PM +0100, Ulf Hansson wrote: > On 26 November 2015 at 17:41, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > When calling sdhci_add_host(), the controller is already suspended. It > > causes to read 0 in registers. > >

Re: [PATCH v2] mmc: sdhci at91: add PM support

On Tue, Nov 10, 2015 at 12:12:30PM +0100, Ulf Hansson wrote: > On 10 November 2015 at 11:36, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > Add runtime PM support and use runtime_force_suspend|resume() for system > > PM. > > [...] > >

Re: [PATCH v2] mmc: sdhci at91: add PM support

On Thu, Nov 26, 2015 at 05:24:40PM +0100, Ulf Hansson wrote: > On 26 November 2015 at 17:07, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > On Tue, Nov 10, 2015 at 12:12:30PM +0100, Ulf Hansson wrote: > >> On 10 November 2015 at 11:36, Ludovic Des

[PATCH] mmc: sdhci-of-at91: controller is suspended too early

When calling sdhci_add_host(), the controller is already suspended. It causes to read 0 in registers. Increment the device's usage counter before calling sdhci_add_host(), decrement it after and put it in suspend if it is possible. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

Hi Ulf, On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: > On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: [...] > > Now, this discussion was interesting, but I forgot what problem you > > actually where trying to solve? :-) > > There is th

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

On Tue, Nov 24, 2015 at 02:56:21PM +0100, Ulf Hansson wrote: > On 24 November 2015 at 14:12, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > On Tue, Nov 24, 2015 at 12:01:53PM +0100, Ulf Hansson wrote: > >> On 24 November 2015 at 10:23, Ludovic Des

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

On Tue, Nov 24, 2015 at 12:01:53PM +0100, Ulf Hansson wrote: > On 24 November 2015 at 10:23, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > Hi Ulf, > > > > On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: > >> On Mon, Nov 09

[PATCH 1/3] mmc: atmel-mci: move atmel-mci-regs.h content in atmel-mci.c

atmel-mci-regs.h is only included in atmel-mci.c so move its content in the driver and do some cleanup in these definitions to remove checkpatch errors. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mmc/host/atmel-mci-regs.h

[PATCH 3/3] mmc: atmel-mci: atmci_convert_chksize depends on controller version

The atmci_convert_chksize() function is no more valid for controller version 0x600 due to the introduction of '2 data' chunk size. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mmc/host/atmel-mci.c | 43 +++ 1 file chang

[PATCH v4] mmc: sdhci at91: add PM support

Add runtime PM support and use runtime_force_suspend|resume() for system PM. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Changes: - from v3: add error handling of runtime PM - from v2: cleanup thanks to Ulf feedback - from v1: take a runtime PM centric approach d

[PATCH v2] mmc: sdhci at91: add PM support

Add runtime PM support and use runtime_force_suspend|resume() for system PM. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Changes: - from v1: take a runtime PM centric approach drivers/mmc/host/sdhci-of-at91.c | 66 +++- 1 file c

Re: [PATCH v3] mmc: sdhci at91: add PM support

On Tue, Nov 10, 2015 at 03:03:57PM +0100, Ulf Hansson wrote: > On 10 November 2015 at 14:23, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > Add runtime PM support and use runtime_force_suspend|resume() for system > > PM. > > > > Signed-off-b

Re: [PATCH v2] mmc: sdhci at91: add PM support

On Tue, Nov 10, 2015 at 12:12:30PM +0100, Ulf Hansson wrote: > On 10 November 2015 at 11:36, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > Add runtime PM support and use runtime_force_suspend|resume() for system > > PM. > > > > Signed-off-b

[PATCH v3] mmc: sdhci at91: add PM support

Add runtime PM support and use runtime_force_suspend|resume() for system PM. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Changes: - from v2: cleanup thanks to Ulf feedback - from v1: take a runtime PM centric approach drivers/mmc/host/sdhci-of-at91.

[PATCH] mmc: core: set regulator not found message as debug

Turn the informative message about no vmmc/vqmmc regulator found in debug one. There is no need to indicate that something optional is missing. Moreover, it can bring confusion, people who doesn't know it is optional may consider these messages as warnings or errors. Signed-off-by: Ludovic

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: > When there is a vmmc regulator, only SD Bus Power is set to 1 in the > Power Control Register. It means SD Bus Voltage Select field is set to 0 > that is a reserved value. The SD Host Controller specification says:

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: > On 9 November 2015 at 14:23, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: > >> When there is a vmmc regulator, on

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

On Mon, Nov 09, 2015 at 11:50:50AM +0100, Ulf Hansson wrote: > [...] > > >> > >> This doesn't seems like a case where a gpio regulator should be used > >> and I am not sure what problem it would solve. Beside to suppress the > >> log warnings (actually those aren't warnings but informations). >

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: > On 9 November 2015 at 15:40, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: > >> On 9 November 2015 at 14:23, Ludovic Des

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

On Mon, Nov 09, 2015 at 10:38:03AM +0100, Ulf Hansson wrote: > [...] > > >> > Is the regulator-gpio usage the right thing to do for vqmmc? In my case > >> > it is > >> > not really driven by a gpio but by a pio from the sdhci device. In the > >> > binding, > >> > >> What's a "pio"? > >> > >>

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

Hi Ulf, Thanks for your answer. On Fri, Nov 06, 2015 at 05:42:51PM +0100, Ulf Hansson wrote: > On 6 November 2015 at 16:59, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > Hi, > > > > I would like to have some feedback for these two patches. I have

[PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

ase it is not really driven by a gpio but by a pio from the sdhci device. In the binding, declaring the gpio is an option so I thought using this regulator fits my need. P.S. patch 2 is based on another patch not yet in next: http://www.spinics.net/lists/arm-kernel/msg453447.html Thanks Ludovic Ludo

[PATCH 2/2] ARM: at91/dt: sama5d2 Xplained: add regulators for sdhci devices

Add vmmc and vqmmc regulators for sdhci devices. The voltage for sdmmc0 vqmmc is selected by a signal from coming from the sdhci device. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 14 ++ 1 file chang

[PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

llows the specification then we need to set a valid value. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mmc/host/sdhci.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index ac97b46..0cfd7b2 100644 --

Re: [PATCH] mmc: sdhci at91: add suspend/resume

On Fri, Oct 16, 2015 at 06:33:44PM +0200, Ulf Hansson wrote: > On 16 October 2015 at 17:01, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > Add suspend and resume PM ops. > > > > Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> &g

[PATCH] mmc: sdhci at91: add suspend/resume

Add suspend and resume PM ops. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mmc/host/sdhci-of-at91.c | 55 +++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mm

Re: [PATCH 1/2] mmc: sdhci: add quirk SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST

On Thu, Oct 08, 2015 at 08:01:23PM +0200, Ulf Hansson wrote: > +Russell > > On 17 September 2015 at 10:16, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > The Atmel sdhci device needs a new quirk. sdhci_set_clock set the Clock > > Control Register to 0

[PATCH 1/2] mmc: sdhci: add quirk SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST

of the internal clock, so a delay is needed. This delay is about 2-3 cycles of the base clock. To be safe, a 1 ms delay is used. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Hi Ulf, Can you take these patches as fixes? I thought it was better to introduce a quirk i

Re: [patch] mmc: sdhci-of-at91: remove a line of dead code

On Wed, Sep 16, 2015 at 09:19:49AM +0300, Dan Carpenter wrote: > The goto is correct and the unreachable "return -EINVAL" should be > removed. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Of course Acked-by: Ludovic Desroches <ludovic.desroc...@atme

[PATCH 2/2] mmc: sdhci-of-at91: use SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST quirk

The Atmel sdhci device needs the SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST quirk. Without it, the internal clock could never stabilised when changing the sd clock frequency. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mmc/host/sdhci-of-at91.c | 1 + 1 file c

Re: [PATCH] mmc: atmel-mci: remove useless include

On Mon, Aug 10, 2015 at 04:26:48PM +0200, Alexandre Belloni wrote: Definitions from linux/platform_data/atmel.h are not used, remove the include. Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc

[PATCH] [wip] repair mci dma transfers for avr32

Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- Hi, Here is a rough draft to fix the regression. I have only compiled it. I will update all the boards later. I have removed the mci_dma_data since it is no more used for ARM platforms. arch/avr32/boards/atngw100/setup.c

Re: [PATCH v1 1/1] mmc: atmel-mci: allow DMA transfers for AVR32

2015 14:53:30 you wrote: The commit ecb89f2f5f3e (mmc: atmel-mci: remove compat for non DT board when requesting dma chan) removes compat transfer which breaks DMA support for ATNGW100. This patch returns back that functionality. Cc: Ludovic Desroches ludovic.desroc...@atmel.com

[PATCH v2 3/3] MAINTAINERS: add entry for Atmel sdhci-of-at91 driver

Add an entry for Atmel SDMMC device. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e7bdbac..6480ce9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1880,6 +1880,12 @@ L

[PATCH v2 0/3] introduce driver for the Atmel SDMMC

. It only fixes a special use case. If there are objections about it, drop it, I don't want to delay the Atmel SDMMC driver inclusion only for this patch. Changes: - from v1: - update license Ludovic Desroches (3): mmc: sdhci: switch from programmable clock mode to divided one if needed mmc

[PATCH v2 2/3] mmc: sdhci-of-at91: introduce driver for the Atmel SDMMC

Introduce driver for he Atmel SDMMC available on sama5d2. It is a sdhci compliant controller. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- .../devicetree/bindings/mmc/sdhci-atmel.txt| 21 +++ drivers/mmc/host/Kconfig | 8 + drivers/mmc

[PATCH v2 1/3] mmc: sdhci: switch from programmable clock mode to divided one if needed

In programmable mode, if the clock frequency is too high, the divider can be too small to meet the clock frequency requirement especially to init the SD card. In this case, switch to the divided clock mode. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/sdhci.c

Re: [PATCH 2/3] mmc: sdhci-of-at91: introduce driver for the Atmel SDMMC

On Sat, Jul 04, 2015 at 10:06:49PM +0200, Arnd Bergmann wrote: On Friday 03 July 2015 16:17:16 Ludovic Desroches wrote: Introduce driver for he Atmel SDMMC available on sama5d2. It is a sdhci compliant controller. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com

Re: [PATCH 2/3] mmc: sdhci-of-at91: introduce driver for the Atmel SDMMC

On Sat, Jul 04, 2015 at 10:30:28AM +0200, Paul Bolle wrote: A nit only: a license mismatch. Thanks Paul, I'll correct it. On vr, 2015-07-03 at 16:17 +0200, Ludovic Desroches wrote: --- /dev/null +++ b/drivers/mmc/host/sdhci-of-at91.c + * This program is free software; you can

[PATCH 3/3] MAINTAINERS: add entry for Atmel sdhci-of-at91 driver

Add an entry for Atmel SDMMC device. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e7bdbac..6480ce9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1880,6 +1880,12 @@ L

[PATCH 2/3] mmc: sdhci-of-at91: introduce driver for the Atmel SDMMC

Introduce driver for he Atmel SDMMC available on sama5d2. It is a sdhci compliant controller. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- .../devicetree/bindings/mmc/sdhci-atmel.txt| 21 +++ drivers/mmc/host/Kconfig | 8 + drivers/mmc

[PATCH 1/3] mmc: sdhci: switch from programmable clock mode to divided one if needed

In programmable mode, if the clock frequency is too high, the divider can be too small to meet the clock frequency requirement especially to init the SD card. In this case, switch to the divided clock mode. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/sdhci.c

[PATCH] mmc: atmel-mci: fix bad variable type for clkdiv

clkdiv is declared as an u32 but it can be set to a negative value causing a huge divisor value. Change its type to int to avoid this case. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com Cc: sta...@vger.kernel.org # 3.4 and later --- drivers/mmc/host/atmel-mci.c | 9 +++-- 1

Re: [PATCH 12/13] mmc: atmel-mci: use endian agnostic IO

On Wed, Mar 18, 2015 at 03:53:11PM +, Ben Dooks wrote: Change the __raw IO functions to endian agnostic relaxed ones to allow the driver to function on big endian ARM systems. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com

Re: [PATCH] mmc: atmel-mci: use SET_RUNTIME_PM_OPS() macro

Hi Rafael, Do you agree to take it in your tree? Regards Ludovic On Wed, Dec 03, 2014 at 03:23:12PM +0100, Ulf Hansson wrote: +Rafael On 3 December 2014 at 14:43, Ludovic Desroches ludovic.desroc...@atmel.com wrote: Use SET_RUNTIME_PM_OPS() since SET_PM_RUNTIME_PM_OPS() has been dropped

Re: [PATCH v4 0/4] mmc: atmel-mci: cleanup and probe deferring

On Tue, Dec 02, 2014 at 11:10:53AM +0100, Ulf Hansson wrote: On 1 December 2014 at 15:35, Ludovic Desroches ludovic.desroc...@atmel.com wrote: Hi Ulf, Same as previous series, based on your next branch, and no errors with checkpatch so let me know if you still have troubles to apply my

[PATCH] mmc: atmel-mci: use SET_RUNTIME_PM_OPS() macro

Use SET_RUNTIME_PM_OPS() since SET_PM_RUNTIME_PM_OPS() has been dropped. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- Hi Ulf, Can you take this patch which fixes a compilation error that has appeared only on next-20141203. Thanks Regards drivers/mmc/host/atmel-mci.c | 2

[PATCH v4 0/4] mmc: atmel-mci: cleanup and probe deferring

Hi Ulf, Same as previous series, based on your next branch, and no errors with checkpatch so let me know if you still have troubles to apply my patches. Changes from v3: - keep __init/__exit attributes for atmci_init/exit - remove useless variable in atmci_configure_dma function Ludovic

[PATCH v4 1/4] mmc: atmel-mci: remove useless DMA stuff for non-dt devices

All devices with a DMA controller are DT compliant and legacy support has been removed. For those reasons, some DMA stuff is useless. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers

[PATCH v4 3/4] mmc: atmel-mci: stop using specific initcall

No more use late initcall to manage probing order. Use probe deferring if needed. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b

[PATCH v4 2/4] mmc: atmel-mci: remove __init/__exit attributes

Using __init/__exit attributes can cause several breakages so remove them. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host

[PATCH v4 4/4] mmc: atmel-mci: use probe deferring if dma controller is not ready yet

Return probe defer if requesting a dma channel without a dma controller probed. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 47 ++-- 1 file changed, 23 insertions(+), 24 deletions(-) diff --git a/drivers

Re: [PATCH] mmc: atmel-mci: use probe deferring if dma controller is not ready yet

On Fri, Nov 28, 2014 at 12:09:47PM +0100, Ulf Hansson wrote: On 25 November 2014 at 15:25, Ludovic Desroches ludovic.desroc...@atmel.com wrote: Return probe defer if requesting a dma channel without a dma controller probed. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com

[PATCH v3 1/4] mmc: atmel-mci: remove useless DMA stuff for non-dt devices

All devices with a DMA controller are DT compliant and legacy support has been removed. For those reasons, some DMA stuff is useless. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers

[PATCH v3 0/4] mmc: atmel-mci: cleanup and probe deferring

Hi Ulf, I have rebased my series on your next branch but I didn't have any conflict and a warning on the whole series with checkpatch so please tell me if something goes wrong. Regards Ludovic Ludovic Desroches (4): mmc: atmel-mci: remove useless DMA stuff for non-dt devices mmc: atmel-mci

[PATCH v3 2/4] mmc: atmel-mci: remove __init/__exit attributes

Using __init/__exit attributes can cause several breakages so remove them. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc

[PATCH v3 3/4] mmc: atmel-mci: stop using specific initcall

No more use late initcall to manage probing order. Use probe deferring if needed. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b

[PATCH v3 4/4] mmc: atmel-mci: use probe deferring if dma controller is not ready yet

Return probe defer if requesting a dma channel without a dma controller probed. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 49 ++-- 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/drivers

Re: [PATCH v3 4/4] mmc: atmel-mci: use probe deferring if dma controller is not ready yet

On Fri, Nov 28, 2014 at 02:19:03PM +, Russell King - ARM Linux wrote: Let's look at the resulting code: On Fri, Nov 28, 2014 at 03:08:06PM +0100, Ludovic Desroches wrote: +static int atmci_configure_dma(struct atmel_mci *host) { + int ret = 0; + host-dma.chan

Re: [RFC PATCH] mmc: sdhci: switch from programmable clock mode to divided one if needed

On Tue, Nov 04, 2014 at 09:06:07AM +0100, Ulf Hansson wrote: On 7 October 2014 10:11, Ludovic Desroches ludovic.desroc...@atmel.com wrote: In programmable mode, if the clock frequency is too high, the divider can be too small to meet the clock frequency requirement especially to init

[PATCH] mmc: atmel-mci: use probe deferring if dma controller is not ready yet

Return probe defer if requesting a dma channel without a dma controller probed. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- Hi Ulf, I didn't send the whole set of patches for this small change, tell me if you want a new series. drivers/mmc/host/atmel-mci.c | 49

[PATCH v2 0/4] mmc: atmel-mci: cleanup and probe deferring

Hi, Some cleanup to introduce probe deferring if dma controller is not probed. The purpose of this second version is to have the __init/__exit attributes removal in a patch that can be backported into stable kernels. Ludovic Desroches (4): mmc: atmel-mci: remove useless DMA stuff for non-dt

[PATCH v2 2/4] mmc: atmel-mci: remove __init/__exit attributes

Using __init/__exit attributes can cause several breakages so remove them. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com Cc: sta...@vger.kernel.org # 3.2.x --- drivers/mmc/host/atmel-mci.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH v2 3/4] mmc: atmel-mci: stop using specific initcall

No more use late initcall to manage probing order. Use probe deferring if needed. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b

[PATCH v2 4/4] mmc: atmel-mci: use probe deferring if dma controller is not ready yet

Return probe defer if requesting a dma channel without a dma controller probed. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 46 1 file changed, 25 insertions(+), 21 deletions(-) diff --git a/drivers

[PATCH 1/3] mmc: atmel-mci: remove useless DMA stuff for non-dt devices

All devices with a DMA controller are DT compliant and legacy support has been removed. For those reasons, some DMA stuff is useless. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers

[PATCH 3/3] mmc: atmel-mci: use probe deferring if dma controller is not ready yet

Return probe defer if requesting a dma channel without a dma controller probed. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 46 1 file changed, 25 insertions(+), 21 deletions(-) diff --git a/drivers

[PATCH 2/3] mmc: atmel-mci: stop using specific initcall

No more use late initcall to manage probing order. Use probe deferring if needed. Then use module_platform_driver and clean init/exit attributes. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 23 ++- 1 file changed, 6

Re: [PATCH 2/3] mmc: atmel-mci: stop using specific initcall

On Thu, Nov 20, 2014 at 12:10:25PM +0100, Arnd Bergmann wrote: On Thursday 20 November 2014 11:07:54 Ludovic Desroches wrote: No more use late initcall to manage probing order. Use probe deferring if needed. Then use module_platform_driver and clean init/exit attributes. Signed-off

Re: [PATCH 2/3] mmc: atmel-mci: stop using specific initcall

On Thu, Nov 20, 2014 at 03:13:30PM +0100, Arnd Bergmann wrote: On Thursday 20 November 2014 15:01:25 Ludovic Desroches wrote: On Thu, Nov 20, 2014 at 12:10:25PM +0100, Arnd Bergmann wrote: On Thursday 20 November 2014 11:07:54 Ludovic Desroches wrote: No more use late initcall to manage

[PATCH v2] mmc: atmel-mci: use probe deferring if dma controller is not ready yet

Return probe defer if requesting a dma channel without a dma controller probed. Using late_initcall is no more needing. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- patch based on mmc: atmel-mci: remove compat for non DT board when requesting dma chan v2 changes: - use

Re: [PATCH v2] mmc: atmel-mci: use probe deferring if dma controller is not ready yet

On Wed, Nov 19, 2014 at 03:57:56PM +0100, Arnd Bergmann wrote: On Wednesday 19 November 2014 15:51:07 Ludovic Desroches wrote: @@ -2265,37 +2265,39 @@ static void atmci_cleanup_slot(struct atmel_mci_slot *slot, mmc_free_host(slot-mmc); } -static bool atmci_configure_dma

[PATCH 1/2] mmc: atmel-mci: remove compat for non DT board when requesting dma chan

All boards with a dma controller have DT support so using dma_request_slave_channel_compat is no more needed. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git

[PATCH 2/2] mmc: atmel-mci: introduce probe deferring

Return probe defer if requesting a dma channel without a dma controller probed. Using late_initcall is no more needing. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 52 +--- 1 file changed, 30 insertions

[RESEND PATCH 1/2] mmc: atmel-mci: remove compat for non DT board when requesting dma chan

All boards with a dma controller have DT support so using dma_request_slave_channel_compat is no more needed. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- Sorry for the noise, typo in cc list. drivers/mmc/host/atmel-mci.c | 20 +--- 1 file changed, 1

[RESEND PATCH 2/2] mmc: atmel-mci: introduce probe deferring

Return probe defer if requesting a dma channel without a dma controller probed. Using late_initcall is no more needing. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- Sorry for the noise, typo in cc list. drivers/mmc/host/atmel-mci.c | 52

Re: [RESEND PATCH 2/2] mmc: atmel-mci: introduce probe deferring

On Fri, Nov 14, 2014 at 03:55:13PM +0100, Nicolas Ferre wrote: On 14/11/2014 15:36, Ludovic Desroches : Return probe defer if requesting a dma channel without a dma controller probed. Using late_initcall is no more needing. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com

Re: [PATCH v2] mmc: atmel-mci: add runtime pm support

. Signed-off-by: Wenyou Yang wenyou.y...@atmel.com Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com Ludovic, any objections to this one? I am not a PM runtime guru, since you have reviewed the first version, it is ok for me :) Regards Ludovic Kind regards Uffe --- Changes

Re: [PATCH] mmc: host: atmel-mci: Add support for non-removable slots

On Mon, Nov 03, 2014 at 01:12:59PM +0200, Timo Kokkonen wrote: Add support for non-removable slots which have no card detection GPIO and which should not be polled for a card change. Signed-off-by: Timo Kokkonen timo.kokko...@offcode.fi Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com

Re: [PATCHv2 0/3] Remove mach/atmel-mci.h

: Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com Alexandre Belloni (3): mmc: atmel-mci: move mache header to platform_data ARM: at91: remove mach/atmel-mci.h avr32: remove mach/atmel-mci.h arch/arm/mach-at91/at91sam9g45_devices.c| 2 +- arch/arm/mach-at91/include/mach

[RFC PATCH] mmc: sdhci: switch from programmable clock mode to divided one if needed

In programmable mode, if the clock frequency is too high, the divider can be too small to meet the clock frequency requirement especially to init the SD card. In this case, switch to the divided clock mode. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- Hi all, I would like

Re: [PATCH] mmc: atmel-mci: fix mismatched section on atmci_cleanup_slot

in the link stage for the built-in case, which would cause undefined behavior when this error path is hit. The solution is to simply drop the __exit annotation. Signed-off-by: Arnd Bergmann a...@arndb.de Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com Thanks, I also missed

Re: [PATCH v2 1/2] mmc: atmel-mci: Switch to using managed resource in probe

lables and remove function. /s/lables/labels Otherwise Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com Thanks Cc: Ludovic Desroches ludovic.desroc...@atmel.com Cc: Chris Ball ch...@printf.net Cc: Ulf Hansson ulf.hans...@linaro.org Cc: linux-mmc@vger.kernel.org Signed-off

Re: [PATCH v2 2/2] mmc: atmel-mci: Release mmc resources on failure in probe

On Tue, Sep 23, 2014 at 03:50:06PM +0530, Pramod Gurav wrote: This change takes care of releasing mmc resources on error cases in probe function which was missing. Also release timer in remove function. Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com Cc: Ludovic Desroches

Re: [PATCH 1/2] mmc: atmel-mci: Switch to using managed resource in probe

and remove function. Cc: Ludovic Desroches ludovic.desroc...@atmel.com Cc: Chris Ball ch...@printf.net Cc: Ulf Hansson ulf.hans...@linaro.org Cc: linux-mmc@vger.kernel.org Signed-off-by: Pramod Gurav pramod.gu...@smartplayin.com --- drivers/mmc/host/atmel-mci.c | 57

Re: [PATCH] mmc: include linux/types.h for bool definition in atmel-mci.h

On Thu, Aug 07, 2014 at 03:14:06PM +0200, Hans-Christian Egtvedt wrote: This patch adds an include of linux/types.h to make sure bool is defined before utilized in this header file. Signed-off-by: Hans-Christian Egtvedt egtv...@samfundet.no Acked-by: Ludovic Desroches ludovic.desroc

[PATCH] mmc: atmel-mci: add 0x600 IP version

From: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel

Re: [PATCH 1/4] mmc: atmel-mci: incude asm/cacheclush.h

' [-Werror=implicit-function-declaration] flush_dcache_page(sg_page(sg)); ^ Signed-off-by: Arnd Bergmann a...@arndb.de Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com Thanks Cc: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 1 + 1 file

Re: [PATCH RFC] mmc: add slot argument to mmc_of_parse

. If this patch didn't work on progress, i will send the patch based-on this patch. Best Regards, Jaehoon Chung On 05/14/2014 06:53 PM, Ulf Hansson wrote: On 7 May 2014 12:06, Ludovic Desroches ludovic.desroc...@atmel.com wrote: Some hosts manage several slots. In these case information

Re: [PATCH RFC] mmc: add slot argument to mmc_of_parse

On Mon, May 26, 2014 at 09:03:01AM +0200, Ludovic Desroches wrote: Hi, Sorry I was on vacation, I'll send a cleaner patch updating other drivers this week. Continuing to clear out my inbox, I have seen you send a patch for it. Thanks. Regards Ludovic On Fri, May 23, 2014 at 01:38

Re: [PATCH 1/3] mmc: host: add slot argument to mmc_of_parse

On Fri, May 23, 2014 at 07:25:19PM +0900, Jaehoon Chung wrote: From: Ludovic Desroches ludovic.desroc...@atmel.com Some hosts manage several slots. In these case information such as the bus width, chi detect and others are into the slot node. So we have to /s/chi detect/chip detect parse

[PATCH RFC] mmc: add slot argument to mmc_of_parse

Some hosts manage several slots. In these case information such as the bus width, chip detect and others are into the slot node. So we have to parse child nodes. If not NULL, slot node will be used instead of the device node. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- Hi

Re: [PATCH] mmc: atmel: don't test host-data

-by: Alexandre Belloni alexandre.bell...@free-electrons.com Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/mmc/host/atmel-mci.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c

Re: possible regression on 3.13 when calling flush_dcache_page

On Mon, Jan 06, 2014 at 09:26:48AM +0900, Joonsoo Kim wrote: On Fri, Jan 03, 2014 at 03:54:04PM +0100, Ludovic Desroches wrote: Hi, On Tue, Dec 24, 2013 at 03:38:37PM +0900, Joonsoo Kim wrote: [...] I think that this commit may not introduce a bug. This patch

Re: possible regression on 3.13 when calling flush_dcache_page

, the commit given by git bisect was not the good one... Since I removed other patches done on top of it, I thought it really was this one but in fact it is 8456a64. dd0f774 Fri Jan 3 12:33:55 2014 +0100 Revert slab: remove useless statement for checking pfmemalloc Ludovic Desroches ff7487d Fri Jan

  1   2   >