On Thursday, November 19, 2015 at 12:52:06 PM, Ulf Hansson wrote:
> On 18 November 2015 at 10:47, Marek Vasut <ma...@denx.de> wrote:
> > This is a trivial patch which fixes printed strings split across two
> > or more lines in the source. I tried to grep for some error output
On Thursday, November 19, 2015 at 01:05:15 PM, Ulf Hansson wrote:
> On 19 November 2015 at 12:58, Marek Vasut <ma...@denx.de> wrote:
> > On Thursday, November 19, 2015 at 12:52:06 PM, Ulf Hansson wrote:
> >> On 18 November 2015 at 10:47, Marek Vasut <ma...@denx.de> w
dware interrupt."
Signed-off-by: Marek Vasut <ma...@denx.de>
Cc: Ulf Hansson <ulf.hans...@linaro.org>
---
drivers/mmc/host/sdhci.c | 57 +++-
1 file changed, 23 insertions(+), 34 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/
from this?
Marek Vasut has the hardware. His board apprently has uSD and eMMC,
and I believe it has just one controller. I'll try to get details.
So please go ahead with this PR, sorry for blocking it.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux
applies to all other socfpga patches across all MLs).
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
...@the-dreams.de
Something like that is already in -next:
mmc: mxs-mmc: Let device core handle pinctrl
Otherwise
Tested-by: Marek Vasut ma...@denx.de
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More
Dear Wei Yongjun,
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Fix to return -ENODEV in the request dma error case instead
of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
Seems ok to me.
Reviewed-by: Marek Vasut ma...@denx.de
Best
Dear Hector Palacios,
Dear Marek Vasut,
On 04/08/2013 06:28 PM, Marek Vasut wrote:
Dear Shawn Guo,
On Mon, Apr 08, 2013 at 03:58:05PM +0200, Hector Palacios wrote:
On 04/08/2013 02:48 PM, Shawn Guo wrote:
On Mon, Apr 08, 2013 at 12:12:20PM +0200, Hector Palacios wrote:
MicroSD
Hi Hector,
Dear Marek Vasut,
On 04/09/2013 10:15 AM, Marek Vasut wrote:
Dear Hector Palacios,
Dear Marek Vasut,
On 04/08/2013 06:28 PM, Marek Vasut wrote:
Dear Shawn Guo,
On Mon, Apr 08, 2013 at 03:58:05PM +0200, Hector Palacios wrote:
On 04/08/2013 02:48 PM, Shawn Guo
. - non-removable: non-removable slot (like eMMC); assume always
present.
But mxs-mmc set MMC_CAP_NEEDS_POLL unconditionally.
I will work on a better way to fix this.
NEEDS_POLL looks nice and seems to fit this case.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send
Dear Alexandre Pereira da Silva,
Some boards and card slots doesn't have card detect feature available.
In that case allow to mark the cards as non-removable, via devicetree.
Signed-off-by: Alexandre Pereira da Silva aletes@gmail.com
Looks good,
Reviewed-by: Marek Vasut ma...@denx.de
Dear Mark Brown,
On Fri, Apr 05, 2013 at 08:37:39AM +0200, Marek Vasut wrote:
btw. did you know you can let git send-email automatically handle CC for
you so you don't have to type it into the command line by simply
sticking
Cc: Us Er e...@ma.il
in the commit message? Preferably
Dear Fabio Estevam,
From: Fabio Estevam fabio.este...@freescale.com
Add an entry for MODULE_ALIAS().
Signed-off-by: Fabio Estevam fabio.este...@freescale.com
Acked-by: Marek Vasut ma...@denx.de
---
drivers/mmc/host/mxs-mmc.c |1 +
1 file changed, 1 insertion(+)
diff --git
[-Wsign-compare]
The warning happens because 'i' is used in 'for_each_sg(sgl, sg, sg_len,
i)' and should be made unsigned.
Signed-off-by: Fabio Estevam fabio.este...@freescale.com
Nice
Acked-by: Marek Vasut ma...@denx.de
---
drivers/mmc/host/mxs-mmc.c |2 +-
1 file changed, 1
: 'warning: ISO C90 forbids mixed declarations and code'.
Signed-off-by: Fabio Estevam fabio.este...@freescale.com
[...]
You might want to do the same for MXS SPI driver.
Acked-by: Marek Vasut ma...@denx.de
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-mmc
when doing too long chains -- so you
might need to fix that part of the mxs DMA driver.
thanks
Huang Shijie
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Dear Huang Shijie,
于 2012年10月18日 15:14, Marek Vasut 写道:
Dear Huang Shijie,
Why such massive CC ?
于 2012年10月18日 14:18, Vinod Koul 写道:
Why cant you do start (prepare clock etc) when you submit the
descriptor to dmaengine. Can be done in tx_submit callback.
Similarly remove
Dear Huang Shijie,
于 2012年10月18日 16:49, Marek Vasut 写道:
Dear Huang Shijie,
于 2012年10月18日 16:16, Marek Vasut 写道:
So we can't stream data from the chip? About time to adjust the MTD
framework to allow that. Maybe implement a command queue?
IMHO, it's not possible. Because the READ
when
combined.
[...]
I'll send Marek's change to Linus once the main MMC merge has been pulled.
Thanks,
- Chris.
Thanks! Sorry from my previous reply from Android phone, I just saw what
horrible email it generated :-(
Best regards,
Marek Vasut
--
To unsubscribe from this list: send
Dear Shawn Guo,
Copy Chris who should be able to help send this fix for 3.7-rc.
Shawn
Ok, thanks.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
named 'devid'
make[3]: *** [drivers/mmc/host/mxs-mmc.o] Error 1
This patches corrects the issue.
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Fabio Estevam fabio.este...@freescale.com
Cc: Shawn Guo shawn@linaro.org
---
drivers/mmc/host/mxs-mmc.c |2 +-
1 file changed, 1 insertion(+), 1
Dear Peter Senna Tschudin,
From: Peter Senna Tschudin peter.se...@gmail.com
The patch description is a bit crap, but otherwise
Acked-by: Marek Vasut ma...@denx.de
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version
Hi,
The write-protect GPIO is inverted on some boards. Handle such case.
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Shawn Guo shawn@linaro.org
Cc: Fabio Estevam fabio.este...@freescale.com
Cc: linux-mmc@vger.kernel.org
Cc: Chris Ball c...@laptop.org
Cc: Lothar Waßmann l...@karo
Dear Chris Ball,
Hi Marek,
On Fri, Jun 08 2012, Marek Vasut wrote:
The write-protect GPIO is inverted on some boards. Handle such case.
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Shawn Guo shawn@linaro.org
Cc: Fabio Estevam fabio.este...@freescale.com
Cc: linux-mmc
regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The write-protect GPIO is inverted on some boards. Handle such case.
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Shawn Guo shawn@linaro.org
Cc: Fabio Estevam fabio.este...@freescale.com
Cc: linux-mmc@vger.kernel.org
Cc: Chris Ball c...@laptop.org
Cc: Lothar Waßmann l...@karo-electronics.de
Dear Chris Ball,
Hi,
On Mon, May 21 2012, Marek Vasut wrote:
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Shawn Guo shawn@linaro.org
Cc: Fabio Estevam fabio.este...@freescale.com
Cc: linux-mmc@vger.kernel.org
Cc: Chris Ball c...@laptop.org
Acked-by: Shawn Guo shawn
The write-protect GPIO is inverted on some boards. Handle such case.
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Shawn Guo shawn@linaro.org
Cc: Fabio Estevam fabio.este...@freescale.com
Cc: linux-mmc@vger.kernel.org
Cc: Chris Ball c...@laptop.org
Cc: Lothar Waßmann l...@karo-electronics.de
Dear Shawn Guo,
Copy Chris and linux-mmc, as I assume that the patch should go via mmc
tree after the merge window.
On Mon, May 21, 2012 at 03:02:20AM +0200, Marek Vasut wrote:
The write-protect GPIO is inverted on some boards. Handle such case.
Signed-off-by: Marek Vasut ma
The write-protect GPIO is inverted on some boards. Handle such case.
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Shawn Guo shawn@linaro.org
Cc: Fabio Estevam fabio.este...@freescale.com
Cc: linux-mmc@vger.kernel.org
Cc: Chris Ball c...@laptop.org
---
Documentation/devicetree/bindings/mmc
Dear Chris Ball,
Hi,
On Sun, May 20 2012, Shawn Guo wrote:
On 21 May 2012 10:38, Marek Vasut ma...@denx.de wrote:
The subject prefix can better be mmc: mxs-mmc: .
Want me to resend it ?
It's Chris' call.
Yes, please -- actually not just because of the subject prefix, which I
Dear Chris Ball,
Hi Marek,
On Sun, May 20 2012, Marek Vasut wrote:
The write-protect GPIO is inverted on some boards. Handle such case.
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Shawn Guo shawn@linaro.org
Cc: Fabio Estevam fabio.este...@freescale.com
Cc: linux-mmc
Signed-off-by: Marek Vasut ma...@denx.de
Cc: Shawn Guo shawn@linaro.org
Cc: Fabio Estevam fabio.este...@freescale.com
Cc: linux-mmc@vger.kernel.org
Cc: Chris Ball c...@laptop.org
Acked-by: Shawn Guo shawn@linaro.org
---
drivers/mmc/host/mxs-mmc.c |2 +-
1 file changed, 1 insertion
Dear Shawn Guo,
Use global stmp_device functionality to reduce mach-dependency.
Signed-off-by: Shawn Guo shawn@linaro.org
Acked-by: Marek Vasut ma...@denx.de
---
drivers/mmc/host/mxs-mmc.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git
Dear Shawn Guo,
The register HW_SSP_VERSION is broken for ssp version detection,
as the address of the register is different between imx23 and imx28.
Let's use platform_device_id to detect the device, so that the use
of cpu_is_xxx can be removed.
Signed-off-by: Shawn Guo
Dear Shawn Guo,
Rename arch/arm/mach-mxs/include/mach/mmc.h to
include/linux/mmc/mxs-mmc.h, so that mxs-mmc driver becomes
mach/* inclusion free.
Good :-)
Acked-by: Marek Vasut ma...@denx.de
Signed-off-by: Shawn Guo shawn@linaro.org
---
arch/arm/mach-mxs/include/mach/devices
Dear Shawn Guo,
Use devm_request_and_ioremap and devm_request_irq helpers to clean up
the code a little bit.
Nice :)
btw do we have i2c dt bindings ?
Acked-by: Marek Vasut ma...@denx.de
Signed-off-by: Shawn Guo shawn@linaro.org
---
drivers/mmc/host/mxs-mmc.c | 40
Dear Shawn Guo,
It replaces dma_res with dma_channel in struct mxs_mmc_host, so that
the device tree support will be a little easier, since dma channel
can not be retrieved from struct resource *dma_res.
Signed-off-by: Shawn Guo shawn@linaro.org
Acked-by: Marek Vasut ma...@denx.de
Dear Shawn Guo,
Let macro ssp_is_old take host as parameter to make the code easy
to read.
Signed-off-by: Shawn Guo shawn@linaro.org
---
drivers/mmc/host/mxs-mmc.c | 59
++- 1 files changed, 30
insertions(+), 29 deletions(-)
diff --git
| MMC_CAP_8_BIT_DATA;
if (pdata-flags SLOTF_4_BIT_CAPABLE)
mmc-caps |= MMC_CAP_4_BIT_DATA;
+ host-wp_gpio = pdata-wp_gpio;
}
mmc-f_min = 40;
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-mmc
)
@@ -857,6 +894,7 @@ static struct platform_driver mxs_mmc_driver = {
.owner = THIS_MODULE,
#ifdef CONFIG_PM
.pm = mxs_mmc_pm_ops,
+ .of_match_table = mxs_mmc_dt_ids,
#endif
},
};
Best regards,
Marek Vasut
--
To unsubscribe from
is to convert mach-mxs over to device tree,
I would also suggest we have all the hardware blocks defined in dts
from the beginning.
Agreed.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo
-mmc: add dt probe support
ARM: imx28evk: add mmc dt support
dma: mxs-dma: add dt probe support
ARM: mxs: add mxs dma dt support
Can you keep me in Cc on new versions of these patches? Thanks!
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-mmc
Dear Dong Aisheng,
From: Dong Aisheng dong.aish...@linaro.org
Signed-off-by: Dong Aisheng dong.aish...@linaro.org
---
The patch is still using a private way for dma part binding
since the common dma binding is still under discussion.
http://www.spinics.net/lists/linux-omap/msg65528.html
domain support for the interrupt controller and use
of_irq_init.
Ok, i will see it.
For others, will fix them all.
Thanks for the review.
Regards
Dong Aisheng
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message
Dear Dong Aisheng,
On Wed, Mar 14, 2012 at 01:58:25PM +0800, Marek Vasut wrote:
Dear Dong Aisheng,
Signed-off-by: Dong Aisheng dong.aish...@linaro.org
+static const struct of_device_id mxs_mmc_dt_ids[] = {
+ { .compatible = fsl,imx23-mmc, .data = NULL
Dear Dong Aisheng,
On Wed, Mar 14, 2012 at 08:09:22AM +0100, Marek Vasut wrote:
Dear Dong Aisheng,
On Wed, Mar 14, 2012 at 01:58:25PM +0800, Marek Vasut wrote:
Dear Dong Aisheng,
Signed-off-by: Dong Aisheng dong.aish...@linaro.org
+static const
Dne Pá 22. října 2010 16:09:03 zhangfei gao napsal(a):
On Fri, Oct 22, 2010 at 7:04 AM, Chris Ball c...@laptop.org wrote:
Hi,
On Fri, Oct 22, 2010 at 10:58:14AM +0100, Chris Ball wrote:
[...]
+#ifdef CONFIG_PM
+static int sdhci_pxa_suspend(struct platform_device *dev)
+{
+
Dne Čt 21. října 2010 16:52:49 Chris Ball napsal(a):
Hi,
On Thu, Oct 21, 2010 at 03:13:02PM +0100, Chris Ball wrote:
On Mon, Oct 18, 2010 at 08:32:46AM -0400, zhangfei gao wrote:
Update with comments from Matt and Eric.
Test with sd and emmc.
From
49 matches
Mail list logo
