Hi Philip,
Minor nitpicks: You should reuse SDHCI_QUIRK_MISSING_CAPS rather than
adding SDHCI_QUIRK2_MISSING_CAPS2. The less quirks the better IMHO.
Also add an initializer for caps array rather than having an else statement:
Instead of this:
+ } else
+ caps[1] = 0;
Do
Philip,
I don't think you should add yet another quirk for this. You should
plumb in a method to mask the capability registers to enable or
disable features you don't want. This would probably fix problems for
a lot of controller and board configurations.
-- Mark
On Fri, Jun 1, 2012 at 11:26
Philip,
1. The code should revert to ADMA in the case when the offset has
proper alignment and/or transfer size meets requirements.
2. The code here has four levels of nesting try to simplify that.
@@ -697,34 +702,62 @@ static void sdhci_prepare_data(struct sdhci_host
*host, struct mmc_command
On Wed, Nov 17, 2010 at 9:56 PM, Philip Rakity prak...@marvell.com wrote:
From 9de09a0575163c223f0aed0842daec9161b2f72e Mon Sep 17 00:00:00 2001
From: Philip Rakity prak...@marvell.com
Date: Wed, 17 Nov 2010 18:52:16 -0800
Subject: [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time.
On Wed, Aug 25, 2010 at 9:01 PM, Primus Mutasingwa
pmutasin...@yahoo.com wrote:
Hello,
I am looking for an example that shows how to use the driver in:
driver/mmc/card/mmc_test.c.
Anyone with sample user space code or instructions on how to use please
forward
to me.
kernel version used
