Re: [PATCH 4/4] sdhci-s3c: add regulator support

2010-07-28 Thread Maurus Cuelenaere
Op 28-07-10 17:41, Mark Brown schreef: > On 28 Jul 2010, at 07:48, Maurus Cuelenaere wrote: >>> + struct sdhci_s3c *sc = sdhci_priv(host); >>> + >>> + if (sc->vmmc) { >>> + int ret = regulator_disable(sc->vmmc); >>> +

Re: [PATCH 4/4] sdhci-s3c: add regulator support

2010-07-28 Thread Maurus Cuelenaere
ulator_disable(sc->vmmc); > + > + return ret; > } > > static int sdhci_s3c_resume(struct platform_device *dev) > { > struct sdhci_host *host = platform_get_drvdata(dev); > + struct sdhci_s3c *sc = sdhci_priv(host); > + > + if (sc->vmmc) { &

Re: [PATCHv5 3/4] sdhci-s3c: add support for new card detection methods (driver part)

2010-07-28 Thread Maurus Cuelenaere
> return 0; > > err_add_host: > @@ -391,10 +459,20 @@ static int __devinit sdhci_s3c_probe(struct > platform_device *pdev) > > static int __devexit sdhci_s3c_remove(struct platform_device *pdev) > { > + struct s3c_sdhci_platdata *pdata = pdev->dev.platform_data; > struct sdhci_host *host = platform_get_drvdata(pdev); > struct sdhci_s3c *sc = sdhci_priv(host); > int ptr; > > + if (pdata->cd_type == S3C_SDHCI_CD_EXTERNAL && pdata->ext_cd_cleanup) > + pdata->ext_cd_cleanup(&sdhci_s3c_notify_change); > + > + if (sc->ext_cd_irq) > + free_irq(sc->ext_cd_irq, sc); > + > + if (sc->ext_cd_gpio != -1) Perhaps if (gpio_is_valid(...)) ? > + gpio_free(sc->ext_cd_gpio); > + > sdhci_remove_host(host, 1); > > for (ptr = 0; ptr < 3; ptr++) { -- Maurus Cuelenaere -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT quirk for Samsung SoC

2010-07-27 Thread Maurus Cuelenaere
Op 27-07-10 13:58, Kukjin Kim schreef: > Maurus Cuelenaere wrote: >> Op 23-07-10 13:56, Kukjin Kim schreef: >>> From: Hyuk Lee >>> >>> If host controller doesn't have WP pin which should be connnected with SDMMC >>> card WP pin, can imple

Re: [PATCH v3 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT quirk for Samsung SoC

2010-07-23 Thread Maurus Cuelenaere
ith GPIO, can get the value which indicates > + * the card is locked or not. > +*/ > +static int sdhci_s3c_get_ro(struct mmc_host *mmc) > +{ > + struct sdhci_s3c *sc; > + struct sdhci_host *host; > + > + host = mmc_priv(mmc); > + sc = sdhci_priv(host); Thi

Re: [PATCH 2/3] ARM: S5PV210: Add support SDMMC WP through EXT_INT on SMDKV210

2010-06-15 Thread Maurus Cuelenaere
static struct s3c_sdhci_platdata hsmmc3_platdata = { > + .cfg_wp = s5pv210_setup_sdhci_gpio_wp, > + .get_ro = s5pv210_sdhci_get_ro, > +}; > + > +void s3c_sdhci_set_platdata(void) > +{ > + s3c_sdhci0_set_platdata(&hsmmc0_platdata); > + s3c_sdhci

Re: [PATCH 1/3] s3c6410: Add new quirk in sdhci driver and update ADMA descriptor build.

2010-05-05 Thread Maurus Cuelenaere
Op 05-05-10 16:59, Ben Dooks schreef: > On Tue, May 04, 2010 at 11:43:22AM +0200, Maurus Cuelenaere wrote: > > The 'From:' line seems to have been lost? > Hmm that's odd, I'm sure it was in the patch though.. Perhaps Thunderbird/Gmail stripped it while send

[PATCH 3/3] SDHCI: Enable multiblock transfers in sdhci-s3c

2010-05-04 Thread Maurus Cuelenaere
Wifi over SDIO doesn't work correctly without multiblock, so enable this. This patch depends on the following patches: [PATCH] s3c6410: Enable ADMA feature in 6410 sdhci controller. [PATCH] s3c6410: Add new quirk in sdhci driver and update ADMA descriptor build. Signed-off-by: Maurus Cuele

[PATCH 2/3] s3c6410: Enable ADMA feature in 6410 sdhci controller.

2010-05-04 Thread Maurus Cuelenaere
This patch enables ADMA feature in 6410 SDHCI controller driver. Signed-off-by: Thomas Abraham Acked-by: Ben Dooks Signed-off-by: Maurus Cuelenaere --- drivers/mmc/host/sdhci-s3c.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b

[PATCH 1/3] s3c6410: Add new quirk in sdhci driver and update ADMA descriptor build.

2010-05-04 Thread Maurus Cuelenaere
descritor table is marked with the 'End' attribute (instead of using a NOP descriptor with 'End' attribute). Signed-off-by: Thomas Abraham Acked-by: Ben Dooks Signed-off-by: Maurus Cuelenaere --- drivers/mmc/host/sdhci.c | 20 +++- drivers/mmc/host/sdhci.h

[PATCH 0/3] Enable ADMA and multiblock in s3c64xx SDHCI controller

2010-05-04 Thread Maurus Cuelenaere
This is a resend of the following patches, rebased against 2.6.34-rc6: Maurus Cuelenaere (1): SDHCI: Enable multiblock transfers in sdhci-s3c Thomas Abraham (2): s3c6410: Add new quirk in sdhci driver and update ADMA descriptor build. s3c6410: Enable ADMA feature in 6410 sdhci

[PATCH] SDHCI: Enable multiblock transfers in sdhci-s3c

2010-04-11 Thread Maurus Cuelenaere
Wifi over SDIO doesn't correctly work without multiblock, so enable this. This patch depends on the following patch: [PATCH] S3C: sdhci: Enable ADMA feature in S3C sdhci controller. Signed-off-by: Maurus Cuelenaere --- drivers/mmc/host/sdhci-s3c.c |3 --- 1 files changed, 0 inser

[PATCH 2/2] [RESEND] s3c6410: Enable ADMA feature in 6410 sdhci controller.

2010-04-11 Thread Maurus Cuelenaere
This patch enables ADMA feature in 6410 SDHCI controller driver. Signed-off-by: Thomas Abraham Acked-by: Ben Dooks --- drivers/mmc/host/sdhci-s3c.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 21

[PATCH 1/2] [RESEND] s3c6410: Add new quirk in sdhci driver and update ADMA descriptor build.

2010-04-11 Thread Maurus Cuelenaere
The s3c6410 sdhci controller does not support the 'End' attribute and NOP attribute in the same 8-Byte ADMA descriptor. This patch adds a new quirk to identify sdhci host contollers with such behaviour. In addition to this, for controllers using the new quirk, the last entry in the ADMA descritor t

[PATCH 0/2] [RESEND] Add ADMA support to s3c64xx SDHCI controller

2010-04-11 Thread Maurus Cuelenaere
/sdhci.c | 20 +++- drivers/mmc/host/sdhci.h |2 ++ 3 files changed, 18 insertions(+), 11 deletions(-) --- Maurus Cuelenaere -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH] S3C64xx: remove SDHCI_QUIRK_NO_MULTIBLOCK

2009-11-25 Thread Maurus Cuelenaere
Sorry, previous version didn't pass checkpatch.pl; here's an updated one. Regards, Maurus Cuelenaere This fixes SDIO as that requires multiblock transfers. This patch depends on the following patches: [PATCH] sdhci: Add new quirk in sdhci driver and update ADMA descriptor build. [

[PATCH] S3C64xx: remove SDHCI_QUIRK_NO_MULTIBLOCK

2009-11-25 Thread Maurus Cuelenaere
This fixes SDIO as that requires multiblock transfers. This patch depends on the following patches: [PATCH] sdhci: Add new quirk in sdhci driver and update ADMA descriptor build. [PATCH] S3C: sdhci: Enable ADMA feature in S3C sdhci controller. Signed-off-by: Maurus Cuelenaere ---  drivers/mmc