[PATCH] mmc: sdhci-acpi: add new ACPI ID

2013-11-12 Thread Mika Westerberg
Newer Intel PCHs with LPSS have the same SDHCI controller than Haswell but ACPI ID is different. Add this ID to the driver list. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/mmc/host/sdhci-acpi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/host

Re: [PATCH 0/3] Add SDHCI ACPI driver

2012-11-23 Thread Mika Westerberg
On Thu, Nov 22, 2012 at 10:24:33PM +0100, Rafael J. Wysocki wrote: On Thursday, November 22, 2012 04:46:10 PM Adrian Hunter wrote: On 22/11/12 15:55, Chris Ball wrote: Hi, On Thu, Nov 22 2012, Adrian Hunter wrote: Here is SDHCI ACPI driver. It is dependent on new ACPI Platform

Re: [PATCH 3/3] mmc: sdhci-acpi: add SDHCI ACPI driver

2012-11-23 Thread Mika Westerberg
On Thu, Nov 22, 2012 at 10:43:50AM +0200, Adrian Hunter wrote: +static int __devinit sdhci_acpi_probe(struct platform_device *pdev) +{ + struct device *dev = pdev-dev; + acpi_handle handle = dev-acpi_handle; This is not going to work anymore, you'll have to use ACPI_HANDLE(dev) for

Re: [PATCH v2 2/3] ACPI: add SDHCI to ACPI platform devices

2012-11-23 Thread Mika Westerberg
On Fri, Nov 23, 2012 at 01:36:00PM +0200, Adrian Hunter wrote: Signed-off-by: Adrian Hunter adrian.hun...@intel.com Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/acpi/scan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/acpi/scan.c b/drivers/acpi

Re: [PATCH v2 3/3] mmc: sdhci-acpi: add SDHCI ACPI driver

2012-11-23 Thread Mika Westerberg
On Fri, Nov 23, 2012 at 01:36:01PM +0200, Adrian Hunter wrote: Signed-off-by: Adrian Hunter adrian.hun...@intel.com Acked-by: Chris Ball c...@laptop.org Looks like you left that redundant check in place but it doesn't hurt anyway. Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com

Re: [PATCH 1/2] mmc: add functions to enable/disable aggressive clock gating

2011-08-18 Thread Mika Westerberg
On Wed, Aug 17, 2011 at 03:19:14PM +0300, Mika Westerberg wrote: On Wed, Aug 17, 2011 at 09:51:31AM +0200, Linus Walleij wrote: I would suggest that in all patches using these functions, try to replace: mmc_host_clk_disable() - mmc_host_clk_ungate() mmc_host_clk_enable

Re: [PATCH 1/2] mmc: add functions to enable/disable aggressive clock gating

2011-08-18 Thread Mika Westerberg
On Thu, Aug 18, 2011 at 02:11:23PM +0300, Andy Shevchenko wrote: Mika, do the patches to check host-clock in (mmc|sdhci)_set_data_timeout() become useless after? If so, probably you could revert them as well. IMHO these functions should work also when the clock is gated, so I suggest that we

[PATCH v2 1/3] mmc: rename mmc_host_clk_{ungate|gate} to mmc_host_clk_{hold|release}

2011-08-18 Thread Mika Westerberg
make the usecases more clear Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Cc: Linus Walleij linus.wall...@linaro.org --- drivers/mmc/core/core.c |4 ++-- drivers/mmc/core/host.c | 10 +- drivers/mmc/core/host.h |8 3 files changed, 11 insertions(+), 11

[PATCH v2 0/3] mmc: fixes for aggressive clock gating framework

2011-08-18 Thread Mika Westerberg
review, thanks. Mika Westerberg (3): mmc: rename mmc_host_clk_{ungate|gate} to mmc_host_clk_{hold|release} mmc: prevent aggressive clock gating to race with ios updates mmc: use non-reentrant workqueue for clock gating drivers/mmc/core/core.c | 35

[PATCH v2 3/3] mmc: use non-reentrant workqueue for clock gating

2011-08-18 Thread Mika Westerberg
happening we use system_nrt_wq instead. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Cc: Linus Walleij linus.wall...@linaro.org --- drivers/mmc/core/host.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c index

[PATCH v2 2/3] mmc: prevent aggressive clock gating to race with ios updates

2011-08-18 Thread Mika Westerberg
that ios.power_mode was still in previous value (MMC_POWER_ON) and ios.vdd was set to zero. We prevent these by inhibiting the clock gating while we update the ios structure. Both problems can be reproduced by simply running the device in a reboot loop. Signed-off-by: Mika Westerberg mika.westerb

Re: [PATCH 1/2] mmc: add functions to enable/disable aggressive clock gating

2011-08-17 Thread Mika Westerberg
On Wed, Aug 17, 2011 at 09:51:31AM +0200, Linus Walleij wrote: I would suggest that in all patches using these functions, try to replace: mmc_host_clk_disable() - mmc_host_clk_ungate() mmc_host_clk_enable() - mmc_host_clk_gate() Wow, that is indeed *much* cleaner way of doing this! One

Re: [PATCH 1/2] mmc: add functions to enable/disable aggressive clock gating

2011-08-16 Thread Mika Westerberg
On Mon, Aug 15, 2011 at 01:03:37PM +0300, Mika Westerberg wrote: There are few places where we want to make sure that no clock gating takes place. For example when we are updating several related fields in ios structure and we don't want to accidentally pass the partially filled ios

[PATCH 1/2] mmc: add functions to enable/disable aggressive clock gating

2011-08-15 Thread Mika Westerberg
the aggressive clock gating where this is needed. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Cc: Linus Walleij linus.wall...@linaro.org --- drivers/mmc/core/host.c | 39 ++- drivers/mmc/core/host.h | 11 +++ include/linux/mmc/host.h

[PATCH 2/2] mmc: prevent aggressive clock gating to race with ios updates

2011-08-15 Thread Mika Westerberg
was still in previous value (MMC_POWER_ON) and ios.vdd was set to zero. We prevent these by disabling the clock gating while we update the ios structure. Both problems can be reproduced by simply running the device in a reboot loop. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Cc