2013/5/13, Artem Bityutskiy :
> On Sat, 2013-04-13 at 22:38 +0900, Namjae Jeon wrote:
>> From: Namjae Jeon
>>
>> It is better to use blk_queue_max_discard_sectors helper
>> function to set max_discard_sectors as it checks
>> max_discard_sectors upper limit UINT
From: Namjae Jeon
when user does
cat /sys/block/mmcblk0boot0/ro_lock_until_next_power_on
power_ro_lock_show increments md->usage by calling mmc_blk_get
but it forgets to call mmc_blk_put to restore md->usage
Signed-off-by: Namjae Jeon
Signed-off-by: Vivek Trivedi
---
drivers/mm
2013/4/23, Kent Overstreet :
> On Sat, Apr 20, 2013 at 01:40:02AM +0900, Namjae Jeon wrote:
>> From: Namjae Jeon
>>
>> linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with
>> commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9
>> (block:
2013/4/19, Neil Armstrong :
> Since eMMC 4.3 a special boot mode operation was introduced to retrieve
> data from the eMMC device with a very simple procedure. Since the Linux
> kernel exports these device boot partitions, it may be useful to select
> the boot partition from the user space.
>
> The
2013/4/21 James Bottomley :
> On Sat, 2013-04-20 at 01:40 +0900, Namjae Jeon wrote:
>> From: Namjae Jeon
>>
>> linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with
>> commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9
>> (block: add plug for
From: Namjae Jeon
https://lkml.org/lkml/2013/4/1/292
As per above discussion, there is possibility that request's __data_len
field may overflow when max_discard_sectors greater than UINT_MAX >> 9
If multiple discard requests get merged, merged discard request's
size excee
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
https://lkml.org/lkml/2013/4/1/292
As per above discussion, it has been oberved that few drivers are
setting q->limits.max_discard_sectors to more than (UINT_MAX >> 9)
If multiple discard requests get merged, merged discard request's
size exceeds 4GB, there
From: Namjae Jeon
linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with
commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9
(block: add plug for blkdev_issue_discard )
For example,
1) DISCARD rq-1 with size size 4GB
2) DISCARD rq-2 with size size 1GB
If these 2 discard requests
2013/4/15, Adrian Hunter :
> On 13/04/13 16:38, Namjae Jeon wrote:
>> From: Namjae Jeon
>>
>> https://lkml.org/lkml/2013/4/1/292
>> As per above discussion, there is possibility that request's __data_len
>> field may overflow when max_discard_sectors greate
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
It is better to use blk_queue_max_discard_sectors helper
function to set max_discard_sectors as it checks
max_discard_sectors upper limit UINT_MAX >> 9
similar issue was reported for mmc in below link
https://lkml.org/lkml/2013/4/1/292
If multiple discard requests get
From: Namjae Jeon
https://lkml.org/lkml/2013/4/1/292
As per above discussion, there is possibility that request's __data_len
field may overflow when max_discard_sectors greater than UINT_MAX >> 9
If multiple discard requests get merged, merged discard request's
size excee
From: Namjae Jeon
https://lkml.org/lkml/2013/4/1/292
As per above discussion, it has been oberved that few drivers are
setting q->limits.max_discard_sectors to more than (UINT_MAX >> 9)
If multiple discard requests get merged, merged discard request's
size exceeds 4GB, there
From: Namjae Jeon
linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with
commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9
(block: add plug for blkdev_issue_discard )
For example,
1) DISCARD rq-1 with size size 4GB
2) DISCARD rq-2 with size size 1GB
If these 2 discard requests
2013/3/14, Sergey Yanovich :
> MMC hosts are added asynchronously. We need to wait until detect returns to
> avoid failed root filesystem mounts.
> ---8<---
> VFS: Cannot open root device "mmcblk0p1" or unknown-block(0,0): error -6
> Please append a correct "root=" boot option; here are the availab
://plus.google.com/111398485184813224730/posts/21pTYfTsCkB#111398485184813224730/posts/21pTYfTsCkB
>
> Signed-off-by: Ian Chen
> ---
Looks good.
Reviewed-by: Namjae Jeon
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@v
s/21pTYfTsCkB
>
> Regards,
> Ian
>
> -Original Message-
> From: Namjae Jeon [mailto:linkinj...@gmail.com]
> Sent: Monday, August 13, 2012 10:03 PM
> To: IAN CHEN
> Cc: c...@laptop.org; adrian.hun...@intel.com; subha...@codeaurora.org;
> linus.wall...@linaro.org;
Hi. Ian.
known issue ? Would you explain more ?
Thanks.
2012/8/13 IAN CHEN :
> From 5c60eb8be04c7440d6e33b8f72ea2046a3657ac4 Mon Sep 17 00:00:00 2001
> From: ian.cy.chen
> Date: Mon, 13 Aug 2012 10:53:55 +0900
> Subject: [PATCH] mmc: card: Skip secure option for MoviNAND.
>
> For several MoviNA
f-by: Johan Rudholm
Looks good to me.
Reviewed-by: Namjae Jeon
You sent only 2/5 patch...
Would you resend all v2 patches after including tag linus's ack and my
reviewed-by ?
Thanks.
> ---
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a mess
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index 276d21c..1b202fe 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -1521,6 +1521,9 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct
> mmc_card *card,
> md->disk->queue = md->queue.q
2012/7/10, Loic pallardy :
> Repost in text format
>
> 2012/7/10 Namjae Jeon
>>
>> >
>> > + err = mmc_blk_part_switch(card, md);
>> > + if (err)
>> > + goto cmd_rel_host;
>> > +
>> Should it wrapped by if (is
>
> + err = mmc_blk_part_switch(card, md);
> + if (err)
> + goto cmd_rel_host;
> +
Should it wrapped by if (is_rpbm) condition ? It can be called in other ioctl.
> if (idata->ic.is_acmd) {
> err = mmc_app_cmd(card->host, card);
> if (err)
>
and error checking.
Hi. Seungwon.
When you measure packed read performance using lmdd, Is there any
improved performance ?
Thanks.
>
> Thanks,
> Maya
> On Mon, June 18, 2012 7:22 am, Namjae Jeon wrote:
>> 2012/6/18 :
>>> I would prefer that you didn't submit this.
performance.
mmc vendors willl be considering to improve packed read cmd.
Reviewed-by: Namjae Jeon
Thanks.
>
> Thanks,
> Maya
> On Sun, June 17, 2012 10:46 pm, Seungwon Jeon wrote:
>> Add the packed read command for issuing data. Unlike the
>> packed write, command header is
atch looks good to me also.
Reviewed-by: Namjae Jeon
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
CKED_CMD should be set.
>
> Signed-off-by: Seungwon Jeon
> ---
Looks good to me.
Reviewed-by: Namjae Jeon
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
2012/6/7, Subhash Jadavani :
> On 6/7/2012 4:05 PM, Namjae Jeon wrote:
>> This change is not meant for improving MMC throughput; it's basically
>> > about becoming fair to other threads/interrupts in the system. By
>> > holding
>> > spin lock and interrup
Hi. Subhash.
Although performance is decreased in result, Why do you try to change ?
What is better than before ?
Thanks.
2012/6/7, Subhash Jadavani :
> For completing any block request, MMC block driver is calling:
> spin_lock_irq(queue)
> __blk_end_request()
> spin_unlock_irq
sector size, ensure that
> USE_NATIVE_SECTOR
> is enabled, partition table is 4KB sector size aligned and file system
> block
> and sector size are 4KB multiples.
>
> Signed-off-by: Saugata Das
Looks good.
Reviewed-by: Namjae Jeon
Thanks.
--
To unsubscribe from this list: send the lin
2012/5/17, Saugata Das :
> On 17 May 2012 06:35, Namjae Jeon wrote:
>> 2012/5/17, Saugata Das :
>>> From: Saugata Das
>>>
>>> This patch adds the support for large sector size of 4KB by disabling
>>> emulation.
>>> This patch passes
2012/5/17, Saugata Das :
> From: Saugata Das
>
> This patch adds the support for large sector size of 4KB by disabling
> emulation.
> This patch passes eMMC DATA_SECTOR_SIZE as the logical block size during
> mmc_blk_alloc_req.
>
> In order to use this patch for 4KB sector size, ensure that
> USE_
Hi. Chris.
Would you check this patch also ?
Thanks.
2012/4/12, Namjae Jeon :
> 2012/4/12 Philippe De Swert :
>> bus_width is passed to the function and when 0 (MMC_BUS_WIDTH_1)
>> will cause the function to return. So in in the second test it
>> definitly is different
Hi. Chris.
Would you check this patch ?
Thanks.
2012/4/12, Namjae Jeon :
> 2012/4/12 Philippe De Swert :
>> After the null check on md the code jumped to cmd_done, which then
>> will dereference md in mmc_blk_put. This patch avoids the possible
>> null pointer der
2012/4/13 Venkatraman S :
> Include the corresponding header file in cd-gpio.c
> for prototype consistency. This gets rid of some
> sparse warnings.
>
> Signed-off-by: Venkatraman S
This patch is same with H Hartley Sweeten's patch ([PATCH v2] mmc:
cd-gpio.c: Include header to pickup exported symb
2012/4/13 Venkatraman S :
> The name mmc_request is used for both the issue function
> and a data structure, which creates conflicts in symbol lookups
> in editors. Rename the function to mmc_request_fn
>
> Signed-off-by: Venkatraman S
Looks reasonable to me~
Reviewed-by: Namj
> Signed-off-by: Venkatraman S
Looks good to me~
Reviewed-by: Namjae Jeon
Thanks.
> ---
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
2012/4/13 Venkatraman S :
> Not needed to memset, as they are pointers and are assigned
> to proper values in the next line anyway.
>
> Signed-off-by: Venkatraman S
Looks good!!
Reviewed-by: Namjae Jeon
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux
2012/4/18 S, Venkatraman :
> On Wed, Apr 18, 2012 at 10:15 AM, Namjae Jeon wrote:
>> 2012/4/18 Jaehoon Chung :
>>> On 04/18/2012 09:20 AM, Namjae Jeon wrote:
>>>
>>>> 2012/4/17 Venkatraman S :
>>>>> mmc_execute_hpi should send the HPI com
Hi. Subhash.
Would you share which option you used in LMDD, iozone test ?
Thanks.
2012/4/18 Subhash Jadavani :
> Hi Chris,
>
>> -Original Message-
>> From: linux-arm-msm-ow...@vger.kernel.org [mailto:linux-arm-msm-
>> ow...@vger.kernel.org] On Behalf Of Subhash Jadavani
>> Sent: Wednesda
2012/4/18 Jaehoon Chung :
> On 04/18/2012 09:20 AM, Namjae Jeon wrote:
>
>> 2012/4/17 Venkatraman S :
>>> mmc_execute_hpi should send the HPI command only
>>> once, only if the card is in PRG state.
>>>
>>> According to eMMC spec, the c
specification ?
Thanks.
>
> Specify the default timeout for the actual sending of HPI
> command, and then use OUT_OF_INTERRUPT_TIME to wait for
> the transition out of PRG state.
>
> Reported-by: Alex Lemberg
> Signed-off-by: Venkatraman S
> CC: Namjae Jeon
> CC: Jae h
2012/4/14 S, Venkatraman :
> On Fri, Apr 13, 2012 at 8:09 PM, Namjae Jeon wrote:
>> Hi. Venkatraman.
>>
>> You fixed 10 times. why is it 10 times ?
> There's no right number - I haven't seen it fail much in my tests but
> should allow a few retries.
Is t
to me.
Reviewed-by: Namjae Jeon
> ---
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi. Venkatraman.
You fixed 10 times. why is it 10 times ?
and checking err from mmc_send_status is not needed ? is it also
infinite case ?
Thanks.
2012/4/13 Venkatraman S :
> Try to send HPI only a fixed number of times till it is
> successful. One successful transfer is enough - but wait
> til
2012/4/12 Girish K S :
> On 11 April 2012 19:24, Namjae Jeon wrote:
>> Hi. Subhash.
Hi.
>> Have you considered return -EINVAL in switch ?
> That is case which should never enter.
Would you explain more why entering never in case?
>> And looks complex more.. how about g
2012/4/12 Philippe De Swert :
> After the null check on md the code jumped to cmd_done, which then
> will dereference md in mmc_blk_put. This patch avoids the possible
> null pointer dereference in that case.
>
> Signed-off-by: Philippe De Swert
This patch is good also.
Reviewed-
od to me.
Reviewed-by: Namjae Jeon
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi. Subhash.
Have you considered return -EINVAL in switch ?
And looks complex more.. how about getting bus_width and ddr value
from argument ?
Thanks.
2012/4/11 Subhash Jadavani :
> With current implementation of power class selection,
> mmc_select_powerclass() should never fail. So treat any erro
Hi. Chris.
You're right~ we can optmize code properly by moving printk to
mmc_select_powerclass.
Thanks for your reply.
2012/4/10 Chris Ball :
> Hi,
>
> On Mon, Apr 09 2012, Namjae Jeon wrote:
>> Hi Subhash.
>> There are duplicate printks in three places. Is there no
Hi Subhash.
There are duplicate printks in three places. Is there no way to avoid
duplicate printks ?
Thanks.
2012/4/9 Subhash Jadavani :
> With current implementation of power class selection,
> mmc_select_powerclass() should never fail. So treat any error
> returned by this function as serious
lass.
>> If mmc_select_powerclass() returns error, just print
>> the warning message and go ahead with rest of the card
>> initialization.
>>
>> Signed-off-by: Subhash Jadavani
> looks good to me
> Acked By: Girish K S
I double checked with specificatio
>
> -Aaron
Looks good to me.
Reviewed-by: Namjae Jeon
Thanks.
>
>> ---
>> drivers/mmc/core/bus.c | 17 +++--
>> 1 files changed, 15 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
>> ind
Actually, Specfication is described to be misunderstood easily.
Nice day.
2012/3/29 Dong, Chuanxiao :
>
>> -Original Message-
>> From: Namjae Jeon [mailto:linkinj...@gmail.com]
>> Sent: Thursday, March 29, 2012 11:30 AM
>> To: Dong, Chuanxiao
>>
:
>> -Original Message-
>> From: Namjae Jeon [mailto:linkinj...@gmail.com]
>> Sent: Wednesday, March 28, 2012 8:36 PM
>> To: Dong, Chuanxiao
>> Cc: linux-mmc@vger.kernel.org; c...@laptop.org; Hunter, Adrian
>> Subject: Re: [Patch v1]mmc:core: correct mmc_erase_timeout
4-A441.pdf
>
> Thanks
> Chuanxiao
>
>> -Original Message-----
>> From: Namjae Jeon [mailto:linkinj...@gmail.com]
>> Sent: Wednesday, March 28, 2012 5:17 PM
>> To: Dong, Chuanxiao
>> Cc: linux-mmc@vger.kernel.org; c...@laptop.org; Hunter, Ad
Hi. Chuanxiao.
Would you share your specification with me ?
When I check the latest emmc 4.5 spec, I can not find it.
Thanks.
2012/3/28 Chuanxiao Dong :
> According to JEDEC 7.8.2, mmc_erase_timeout calculation should be follow:
> 1. Secure erase timeout = 300ms * ERASE_TIMEOUT_MULT * SEC_ERASE_MU
would like to add my reviewd-by tag in updated patches also.
Reviewed-by: Namjae Jeon
Thanks.
2012/3/2 :
> Hi,
>
> Our tests showed that the write packing improved the performance of the
> write sequential operations:
>
> Long write operation:
> --
&g
Hi. merez.
Would you share random read speed with us ?
And Write speed also..
Thanks.
2012/3/1 :
>> This patch supports packed command of eMMC4.5 device.
>> Several reads(or writes) can be grouped in packed command
>> and all data of the individual commands can be sent in a
>> single transfer
2012/2/21 :
>>
>> @@ -1262,21 +1608,32 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue
>> *mq, struct request *rqc)
>> int ret = 1, disable_multi = 0, retry = 0, type;
>> enum mmc_blk_status status;
>> struct mmc_queue_req *mq_rq;
>> - struct request *req;
>> + struct
-by: Seungwon Jeon
Hi. Seungwon.
This patch make sense.
Reviewed-by: Namjae Jeon
> ---
> drivers/mmc/host/dw_mmc.c | 25 +
> 1 files changed, 9 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> i
2012/2/8 Jaehoon Chung :
> On 02/07/2012 04:27 PM, Namjae Jeon wrote:
>
>> 2012/2/7 Jaehoon Chung :
>>> This patch is added just debug message.
>>> Almost features need to use the CMD23.
>>> But we didn't see the debug message for sbc.
>>> I
2012/2/7 Jaehoon Chung :
> This patch is added just debug message.
> Almost features need to use the CMD23.
> But we didn't see the debug message for sbc.
> If sbc's message can see, should be help for debugging.
> (We can check whether use the cmd23 or not)
Hi. Jaehoon.
how about using CONFIG_MMC_
2012/2/6 Namjae Jeon :
> 2012/2/6 Jaehoon Chung :
>> On 02/06/2012 03:17 PM, Namjae Jeon wrote:
>>
>>> 2012/2/6 Jaehoon Chung :
>>>> Hi Mr.Jeon.
>>>>
>>>> On 02/06/2012 01:19 PM, Namjae Jeon wrote:
>>>>
>>>>>
2012/2/6 Jaehoon Chung :
> On 02/06/2012 03:17 PM, Namjae Jeon wrote:
>
>> 2012/2/6 Jaehoon Chung :
>>> Hi Mr.Jeon.
>>>
>>> On 02/06/2012 01:19 PM, Namjae Jeon wrote:
>>>
>>>> Hi. Jaehoon.
>>>>
>>>> I have qu
2012/2/6 Jaehoon Chung :
> Hi Mr.Jeon.
>
> On 02/06/2012 01:19 PM, Namjae Jeon wrote:
>
>> Hi. Jaehoon.
>>
>> I have questions.
>>
>> 1. Would you explain why we need on/off function of this CMD23 at runtime ?
>
> Now..operation mode is set at compi
Hi. Jaehoon.
I have questions.
1. Would you explain why we need on/off function of this CMD23 at runtime ?
2. While frequently reading/writing, Have you tested by being
enabling/disbling CMD23 using this function ?
3. Why is irq disable needed when calling mmc_change_operation_mode ?
If are we ju
2012/2/3 Jaehoon Chung :
> On 02/03/2012 06:33 PM, Ulf Hansson wrote:
>
>> To prevent I/O as soon as possible at card removal, a new
>> detect work is re-scheduled without a delay to let a rescan
>> remove the card device as soon a possible.
>>
>> Additionally, MMC_CAP2_DETECT_ON_ERR can now be use
moved cards that a scheduled detect work did not
> detect as removed. To prevent further I/O requests for these
> lingering removed cards, check if card has been removed and then
> schedule a detect work to properly remove it.
>
> Signed-off-by: Ulf Hansson
Reviewed-by: Namj
2012/2/2 Jaehoon Chung :
> On 02/02/2012 12:36 PM, Namjae Jeon wrote:
>
>> 2012/2/2 Jaehoon Chung :
>>> On 02/02/2012 09:34 AM, Namjae Jeon wrote:
>>>
>>>> 2012/2/1 Ulf Hansson :
>>>>> To prevent I/O as soon as possible at card removal, a
2012/2/2 Jaehoon Chung :
> On 02/02/2012 09:34 AM, Namjae Jeon wrote:
>
>> 2012/2/1 Ulf Hansson :
>>> To prevent I/O as soon as possible at card removal, a new
>>> detect work is re-scheduled without a delay to let a rescan
>>> remove the card device a
2012/2/1 Ulf Hansson :
> To prevent I/O as soon as possible at card removal, a new
> detect work is re-scheduled without a delay to let a rescan
> remove the card device as soon a possible.
>
> Additionally, MMC_CAP2_DETECT_ON_ERR can now be used to handle
> "slowly" removed cards that a scheduled
2012/2/2 Linus Walleij :
> On Wed, Feb 1, 2012 at 4:31 PM, Ulf Hansson
> wrote:
>
>> From: Rabin Vincent
>>
>> Signed-off-by: Rabin Vincent
>> Signed-off-by: Johan Rudholm
>> Signed-off-by: Ulf Hansson
>
> Acked-by: Linus Walleij
Reviewed-by: Nam
2012/2/1 Jurgen Heeks :
> Found this issue during code review. Actually, there are two
> issues which both compensate together in lucky case.
> In unlucky case the bus width probing might not work as expected.
>
> Signed-off-by: Jurgen Heeks
> ---
Reviewed-by: Namjae Jeon
2012/1/26 Seungwon Jeon :
> This patch supports packed command of eMMC4.5 device.
> Several reads(or writes) can be grouped in packed command
> and all data of the individual commands can be sent in a
> single transfer on the bus.
>
> Signed-off-by: Seungwon Jeon
Reviewed-by: N
CKED_CMD should be set.
>
> Signed-off-by: Seungwon Jeon
Reviewed-by: Namjae Jeon
Looks good to me.
Thanks.
> ---
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
>> > - Add a variable member in mmc_host for minimum number of packed
>> > entries.
>> > This value can be overridden by host.
>> Ah.. Okay~ I clearly understand about two queston.
>> Totally, Looks good to me.
>> Thanks for your reply.
>> And I heard that packed cmd is not good wh
2012/1/26 Seungwon Jeon :
> Namjae Jeon :
>> 2012/1/25 Namjae Jeon :
>> >>> >> +
>> >>> >> +static int mmc_blk_issue_packed_rd(struct mmc_queue *mq,
>> >>> >> + struct mmc_queue_req *mq_rq)
>> >>&g
2012/1/25 Namjae Jeon :
>>> >> +
>>> >> +static int mmc_blk_issue_packed_rd(struct mmc_queue *mq,
>>> >> + struct mmc_queue_req *mq_rq)
>>> >> +{
>>> >> + struct mmc_blk_data *md = mq->data;
>>
>> >> +
>> >> +static int mmc_blk_issue_packed_rd(struct mmc_queue *mq,
>> >> + struct mmc_queue_req *mq_rq)
>> >> +{
>> >> + struct mmc_blk_data *md = mq->data;
>> >> + struct mmc_card *card = md->queue.card;
>> >> + int status, ret = -EIO, retry = 2;
Hi. Seungwon.
2012/1/23 Saugata Das :
> On 20 January 2012 09:36, Seungwon Jeon wrote:
>> This patch supports packed command of eMMC4.5 device.
>> Several reads(or writes) can be grouped in packed command
>> and all data of the individual commands can be sent in a
>> single transfer on the bus.
>>
>> Signed-off
Hi. Seungwon,
Would you show improved performance measurement
result(read/write,seq,ran) when using packed cmd ?
Thanks.
2012/1/20 Kyungmin Park :
> Hi,
>
> FYI: we get performance gain using packed command at write. however in
> case of small size read, there are some performance drop since
>
o)
> to:
> mmc_host_(foo, ...)
>
> Add a couple of missing newlines.
> Convert bare printks to pr_cont where appropriate.
> Spelling/typo fix of initialiazed to initialized.
>
> Signed-off-by: Joe Perches
Reviewed-by: NamJae Jeon
> ---
--
To unsubscribe from th
2011/11/16 Joe Perches :
> On Wed, 2011-11-16 at 10:55 +0900, NamJae Jeon wrote:
>> 2011/11/16 Joe Perches :
>> > On Wed, 2011-11-16 at 10:48 +0900, NamJae Jeon wrote:
>> >
>> > [123K of untrimmed reply]
>> >
>> > If you wrote something, I di
2011/11/16 Joe Perches :
> On Wed, 2011-11-16 at 10:48 +0900, NamJae Jeon wrote:
>
> [123K of untrimmed reply]
>
> If you wrote something, I didn't find it.
>
> - dev_info(&pdev->dev, "DW MMC controller at irq %d, "
> -"%d
2011/11/16 Joe Perches :
> Add pr_fmt.
> Remove DRIVER_NAME from logging calls.
> Remove DBG, use pr_debug.
>
> Signed-off-by: Joe Perches
Reviewed-by: NamJae Jeon
> ---
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message
2011/11/16 Joe Perches :
> Convert pr_warning to pr_warn.
> Coalesce format strings.
> Align arguments.
> Add missing \n.
>
> Signed-off-by: Joe Perches
Reviewed-by: NamJae Jeon
> ---
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
2011/11/16 Joe Perches :
> On Wed, 2011-11-16 at 09:52 +0900, NamJae Jeon wrote:
>> 2011/11/16 Joe Perches :
>> > Centralize the pr_ uses of mmc_hostname into specific
>> > mmc_host_ calls to allow a flexible presentation style
>> > and shorten the code a bit.
2011/10/13 Andrei Warkentin :
> - Original Message -
>> From: "Randy Dunlap"
>> To: "Namjae Jeon"
>> Cc: c...@laptop.org, awarken...@vmware.com
>> Sent: Wednesday, October 12, 2011 1:52:35 PM
>> Subject: Re: [PATCH] mmc : fix compile
2011/10/12 Andrei Warkentin :
> Hi,
>
> - Original Message -
>> From: "NamJae Jeon"
>> To: "Andrei Warkentin"
>> Cc: linux-n...@vger.kernel.org, "LKML" ,
>> linux-mmc@vger.kernel.org, "Chris Ball"
>> , &quo
1 - 100 of 157 matches
Mail list logo
