Re: [PATCH] mmc: always save error codes in mmc_regulator_get_supply()

2012-07-01 Thread Pankaj Jangra
pply. Please let me know if i am missing something here. Also if you want to save the error code only you may want to move the statement "mmc->supply.vmmc = supply" only above the error checking right? > ret = mmc_regulator_get_ocrmask(supply); > if (ret > 0)

Re: [PATCH 1/2] regulator: core.c Pass voltage to notifier when setting voltage

2012-06-15 Thread Pankaj Jangra
Hi, On Sat, Jun 16, 2012 at 12:48 AM, Philip Rakity wrote: > > On Jun 15, 2012, at 11:50 AM, Pankaj Jangra wrote: > >> Hi, >> >> On Fri, Jun 15, 2012 at 11:57 PM, Philip Rakity >> wrote: >>> V3 >>> -- >>> >>> >>>

Re: [PATCH 1/2] regulator: core.c Pass voltage to notifier when setting voltage

2012-06-15 Thread Pankaj Jangra
> --- Since you are submitting your patch from the different email than your Singed-off email. So you should put in first line of message From: . Regards, Pankaj Jangra -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] regulator: core.c Pass voltage to notifier when setting voltage

2012-06-15 Thread Pankaj Jangra
Hi, On Fri, Jun 15, 2012 at 11:59 PM, Philip Rakity wrote: > > On Jun 15, 2012, at 10:58 AM, Pankaj Jangra wrote: > >> Hi Philip, >> >> Just a cosmetic comments. >> >> On Fri, Jun 15, 2012 at 3:36 AM, Philip Rakity >> wrote: >> V2 >>