Re: [PATCH 00/12] mmc: core: mmc_bus to handle suspend|resume|shutdown

2013-06-12 Thread Pierre Ossman
On Tue, 11 Jun 2013 11:24:49 +0200 Linus Walleij wrote: > > Hm a significant portion of this patch set hits code which has not > been touched since Pierre Ossman wrote the first MMC code. > E.g. patch 1. In the spirit of giving credit where credit is due, the MMC code existed long

Re: mmc_test Correct xfer_size at write

2011-06-28 Thread Pierre Ossman
#x27;s more or less by convention. ETIMEDOUT is the closest thing we have to "we expected a response from the card but got bupkis". You can find some informal definitions here: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=include/linux/mmc/core.h;h=b6718e

Re: + sdio-recognize-io-card-without-powercycle.patch added to -mm tree

2010-03-16 Thread Pierre Ossman
guess there's no more testing we can do so I'll merge it? Sounds reasonable. Although the question is if anyone has -mm on a system which lacks slot power control. :) Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by FRA, a Swedish intelligence age

Re: Subject: [PATCH] v2.6.32: Add new device IDs and quircks for MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND SDIO SUBSYSTEM

2010-02-13 Thread Pierre Ossman
an, valid, end*/ > > +} > > + > > desc += 8; > > > > /* > > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h > > index ce5f1d7..2fa8245 100644 > > --- a/drivers/mmc/host/sdhci.h > > +

Re: [PATCH v3] mmc: Make ID freq configurable

2010-01-02 Thread Pierre Ossman
should all be using the same init sequence. If there isn't a single frequency where all cards will work, then we'll have to make something more advanced where the kernel will try the init several times with different clocking. Rgds -- -- Pierre Ossman WARNING: This correspondence

Re: [PATCH v2] mmc: lower init clock frequency to 300kHz

2010-01-02 Thread Pierre Ossman
intermediate value each time? I.e. halvway between 400 and 100 for now (250). If that is too fast, then halway between that and 100 (175), and so on. Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by FRA, a Swedish intelligence agency. Make sure your server uses

Re: [PATCH] mmc: add module parameter to set whether cards are assumed removable

2009-11-30 Thread Pierre Ossman
k, although it would certainly be safer that way. > The hardware driver layer can only check if it's the same device being plugged in, not if someone has done something with it during suspend, so I see no other way than solving this in the filesystem layer. Rgds -- -- Pierre Ossman

Re: [PATCH] mmc: add module parameter to set whether cards are assumed removable

2009-11-30 Thread Pierre Ossman
that the kernel needs to umount/mount around suspend in a way that's transparent to users of the filesystem. Until we have such a system in place then everything will be hacks which only shift around the problem. Rgds -- -- Pierre Ossman WARNING: This correspondence is being mo

Re: [PATCH] sdio: add MMC_CAP_VDD_165_195 host capability

2009-10-14 Thread Pierre Ossman
; enumerated, have a hook for per-card fixups. For the particular > non-standard card in question, this would then reduce the voltage to 1.8V. > In theory. But it would require a bit of redesign of the code as it would have to restart the whole init again. Rgds -- -- Pierre Ossman WA

Re: [PATCH] sdio: add MMC_CAP_VDD_165_195 host capability

2009-10-14 Thread Pierre Ossman
vger.kernel.org/msg00386.html) ? > Since this is out-of-spec and therefore possibly dangerous behaviour, I'd like it to be opt-in for the user. And since it's so early in the init process, we can't automate it based on card id. Rgds -- -- Pierre Ossman WARNING: This

Re: [PATCH] sdio: add MMC_CAP_VDD_165_195 host capability

2009-10-08 Thread Pierre Ossman
On Tue, 29 Sep 2009 23:10:13 -0700 Philip Langdale wrote: > On Tue, 29 Sep 2009 23:37:32 +0200 > Pierre Ossman wrote: > > > I must have missed that part of discussion. If the voltage fully > > overlaps with the MMC definition, then I don't see the controllers

Re: MMC support for password protection of SD cards

2009-10-05 Thread Pierre Ossman
el/373855 > > But no discussions being done on that thread since 2006. Is it because > of the propitiatory nature or legal issues with the SD Organization? > Neither. It simply never got finished with regard to handling SD cards. Rgds -- -- Pierre Ossman WARNING: This corresp

Re: + sdio-pass-whitelisted-cis-funce-tuples-to-sdio-drivers.patch added to -mm tree

2009-10-04 Thread Pierre Ossman
On Wed, 30 Sep 2009 15:23:09 -0700 (PDT) Albert Herranz wrote: > Pierre Ossman wrote: > > > > Anyway, my ideal solution would be something like this: > > > > - We start checking the type field in cistpl_funce. We already know > >about types 0 and 1 (and n

Re: [PATCH 1/1] Implementation for knowing speed_class of inserted SD card from user space

2009-09-30 Thread Pierre Ossman
he kernel? Userspace ABI stuff should be added with great care. 2. I think it's better to not show the attribute when it isn't relevant rather than return 0xFF. 3. Isn't this a SD 2.0 feature? So you should check the version of the card before populating/showing this field. Rgds -

Re: stalled mmc patches

2009-09-29 Thread Pierre Ossman
They'd need to make sure the card remains powered between inits to fully expose the bug I saw. PS. try to clear my @drzeus.cx addresses from your address books. They will cease to function in the future. Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by th

Re: [PATCH] sdio: add MMC_CAP_VDD_165_195 host capability

2009-09-29 Thread Pierre Ossman
whip some sense into the line handling of your email client. :) Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption. signature.asc Description: PGP signature

Re: TMIO MMC: full patchset.

2009-09-29 Thread Pierre Ossman
argins already at the first attempt. Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption. signature.asc Description: PGP signature

Re: [PATCH] sdio: add MMC_CAP_VDD_165_195 host capability

2009-09-29 Thread Pierre Ossman
e can do is interpret it as being the same as the MMC bit, but then only with an opt-in configuration as we might be killing hardware with this. Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses enc

Re: + sdio-pass-whitelisted-cis-funce-tuples-to-sdio-drivers.patch added to -mm tree

2009-09-29 Thread Pierre Ossman
al version, but this would be the model that would make blissful. :) Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption. signature.asc Description: PGP signature

Re: [PATCH RFC] MMC card of Size > 4GB support in Linu

2009-09-22 Thread Pierre Ossman
#define EXT_CSD_CARD_TYPE 196 /* RO */ > +#define EXT_CSD_STRUCT_REV 194 /* RO */ > #define EXT_CSD_REV192 /* RO */ > #define EXT_CSD_SEC_CNT212 /* RO, 4 bytes */ > And this is just even more wrong. You're telling the stack to check the

Re: [PATCH] sdhci: Increase timeout for internal clock stabilization.

2009-09-19 Thread Pierre Ossman
ittle longer for in general. > > Signed-off-by: Chris Ball > Cc: Harald Welte > --- Seems reasonable enough to me. The initial limit was completely arbitrary anyway. Acked-by: Pierre Ossman Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Sw

Re: Regression in suspend to ram in 2.6.31-rc kernels

2009-09-14 Thread Pierre Ossman
It _does_ check the card id when you have UNSAFE_RESUME selected. It doesn't just hook up whatever card you happen to have in the slot with your old block device. I may have a lot of opponents when it comes to my suspend design choices, but I'm not completely crazy. ;) Rgds -- -- Pierre

Re: [PATCH RFC 2/3] sdio: pass unknown cis tuples to sdio drivers

2009-09-14 Thread Pierre Ossman
On Mon, 7 Sep 2009 20:55:58 +0200 Michael Buesch wrote: > On Monday 07 September 2009 20:47:12 Albert Herranz wrote: > > > > > > Please also submit to the SDIO maintainer. > There isn't one anymore, so submitting to this list is the correct method. R

Re: EXT_CSD Register : CSD_STRUCTURE vs CSD_CSD_REV

2009-09-14 Thread Pierre Ossman
nion. No, as that would violate the spec and possibly misinterpret some cards as high-capacity. To handle your card you would have to build some kind of quirks system so that the kernel can identify that this card is buggy and compensate for it. Rgds -- -- Pierre Ossman WARNING: This corres

Re: MMC retry mechanism

2009-09-14 Thread Pierre Ossman
been more threads over the years, but I'm afraid I don't remember enough about them to find them again. Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider us

Re: [PATCH] sdio: pass unknown cis tuples to sdio drivers

2009-09-10 Thread Pierre Ossman
Silencing a legitimate error. > + if (ret == -EILSEQ) { > + /* this tuple is unknown to the core */ Misleading comment, the tuple might be known but malformed. Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption. signature.asc Description: PGP signature

Re: [PATCH] sdio: recognize io card without powercycle

2009-09-10 Thread Pierre Ossman
struct mmc_host *host) > +{ It might be clearer if you use the terminology from the spec, so either sdio_abort() or sdio_reset(). Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traf

Re: MMC retry mechanism

2009-09-06 Thread Pierre Ossman
laim is that doing so can break some filesystem drivers (notably the journaling ones). There has been several threads and patches about this in the past. Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption

Re: [PATCH 1/4] [MMC] core SDIO suspend/resume support

2009-09-06 Thread Pierre Ossman
7;s also the issue of e.g. having two "identical" wifi cards but with different MAC addresses). I think the right way to go is to retain enough power to the card for it to stay initialised and then poke it at resume to see if it is still running in the same state we left it. Rgds

[PATCH] Orphaning sdhci driver and list

2009-09-06 Thread Pierre Ossman
Remove myself as maintainer from the sdhci driver and steer people towards the new MMC list for discussing it. Signed-off-by: Pierre Ossman --- I've noticed that people have already begun sending their sdhci patches to Andrew, so this is more or less a formality at this point. I won

Re: mmcqd cpu utilization

2009-09-02 Thread Pierre Ossman
oughts? > My guess would be that the omap driver doesn't (cannot?) use the hardware to wait for busy to end, so the system must poll. Anything better than that guess will require some profiling. :) Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedi