Re: Possible bug in sdio.c?

2011-05-29 Thread Prashanth Bhat
On Sunday 29 May 2011 07:42 PM, Michał Mirosław wrote: On Sun, May 29, 2011 at 07:26:00AM +0530, Prashanth Bhat wrote: Hi Michał, In mmc/core/sdio.c, routine mmc_enable_4bit_bus(): I think: if (card-type == MMC_TYPE_SDIO) return sdio_enable_wide(card); should really

Possible bug in sdio.c?

2011-05-28 Thread Prashanth Bhat
Hi Michał, In mmc/core/sdio.c, routine mmc_enable_4bit_bus(): I think: if (card-type == MMC_TYPE_SDIO) return sdio_enable_wide(card); should really be: if (card-type == MMC_TYPE_SDIO || card-type == MMC_TYPE_SD_COMBO ) return sdio_enable_wide(card);

Re: [PATCH] mmc: mmc_add_card(): fix missing break in switch statement

2011-05-04 Thread Prashanth Bhat
) /* SDIO card */ #define MMC_TYPE_SD_COMBO (MMC_TYPE_SD | MMC_TYPE_SDIO)/* SD combo (IO+mem) card */ Thanks, Prashanth On Wednesday 04 May 2011 04:53 PM, Michał Mirosław wrote: On Tue, May 03, 2011 at 05:00:03PM +0530, Prashanth Bhat wrote: To be more specific, I would think

Re: [PATCH] mmc: mmc_add_card(): fix missing break in switch statement

2011-05-03 Thread Prashanth Bhat
Michal, I hope you remember the email exchange we had about a month ago. I think I see an issue with SD-COMBO support. In include/linux/mmc/card.h, there are macros: #define mmc_card_mmc(c) ((c)-type == MMC_TYPE_MMC) #define mmc_card_sd(c) ((c)-type == MMC_TYPE_SD) #define

Re: [PATCH] mmc: mmc_add_card(): fix missing break in switch statement

2011-05-03 Thread Prashanth Bhat
mmc_card_sd(c) ((c)-type == MMC_TYPE_SD || (c)-type == MMC_TYPE_SD_COMBO) + #define mmc_card_sdio(c)((c)-type == MMC_TYPE_SDIO || (c)-type == MMC_TYPE_SD_COMBO) Thanks, Prashanth On Tuesday 03 May 2011 04:50 PM, Prashanth Bhat wrote: Michal, I hope you remember the email exchange

Potential Bug in drivers/mmc/

2011-04-08 Thread Prashanth Bhat
don't see this, even in a later version of the source (namely 2.6.38). Please take a look, and also let me know what you decide. Thanks, Prashanth Bhat = Prashanth B. Bhat, Ph. D. Chief Technology Officer, Manipal Dot Net Pvt. Ltd