Re: [PATCH v2 1/2] mmc: sdhci-of-arasan: add phy support for sdhci-of-arasan

On Tue, 2015-09-15 at 09:07AM +0800, Shawn Lin wrote: > On 2015/9/14 23:07, Sören Brinkmann wrote: > >Hi Shawn, > > > >overall, it looks good to me. I have some questions though. > > > >On Mon, 2015-09-14 at 02:29PM +0800, Shawn Lin wrote: > > [...] >

Re: [PATCH v2 1/2] mmc: sdhci-of-arasan: add phy support for sdhci-of-arasan

phy_power_off(sdhci_arasan->phy); > + goto clk_dis_ahb; > + } > + > + ret = phy_init(sdhci_arasan->phy); > + if (ret < 0) { > + dev_err(>dev, "phy_init err.\n"); > + phy_exit(sdhci_arasan->phy); > + phy_power_off(sdhci_arasan->phy); > + goto clk_dis_ahb; > + } > + } I assume you looked at options for having the error paths in a consolidated location? I guess this may be the nicest solution since all of this is in this conditional block? Feel free to add my Acked-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Sören -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/2] Documentation: bindings: add description of phy for sdhci-of-arasan

On Mon, 2015-09-14 at 02:29PM +0800, Shawn Lin wrote: > This patch adds phys and phy-names for sdhci-of-arasan as required > properties for arasan,sdhci-5.1, and details the example as well. > > Signed-off-by: Shawn Lin <shawn@rock-chips.com> Acked-by: Sören Brink

Re: [PATCH 2/2] Documentation: bindings: add description of phy for sdhci-of-arasan

Hi Shawn, On Fri, 2015-09-11 at 04:55PM +0800, Shawn Lin wrote: > This patch adds phys and phy-names for sdhci-of-arasan as optional > properties, and details the example as well. > > Signed-off-by: Shawn Lin > --- > >

Re: [PATCH v2] mmc: sdhci: add quirk for broken write protect detection

Hi Eli, On Sun, 2014-03-02 at 01:20PM +0200, Eli Billauer wrote: The write protection signal is absent on a board based upon Xilinx' Zynq processor (ZyBo). This leads the kernel to think that the MicroSD card is write protected, and causes a kernel panic during boot, as root fails to mount

Re: [PATCH v2] mmc: sdhci: add quirk for broken write protect detection

On Tue, 2014-03-04 at 10:06PM +0200, Eli Billauer wrote: Hello Sören, wp-inverted solves the practical problem indeed, and fools the driver into thinking that the card has an inverted write protection sensor, and the logic zero that it finds in the hardware register means that the card

Re: [PATCH v3 1/2] mmc: arasan: Add driver for Arasan SDHCI

On Sun, Jan 12, 2014 at 06:06:32PM +, Chris Ball wrote: Hi Soren, On Mon, Dec 02 2013, Soren Brinkmann wrote: Add a driver for Arasan's SDHCI controller core. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com Acked-by: Rob Herring rob.herr...@calxeda.com [binding]

Re: [GIT PULL] Xilinx Zynq mmc changes for v3.14

Hi Chris, On Wed, Dec 18, 2013 at 10:42:29AM +0100, Michal Simek wrote: Hi Chris, Soren and I are trying to reach you regarding Arasan driver we sent to mailing list for review. There are no complains about this version 3 that's why I have added to our repo and sending you this pull

Re: [PATCH v2 1/2] mmc: arasan: Add driver for Arasan SDHCI

Hi Chris, On Tue, Nov 26, 2013 at 06:22:46PM -0500, Chris Ball wrote: Hi Soren, sorry for the late review, just trivial changes: No problem. Thanks for looking at it. On Wed, Oct 30 2013, Soren Brinkmann wrote: diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt

Re: [PATCH v2 1/2] mmc: arasan: Add driver for Arasan SDHCI

Hi Chris, any comments from your side? Could you consider applying it to your tree, please? Thanks, Sören On Wed, Oct 30, 2013 at 09:38:09AM -0700, Soren Brinkmann wrote: Add a driver for Arasan's SDHCI controller core. Signed-off-by: Soren Brinkmann

Re: [PATCH 1/2] mmc: arasan: Add driver for Arasan SDHCI

ping? On Tue, Oct 15, 2013 at 12:08:04PM -0700, Soren Brinkmann wrote: Add a driver for Arasan's SDHCI controller core. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com --- .../devicetree/bindings/mmc/arasan,sdhci.txt | 23 +++ MAINTAINERS

Re: [PATCH 1/2] mmc: arasan: Add driver for Arasan SDHCI

On Mon, Oct 28, 2013 at 10:16:49PM +0100, Tomasz Figa wrote: Hi Soren, On Tuesday 15 of October 2013 12:08:04 Soren Brinkmann wrote: Add a driver for Arasan's SDHCI controller core. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com ---

Re: [PATCH 1/2] mmc: arasan: Add driver for Arasan SDHCI

On Mon, Oct 28, 2013 at 06:20:41PM -0500, Rob Herring wrote: On 10/15/2013 02:08 PM, Soren Brinkmann wrote: Add a driver for Arasan's SDHCI controller core. Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com --- .../devicetree/bindings/mmc/arasan,sdhci.txt | 23 +++