Re: [PATCH 0/3] ARM: edma: Correct header file usage

2015-01-14 Thread Sekhar Nori
On Thursday 27 November 2014 04:11 PM, Peter Ujfalusi wrote: > Hi, > > The linux/platform_data/edma.h file was used for API definition as well, which > is not correct since the header should only contain platform data related > structures, defines, etc. I would like to queue this series through A

Re: [PATCH v3] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-09-27 Thread Sekhar Nori
device is EDMA. For this purpose we use the of_* helpers to >>> parse >>> the arguments in the dmas phandle list. >>> >>> Also introduced is a minor clean up of a checkpatch error in old code. >>> >>> Reviewed-by: Sekhar Nori >>> Reported

Re: [PATCH v3] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-09-27 Thread Sekhar Nori
device is EDMA. For this purpose we use the of_* helpers to >>> parse >>> the arguments in the dmas phandle list. >>> >>> Also introduced is a minor clean up of a checkpatch error in old code. >>> >>> Reviewed-by: Sekhar Nori >>> Reported

Re: [PATCH v3] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-09-19 Thread Sekhar Nori
On Tuesday 17 September 2013 07:59 PM, Joel Fernandes wrote: > On 09/17/2013 01:05 AM, Sekhar Nori wrote: > [..] >>>> mixed messages. In short, we aim for consistency with situation today, >>>> not tomorrow. >>> >>> What you're asking to do inf

Re: [PATCH v3] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-09-16 Thread Sekhar Nori
On Tuesday 17 September 2013 11:08 AM, Joel Fernandes wrote: > On 09/17/2013 12:08 AM, Sekhar Nori wrote: > [..] >>>> I still cannot find any users of edma in the device tree sources either >>>> in linux-next or linus/master. Why cannot this wait until v3.13? >>

Re: [PATCH v3] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-09-16 Thread Sekhar Nori
On Monday 16 September 2013 09:56 PM, Joel Fernandes wrote: > On 09/16/2013 06:48 AM, Sekhar Nori wrote: >> Hi Joel, >> >> On Saturday 14 September 2013 06:27 AM, Joel Fernandes wrote: >>> From: Joel Fernandes >>> Subject: [PATCH v4] ARM: EDMA:

Re: [PATCH 0/3] mmc: omap_hsmmc: get rid of ti,non-removable

2013-09-16 Thread Sekhar Nori
On Saturday 14 September 2013 03:37 AM, Balaji T K wrote: > On Friday 13 September 2013 09:07 PM, Tony Lindgren wrote: >> * Sekhar Nori [130913 03:18]: >>> Get rid of TI specific binding ti,non-removable in favour of the >>> generic binding present for the same purpose.

Re: [PATCH 0/3] mmc: omap_hsmmc: get rid of ti,non-removable

2013-09-16 Thread Sekhar Nori
On Friday 13 September 2013 09:07 PM, Tony Lindgren wrote: > * Sekhar Nori [130913 03:18]: >> Get rid of TI specific binding ti,non-removable in favour of the >> generic binding present for the same purpose. > > Looks like there's a different handli

Re: [PATCH v3] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-09-16 Thread Sekhar Nori
to unused channel list not being clear. > > This patch fixes the issue, by reading the "dmas" property from the DT node if > it exists and clearing the bits in the unused channel list. For this purpose > we use the of_* helpers to parse the arguments in the dmas pha

Re: [PATCH 3/3] ARM: OMAP2+: BBB DT: mark eMMC as non removable

2013-09-13 Thread Sekhar Nori
On Friday 13 September 2013 03:39 PM, Sekhar Nori wrote: > Mark the eMMC module on BeagleBone black as non removable. > > Signed-off-by: Sekhar Nori The patches which touch dts files are not really following the subject line conventions. I will fix that and send a v2. Thanks to Ni

[PATCH 3/3] ARM: OMAP2+: BBB DT: mark eMMC as non removable

2013-09-13 Thread Sekhar Nori
Mark the eMMC module on BeagleBone black as non removable. Signed-off-by: Sekhar Nori --- arch/arm/boot/dts/am335x-boneblack.dts |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts index f4703cf..58515dc 100644

[PATCH 2/3] ARM: OMAP2+: DT: start using generic binding for non-removable mmc cards

2013-09-13 Thread Sekhar Nori
The TI specific binding for non-removable cards is now gone. The driver supports the generic binding, start using it. Signed-off-by: Sekhar Nori --- arch/arm/boot/dts/omap4-panda-common.dtsi |2 +- arch/arm/boot/dts/omap4-sdp.dts |4 ++-- arch/arm/boot/dts/omap4-var-som.dts

[PATCH 0/3] mmc: omap_hsmmc: get rid of ti,non-removable

2013-09-13 Thread Sekhar Nori
le MMC/SD works though. Sekhar Nori (3): mmc: omap_hsmmc: remove TI specific DT binding for non removable cards ARM: OMAP2+: DT: start using generic binding for non-removable mmc cards ARM: OMAP2+: BBB DT: mark eMMC as non removable Documentation/devicetree/bindings/mmc/ti-omap-h

[PATCH 1/3] mmc: omap_hsmmc: remove TI specific DT binding for non removable cards

2013-09-13 Thread Sekhar Nori
Remove the vendor specific "ti,non-removable" DT binding and support the generic binding "non-removable" instead. Signed-off-by: Sekhar Nori --- Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt |5 ++--- drivers/mmc/host/omap_hsmmc.c

Re: [PATCH v3] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-09-12 Thread Sekhar Nori
ode if > it exists and clearing the bits in the unused channel list. For this purpose > we use the of_* helpers to parse the arguments in the dmas phandle list. > > Reviewed-by: Sekhar Nori > Reported-by: Balaji T K > Cc: Pantel Antoniou > Signed-off-by: Joel Fernandes >

Re: [PATCH v4 3/6] ARM: edma: Add function to manually trigger an EDMA channel

2013-09-02 Thread Sekhar Nori
On 8/30/2013 4:35 AM, Joel Fernandes wrote: > Manual trigger for events missed as a result of splitting a > scatter gather list and DMA'ing it in batches. Add a helper > function to trigger a channel incase any such events are missed. > > Signed-off-by: Joel Fernandes A

Re: [PATCH v2] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-08-26 Thread Sekhar Nori
On 8/26/2013 10:22 PM, Joel Fernandes wrote: > On 08/26/2013 05:46 AM, Sekhar Nori wrote: >> On Saturday 24 August 2013 01:23 AM, Joel Fernandes wrote: >>> HWMOD removal for MMC and Crypto is breaking edma_start as the events are >>> being manually triggered due to un

Re: [PATCH v2] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-08-26 Thread Sekhar Nori
tion by returning from if block. Is this a v2 or v3 since you already sent a v2 about a month back? > > Reviewed-by: Sekhar Nori > Reported-by: Balaji T K > Cc: Pantel Antoniou > Signed-off-by: Joel Fernandes > --- > Note: > Patch should go in for -rc cycle as it fi

Re: [PATCH v3 09/12] dma: edma: Implement multiple linked sets for continuity

2013-08-12 Thread Sekhar Nori
dependent on interrupts and DMA > continues till the end of the SG-lists without any interruption. > > Suggested-by: Sekhar Nori > Signed-off-by: Joel Fernandes > --- > drivers/dma/edma.c | 157 > +++- > 1 file chang

Re: [PATCH v3 08/12] dma: edma: Add one more required slot to MAX slots

2013-08-12 Thread Sekhar Nori
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: > We'd now need a separate slot just for the channel and separate > ones for the 2 linked sets, so we make adjustments to allocate > an extra channel accordingly. > > Signed-off-by: Joel Fernandes No need for a separate patch for this, jus

Re: [PATCH v3 07/12] dma: edma: Add function to dump a PaRAM set from PaRAM

2013-08-12 Thread Sekhar Nori
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: > Previously, such a dump function was used but it wasn't reading > from the PaRAM, rather just from a edmacc_param structure, we > add a helpful function for debugging that directly reads from > the PaRAM and gives the current state correctl

Re: [PATCH v3 03/12] dma: edma: remove limits on number of slots

2013-08-12 Thread Sekhar Nori
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: > With this series, this check is no longer required and > we shouldn't need to reject drivers DMA'ing more than the > MAX number of slots. > > Signed-off-by: Joel Fernandes > --- > drivers/dma/edma.c |6 -- > 1 file changed, 6 del

Re: [PATCH v3 01/12] dma: edma: Setup parameters to DMA MAX_NR_SG at a time

2013-08-12 Thread Sekhar Nori
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: > Changes are made here for configuring existing parameters to support > DMA'ing them out in batches as needed. > > Also allocate as many as slots as needed by the SG list, but not more > than MAX_NR_SG. Then these slots will be reused accor

Re: [PATCH v3 02/12] ARM: edma: Don't clear EMR of channel in edma_stop

2013-08-11 Thread Sekhar Nori
On Monday 12 August 2013 09:59 AM, Joel Fernandes wrote: > On Sun, Aug 11, 2013 at 11:25 PM, Sekhar Nori wrote: >> On 8/8/2013 5:19 PM, Sekhar Nori wrote: >>> On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: >>>> We certainly don't want error conditions

Re: [PATCH v3 02/12] ARM: edma: Don't clear EMR of channel in edma_stop

2013-08-11 Thread Sekhar Nori
On 8/8/2013 5:19 PM, Sekhar Nori wrote: > On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: >> We certainly don't want error conditions to be cleared any other >> place but the EDMA error handler, as this will make us 'forget' >> about missed even

Re: [PATCH v3 02/12] ARM: edma: Don't clear EMR of channel in edma_stop

2013-08-08 Thread Sekhar Nori
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote: > We certainly don't want error conditions to be cleared any other > place but the EDMA error handler, as this will make us 'forget' > about missed events we might need to know errors have occurred. > > This fixes a race condition where the

Re: [PATCH 4/9] dma: edma: Find missed events and issue them

2013-08-02 Thread Sekhar Nori
On 8/2/2013 1:58 AM, Joel Fernandes wrote: > On 08/01/2013 01:13 AM, Sekhar Nori wrote: >> On Thursday 01 August 2013 07:57 AM, Joel Fernandes wrote: >>> On 07/31/2013 04:18 AM, Sekhar Nori wrote: >>>> On Wednesday 31 July 2013 10:19 AM, Joel Fernandes wrote: >>

Re: [PATCH 4/9] dma: edma: Find missed events and issue them

2013-07-31 Thread Sekhar Nori
On Thursday 01 August 2013 07:57 AM, Joel Fernandes wrote: > On 07/31/2013 04:18 AM, Sekhar Nori wrote: >> On Wednesday 31 July 2013 10:19 AM, Joel Fernandes wrote: >>> Hi Sekhar, >>> >>> On 07/30/2013 02:05 AM, Sekhar Nori wrote: >>>> On Mo

Re: [PATCH 7/9] ARM: edma: Don't clear EMR of channel in edma_stop

2013-07-31 Thread Sekhar Nori
On Wednesday 31 July 2013 10:35 AM, Joel Fernandes wrote: > On 07/30/2013 03:29 AM, Sekhar Nori wrote: >> On Monday 29 July 2013 06:59 PM, Joel Fernandes wrote: >>> We certainly don't want error conditions to be cleared anywhere >> >> 'anywhere' is a re

Re: [PATCH 4/9] dma: edma: Find missed events and issue them

2013-07-31 Thread Sekhar Nori
On Wednesday 31 July 2013 10:19 AM, Joel Fernandes wrote: > Hi Sekhar, > > On 07/30/2013 02:05 AM, Sekhar Nori wrote: >> On Monday 29 July 2013 06:59 PM, Joel Fernandes wrote: >>> In an effort to move to using Scatter gather lists of any size with >>> EDMA as di

Re: [PATCH 3/9] ARM: edma: Add function to manually trigger an EDMA channel

2013-07-30 Thread Sekhar Nori
On Wednesday 31 July 2013 10:00 AM, Joel Fernandes wrote: > On 07/30/2013 12:18 AM, Sekhar Nori wrote: >> On Monday 29 July 2013 06:59 PM, Joel Fernandes wrote: >>> Manual trigger for events missed as a result of splitting a >>> scatter gather list and DMA'

Re: [PATCH v2] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-07-30 Thread Sekhar Nori
On 7/30/2013 9:17 AM, Joel Fernandes wrote: >>> diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c >>> index a432e6c..765d578 100644 >>> --- a/arch/arm/common/edma.c >>> +++ b/arch/arm/common/edma.c >>> + } else { >>> + for (; i < pdev->num_resources; i++) { >>> +

Re: [PATCH 7/9] ARM: edma: Don't clear EMR of channel in edma_stop

2013-07-30 Thread Sekhar Nori
On Monday 29 July 2013 06:59 PM, Joel Fernandes wrote: > We certainly don't want error conditions to be cleared anywhere 'anywhere' is a really loaded term. > as this will make us 'forget' about missed events. We depend on > knowing which events were missed in order to be able to reissue them. >

Re: [PATCH 4/9] dma: edma: Find missed events and issue them

2013-07-30 Thread Sekhar Nori
On Monday 29 July 2013 06:59 PM, Joel Fernandes wrote: > In an effort to move to using Scatter gather lists of any size with > EDMA as discussed at [1] instead of placing limitations on the driver, > we work through the limitations of the EDMAC hardware to find missed > events and issue them. > >

Re: [PATCH 3/9] ARM: edma: Add function to manually trigger an EDMA channel

2013-07-29 Thread Sekhar Nori
On Monday 29 July 2013 06:59 PM, Joel Fernandes wrote: > Manual trigger for events missed as a result of splitting a > scatter gather list and DMA'ing it in batches. Add a helper > function to trigger a channel incase any such events are missed. > > Signed-off-by: Joel Fernandes > --- > arch/arm

Re: [PATCH v2] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-07-29 Thread Sekhar Nori
On Tuesday 30 July 2013 09:23 AM, Joel Fernandes wrote: > On 07/29/2013 02:04 AM, Sekhar Nori wrote: >> On Sunday 28 July 2013 05:02 AM, Joel Fernandes wrote: >>> Hi Tony or Sekhar, >>> >>> If this patch looks ok, could you pick it up for -rc cycle? >>&g

Re: [PATCH v2] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-07-29 Thread Sekhar Nori
On Sunday 28 July 2013 05:02 AM, Joel Fernandes wrote: > Hi Tony or Sekhar, > > If this patch looks ok, could you pick it up for -rc cycle? > > It fixes DMA breakages after the merge window for devices for which DMA > resources are being populated in device tree instead pdev. But which DT-enable

Re: [PATCH v2] ARM: EDMA: Fix clearing of unused list for DT DMA resources

2013-07-29 Thread Sekhar Nori
On Monday 22 July 2013 11:29 PM, Joel Fernandes wrote: > HWMOD removal for MMC is breaking edma_start as the events are being manually > triggered due to unused channel list not being clear, Thanks to Balaji TK for > finding this issue. So, Reported-by: Balaji T K ? > > This patch fixes the is

Re: [PATCH v12 00/11] DMA Engine support for AM33XX

2013-06-25 Thread Sekhar Nori
On 6/25/2013 12:24 PM, Tony Lindgren wrote: > * Benoit Cousson [130624 07:42]: >> Hi Tony, >> >> On 06/24/2013 12:19 PM, Tony Lindgren wrote: >>> Hi, >>> >>> For merging this series, I suggest the following sets: >>> >>> * Joel A Fernandes [130620 14:13]: Joel A Fernandes (3): ed

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-24 Thread Sekhar Nori
On 6/22/2013 8:23 AM, Joel A Fernandes wrote: config TI_EDMA tristate "TI EDMA support" default m if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2 select DMA_ENGINE select DMA_VIRTUAL_CHANNELS >>> >>> >>> MMC depends on EDMA specially on AM33xx t

Re: [PATCH v12 00/11] DMA Engine support for AM33XX

2013-06-24 Thread Sekhar Nori
Sourav, On 6/24/2013 3:49 PM, Tony Lindgren wrote: > Hi, > > For merging this series, I suggest the following sets: > > * Joel A Fernandes [130620 14:13]: >> spi: omap2-mcspi: add generic DMA request support to the DT binding >> spi: omap2-mcspi: convert to dma_request_slave_channel_compat

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-24 Thread Sekhar Nori
On 6/24/2013 4:53 PM, Sekhar Nori wrote: > On 6/22/2013 3:23 AM, Joel A Fernandes wrote: >> Hi Arnd, >> >> On Fri, Jun 21, 2013 at 1:44 PM, Arnd Bergmann wrote: >>> On Friday 21 June 2013, Joel A Fernandes wrote: >>>> I think we are talking a

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-24 Thread Sekhar Nori
On 6/22/2013 3:23 AM, Joel A Fernandes wrote: > Hi Arnd, > > On Fri, Jun 21, 2013 at 1:44 PM, Arnd Bergmann wrote: >> On Friday 21 June 2013, Joel A Fernandes wrote: >>> I think we are talking about different things, I agree the 'select >>> DMADEVICES' can be dropped but lets please keep the defa

Re: [PATCH v12 04/11] dmaengine: edma: enable build for AM33XX

2013-06-24 Thread Sekhar Nori
On 6/24/2013 3:47 PM, Tony Lindgren wrote: > * Sekhar Nori [130621 03:21]: >> On 6/21/2013 2:36 AM, Joel A Fernandes wrote: >>> From: Matt Porter >>> >>> Enable TI EDMA option on OMAP and TI_PRIV_EDMA >>> >>> Signed-off-by: Matt Porter >

Re: [PATCH v13] ARM: edma: Add DT and runtime PM support to the private EDMA API

2013-06-24 Thread Sekhar Nori
On 6/21/2013 3:23 PM, Sekhar Nori wrote: > From: Matt Porter > > Adds support for parsing the TI EDMA DT data into the required EDMA > private API platform data. Enables runtime PM support to initialize > the EDMA hwmod. Enables build on OMAP. > > Changes by Joel: > *

Re: [PATCH v12 09/11] spi: omap2-mcspi: convert to dma_request_slave_channel_compat()

2013-06-21 Thread Sekhar Nori
Fixing Mark's e-mail. Mark, On 6/21/2013 3:56 PM, Sourav Poddar wrote: > Hi Mark, > On Friday 21 June 2013 02:36 AM, Joel A Fernandes wrote: >> From: Matt Porter >> >> Convert dmaengine channel requests to use >> dma_request_slave_channel_compat(). This supports the DT case of >> platforms requi

Re: [PATCH v12 00/11] DMA Engine support for AM33XX

2013-06-21 Thread Sekhar Nori
Joel, On 6/21/2013 2:36 AM, Joel A Fernandes wrote: > From: Joel A Fernandes > > This series is remaining of Matt Porter's EDMA patches for AM33XX EDMA support > with changes for few pending review comments on v11 series. I have posted a branch with fixes for patches accepted by me in this seri

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Sekhar Nori
On 6/21/2013 2:36 AM, Joel A Fernandes wrote: > From: Joel A Fernandes > > Build TI_EDMA by default for ARCH_DAVINCI and ARCH_OMAP2PLUS > > Signed-off-by: Joel A Fernandes You should sign-off with author e-mail address. > --- > arch/arm/Kconfig|1 + > arch/arm/mach-omap2/Kcon

[PATCH] ARM: edma: Add EDMA crossbar event mux support

2013-06-21 Thread Sekhar Nori
EDMA xbar support out of original EDMA DT parsing patch to keep it easier for review. * Rewrite shift and offset calculation. Suggested-by: Sekhar Nori Suggested by: Andy Shevchenko Signed-off-by: Joel A Fernandes Acked-by: Arnd Bergmann [nsek...@ti.com: fix checkpatch errors and a minor coding

Re: [PATCH v12 04/11] dmaengine: edma: enable build for AM33XX

2013-06-21 Thread Sekhar Nori
On 6/21/2013 2:36 AM, Joel A Fernandes wrote: > From: Matt Porter > > Enable TI EDMA option on OMAP and TI_PRIV_EDMA > > Signed-off-by: Matt Porter > Signed-off-by: Joel A Fernandes This will have to be taken by Tony. Thanks, Sekhar > --- > arch/arm/mach-omap2/Kconfig |1 + > drivers/d

Re: [PATCH v12 03/11] ARM: edma: Add EDMA crossbar event mux support

2013-06-21 Thread Sekhar Nori
t; * Rewrite shift and offset calculation. > > Suggested-by: Sekhar Nori > Suggested by: Andy Shevchenko > Signed-off-by: Joel A Fernandes > > Reference: > [1] https://patchwork.kernel.org/patch/2226991/ > --- > arch/arm/common/edma.c | 62 > +

[PATCH v13] ARM: edma: Add DT and runtime PM support to the private EDMA API

2013-06-21 Thread Sekhar Nori
] Signed-off-by: Joel A Fernandes Acked-by: Arnd Bergmann Signed-off-by: Sekhar Nori --- arch/arm/common/edma.c| 186 +++-- arch/arm/mach-davinci/devices-da8xx.c |8 +- arch/arm/mach-davinci/devices-tnetv107x.c |4 +- arch/arm/mach-davinci

Re: [PATCH v12 02/11] ARM: edma: Add DT and runtime PM support to the private EDMA API

2013-06-21 Thread Sekhar Nori
ed unused DT helper to convert to array > > [1] https://patchwork.kernel.org/patch/2226761/ > > Signed-off-by: Matt Porter > Acked-by: Sekhar Nori > Signed-off-by: Joel A Fernandes > --- > arch/arm/common/edma.c | 180 > +

Re: [PATCH v11 3/8] ARM: edma: Add EDMA crossbar event mux support

2013-06-19 Thread Sekhar Nori
On 6/20/2013 6:06 AM, Joel A Fernandes wrote: >>> + /* Clear the xbar mapped channels in unused list */ >>> + xbar_chans = info[j]->xbar_chans; >>> + if (xbar_chans) { >>> + for (i = 0; xbar_chans[i][1] != -1; i++) { >>> +

Re: [PATCH v11 3/8] ARM: edma: Add EDMA crossbar event mux support

2013-06-18 Thread Sekhar Nori
On 6/18/2013 12:08 PM, Joel A Fernandes wrote: > From: Matt Porter > > Changes by Joel: > * Split EDMA xbar support out of original EDMA DT parsing patch > to keep it easier for review. > * Rewrite shift and offset calculation. > > Suggested-by: Sekhar Nori > Su

Re: [PATCH v11 2/8] ARM: edma: Add DT and runtime PM support to the private EDMA API

2013-06-18 Thread Sekhar Nori
> * Setup default one-to-one mapping for queue_priority and queue_tc > mapping as discussed in [1]. > * Split out xbar stuff to separate patch. [1] > > [1] https://patchwork.kernel.org/patch/2226761/ > > Signed-off-by: Matt Porter > Acked-by: Sekhar Nori > Signed-of

Re: [PATCH v10 0/8] DMA Engine support for AM33XX

2013-06-17 Thread Sekhar Nori
Joel, When you respin this, please base on top of Prabhakar's clean-up titled: "ARM: edma: Convert to devm_* api". Or better still, include his patch in your series. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.

Re: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree binding

2013-06-17 Thread Sekhar Nori
On 6/17/2013 9:10 PM, Fernandes, Joel A wrote: > Hi Arnd, > >> -Original Message- >> From: Arnd Bergmann [mailto:a...@arndb.de] >> Sent: Monday, June 17, 2013 6:13 AM >> To: Fernandes, Joel A >> Cc: Tony Lindgren; Nori, Sekhar; Matt Porter; Grant Likely; Rob Herring; >> Vinod >> Koul; Ma

Re: [PATCH v10 1/2] ARM: davinci: move private EDMA API to arm/common

2013-06-17 Thread Sekhar Nori
vate EDMA API to >> arm/common >> >> On Mon, Jun 17, 2013 at 03:36:10PM +0530, Sekhar Nori wrote: >>> From: Matt Porter >>> >>> Move mach-davinci/dma.c to common/edma.c so it can be used by OMAP >>> (specifically AM33xx) as well. >>> &g

Re: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree binding

2013-06-17 Thread Sekhar Nori
Grant, Rob, Can one of you please take a look at this patch and see if you have any comments on the binding definition? Joel, Ideally the bindings are described before they are used or along with its usage. In that aspect, this patch is present too far back in the series. Can you please fix this

[PATCH v10 2/2] ARM: edma: remove unused transfer controller handlers

2013-06-17 Thread Sekhar Nori
From: Matt Porter Fix build on OMAP, the irqs are undefined on AM33xx. These error interrupt handlers were hardcoded as disabled so since they are unused code, simply remove them. Signed-off-by: Matt Porter Signed-off-by: Sekhar Nori --- arch/arm/common/edma.c | 37

[PATCH v10 1/2] ARM: davinci: move private EDMA API to arm/common

2013-06-17 Thread Sekhar Nori
From: Matt Porter Move mach-davinci/dma.c to common/edma.c so it can be used by OMAP (specifically AM33xx) as well. Signed-off-by: Matt Porter Acked-by: Chris Ball # davinci_mmc.c [nsek...@ti.com: dropped davinci sffsdr changes] Signed-off-by: Sekhar Nori --- arch/arm/Kconfig

[PATCH v10 0/2] ARM: davinci: move EDMA API to arm/common

2013-06-17 Thread Sekhar Nori
This is a repost of first two patches of Matt Porter's EDMA series below: http://www.mail-archive.com/davinci-linux-open-source@linux.davincidsp.com/msg25317.html The only change that has been made is to drop changes related to DaVinci SFFSDR machine support for sound since that code is now queue

Re: [PATCH v9 1/9] ARM: davinci: move private EDMA API to arm/common

2013-06-06 Thread Sekhar Nori
+ Chris since the patch has some davinci_mmc.c changes. Chris, Mark, On 3/6/2013 9:45 PM, Matt Porter wrote: > Move mach-davinci/dma.c to common/edma.c so it can be used > by OMAP (specifically AM33xx) as well. > > Signed-off-by: Matt Porter > Acked-by: Sekhar Nori Can you ple

Re: [PATCH v9 1/9] ARM: davinci: move private EDMA API to arm/common

2013-06-05 Thread Sekhar Nori
Hi Russell, On 3/6/2013 9:45 PM, Matt Porter wrote: > Move mach-davinci/dma.c to common/edma.c so it can be used > by OMAP (specifically AM33xx) as well. > > Signed-off-by: Matt Porter > Acked-by: Sekhar Nori Can you please ack this movement of davinci private EDMA implementat

Re: [PATCH v9 0/9] DMA Engine support for AM33XX

2013-04-03 Thread Sekhar Nori
Hi Matt, On 3/6/2013 9:45 PM, Matt Porter wrote: > This series adds DMA Engine support for AM33xx, which uses > an EDMA DMAC. The EDMA DMAC has been previously supported by only > a private API implementation (much like the situation with OMAP > DMA) found on the DaVinci family of SoCs. > Matt P

Re: [PATCH v7 0/5] Add DT support for davinci_mmc driver

2013-04-02 Thread Sekhar Nori
On 4/2/2013 9:31 PM, Chris Ball wrote: > Hi, > > On Tue, Apr 02 2013, Sekhar Nori wrote: >> I would like to take this series through DaVinci tree to manage the >> dependencies with mach-davinci. I need your ack on the driver part and >> the DT binding. Can you please p

Re: [PATCH v7 0/5] Add DT support for davinci_mmc driver

2013-04-02 Thread Sekhar Nori
Hi Chris, On 3/28/2013 6:40 PM, Manjunathappa, Prakash wrote: > Patch set adds DT support for davinci_mmc driver and is > verified on da850-evm without card_detect/write_protect and > EDMA support. Also takecare to derive controller IP version from > platform_device_id table, remove version specif

Re: [PATCH v7 1/5] mmc: davinci: allow driver to work without DMA resource

2013-04-02 Thread Sekhar Nori
On 3/28/2013 6:40 PM, Manjunathappa, Prakash wrote: > Do not return probe failure with missing DMA resources, > allow driver to work in PIO mode. > Tested on da850-evm by mounting partition followed by > file creation and deletion. > > Signed-off-by: Manjunathappa, Prakash &

Re: [PATCH v5 0/4] Add DT support for davinci_mmc driver

2013-03-14 Thread Sekhar Nori
On 3/12/2013 7:43 PM, Manjunathappa, Prakash wrote: > Patch set adds DT support for davinci_mmc driver and is > verified on da850-evm without card_detect/write_protect and > EDMA support. Also takecare to derive controller IP version from > platform_device_id table, remove version specification in

Re: [PATCH v5 1/4] ARM: davinci: mmc: derive version information from device name

2013-03-14 Thread Sekhar Nori
t from > platform_device_id table. Also change the clock node name to match > the changed dev_id. > Tested on da850-evm to make sure driver loads without clk_get failures. > > Signed-off-by: Manjunathappa, Prakash > Reviewed-by: Sekhar Nori > --- > diff --git a/drivers/mmc/host/da

Re: [PATCH v9 5/9] dmaengine: edma: Add TI EDMA device tree binding

2013-03-11 Thread Sekhar Nori
On 3/6/2013 9:45 PM, Matt Porter wrote: > The binding definition is based on the generic DMA controller > binding. > > Signed-off-by: Matt Porter Okay the bindings the documented after they are used leading to some confusion. This patch should be moved up the series. As I noted in my other e-mai

Re: [PATCH v9 3/9] ARM: edma: add AM33XX support to the private EDMA API

2013-03-11 Thread Sekhar Nori
igned-off-by: Matt Porter > Acked-by: Sekhar Nori > --- > arch/arm/common/edma.c | 300 > ++-- > arch/arm/mach-omap2/Kconfig|1 + > include/linux/platform_data/edma.h |1 + > 3 files changed, 292 insertions(+), 10

Re: [PATCH v4 3/5] mmc: davinci_mmc: add DT support

2013-03-05 Thread Sekhar Nori
On 3/5/2013 4:54 PM, Manjunathappa, Prakash wrote: >>> + pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); >>> + if (!pdata) { >>> + dev_err(&pdev->dev, "Failed to allocate memory for struct >>> davinci_mmc_config\n"); >>> + goto nodata; >> >> devm_kzalloc() re

Re: [PATCH v2] mmc: davinci: allow driver to work without DMA resource

2013-02-28 Thread Sekhar Nori
erified this along with your other patches enabling use of MMC with DT boot. Tested-by: Sekhar Nori Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 5/5] ARM: davinci: da850: override mmc DT node device name

2013-02-28 Thread Sekhar Nori
ed-off-by: Manjunathappa, Prakash >> Cc: linux-mmc@vger.kernel.org >> Cc: linux-arm-ker...@lists.infradead.org >> Cc: linux-ker...@vger.kernel.org >> Cc: davinci-linux-open-sou...@linux.davincidsp.com >> Cc: devicetree-disc...@lists.ozlabs.org >> Cc: c...@laptop.org &

Re: [PATCH v4 1/5] ARM: davinci: mmc: derive version information from device name

2013-02-27 Thread Sekhar Nori
On 2/15/2013 11:51 AM, Manjunathappa, Prakash wrote: > Remove specifying mmc controller IP version information via platform > data, instead specify device name so that driver derives it from > platform_device_id table. Also change the clock node name to match > the changed dev_id. > Tested on da850

Re: [PATCH v4 3/5] mmc: davinci_mmc: add DT support

2013-02-27 Thread Sekhar Nori
; Signed-off-by: Manjunathappa, Prakash > Reviewed-by: Mark Rutland > Cc: linux-mmc@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: davinci-linux-open-sou...@linux.davincidsp.com > Cc: devicetree-disc...@lists.ozlabs.org > Cc: c...@laptop.org > Cc: Sekhar Nori

Re: [PATCH v2 2/3] mmc: davinci_mmc: add DT support

2013-02-11 Thread Sekhar Nori
; Signed-off-by: Manjunathappa, Prakash > Cc: linux-mmc@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-ker...@vger.kernel.org > Cc: davinci-linux-open-sou...@linux.davincidsp.com > Cc: devicetree-disc...@lists.ozlabs.org > Cc: c...@laptop.org > Cc: Sekhar Nori &

Re: [PATCH v2 1/3] ARM: davinci: da850: override mmc DT node device name

2013-02-11 Thread Sekhar Nori
On 2/7/2013 1:27 PM, Manjunathappa, Prakash wrote: > Populate OF_DEV_AUXDATA with desired device name expected by > davinci_mmc driver. Without this clk_get of davinci_mmc DT driver > fails. But there is no mmc DT support for DaVinci at this time. This patch should come after the driver DT support

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-09 Thread Sekhar Nori
Hi Matt, This version introduces build/bisect issues. On 2/1/2013 11:52 PM, Matt Porter wrote: > Move mach-davinci/dma.c to common/edma.c so it can be used > by OMAP (specifically AM33xx) as well. > > Signed-off-by: Matt Porter > Acked-by: Sekhar Nori > diff --git a/arc

Re: [PATCH] mmc: davinci: allow driver to work without DMA resource

2013-01-31 Thread Sekhar Nori
On 1/31/2013 1:50 PM, Manjunathappa, Prakash wrote: > Do not return probe failure with missing DMA resources, > allow driver to work in PIO mode. > Tested on da850-evm. It will be nice to mention what exactly was tested. rootfs mount? file create/deletion? mount/unmount? > Signed-off-by: Manjunat

Re: [PATCH v5 00/14] DMA Engine support for AM33XX

2013-01-23 Thread Sekhar Nori
Matt, On 1/24/2013 3:07 AM, Matt Porter wrote: > On Wed, Jan 23, 2013 at 10:21:42AM +0800, Mark Brown wrote: >> On Tue, Jan 22, 2013 at 09:26:34PM +0530, Sekhar Nori wrote: >>> On 1/16/2013 2:02 AM, Matt Porter wrote: >> >>>> This series adds DMA Engine support

Re: [PATCH v5 00/14] DMA Engine support for AM33XX

2013-01-23 Thread Sekhar Nori
Hi Mark, On 1/23/2013 7:51 AM, Mark Brown wrote: > On Tue, Jan 22, 2013 at 09:26:34PM +0530, Sekhar Nori wrote: >> On 1/16/2013 2:02 AM, Matt Porter wrote: > >>> This series adds DMA Engine support for AM33xx, which uses >>> an EDMA DMAC. The EDMA DMAC has been prev

Re: [PATCH v5 00/14] DMA Engine support for AM33XX

2013-01-22 Thread Sekhar Nori
Hi Tony, On 1/16/2013 2:02 AM, Matt Porter wrote: > This series adds DMA Engine support for AM33xx, which uses > an EDMA DMAC. The EDMA DMAC has been previously supported by only > a private API implementation (much like the situation with OMAP > DMA) found on the DaVinci family of SoCs. Will yo

Re: [RFC PATCH v3 02/16] ARM: davinci: move private EDMA API to arm/common

2013-01-22 Thread Sekhar Nori
Matt, Sorry about the late reply. I noticed this mail only after I started to look at v5 of your series :( On 1/11/2013 5:21 AM, Matt Porter wrote: > On Sun, Oct 28, 2012 at 01:47:09PM +0530, Sekhar Nori wrote: >> On 10/18/2012 6:56 PM, Matt Porter wrote: >>> Move mach-davin

Re: [RFC PATCH v3 11/16] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC

2012-10-29 Thread Sekhar Nori
On 10/18/2012 6:56 PM, Matt Porter wrote: > The EDMA DMAC has a hardware limitation that prevents supporting > scatter gather lists with any number of segments. Since the EDMA > DMA Engine driver sets the maximum segments to 16, we do the > same. > > TODO: this will be replaced once the DMA Engine

Re: [RFC PATCH v3 16/16] ARM: dts: add AM33XX SPI support

2012-10-28 Thread Sekhar Nori
On 10/18/2012 6:56 PM, Matt Porter wrote: > Adds AM33XX SPI support for am335x-bone and am335x-evm. > > Signed-off-by: Matt Porter > --- > arch/arm/boot/dts/am335x-bone.dts | 17 +++ > arch/arm/boot/dts/am335x-evm.dts |9 > arch/arm/boot/dts/am33xx.dtsi | 43 >

Re: [RFC PATCH v3 08/16] ARM: dts: add AM33XX EDMA support

2012-10-28 Thread Sekhar Nori
On 10/18/2012 6:56 PM, Matt Porter wrote: > Adds AM33XX EDMA support to the am33xx.dtsi as documented in > Documentation/devicetree/bindings/dma/ti-edma.txt > > Signed-off-by: Matt Porter > --- > arch/arm/boot/dts/am33xx.dtsi | 31 +++ > 1 file changed, 31 insertion

Re: [RFC PATCH v3 05/16] ARM: edma: add AM33XX crossbar event support

2012-10-28 Thread Sekhar Nori
On 10/18/2012 6:56 PM, Matt Porter wrote: > Adds support for the per-EDMA channel event mux. This is required > for any peripherals using DMA crossbar mapped events. > > Signed-off-by: Matt Porter > --- > arch/arm/common/edma.c | 63 > +++- > includ

Re: [RFC PATCH v3 04/16] ARM: edma: add DT and runtime PM support for AM33XX

2012-10-28 Thread Sekhar Nori
On 10/18/2012 6:56 PM, Matt Porter wrote: > Adds support for parsing the TI EDMA DT data into the required > EDMA private API platform data. > > Calls runtime PM API only in the DT case in order to unidle the > associated hwmods on AM33XX. Runtime PM is supported on DaVinci now, so if that was th

Re: [RFC PATCH v3 02/16] ARM: davinci: move private EDMA API to arm/common

2012-10-28 Thread Sekhar Nori
On 10/18/2012 6:56 PM, Matt Porter wrote: > Move mach-davinci/dma.c to common/edma.c so it can be used > by OMAP (specifically AM33xx) as well. This just moves the > private EDMA API but does not support OMAP. > > Signed-off-by: Matt Porter > --- > diff --git a/arch/arm/mach-davinci/devices.c b/

Re: [PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API

2012-08-31 Thread Sekhar Nori
On 8/31/2012 10:01 PM, Vinod Koul wrote: > On Fri, 2012-08-31 at 21:32 +0530, Sekhar Nori wrote: >> Hi Matt, >> >> On 8/30/2012 8:13 PM, Matt Porter wrote: >>> On Thu, Aug 30, 2012 at 07:46:32PM +0530, Sekhar Nori wrote: >>>> Hi Matt, >>

Re: [PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API

2012-08-31 Thread Sekhar Nori
Hi Matt, On 8/30/2012 8:13 PM, Matt Porter wrote: > On Thu, Aug 30, 2012 at 07:46:32PM +0530, Sekhar Nori wrote: >> Hi Matt, >> >> On 8/23/2012 6:39 AM, Matt Porter wrote: >>> Removes use of the DaVinci EDMA private DMA API and replaces >>> it with use of th

Re: [PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API

2012-08-30 Thread Sekhar Nori
Hi Matt, On 8/23/2012 6:39 AM, Matt Porter wrote: > Removes use of the DaVinci EDMA private DMA API and replaces > it with use of the DMA engine API. > > Signed-off-by: Matt Porter I tried testing this patch on my OMAP-L138 EVM, but SPI fails to initialize after applying the patch. root@arago

[PATCH v5] mmc: davinci: add support for SDIO irq handling

2011-01-02 Thread Sekhar Nori
From: Alagu Sankar This patch adds support for handling SDIO interrupt on DaVinci MMC/SD controller. The patch has been tested on DM355 and DA850 EVMs with Marvell Libertas based SDIO wireless LAN card. Signed-off-by: Alagu Sankar Signed-off-by: Sekhar Nori --- Applies to mmc-next branch of

[PATCH v4] mmc: davinci: add support for SDIO irq handling

2011-01-02 Thread Sekhar Nori
From: Alagu Sankar This patch adds support for handing SDIO interrupt on DaVinci MMC/SD controller. The patch has been tested on DM355 and DA850 EVMs with Marvell Libertas based SDIO wireless LAN card. Signed-off-by: Alagu Sankar Signed-off-by: Sekhar Nori --- Applies to mmc-next branch of

[PATCH v3] mmc: davinci: add support for SDIO irq handling

2010-12-30 Thread Sekhar Nori
From: Alagu Sankar This patch adds support for handing SDIO interrupt on DaVinci MMC/SD controller. The patch has been tested on DM355 and DA850 EVMs with Marvell Libertas based SDIO wireless LAN card. Signed-off-by: Alagu Sankar Signed-off-by: Sekhar Nori --- Applies to mmc-next branch of