Re: [PATCH v3 1/3] mmc: dw_mmc: fix the max_blk_count in IDMAC

2015-01-05 Thread Sonny Rao
On Sat, Jan 3, 2015 at 4:51 PM, Alim Akhtar wrote: > Hi Doug / Sonny > New year greetings!! > > On Sat, Jan 3, 2015 at 4:37 AM, Doug Anderson wrote: >> Alim, >> >> On Mon, Dec 22, 2014 at 4:12 AM, Alim Akhtar wrote: >>> From: Seungwon Jeon >>> >>> Even though 1MB is reserved for descriptor tabl

Re: [PATCH v2] mmc: dw_mmc: Reset DMA before enabling IDMAC

2014-10-18 Thread Sonny Rao
On Fri, Oct 17, 2014 at 1:26 AM, Jaehoon Chung wrote: > Hi, Sonny. > > On 10/17/2014 01:58 AM, Sonny Rao wrote: >> We've already got a reset of DMA after it's done. Add one before we >> start DMA too. This fixes a data corruption on Rockchip SoCs which >&g

[PATCH v2] mmc: dw_mmc: Reset DMA before enabling IDMAC

2014-10-16 Thread Sonny Rao
y difference in sequential read throughput. Signed-off-by: Sonny Rao Signed-off-by: Doug Anderson Tested-by: Doug Anderson --- drivers/mmc/host/dw_mmc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 69f0cc6..ca67f69 100644 --- a/d

[PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC

2014-10-06 Thread Sonny Rao
y difference in sequential read throughput. Signed-off-by: Sonny Rao Signed-off-by: Doug Anderson --- drivers/mmc/host/dw_mmc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 69f0cc6..2b5401e 100644 --- a/drivers/mmc/host/dw_mmc.c ++

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-28 Thread Sonny Rao
On Thu, Aug 28, 2014 at 8:50 AM, Doug Anderson wrote: > Ulf, > > On Thu, Aug 28, 2014 at 12:25 AM, Ulf Hansson wrote: >> On 27 August 2014 17:52, Doug Anderson wrote: >>> Ulf, >>> >>> On Wed, Aug 27, 2014 at 4:17 AM, Ulf Hansson wrote: > Now, we've got MMC_CAP_NEEDS_POLL, so dw_mmc will per

Re: [PATCH V2 3/3] mmc: dw_mmc: Dont cut off vqmmc and vmmc

2014-08-22 Thread Sonny Rao
On Fri, Aug 22, 2014 at 8:31 AM, Ulf Hansson wrote: > On 22 August 2014 15:47, Yuvaraj Kumar C D wrote: >> Exynos 5250 and 5420 based boards uses built-in CD# line for card >> detection.But unfortunately CD# line is on the same voltage rails >> as of I/O voltage rails. When we cut off vqmmc,the c

Re: [PATCH v3 1/4] ARM: dts: Add emmc and sdmmc to the rk3288 device tree

2014-08-12 Thread Sonny Rao
On Tue, Aug 12, 2014 at 3:07 PM, Heiko Stübner wrote: > Am Dienstag, 12. August 2014, 14:06:11 schrieb Doug Anderson: >> Heiko, >> >> On Wed, Aug 6, 2014 at 10:09 AM, Doug Anderson > wrote: >> > This adds support for the sdmmc and emmc ports on the rk3288 using the >> > >> > currently posted driv

[PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-08-04 Thread Sonny Rao
This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny Rao Signed-off-by: Yuvaraj Kumar C D Acked-by: Seungwon Jeon Signed-off-by: Ulf Hansson [sonnyrao: fix compile for

[PATCHv6] mmc: dw_mmc: change to use recommended reset procedure

2014-07-14 Thread Sonny Rao
This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny Rao Signed-off-by: Yuvaraj Kumar C D --- v2: Add Generic DMA support per the documentation, move interrupt clear before wait

[PATCHv5] mmc: dw_mmc: change to use recommended reset procedure

2014-07-11 Thread Sonny Rao
This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny Rao Signed-off-by: Yuvaraj Kumar C D --- v2: Add Generic DMA support per the documentation, move interrupt clear before wait

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-07-11 Thread Sonny Rao
On Fri, Jul 11, 2014 at 3:20 AM, Seungwon Jeon wrote: > On Fri, July 11, 2014, Sonny Rao wrote: >> On Thu, Jul 10, 2014 at 5:28 AM, Seungwon Jeon wrote: >> > Hi Sonny, >> > >> > I have missed this patch. >> > >> > You finally choose to take

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-07-10 Thread Sonny Rao
kay and is just ignored. > > Please check one thing below. > > On Tue, June 10, 2014, Sonny Rao wrote: >> This patch changes the fifo reset code to follow the reset procedure >> outlined in the documentation of Synopsys Mobile storage host databook. >> >> Si

[PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-06-09 Thread Sonny Rao
This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny Rao Signed-off-by: Yuvaraj Kumar C D --- v2: Add Generic DMA support per the documentation, move interrupt clear before wait

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-06-09 Thread Sonny Rao
On Wed, May 28, 2014 at 10:17 PM, Jaehoon Chung wrote: > Hi, Sonny. > > On 05/29/2014 09:35 AM, Sonny Rao wrote: >> This patch changes the fifo reset code to follow the reset procedure >> outlined in the documentation of Synopsys Mobile storage host databook. >>

[PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-28 Thread Sonny Rao
This patch changes the fifo reset code to follow the reset procedure outlined in the documentation of Synopsys Mobile storage host databook. Signed-off-by: Sonny Rao Signed-off-by: Yuvaraj Kumar C D --- v2: Add Generic DMA support per the documentation, move interrupt clear before wait

Re: [PATCHv2] mmc: dw_mmc: change to use recommended reset procedure

2014-05-22 Thread Sonny Rao
On Mon, May 19, 2014 at 6:49 PM, Seungwon Jeon wrote: > On Sat, May 17, 2014, Sonny Rao wrote: >> On Tue, May 13, 2014 at 4:09 AM, Seungwon Jeon wrote: >> > On Tuesday, May 13, Sonny Rao wrote: >> >> On Mon, May 12, 2014 at 10:02 PM, Seungwon Jeon >>

Re: [PATCHv2] mmc: dw_mmc: change to use recommended reset procedure

2014-05-16 Thread Sonny Rao
On Tue, May 13, 2014 at 4:09 AM, Seungwon Jeon wrote: > On Tuesday, May 13, Sonny Rao wrote: >> On Mon, May 12, 2014 at 10:02 PM, Seungwon Jeon wrote: >> > As I mentioned in previous version, you put all reset stuff in existing >> > fifo_reset function. >> >

Re: [PATCHv2] mmc: dw_mmc: change to use recommended reset procedure

2014-05-13 Thread Sonny Rao
in all cases, and based on our testing it seems to work. I understand the skepticism, as I shared it initially when I saw this, but based on our experience, this is correct and it doesn't need to live in a separate function. > Please check my comments below. > > On Tue, May 13, 2014, S

[PATCHv2] mmc: dw_mmc: change to use recommended reset procedure

2014-05-12 Thread Sonny Rao
ost->using_dma add proper return values (although it appears no caller checks) Signed-off-by: Sonny Rao Signed-off-by: Yuvaraj Kumar C D --- drivers/mmc/host/dw_mmc.c | 55 ++- drivers/mmc/host/dw_mmc.h | 1 + 2 files changed, 55 insertions

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-12 Thread Sonny Rao
On Mon, May 12, 2014 at 2:44 PM, Sonny Rao wrote: > On Fri, May 9, 2014 at 8:36 PM, Sonny Rao wrote: >> On Fri, May 9, 2014 at 12:32 AM, Jaehoon Chung >> wrote: >>> Hi, Sonny. >>> >>> You can discard the my previous some comment. >>> As y

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-12 Thread Sonny Rao
On Fri, May 9, 2014 at 8:36 PM, Sonny Rao wrote: > On Fri, May 9, 2014 at 12:32 AM, Jaehoon Chung wrote: >> Hi, Sonny. >> >> You can discard the my previous some comment. >> As you mentioned, this reset sequence is recommended at Synopsys TRM. >> >> Add the

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-12 Thread Sonny Rao
the controller_reset bit should be set in all cases, so I don't think that it should be separated. > > Thanks, > Seungwon Jeon > > On Sat, May 10, 2014, Sonny Rao wrote: >> On Fri, May 9, 2014 at 12:32 AM, Jaehoon Chung >> wrote: >> > Hi, Sonny. >> &g

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-09 Thread Sonny Rao
t;> Hi, Sonny. >> >> I have checked the Synopsys TRM.. >> >> On 05/09/2014 10:34 AM, Sonny Rao wrote: >>> On Thu, May 8, 2014 at 6:15 PM, Jaehoon Chung >>> wrote: >>>> On 05/08/2014 06:40 PM, Yuvaraj Kumar wrote: >>>>> Any c

Re: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-08 Thread Sonny Rao
On Thu, May 8, 2014 at 2:42 AM, Yuvaraj Kumar wrote: > Any comments on this patch? > I'll just add that without this fix, running the tuning loop for UHS modes is not reliable on dw_mmc because errors will happen and you will eventually hit this race and hang. This can happen any time there is t

Re: [PATCH] mmc: dw_mmc: change to use recommended reset procedure

2014-05-08 Thread Sonny Rao
On Thu, May 8, 2014 at 6:15 PM, Jaehoon Chung wrote: > On 05/08/2014 06:40 PM, Yuvaraj Kumar wrote: >> Any comments on this patch? >> >> On Wed, Mar 26, 2014 at 5:16 PM, Yuvaraj Kumar C D >> wrote: >>> From: Sonny Rao >>> >>> This patch cha