Re: [PATCH] mmc: add module parameter to set whether cards are assumed removable

2009-11-16 Thread Stefan Richter
ite buffer at suspend time, so that you can remove this choice for good? -- Stefan Richter -=-==--= =-== =---= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] Disk hot removal causing oopses and fixes

2009-11-03 Thread Stefan Richter
block layer data 6. low-level can now clean up/ free its own data Does the MMC layer miss step 2? Because without this, step 4 would be in vain. -- Stefan Richter -=-==--= =-== ---== http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the

Re: [PATCH 1/2] Disk hot removal causing oopses and fixes

2009-10-21 Thread Stefan Richter
Stefan Richter wrote: > I dare say without knowing the MMC and block system: It is not a > locking issue, it is a reference counting issue. [...] > The whole secret is not to forget to count _all_ references. PS, in case that it might be needed: Sometimes a low level wants to wai

Re: [PATCH 1/2] Disk hot removal causing oopses and fixes

2009-10-21 Thread Stefan Richter
t queue. PS: The kref API is based on an atomic counter so that there is fundamentally never a need to use locking (mutual exclusion) for proper reference counting and proper deferral of object destruction. The whole secret is not to forget to count _all_ references. -- Stefan Richter -=-==--

Re: [PATCH 1/8] trivial: coding style fixes

2009-10-16 Thread Stefan Richter
rt->icount.overrun); > if (port->icount.cts) [...] The style problem of the original code was not indentation, but depth of indentation levels. Why not factor this cascade out to a show_icount_fields() function? Plus, I hope Jiri enhanced your changelog a