[PATCH] [PATCH v2] mmc: Fix read-only detection with JMicron 388 chip

2011-04-21 Thread Takashi Iwai
-only detection by adding a new sdhci quirk indicating to check the register more intensively with a relatively long delay. The patch is tested with 2.6.39-rc4 kernel. Cc: Aries Lee Signed-off-by: Takashi Iwai --- v1->v2 rewritten to use a quirk drivers/mmc/host/sdhci-pci.c |5 + drivers/

Re: [PATCH] mmc: Fix read-only detection with JMicron 388 chip

2011-04-21 Thread Takashi Iwai
At Thu, 21 Apr 2011 13:36:03 -0400, Chris Ball wrote: > > Hi Takashi, > > On Thu, Apr 21 2011, Takashi Iwai wrote: > >> I don't like overwriting ops here -- it's too magical, and now we have > >> to maintain the ops table in two places. A quirk seem

Re: [PATCH] mmc: Fix read-only detection with JMicron 388 chip

2011-04-21 Thread Takashi Iwai
At Thu, 21 Apr 2011 12:40:26 -0400, Chris Ball wrote: > > Hi Takashi, > > On Thu, Apr 21 2011, Takashi Iwai wrote: > > On HP laptops with JMicron 388 chip, the write-locked SD card isn't > > detected correctly as read-only in many cases. This is because the >

[PATCH] mmc: Fix read-only detection with JMicron 388 chip

2011-04-21 Thread Takashi Iwai
-only detection by adding the own get_ro op for checking the register more intensively with a relatively long delay. The patch is tested with 2.6.39-rc4 kernel. Cc: Aries Lee Signed-off-by: Takashi Iwai --- drivers/mmc/host/sdhci-pci.c | 34 ++ 1 files change

Re: [PATCH] mmc: Test bus-width for old MMC devices (v2)

2010-12-22 Thread Takashi Iwai
r=0 && (!(host->caps & MMC_CAP_BUS_WIDTH_TEST)), though > not impact function. > mmc_set_bus_width is mmc_set_bus_width_ddr(host, width, MMC_SDR_MODE). Right. How about the patch below? This one just moves the call before caps test, so it's simpler (and avoiding double c

Re: [PATCH] mmc: Test bus-width for old MMC devices (v2)

2010-12-17 Thread Takashi Iwai
At Fri, 17 Dec 2010 03:43:42 +, Chris Ball wrote: > > Hi Philip, > > On Thu, Dec 16, 2010 at 06:33:49PM -0800, Philip Rakity wrote: > > It is not possible for bus_width to be not initialized. This would imply > > ARRAY_SIZE(bus_widths) is 1. Certainly not true. > > Right, I agree. We sho

Re: [PATCH] mmc: Fix a typo in ocr_avail mask check for MMC

2010-12-17 Thread Takashi Iwai
At Thu, 16 Dec 2010 23:45:11 +, Chris Ball wrote: > > Hi Takashi, > > On Wed, Dec 15, 2010 at 02:19:22PM +0100, Takashi Iwai wrote: > > In the patch "mmc: Add support for JMicron 388 SD/MMC controller", > > I changed a wrong field for MMC during rewrite.

[PATCH] mmc/sdhci: Enable bus-width test for JMicron controllers

2010-12-16 Thread Takashi Iwai
Signed-off-by: Takashi Iwai --- This is a patch to be applied after "mmc: Test bus-width for old MMC devices (v2)" and a replacement for the previous "mmc: Enable bus-width tests on SDHCI host" patch. Instead of enabling all for sdhci, this one turns on the feature only

Re: [PATCH] mmc: Enable bus-width tests on SDHCI host

2010-12-15 Thread Takashi Iwai
At Wed, 15 Dec 2010 14:17:27 +0100, Takashi Iwai wrote: > > Let's enable the new bus-width tests on SDHCI hosts unless 1-bit data > is set forcibly. > > Signed-off-by: Takashi Iwai Please drop this patch. After a short discussion with Philip, we concluded that it&

[PATCH] mmc: Fix a typo in ocr_avail mask check for MMC

2010-12-15 Thread Takashi Iwai
In the patch "mmc: Add support for JMicron 388 SD/MMC controller", I changed a wrong field for MMC during rewrite. Fixed now. Signed-off-by: Takashi Iwai --- drivers/mmc/host/sdhci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/sdhci.c

[PATCH] mmc: Enable bus-width tests on SDHCI host

2010-12-15 Thread Takashi Iwai
Let's enable the new bus-width tests on SDHCI hosts unless 1-bit data is set forcibly. Signed-off-by: Takashi Iwai --- This is a patch to be applied after "mmc: Test bus-width for old MMC devices (v2)" drivers/mmc/host/sdhci.c |4 +++- 1 files changed, 3 insertions(

[PATCH] mmc: Test bus-width for old MMC devices (v2)

2010-12-14 Thread Takashi Iwai
T_W -- improves chances test will work Signed-off-by: Aries Lee Signed-off-by: Takashi Iwai Signed-off-by: Philip Rakity Tested-by: Philip Rakity --- Chris, this is a revised version of the patch. Philip merged his patch into this version and tested. Please apply. drivers/mmc/core/mmc.c |

Re: [PATCH 2/2] mmc: Test bus-width for old MMC devices

2010-12-14 Thread Takashi Iwai
At Tue, 14 Dec 2010 23:03:42 -0500, zhangfei gao wrote: > > On Wed, Nov 24, 2010 at 1:21 AM, Takashi Iwai wrote: > > From: Aries Lee > > > > Some old MMC devices fail with the 4/8 bits the driver tries to use > > exclusively.  This patch adds a test for the given b

Re: [PATCH] mmc: Fix re-probing after hibernation

2010-12-09 Thread Takashi Iwai
At Thu, 9 Dec 2010 21:37:24 +0100, Rafael J. Wysocki wrote: > > On Thursday, December 09, 2010, Takashi Iwai wrote: > > At Thu, 9 Dec 2010 01:53:03 +, > > Chris Ball wrote: > > > > > > Hi Takashi, > > > > > > On Wed, Dec 08, 2010 at 04

Re: [PATCH v2] mmc: Add support for JMicron 388 SD/MMC controller

2010-12-09 Thread Takashi Iwai
At Wed, 8 Dec 2010 21:18:38 -0500, zhangfei gao wrote: > > On Wed, Dec 8, 2010 at 4:04 AM, Takashi Iwai wrote: > > JMicron 388 SD/MMC combo controller supports the 1.8V low-voltage for > > SD, but MMC doesn't work with the low-voltage, resulting in an error > > a

[PATCH] mmc: Fix re-probing after hibernation

2010-12-08 Thread Takashi Iwai
sends PM_POST_RESTORE instead, thus disable_rescan is kept as 1. Cc: Signed-off-by: Takashi Iwai --- drivers/mmc/core/core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 31ae07a..30094f6 100644 --- a/drivers/mmc

[PATCH v2] mmc: Add support for JMicron 388 SD/MMC controller

2010-12-08 Thread Takashi Iwai
-by: Aries Lee Signed-off-by: Takashi Iwai --- v1->v2 - Rebased to the latest mmc-next branch of linux-mmc tree drivers/mmc/core/mmc.c |2 + drivers/mmc/core/sd.c|5 +++- drivers/mmc/core/sdio.c |2 + drivers/mmc/host/sdhci

Re: [PATCH 1/2] mmc: Add support for JMicron 388 SD/MMC controller

2010-12-07 Thread Takashi Iwai
At Wed, 24 Nov 2010 23:04:25 +0100, Wolfram Sang wrote: > > On Wed, Nov 24, 2010 at 12:29:57PM +0100, Takashi Iwai wrote: > > At Wed, 24 Nov 2010 10:59:35 +0100, > > Wolfram Sang wrote: > > > > > > On Wed, Nov 24, 2010 at 07:21:13AM +0100, Takashi Iwai

Re: [PATCH 2/2] mmc: Test bus-width for old MMC devices

2010-12-05 Thread Takashi Iwai
Hi Chris, At Sun, 5 Dec 2010 04:02:24 +, Chris Ball wrote: > > Hi Takashi, Philip, > > On Wed, Nov 24, 2010 at 07:21:14AM +0100, Takashi Iwai wrote: > > From: Aries Lee > > > > Some old MMC devices fail with the 4/8 bits the driver tries to use > > excl

Re: [PATCH 1/2] mmc: Add support for JMicron 388 SD/MMC controller

2010-11-24 Thread Takashi Iwai
At Wed, 24 Nov 2010 10:59:35 +0100, Wolfram Sang wrote: > > On Wed, Nov 24, 2010 at 07:21:13AM +0100, Takashi Iwai wrote: > > > +/* Controller doesn't support VDD 180 for MMC (for SD/MMC combo chips) */ > > +#define SDHCI_QUIRK_MMC_VDD_180(1

[PATCH 2/2] mmc: Test bus-width for old MMC devices

2010-11-23 Thread Takashi Iwai
-off-by: Takashi Iwai --- drivers/mmc/core/mmc.c | 49 - drivers/mmc/core/mmc_ops.c | 102 drivers/mmc/core/mmc_ops.h |1 + 3 files changed, 131 insertions(+), 21 deletions(-) diff --git a/drivers/mmc/core/mmc.c b/drivers

[PATCH 1/2] mmc: Add support for JMicron 388 SD/MMC controller

2010-11-23 Thread Takashi Iwai
-by: Aries Lee Signed-off-by: Takashi Iwai --- drivers/mmc/core/mmc.c |2 ++ drivers/mmc/core/sd.c|5 - drivers/mmc/core/sdio.c |2 ++ drivers/mmc/host/sdhci-pci.c | 42 -- drivers/mmc/host/sdhci.c | 11 ++

[PATCH 0/2] mmc: Add support for JMicron 388 SD/MMC controller

2010-11-23 Thread Takashi Iwai
Hi, this is a patch series to add the support for the new JMicron 388 SD/MMC controller. The first patch is to add the support for the new PCI device, including the quirks to handle different voltages per medium. The second patch is for improving the handling of different bus- widths dynamically